153695 2016-01-29 20:17:51 -0800 REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scrollbar groundwork 2016-03-05 05:24:37 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=153936 https://bugs.webkit.org/show_bug.cgi?id=155048 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58876 P2 Normal --- 1 mcatanzaro webkit-unassigned bugs-noreply cgarcia darin mcatanzaro oldest_to_newest 1160392 0 mcatanzaro 2016-01-29 20:17:51 -0800 fast/repaint/fixed-move-after-scroll.html has been crashing flakily beginning with r195672-r195673. These two commits are obviously not the cause of the crash, but they come shortly after several commits implementing the groundwork for overlay scrollbars landed. 1160394 1 mcatanzaro 2016-01-29 20:31:07 -0800 And fast/scrolling/scroll-position-on-reload-rtl.html has been fairly reliably since r195660-r195661. r195660 looks like a more likely culprit so I'll pick that for the bug title. 1160395 2 mcatanzaro 2016-01-29 20:31:26 -0800 (In reply to comment #1) > And fast/scrolling/scroll-position-on-reload-rtl.html has been fairly > reliably since r195660-r195661. fairly reliably crashing 1162570 3 mcatanzaro 2016-02-05 20:39:27 -0800 Also scrollbars/scrollbar-initial-position.html (flaky since r195660-r195661). 1162578 4 cgarcia 2016-02-05 23:38:21 -0800 When reporting this kind of failures it's very useful to include links to the bots results, especially if they are flaky. That way I know if it's an assert only happening in debug or if it also fails in release, and I can focus on fixing the bug instead of figuring out how to make it crash. 1162590 5 cgarcia 2016-02-06 03:16:32 -0800 *** Bug 153936 has been marked as a duplicate of this bug. *** 1162591 6 270792 cgarcia 2016-02-06 03:20:02 -0800 Created attachment 270792 Patch 1162603 7 mcatanzaro 2016-02-06 07:37:38 -0800 (In reply to comment #4) > When reporting this kind of failures it's very useful to include links to > the bots results, especially if they are flaky. That way I know if it's an > assert only happening in debug or if it also fails in release, and I can > focus on fixing the bug instead of figuring out how to make it crash. OK 1162604 8 270792 mcatanzaro 2016-02-06 07:43:18 -0800 Comment on attachment 270792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270792&action=review Also update the test expectations? > Source/WebCore/platform/ScrollAnimation.h:38 > + virtual ~ScrollAnimation() { }; Ugh, real shame this was not caught by -Wdelete-non-virtual-dtor. 1162716 9 cgarcia 2016-02-07 01:43:51 -0800 (In reply to comment #8) > Comment on attachment 270792 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270792&action=review > > Also update the test expectations? Ah, did you also update the test expectations? It's also very useful to add a comment to the bug when you do so, saying, expectations update in r123456. 1162720 10 cgarcia 2016-02-07 02:09:42 -0800 Committed r196238: <http://trac.webkit.org/changeset/196238> 1162722 11 mcatanzaro 2016-02-07 07:18:51 -0800 (In reply to comment #9) > Ah, did you also update the test expectations? It's also very useful to add > a comment to the bug when you do so, saying, expectations update in r123456. OK, I'll try to start doing this. (I always update expectations when filing bugs against layout tests.) 1171083 12 darin 2016-03-04 15:32:16 -0800 I’d like to understand where this was being deleted in a polymorphic way, but with something other than delete. If it was being deleted with delete, then -Wdelete-non-virtual-dtor should have warned us about this mistake. 1171114 13 mcatanzaro 2016-03-04 17:02:18 -0800 I think through std::unique_ptr. A quick test: #include <memory> class A { public: virtual void something() { } }; class B : public A { }; This code triggers -Wdelete-non-virtual-dtor in both GCC and Clang: int main() { A* a = new B; delete a; } But this code triggers only -Wnon-virtual-dtor: int main() { auto a = std::make_unique<B>(); } 1171115 14 mcatanzaro 2016-03-04 17:04:46 -0800 Just found https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58876 """This is because warnings are suppressed by default in system headers, and the undefined delete operation occurs in a system header. You get the warning if you use -Wsystem-headers""" (Of course we don't want to do that though, we'd be spammed by tons of warnings we can't control.) 1171206 15 mcatanzaro 2016-03-05 05:24:37 -0800 (In reply to comment #13) > But this code triggers only -Wnon-virtual-dtor: > > int main() > { > auto a = std::make_unique<B>(); > } Well that's a bad example because that's not polymorphic, the right example is: int main() { auto a = std::unique_ptr<A>(new B); } (It still triggers only -Wnon-virtual-dtor, so my point is sound.) 270792 2016-02-06 03:20:02 -0800 2016-02-06 07:43:18 -0800 Patch wcore-scroll-animation-crash.diff text/plain 1371 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3Yzc5YzVlLi5lNTBiMDVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTYtMDItMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE5NTY2MSk6IFtHVEtdIFNjcm9sbGJhciB0ZXN0cyBj cmFzaGluZyBhZnRlciBvdmVybGF5IHNjcm9sbGJhciBncm91bmR3b3JrCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM2OTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IFNj cm9sbEFuaW1hdGlvbiBvYmplY3RzIGFyZSBub3QgZGVzdHJveWVkIGJ5CisgICAgICAgIHRoZSBT Y3JvbGxBbmltYXRvciBkZXN0cnVjdG9yLCBiZWNhdXNlIEkgZm9yZ290IHRvIGFkZCBhIHZpcnR1 YWwKKyAgICAgICAgZGVzdHJ1Y3RvciBmb3IgU2Nyb2xsQW5pbWF0aW9uIGluIHIxOTU2NjEuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRpb24uaDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbEFuaW1hdGlvbjo6flNjcm9sbEFuaW1hdGlvbik6CisKIDIwMTYtMDItMDUgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFNj cm9sbGJhcnMgaW5jb3JyZWN0bHkgcmVuZGVyZWQgd2l0aCBvbGRlciB2ZXJzaW9ucyBvZiBHVEsr CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRpb24uaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdGlvbi5oCmluZGV4IDcyZjJiYjQu LjM5Mjk5OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1h dGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdGlvbi5oCkBA IC0zNSw2ICszNSw3IEBAIGNsYXNzIFNjcm9sbGFibGVBcmVhOwogCiBjbGFzcyBTY3JvbGxBbmlt YXRpb24gewogcHVibGljOgorICAgIHZpcnR1YWwgflNjcm9sbEFuaW1hdGlvbigpIHsgfTsKICAg ICB2aXJ0dWFsIGJvb2wgc2Nyb2xsKFNjcm9sbGJhck9yaWVudGF0aW9uLCBTY3JvbGxHcmFudWxh cml0eSwgZmxvYXQgc3RlcCwgZmxvYXQgbXVsdGlwbGllcikgPSAwOwogICAgIHZpcnR1YWwgdm9p ZCBzdG9wKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVWaXNpYmxlTGVuZ3RocygpID0g MDsK