<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>153488</bug_id>
          
          <creation_ts>2016-01-26 08:28:34 -0800</creation_ts>
          <short_desc>[meta][css-grid] Support implicit grid before explicit grid</short_desc>
          <delta_ts>2016-03-18 07:04:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>153592</dependson>
    
    <dependson>153868</dependson>
    
    <dependson>154336</dependson>
    
    <dependson>154818</dependson>
    
    <dependson>154911</dependson>
    
    <dependson>155014</dependson>
    
    <dependson>155199</dependson>
    
    <dependson>155230</dependson>
    
    <dependson>155486</dependson>
    
    <dependson>155489</dependson>
    
    <dependson>155636</dependson>
          <blocked>60731</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Manuel Rego Casasnovas">rego</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1158820</commentid>
    <comment_count>0</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2016-01-26 08:28:34 -0800</bug_when>
    <thetext>In our current implementation the implicit grid is only after the explicit grid.

For example, in a 2x2 grid, if you have an item with:
  grid-row: 3;
An implicit 3rd row is created.

However, if you have an item like:
  grid-column: -4;
We should be creating an implicit column before the first one.

This has been already implemented on Blink (http://crbug.com/444011)
following a plan described in this document (http://bit.ly/1j3CRdi).

We should port these patches to WebKit as the grid layout code has the same issues.

This will be used as meta-bug for all the patches related.

More info in the spec: http://dev.w3.org/csswg/css-grid/#line-placement</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1174928</commentid>
    <comment_count>1</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2016-03-15 01:36:17 -0700</bug_when>
    <thetext>We&apos;ve a TODO in GridResolvedPosition class:
// TODO(rego): Rename class to GridPositionsResolver.

This was already done in Blink:
https://codereview.chromium.org/1648903002/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1174930</commentid>
    <comment_count>2</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2016-03-15 01:36:58 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; We&apos;ve a TODO in GridResolvedPosition class:
&gt; // TODO(rego): Rename class to GridPositionsResolver.
&gt; 
&gt; This was already done in Blink:
&gt; https://codereview.chromium.org/1648903002/

Sorry this comment was for bug #155486.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1176158</commentid>
    <comment_count>3</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2016-03-18 07:04:35 -0700</bug_when>
    <thetext>With the last refactorings this task has been completed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>