153398 2016-01-23 04:02:45 -0800 ScrollAnimator is not notified when mouse entered, moved or exited a RenderListBox 2016-01-27 02:25:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153405 1 cgarcia webkit-unassigned bdakin darin mcatanzaro simon.fraser oldest_to_newest 1158031 0 cgarcia 2016-01-23 04:02:45 -0800 EvenHandler is checking whether the enclosing layer of a node is registered as scrollable area of its frame view. That doesn't work for list boxes, because they are the scrollable area themselves. Also when entering a list box the node under mouse it not usually the list box itself, but any of its children, a HTMLOptionElement or a HTMLOptGroupElement. Instead of comparing layers, we should find the enclosing scrollable area of the target elements and compare them to decide whether the mouse has entered, left or moved a scrollable area. 1158033 1 269667 cgarcia 2016-01-23 04:08:49 -0800 Created attachment 269667 Patch 1158114 2 269667 simon.fraser 2016-01-24 10:49:10 -0800 Comment on attachment 269667 Patch Is this testable? 1158151 3 269667 darin 2016-01-24 14:17:51 -0800 Comment on attachment 269667 Patch Fix looks great. Needs a test. 1158256 4 cgarcia 2016-01-25 01:24:42 -0800 I'm not sure how to test this, since it only affects the scroll animator notifications, you can still scroll and use the list box normally. 1158391 5 bdakin 2016-01-25 11:06:55 -0800 (In reply to comment #4) > I'm not sure how to test this, since it only affects the scroll animator > notifications, you can still scroll and use the list box normally. Yeah, we never figured out how to test this stuff, which is really unfortunate because we definitely have a history of accidentally introducing regressions in this area. 1158440 6 269667 mcatanzaro 2016-01-25 12:14:08 -0800 Comment on attachment 269667 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269667&action=review OK then. Since it's apparently hard to test, and we (GTK folks) will notice almost immediately if this ever breaks, I think a test is not needed.... > Source/WebCore/ChangeLog:11 > + themselves. Also when entering a list box the node under mouse it it -> is 1158456 7 simon.fraser 2016-01-25 12:58:04 -0800 (In reply to comment #6) > Comment on attachment 269667 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269667&action=review > > OK then. Since it's apparently hard to test, and we (GTK folks) will notice > almost immediately if this ever breaks, I think a test is not needed.... I disagree. If you want to avoid Mac people breaking GTK by accident, you should add a test. 1158482 8 mcatanzaro 2016-01-25 13:50:50 -0800 (In reply to comment #7) > I disagree. If you want to avoid Mac people breaking GTK by accident, you > should add a test. A test won't help one bit, since the EWS only runs tests for Mac, you will never notice when you break it, and it takes us weeks or months to triage and file bugs for failing tests. We will definitely notice if scrollbars break long before we notice the test failing. That said, of course it would be better to have a test than not! But I would not want to block the feature on this. 1158738 9 cgarcia 2016-01-25 23:30:07 -0800 I also don't want to block this on a test, but agree that we need tests for this, so I'll work on adding tests after these patches land. 1158879 10 bdakin 2016-01-26 11:12:49 -0800 (In reply to comment #9) > I also don't want to block this on a test, but agree that we need tests for > this, so I'll work on adding tests after these patches land. YAAAAY 1159254 11 cgarcia 2016-01-27 02:25:13 -0800 Committed r195659: <http://trac.webkit.org/changeset/195659> 269667 2016-01-23 04:08:49 -0800 2016-01-25 12:14:08 -0800 Patch wcore-list-box-scroll-notifications.diff text/plain 6469 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODA1NWY2Li4xZDg4MjA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkg QEAKKzIwMTYtMDEtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFNjcm9sbEFuaW1hdG9yIGlzIG5vdCBub3RpZmllZCB3aGVuIG1vdXNlIGVu dGVyZWQsIG1vdmVkIG9yIGV4aXRlZCBhIFJlbmRlckxpc3RCb3gKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzM5OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV2ZW5IYW5kbGVyIGlzIGNoZWNraW5nIHdo ZXRoZXIgdGhlIGVuY2xvc2luZyBsYXllciBvZiBhIG5vZGUgaXMKKyAgICAgICAgcmVnaXN0ZXJl ZCBhcyBzY3JvbGxhYmxlIGFyZWEgb2YgaXRzIGZyYW1lIHZpZXcuIFRoYXQgZG9lc24ndCB3b3Jr CisgICAgICAgIGZvciBsaXN0IGJveGVzLCBiZWNhdXNlIHRoZXkgYXJlIHRoZSBzY3JvbGxhYmxl IGFyZWEKKyAgICAgICAgdGhlbXNlbHZlcy4gQWxzbyB3aGVuIGVudGVyaW5nIGEgbGlzdCBib3gg dGhlIG5vZGUgdW5kZXIgbW91c2UgaXQKKyAgICAgICAgbm90IHVzdWFsbHkgdGhlIGxpc3QgYm94 IGl0c2VsZiwgYnV0IGFueSBvZiBpdHMgY2hpbGRyZW4sIGEKKyAgICAgICAgSFRNTE9wdGlvbkVs ZW1lbnQgb3IgYSBIVE1MT3B0R3JvdXBFbGVtZW50LiBJbnN0ZWFkIG9mIGNvbXBhcmluZworICAg ICAgICBsYXllcnMsIHdlIHNob3VsZCBmaW5kIHRoZSBlbmNsb3Npbmcgc2Nyb2xsYWJsZSBhcmVh IG9mIHRoZSB0YXJnZXQKKyAgICAgICAgZWxlbWVudHMgYW5kIGNvbXBhcmUgdGhlbSB0byBkZWNp ZGUgd2hldGhlciB0aGUgbW91c2UgaGFzIGVudGVyZWQsCisgICAgICAgIGxlZnQgb3IgbW92ZWQg YSBzY3JvbGxhYmxlIGFyZWEuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjplbmNsb3NpbmdTY3JvbGxhYmxlQXJlYSk6IFJldHVybiB0aGUgZW5j bG9zaW5nCisgICAgICAgIHNjcm9sbGFibGUgYXJlYSBvZiB0aGUgZ2l2ZW4gbm9kZS4gSWYgdGhl IG5vZGUgZG9lc24ndCBoYXZlIGEKKyAgICAgICAgcmVuZGVyZXIsIGl0IHRyYXZlcnNlcyBpdHMg cGFyZW50cy4gSWYgdGhlIHJlbmRlcmVyIGlzIGEKKyAgICAgICAgUmVuZGVyTGlzdEJveCBpdCBp cyByZXR1cm5lZCwgb3RoZXJ3aGlzZSB0aGUgZW5jbG9zaW5nIGxheWVyIGlzCisgICAgICAgIHJl dHVybmVkLgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjptb3VzZU1vdmVkKTogVXNl IGVuY2xvc2luZ1Njcm9sbGFibGVBcmVhLgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVy Ojp1cGRhdGVNb3VzZUV2ZW50VGFyZ2V0Tm9kZSk6IERpdHRvLgorCiAyMDE2LTAxLTIyICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBPdmVybGF5 IHNjcm9sbGJhcnMgc2hvdWxkIGFsd2F5cyB1c2UgdGhlIHdob2xlIGNvbnRlbnRzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggOTE4MmQzZC4uYTI0ODkwYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMTc1MywyMCArMTc1MywyNiBAQCBib29sIEV2 ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VEb3VibGVDbGlja0V2ZW50KGNvbnN0IFBsYXRmb3JtTW91 c2VFdmVudCYgcGxhdGZvcgogICAgIHJldHVybiBzd2FsbG93TW91c2VVcEV2ZW50IHx8IHN3YWxs b3dDbGlja0V2ZW50IHx8IHN3YWxsb3dNb3VzZVJlbGVhc2VFdmVudDsKIH0KIAotc3RhdGljIFJl bmRlckxheWVyKiBsYXllckZvck5vZGUoTm9kZSogbm9kZSkKK3N0YXRpYyBTY3JvbGxhYmxlQXJl YSogZW5jbG9zaW5nU2Nyb2xsYWJsZUFyZWEoTm9kZSogbm9kZSkKIHsKICAgICBpZiAoIW5vZGUp Ci0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAotICAgIGF1dG8g cmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigpOwotICAgIGlmICghcmVuZGVyZXIpCi0gICAgICAg IHJldHVybiAwOworICAgIGZvciAoYXV0byBlbGVtZW50ID0gbm9kZTsgZWxlbWVudDsgZWxlbWVu dCA9IGVsZW1lbnQtPnBhcmVudE9yU2hhZG93SG9zdE5vZGUoKSkgeworICAgICAgICBpZiAoaXM8 SFRNTElGcmFtZUVsZW1lbnQ+KCplbGVtZW50KSB8fCBpczxIVE1MSHRtbEVsZW1lbnQ+KCplbGVt ZW50KSB8fCBpczxIVE1MRG9jdW1lbnQ+KCplbGVtZW50KSkKKyAgICAgICAgICAgIHJldHVybiBu dWxscHRyOwogCi0gICAgUmVuZGVyTGF5ZXIqIGxheWVyID0gcmVuZGVyZXItPmVuY2xvc2luZ0xh eWVyKCk7Ci0gICAgaWYgKCFsYXllcikKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIGF1dG8g cmVuZGVyZXIgPSBlbGVtZW50LT5yZW5kZXJlcigpOworICAgICAgICBpZiAoIXJlbmRlcmVyKQor ICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgaWYgKGlzPFJlbmRlckxpc3RCb3g+KCpy ZW5kZXJlcikpCisgICAgICAgICAgICByZXR1cm4gZG93bmNhc3Q8UmVuZGVyTGlzdEJveD4ocmVu ZGVyZXIpOwogCi0gICAgcmV0dXJuIGxheWVyOworICAgICAgICByZXR1cm4gcmVuZGVyZXItPmVu Y2xvc2luZ0xheWVyKCk7CisgICAgfQorCisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIGJvb2wg RXZlbnRIYW5kbGVyOjptb3VzZU1vdmVkKGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQp CkBAIC0xNzg0LDEwICsxNzkwLDEwIEBAIGJvb2wgRXZlbnRIYW5kbGVyOjptb3VzZU1vdmVkKGNv bnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQpCiAgICAgaWYgKCFwYWdlKQogICAgICAgICBy ZXR1cm4gcmVzdWx0OwogCi0gICAgaWYgKFJlbmRlckxheWVyKiBsYXllciA9IGxheWVyRm9yTm9k ZShob3ZlcmVkTm9kZS5pbm5lck5vZGUoKSkpIHsKKyAgICBpZiAoYXV0byBzY3JvbGxlZEFyZWEg PSBlbmNsb3NpbmdTY3JvbGxhYmxlQXJlYShob3ZlcmVkTm9kZS5pbm5lck5vZGUoKSkpIHsKICAg ICAgICAgaWYgKEZyYW1lVmlldyogZnJhbWVWaWV3ID0gbV9mcmFtZS52aWV3KCkpIHsKLSAgICAg ICAgICAgIGlmIChmcmFtZVZpZXctPmNvbnRhaW5zU2Nyb2xsYWJsZUFyZWEobGF5ZXIpKQotICAg ICAgICAgICAgICAgIGxheWVyLT5tb3VzZU1vdmVkSW5Db250ZW50QXJlYSgpOworICAgICAgICAg ICAgaWYgKGZyYW1lVmlldy0+Y29udGFpbnNTY3JvbGxhYmxlQXJlYShzY3JvbGxlZEFyZWEpKQor ICAgICAgICAgICAgICAgIHNjcm9sbGVkQXJlYS0+bW91c2VNb3ZlZEluQ29udGVudEFyZWEoKTsK ICAgICAgICAgfQogICAgIH0KIApAQCAtMjM2MCw4ICsyMzY2LDggQEAgdm9pZCBFdmVudEhhbmRs ZXI6OnVwZGF0ZU1vdXNlRXZlbnRUYXJnZXROb2RlKE5vZGUqIHRhcmdldE5vZGUsIGNvbnN0IFBs YXRmb3JtTW8KIAogICAgIC8vIEZpcmUgbW91c2VvdXQvbW91c2VvdmVyIGlmIHRoZSBtb3VzZSBo YXMgc2hpZnRlZCB0byBhIGRpZmZlcmVudCBub2RlLgogICAgIGlmIChmaXJlTW91c2VPdmVyT3V0 KSB7Ci0gICAgICAgIFJlbmRlckxheWVyKiBsYXllckZvckxhc3ROb2RlID0gbGF5ZXJGb3JOb2Rl KG1fbGFzdEVsZW1lbnRVbmRlck1vdXNlLmdldCgpKTsKLSAgICAgICAgUmVuZGVyTGF5ZXIqIGxh eWVyRm9yTm9kZVVuZGVyTW91c2UgPSBsYXllckZvck5vZGUobV9lbGVtZW50VW5kZXJNb3VzZS5n ZXQoKSk7CisgICAgICAgIGF1dG8gc2Nyb2xsYWJsZUFyZWFGb3JMYXN0Tm9kZSA9IGVuY2xvc2lu Z1Njcm9sbGFibGVBcmVhKG1fbGFzdEVsZW1lbnRVbmRlck1vdXNlLmdldCgpKTsKKyAgICAgICAg YXV0byBzY3JvbGxhYmxlQXJlYUZvck5vZGVVbmRlck1vdXNlID0gZW5jbG9zaW5nU2Nyb2xsYWJs ZUFyZWEobV9lbGVtZW50VW5kZXJNb3VzZS5nZXQoKSk7CiAgICAgICAgIFBhZ2UqIHBhZ2UgPSBt X2ZyYW1lLnBhZ2UoKTsKIAogICAgICAgICBpZiAobV9sYXN0RWxlbWVudFVuZGVyTW91c2UgJiYg KCFtX2VsZW1lbnRVbmRlck1vdXNlIHx8ICZtX2VsZW1lbnRVbmRlck1vdXNlLT5kb2N1bWVudCgp ICE9IG1fZnJhbWUuZG9jdW1lbnQoKSkpIHsKQEAgLTIzNzAsMTIgKzIzNzYsMTIgQEAgdm9pZCBF dmVudEhhbmRsZXI6OnVwZGF0ZU1vdXNlRXZlbnRUYXJnZXROb2RlKE5vZGUqIHRhcmdldE5vZGUs IGNvbnN0IFBsYXRmb3JtTW8KICAgICAgICAgICAgICAgICBpZiAoRnJhbWVWaWV3KiBmcmFtZVZp ZXcgPSBmcmFtZS0+dmlldygpKQogICAgICAgICAgICAgICAgICAgICBmcmFtZVZpZXctPm1vdXNl RXhpdGVkQ29udGVudEFyZWEoKTsKICAgICAgICAgICAgIH0KLSAgICAgICAgfSBlbHNlIGlmIChw YWdlICYmIChsYXllckZvckxhc3ROb2RlICYmICghbGF5ZXJGb3JOb2RlVW5kZXJNb3VzZSB8fCBs YXllckZvck5vZGVVbmRlck1vdXNlICE9IGxheWVyRm9yTGFzdE5vZGUpKSkgeworICAgICAgICB9 IGVsc2UgaWYgKHBhZ2UgJiYgKHNjcm9sbGFibGVBcmVhRm9yTGFzdE5vZGUgJiYgKCFzY3JvbGxh YmxlQXJlYUZvck5vZGVVbmRlck1vdXNlIHx8IHNjcm9sbGFibGVBcmVhRm9yTm9kZVVuZGVyTW91 c2UgIT0gc2Nyb2xsYWJsZUFyZWFGb3JMYXN0Tm9kZSkpKSB7CiAgICAgICAgICAgICAvLyBUaGUg bW91c2UgaGFzIG1vdmVkIGJldHdlZW4gbGF5ZXJzLgogICAgICAgICAgICAgaWYgKEZyYW1lKiBm cmFtZSA9IG1fbGFzdEVsZW1lbnRVbmRlck1vdXNlLT5kb2N1bWVudCgpLmZyYW1lKCkpIHsKICAg ICAgICAgICAgICAgICBpZiAoRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBmcmFtZS0+dmlldygpKSB7 Ci0gICAgICAgICAgICAgICAgICAgIGlmIChmcmFtZVZpZXctPmNvbnRhaW5zU2Nyb2xsYWJsZUFy ZWEobGF5ZXJGb3JMYXN0Tm9kZSkpCi0gICAgICAgICAgICAgICAgICAgICAgICBsYXllckZvckxh c3ROb2RlLT5tb3VzZUV4aXRlZENvbnRlbnRBcmVhKCk7CisgICAgICAgICAgICAgICAgICAgIGlm IChmcmFtZVZpZXctPmNvbnRhaW5zU2Nyb2xsYWJsZUFyZWEoc2Nyb2xsYWJsZUFyZWFGb3JMYXN0 Tm9kZSkpCisgICAgICAgICAgICAgICAgICAgICAgICBzY3JvbGxhYmxlQXJlYUZvckxhc3ROb2Rl LT5tb3VzZUV4aXRlZENvbnRlbnRBcmVhKCk7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAg ICAgfQogICAgICAgICB9CkBAIC0yMzg2LDEyICsyMzkyLDEyIEBAIHZvaWQgRXZlbnRIYW5kbGVy Ojp1cGRhdGVNb3VzZUV2ZW50VGFyZ2V0Tm9kZShOb2RlKiB0YXJnZXROb2RlLCBjb25zdCBQbGF0 Zm9ybU1vCiAgICAgICAgICAgICAgICAgaWYgKEZyYW1lVmlldyogZnJhbWVWaWV3ID0gZnJhbWUt PnZpZXcoKSkKICAgICAgICAgICAgICAgICAgICAgZnJhbWVWaWV3LT5tb3VzZUVudGVyZWRDb250 ZW50QXJlYSgpOwogICAgICAgICAgICAgfQotICAgICAgICB9IGVsc2UgaWYgKHBhZ2UgJiYgKGxh eWVyRm9yTm9kZVVuZGVyTW91c2UgJiYgKCFsYXllckZvckxhc3ROb2RlIHx8IGxheWVyRm9yTm9k ZVVuZGVyTW91c2UgIT0gbGF5ZXJGb3JMYXN0Tm9kZSkpKSB7CisgICAgICAgIH0gZWxzZSBpZiAo cGFnZSAmJiAoc2Nyb2xsYWJsZUFyZWFGb3JOb2RlVW5kZXJNb3VzZSAmJiAoIXNjcm9sbGFibGVB cmVhRm9yTGFzdE5vZGUgfHwgc2Nyb2xsYWJsZUFyZWFGb3JOb2RlVW5kZXJNb3VzZSAhPSBzY3Jv bGxhYmxlQXJlYUZvckxhc3ROb2RlKSkpIHsKICAgICAgICAgICAgIC8vIFRoZSBtb3VzZSBoYXMg bW92ZWQgYmV0d2VlbiBsYXllcnMuCiAgICAgICAgICAgICBpZiAoRnJhbWUqIGZyYW1lID0gbV9l bGVtZW50VW5kZXJNb3VzZS0+ZG9jdW1lbnQoKS5mcmFtZSgpKSB7CiAgICAgICAgICAgICAgICAg aWYgKEZyYW1lVmlldyogZnJhbWVWaWV3ID0gZnJhbWUtPnZpZXcoKSkgewotICAgICAgICAgICAg ICAgICAgICBpZiAoZnJhbWVWaWV3LT5jb250YWluc1Njcm9sbGFibGVBcmVhKGxheWVyRm9yTm9k ZVVuZGVyTW91c2UpKQotICAgICAgICAgICAgICAgICAgICAgICAgbGF5ZXJGb3JOb2RlVW5kZXJN b3VzZS0+bW91c2VFbnRlcmVkQ29udGVudEFyZWEoKTsKKyAgICAgICAgICAgICAgICAgICAgaWYg KGZyYW1lVmlldy0+Y29udGFpbnNTY3JvbGxhYmxlQXJlYShzY3JvbGxhYmxlQXJlYUZvck5vZGVV bmRlck1vdXNlKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHNjcm9sbGFibGVBcmVhRm9yTm9k ZVVuZGVyTW91c2UtPm1vdXNlRW50ZXJlZENvbnRlbnRBcmVhKCk7CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgfQogICAgICAgICB9Cg==