153068 2016-01-13 10:19:47 -0800 [ES6] Support subclassing the String builtin object 2016-01-14 13:25:07 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142591 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1155111 0 keith_miller 2016-01-13 10:19:47 -0800 [ES6] Support subclassing the String builtin object 1155140 1 268881 keith_miller 2016-01-13 11:17:57 -0800 Created attachment 268881 Patch 1155146 2 268881 msaboff 2016-01-13 11:31:33 -0800 Comment on attachment 268881 Patch r=me 1155269 3 268881 commit-queue 2016-01-13 15:45:28 -0800 Comment on attachment 268881 Patch Clearing flags on attachment: 268881 Committed r194998: <http://trac.webkit.org/changeset/194998> 1155270 4 commit-queue 2016-01-13 15:45:30 -0800 All reviewed patches have been landed. Closing bug. 268881 2016-01-13 11:17:57 -0800 2016-01-13 15:45:28 -0800 Patch bug-153068-20160113111725.patch text/plain 4737 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YmU3ZjQ1M2IyOTIzMjVkZjQzNGVhZGI5ZjM2NzczNWRkN2IxZTA5Li45MTg3MGE1NjdlYWI1ZTkx MjlmNzJiMTYwYzQxMjlkNGQ5NjI0NzFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wMS0xMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBbRVM2XSBTdXBwb3J0IHN1YmNsYXNzaW5nIHRoZSBTdHJpbmcgYnVp bHRpbiBvYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MzA2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgcGF0Y2ggYWRkcyBzdWJjbGFzc2luZyBvZiBzdHJpbmdzLiBBbHNvLCB0aGlzIHBh dGNoIGZpeGVzIGEgYnVnIHdoZXJlIHdlIGNvdWxkIGhhdmUKKyAgICAgICAgdGhlIHdyb25nIGlu ZGV4aW5nIHR5cGUgZm9yIGJ1aWx0aW5zIGNvbnN0cnVjdGVkIHdpdGhvdXQgc3RvcmFnZS4KKwor ICAgICAgICAqIHJ1bnRpbWUvUHJvdG90eXBlTWFwLmNwcDoKKyAgICAgICAgKEpTQzo6UHJvdG90 eXBlTWFwOjplbXB0eVN0cnVjdHVyZUZvclByb3RvdHlwZUZyb21CYXNlU3RydWN0dXJlKToKKyAg ICAgICAgKiBydW50aW1lL1N0cmluZ0NvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6Y29u c3RydWN0V2l0aFN0cmluZ0NvbnN0cnVjdG9yKToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvY2xh c3Mtc3ViY2xhc3Npbmctc3RyaW5nLmpzOiBBZGRlZC4KKyAgICAgICAgKHRlc3QpOgorCiAyMDE2 LTAxLTEyICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KIAogICAgICAgICBb RlRMXVtXaW42NF0gQ29tcGlsZSBlcnJvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1Byb3RvdHlwZU1hcC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9Qcm90b3R5cGVNYXAuY3BwCmluZGV4IGU2M2Y2NDIxODIwOTVkMzAwYzUyMWUyNDc1ZTA3 NWViZmY0N2M5ZDAuLmQ5YTE1MGRiMDY5NTI1OTVhYWE4MTQ2NzhiZjllMjgwZjlkMWI3YzMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Byb3RvdHlwZU1hcC5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvdG90eXBlTWFwLmNwcApAQCAt NzIsNyArNzIsNyBAQCBTdHJ1Y3R1cmUqIFByb3RvdHlwZU1hcDo6ZW1wdHlTdHJ1Y3R1cmVGb3JQ cm90b3R5cGVGcm9tQmFzZVN0cnVjdHVyZShKU09iamVjdCogcAogewogICAgIC8vIFdlIGN1cnJl bnRseSBkbyBub3QgaGF2ZSBpbmxpbmUgY2FwYWNpdHkgc3RhdGljIGFuYWx5c2lzIGZvciBzdWJj bGFzc2VzIGFuZCBhbGwgaW50ZXJuYWwgZnVuY3Rpb24gY29uc3RydWN0b3JzIGhhdmUgYSBkZWZh dWx0IGlubGluZSBjYXBhY2l0eSBvZiAwLgogICAgIEluZGV4aW5nVHlwZSBpbmRleGluZ1R5cGUg PSBiYXNlU3RydWN0dXJlLT5pbmRleGluZ1R5cGUoKTsKLSAgICBpZiAocHJvdG90eXBlLT5zdHJ1 Y3R1cmUoKS0+YW55T2JqZWN0SW5DaGFpbk1heUludGVyY2VwdEluZGV4ZWRBY2Nlc3NlcygpKQor ICAgIGlmIChwcm90b3R5cGUtPnN0cnVjdHVyZSgpLT5hbnlPYmplY3RJbkNoYWluTWF5SW50ZXJj ZXB0SW5kZXhlZEFjY2Vzc2VzKCkgJiYgaGFzSW5kZXhlZFByb3BlcnRpZXMoaW5kZXhpbmdUeXBl KSkKICAgICAgICAgaW5kZXhpbmdUeXBlID0gKGluZGV4aW5nVHlwZSAmIH5JbmRleGluZ1NoYXBl TWFzaykgfCBTbG93UHV0QXJyYXlTdG9yYWdlU2hhcGU7CiAKICAgICByZXR1cm4gY3JlYXRlRW1w dHlTdHJ1Y3R1cmUocHJvdG90eXBlLCBiYXNlU3RydWN0dXJlLT50eXBlSW5mbygpLCBiYXNlU3Ry dWN0dXJlLT5jbGFzc0luZm8oKSwgaW5kZXhpbmdUeXBlLCAwKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ0NvbnN0cnVjdG9yLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ0NvbnN0cnVjdG9yLmNwcAppbmRleCAyYWNmMDcz NWM1M2ZjNDBlZDQ3NmNkMDFlZjFjMTQ0MDgyMWU2Y2EwLi44MzVkMjQ2NDkzODE5MzcwNGZhM2Vj NzhiMmJiYzZmZTk3ZGI5ZjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TdHJpbmdDb25zdHJ1Y3Rvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvU3RyaW5nQ29uc3RydWN0b3IuY3BwCkBAIC0xMjYsOSArMTI2LDkgQEAgc3RhdGljIEVu Y29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgY29uc3RydWN0V2l0aFN0cmluZ0NvbnN0cnVjdG9y KEV4ZWNTdGF0ZSogZXgKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwogCiAgICAgaWYgKCFleGVj LT5hcmd1bWVudENvdW50KCkpCi0gICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoU3RyaW5n T2JqZWN0OjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdC0+c3RyaW5nT2JqZWN0U3RydWN0dXJlKCkp KTsKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShTdHJpbmdPYmplY3Q6OmNyZWF0ZSh2 bSwgSW50ZXJuYWxGdW5jdGlvbjo6Y3JlYXRlU3ViY2xhc3NTdHJ1Y3R1cmUoZXhlYywgZXhlYy0+ bmV3VGFyZ2V0KCksIGdsb2JhbE9iamVjdC0+c3RyaW5nT2JqZWN0U3RydWN0dXJlKCkpKSk7CiAK LSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKFN0cmluZ09iamVjdDo6Y3JlYXRlKHZtLCBnbG9i YWxPYmplY3QtPnN0cmluZ09iamVjdFN0cnVjdHVyZSgpLCBleGVjLT51bmNoZWNrZWRBcmd1bWVu dCgwKS50b1N0cmluZyhleGVjKSkpOworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoU3RyaW5n T2JqZWN0OjpjcmVhdGUodm0sIEludGVybmFsRnVuY3Rpb246OmNyZWF0ZVN1YmNsYXNzU3RydWN0 dXJlKGV4ZWMsIGV4ZWMtPm5ld1RhcmdldCgpLCBnbG9iYWxPYmplY3QtPnN0cmluZ09iamVjdFN0 cnVjdHVyZSgpKSwgZXhlYy0+dW5jaGVja2VkQXJndW1lbnQoMCkudG9TdHJpbmcoZXhlYykpKTsK IH0KIAogQ29uc3RydWN0VHlwZSBTdHJpbmdDb25zdHJ1Y3Rvcjo6Z2V0Q29uc3RydWN0RGF0YShK U0NlbGwqLCBDb25zdHJ1Y3REYXRhJiBjb25zdHJ1Y3REYXRhKQpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9jbGFzcy1zdWJjbGFzc2luZy1zdHJpbmcuanMg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2NsYXNzLXN1YmNsYXNzaW5nLXN0 cmluZy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5iZDliMzc3MjliNDY0ZDgxMTdhMGMxZDdhNWE2NzQ1ZmVkMzlh NzkxCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy9jbGFzcy1zdWJjbGFzc2luZy1zdHJpbmcuanMKQEAgLTAsMCArMSwzOCBAQAorQSA9IGNsYXNz IGV4dGVuZHMgU3RyaW5nIHsgfQorQiA9IGNsYXNzIGV4dGVuZHMgQSB7IGdldCA0KCkgeyByZXR1 cm4gMTsgfSB9CitDID0gY2xhc3MgZXh0ZW5kcyBCIHsgfQorCitBLnByb3RvdHlwZVszXSA9IDE7 CisKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgbGV0IGEgPSBuZXcgQSgiZm9vIik7CisgICAgbGV0 IGIgPSBuZXcgQigiYmF6Iik7CisgICAgbGV0IGMgPSBuZXcgQygiYmFyIik7CisKKyAgICAvLyBT dHJpbmcgb2JqZWN0cyBoYXZlIGEgbm9uLXdyaXRhYmxlIGxlbmd0aCBwcm9wZXJ0eQorICAgIGEu bGVuZ3RoID0gMTsKKyAgICBiLmxlbmd0aCA9IDE7CisgICAgYy5sZW5ndGggPSAxOworCisgICAg aWYgKGEubGVuZ3RoICE9PSAzIHx8IGIubGVuZ3RoICE9PSAzIHx8IGMubGVuZ3RoICE9PSAzKQor ICAgICAgICB0aHJvdyAibm90IHN0cmluZyBvYmplY3RzIjsKKworICAgIGlmICghKGEgaW5zdGFu Y2VvZiBBICYmIGEgaW5zdGFuY2VvZiBTdHJpbmcpKQorICAgICAgICB0aHJvdyAiYSBoYXMgaW5j b3JyZWN0IHByb3RvdHlwZSBjaGFpbiI7CisKKyAgICBpZiAoIShiIGluc3RhbmNlb2YgQiAmJiBi IGluc3RhbmNlb2YgQSAmJiBiIGluc3RhbmNlb2YgU3RyaW5nKSkKKyAgICAgICAgdGhyb3cgImIg aGFzIGluY29ycmVjdCBwcm90b3R5cGUgY2hhaW4iOworCisgICAgaWYgKCEoYyBpbnN0YW5jZW9m IEMgJiYgYyBpbnN0YW5jZW9mIEIgJiYgYyBpbnN0YW5jZW9mIEEgJiYgYyBpbnN0YW5jZW9mIFN0 cmluZykpCisgICAgICAgIHRocm93ICJjIGhhcyBpbmNvcnJlY3QgcHJvdG90eXBlIGNoYWluIjsK KworICAgIGlmIChhWzRdICE9PSB1bmRlZmluZWQgfHwgYls0XSAhPT0gMSB8fCBjWzRdICE9PSAx KQorICAgICAgICB0aHJvdyAiYmFkIGluZGV4aW5nIHR5cGUgd2l0aCBhY2Nlc3NvcnMgb24gY2hh aW4iOworCisgICAgaWYgKGFbM10gIT09IDEgfHwgYlszXSAhPT0gMSB8fCBjWzNdICE9PSAxKQor ICAgICAgICB0aHJvdyAiYmFkIGluZGV4aW5nIHR5cGUgd2l0aCB2YWx1ZXMgb24gY2hhaW4iOwor fQorbm9JbmxpbmUodGVzdCk7CisKK2ZvciAoaSA9IDA7IGkgPCAxMDAwMDsgaSsrKQorICAgIHRl c3QoKTsK