152798 2016-01-06 12:28:57 -0800 Make sure that the basic throw-from-operation mode of throwing makes sense in FTL B3 2016-01-06 13:17:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 151686 1 fpizlo fpizlo barraclough benjamin ggaren keith_miller mark.lam mhahnenb msaboff oliver saam sam oldest_to_newest 1153147 0 fpizlo 2016-01-06 12:28:57 -0800 Patch forthcoming. 1153149 1 268389 fpizlo 2016-01-06 12:31:42 -0800 Created attachment 268389 the patch 1153157 2 fpizlo 2016-01-06 12:50:10 -0800 Landed in http://trac.webkit.org/changeset/194655 1153186 3 268389 saam 2016-01-06 13:17:43 -0800 Comment on attachment 268389 the patch LGTM too 268389 2016-01-06 12:31:42 -0800 2016-01-06 12:46:01 -0800 the patch blah.patch text/plain 5882 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NjUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE2LTAxLTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TWFrZSBzdXJlIHRoYXQgdGhlIGJhc2ljIHRocm93LWZyb20tb3BlcmF0aW9uIG1vZGUgb2YgdGhy b3dpbmcgbWFrZXMgc2Vuc2UgaW4gRlRMIEIzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI3OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHJlYWxseSBqdXN0IGNvbnRhaW5zIG9uZSBjaGFuZ2U6 IHdlIGlubGluZSBlbWl0QnJhbmNoVG9PU1JFeGl0SWZXaWxsQ2F0Y2hFeGNlcHRpb24oKQorICAg ICAgICBpbnRvIGNhbGxDaGVjaygpLCBzaW5jZSB0aGF0IHdhcyBpdHMgb25seSBjYWxsZXIuIFRo aXMgbWFrZXMgaXQgYSBiaXQgbW9yZSBjbGVhciB3aGF0IGlzCisgICAgICAgIGdvaW5nIG9uLgor CisgICAgICAgIEl0IHR1cm5zIG91dCB0aGF0IEZUTCBCMyBhbHJlYWR5IGhhbmRsZWQgdGhpcyBj YXNlIHByb3Blcmx5LiBJIGFkZGVkIGEgdGVzdCB0aGF0IEkgYmVsaWV2ZQorICAgICAgICBpbGx1 c3RyYXRlcyB0aGlzLiBOb3RlIHRoYXQgYWx0aG91Z2ggdGhlIHRlc3QgdXNlcyBHZXRCeUlkLCB3 aGljaCBvcmRpbmFyaWx5IHRocm93cworICAgICAgICBleGNlcHRpb25zIGZyb20gaW5zaWRlIGEg cGF0Y2hwb2ludCwgaXQgdXNlcyBpdCBpbiBzdWNoIGEgd2F5IHRoYXQgdGhlIGV4Y2VwdGlvbiBp cyB0aHJvd24KKyAgICAgICAgZnJvbSB0aGUgb3BlcmF0aW9uIGNhbGwgZm9yIHRoZSBub24tY2Vs bCBieXBhc3MgcGF0aCBvZiBhIEdldEJ5SWQoVW50eXBlZFVzZTopLgorCisgICAgICAgICogZnRs L0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZH VG9MTFZNOjpjYWxsQ2hlY2spOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0xM Vk06OmFwcGVuZE9TUkV4aXRBcmd1bWVudHNGb3JQYXRjaHBvaW50SWZXaWxsQ2F0Y2hFeGNlcHRp b24pOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0xMVk06Omxvd0Jsb2NrKToK KyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjplbWl0QnJhbmNoVG9PU1JF eGl0SWZXaWxsQ2F0Y2hFeGNlcHRpb24pOiBEZWxldGVkLgorICAgICAgICAqIHRlc3RzL3N0cmVz cy9mdGwtb3BlcmF0aW9uLWV4Y2VwdGlvbi5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorCiAy MDE2LTAxLTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIGR1cGxpY2F0ZSBjaGVjawpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHJldmlzaW9uIDE5 NDY0OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMDExMyw5ICsxMDExMywxNiBAQCBwcml2YXRlOgogICAgICAg ICBMVmFsdWUgZXhjZXB0aW9uID0gbV9vdXQubG9hZDY0KG1fb3V0LmFic29sdXRlKHZtKCkuYWRk cmVzc09mRXhjZXB0aW9uKCkpKTsKICAgICAgICAgTFZhbHVlIGhhZEV4Y2VwdGlvbiA9IG1fb3V0 Lm5vdFplcm82NChleGNlcHRpb24pOwogCi0gICAgICAgIGJvb2wgZW1pdHRlZEV4Y2VwdGlvbkhh bmRsaW5nQ29kZUZvck9TUkV4aXQgPSBlbWl0QnJhbmNoVG9PU1JFeGl0SWZXaWxsQ2F0Y2hFeGNl cHRpb24oaGFkRXhjZXB0aW9uKTsKLSAgICAgICAgaWYgKGVtaXR0ZWRFeGNlcHRpb25IYW5kbGlu Z0NvZGVGb3JPU1JFeGl0KSAvLyBJdCBhbHJlYWR5IHRvb2sgY2FyZSBvZiBleGNlcHRpb24gaGFu ZGxpbmcgbG9naWMuCisgICAgICAgIENvZGVPcmlnaW4gb3BDYXRjaE9yaWdpbjsKKyAgICAgICAg SGFuZGxlckluZm8qIGV4Y2VwdGlvbkhhbmRsZXI7CisgICAgICAgIGlmIChtX2dyYXBoLndpbGxD YXRjaEV4Y2VwdGlvbkluTWFjaGluZUZyYW1lKG1fb3JpZ2luLmZvckV4aXQsIG9wQ2F0Y2hPcmln aW4sIGV4Y2VwdGlvbkhhbmRsZXIpKSB7CisgICAgICAgICAgICBib29sIGV4aXRPSyA9IHRydWU7 CisgICAgICAgICAgICBib29sIGlzRXhjZXB0aW9uSGFuZGxlciA9IHRydWU7CisgICAgICAgICAg ICBhcHBlbmRPU1JFeGl0KAorICAgICAgICAgICAgICAgIFVuY291bnRhYmxlLCBub1ZhbHVlKCks IG51bGxwdHIsIGhhZEV4Y2VwdGlvbiwKKyAgICAgICAgICAgICAgICBtX29yaWdpbi53aXRoRm9y RXhpdEFuZEV4aXRPSyhvcENhdGNoT3JpZ2luLCBleGl0T0spLCBpc0V4Y2VwdGlvbkhhbmRsZXIp OwogICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAKICAgICAgICAgTEJhc2ljQmxvY2sg Y29udGludWF0aW9uID0gRlRMX05FV19CTE9DSyhtX291dCwgKCJFeGNlcHRpb24gY2hlY2sgY29u dGludWF0aW9uIikpOwogCkBAIC0xMDE0OCwxOCArMTAxNTUsNiBAQCBwcml2YXRlOgogICAgIH0K ICNlbmRpZiAvLyAhRlRMX1VTRVNfQjMKIAotICAgIGJvb2wgZW1pdEJyYW5jaFRvT1NSRXhpdElm V2lsbENhdGNoRXhjZXB0aW9uKExWYWx1ZSBoYWRFeGNlcHRpb24pCi0gICAgewotICAgICAgICBD b2RlT3JpZ2luIG9wQ2F0Y2hPcmlnaW47Ci0gICAgICAgIEhhbmRsZXJJbmZvKiBleGNlcHRpb25I YW5kbGVyOwotICAgICAgICBib29sIHdpbGxDYXRjaEV4Y2VwdGlvbiA9IG1fZ3JhcGgud2lsbENh dGNoRXhjZXB0aW9uSW5NYWNoaW5lRnJhbWUobV9vcmlnaW4uZm9yRXhpdCwgb3BDYXRjaE9yaWdp biwgZXhjZXB0aW9uSGFuZGxlcik7IAotICAgICAgICBpZiAoIXdpbGxDYXRjaEV4Y2VwdGlvbikK LSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgICAgICBhcHBlbmRPU1JFeGl0KFVuY291 bnRhYmxlLCBub1ZhbHVlKCksIG51bGxwdHIsIGhhZEV4Y2VwdGlvbiwgbV9vcmlnaW4ud2l0aEZv ckV4aXRBbmRFeGl0T0sob3BDYXRjaE9yaWdpbiwgdHJ1ZSksIHRydWUpOwotICAgICAgICByZXR1 cm4gdHJ1ZTsKLSAgICB9Ci0gICAgCiAgICAgTEJhc2ljQmxvY2sgbG93QmxvY2soREZHOjpCYXNp Y0Jsb2NrKiBibG9jaykKICAgICB7CiAgICAgICAgIHJldHVybiBtX2Jsb2Nrcy5nZXQoYmxvY2sp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9mdGwtb3BlcmF0aW9u LWV4Y2VwdGlvbi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMv c3RyZXNzL2Z0bC1vcGVyYXRpb24tZXhjZXB0aW9uLmpzCShyZXZpc2lvbiAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9mdGwtb3BlcmF0aW9uLWV4Y2VwdGlvbi5qcwko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDYyIEBACitmdW5jdGlvbiBmb28obywgcCkgeworICAg IHZhciB4ID0gMTAwOworICAgIHZhciByZXN1bHQgPSAxMDE7CisgICAgdHJ5IHsKKyAgICAgICAg eCA9IDEwMjsKKyAgICAgICAgcCA9IDEwMzsKKyAgICAgICAgcmVzdWx0ID0gby5mOworICAgICAg ICBvID0gMTA0OworICAgICAgICBwID0gMTA1OworICAgICAgICB4ID0gMTA2OworICAgIH0gY2F0 Y2ggKGUpIHsKKyAgICAgICAgcmV0dXJuIHtvdXRjb21lOiAiZXhjZXB0aW9uIiwgdmFsdWVzOiBb bywgcCwgeCwgcmVzdWx0XX07CisgICAgfQorICAgIHJldHVybiB7b3V0Y29tZTogInJldHVybiIs IHZhbHVlczogW28sIHAsIHgsIHJlc3VsdF19OworfQorCitub0lubGluZShmb28pOworCisvLyBX YXJtIHVwIGZvbygpIHdpdGggcG9seW1vcnBoaWMgb2JqZWN0cyBhbmQgbm9uLW9iamVjdCB0eXBl cy4KK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwOyArK2kpIHsKKyAgICB2YXIgbzsKKyAgICB2 YXIgaXNPYmplY3QgPSBpICYgMTsKKyAgICBpZiAoaXNPYmplY3QpIHsKKyAgICAgICAgbyA9IHtm OjEwN307CisgICAgICAgIG9bImkiICsgaV0gPSBpOyAvLyBNYWtlIGl0IHBvbHltb3JwaGljLgor ICAgIH0gZWxzZQorICAgICAgICBvID0gNDI7CisgICAgdmFyIHJlc3VsdCA9IGZvbyhvKTsKKyAg ICBpZiAocmVzdWx0Lm91dGNvbWUgIT09ICJyZXR1cm4iKQorICAgICAgICB0aHJvdyAiRXJyb3Ig aW4gbG9vcDogYmFkIG91dGNvbWU6ICIgKyByZXN1bHQub3V0Y29tZTsKKyAgICBpZiAocmVzdWx0 LnZhbHVlcy5sZW5ndGggIT09IDQpCisgICAgICAgIHRocm93ICJFcnJvciBpbiBsb29wOiBiYWQg bnVtYmVyIG9mIHZhbHVlczogIiArIHJlc3VsdC52YWx1ZXMubGVuZ3RoOworICAgIGlmIChyZXN1 bHQudmFsdWVzWzBdICE9PSAxMDQpCisgICAgICAgIHRocm93ICJFcnJvciBpbiBsb29wOiBiYWQg dmFsdWVzWzBdOiAiICsgcmVzdWx0LnZhbHVlc1swXTsKKyAgICBpZiAocmVzdWx0LnZhbHVlc1sx XSAhPT0gMTA1KQorICAgICAgICB0aHJvdyAiRXJyb3IgaW4gbG9vcDogYmFkIHZhbHVlc1sxXTog IiArIHJlc3VsdC52YWx1ZXNbMV07CisgICAgaWYgKHJlc3VsdC52YWx1ZXNbMl0gIT09IDEwNikK KyAgICAgICAgdGhyb3cgIkVycm9yIGluIGxvb3A6IGJhZCB2YWx1ZXNbMl06ICIgKyByZXN1bHQu dmFsdWVzWzJdOworICAgIGlmIChpc09iamVjdCkgeworICAgICAgICBpZiAocmVzdWx0LnZhbHVl c1szXSAhPT0gMTA3KQorICAgICAgICAgICAgdGhyb3cgIkVycm9yIGluIGxvb3A6IGJhZCB2YWx1 ZXNbM106ICIgKyByZXN1bHQudmFsdWVzWzNdOworICAgIH0gZWxzZSB7CisgICAgICAgIGlmIChy ZXN1bHQudmFsdWVzWzNdICE9PSB2b2lkIDApCisgICAgICAgICAgICB0aHJvdyAiRXJyb3IgaW4g bG9vcDogYmFkIHZhbHVlc1szXTogIiArIHJlc3VsdC52YWx1ZXNbM107CisgICAgfQorfQorCisv LyBOb3cgdGhyb3cgYW4gZXhjZXB0aW9uLgordmFyIHJlc3VsdCA9IGZvbyhudWxsLCAxMDgpOwor aWYgKHJlc3VsdC5vdXRjb21lICE9PSAiZXhjZXB0aW9uIikKKyAgICB0aHJvdyAiRXJyb3IgYXQg ZW5kOiBiYWQgb3V0Y29tZTogIiArIHJlc3VsdC5vdXRjb21lOworaWYgKHJlc3VsdC52YWx1ZXMu bGVuZ3RoICE9PSA0KQorICAgIHRocm93ICJFcnJvciBhdCBlbmQ6IGJhZCBudW1iZXIgb2YgdmFs dWVzOiAiICsgcmVzdWx0LnZhbHVlcy5sZW5ndGg7CitpZiAocmVzdWx0LnZhbHVlc1swXSAhPT0g bnVsbCkKKyAgICB0aHJvdyAiRXJyb3IgYXQgZW5kOiBiYWQgdmFsdWVzWzBdOiAiICsgcmVzdWx0 LnZhbHVlc1swXTsKK2lmIChyZXN1bHQudmFsdWVzWzFdICE9PSAxMDMpCisgICAgdGhyb3cgIkVy cm9yIGF0IGVuZDogYmFkIHZhbHVlc1sxXTogIiArIHJlc3VsdC52YWx1ZXNbMV07CitpZiAocmVz dWx0LnZhbHVlc1syXSAhPT0gMTAyKQorICAgIHRocm93ICJFcnJvciBhdCBlbmQ6IGJhZCB2YWx1 ZXNbMl06ICIgKyByZXN1bHQudmFsdWVzWzJdOworaWYgKHJlc3VsdC52YWx1ZXNbM10gIT09IDEw MSkKKyAgICB0aHJvdyAiRXJyb3IgYXQgZW5kOiBiYWQgdmFsdWVzWzNdOiAiICsgcmVzdWx0LnZh bHVlc1szXTsKKwo=