152748 2016-01-05 12:26:49 -0800 Rename badly named JSC_timeout env var to JSCTEST_timeout. 2016-01-18 04:27:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153204 1 mark.lam mark.lam lforschler ossy oldest_to_newest 1152813 0 mark.lam 2016-01-05 12:26:49 -0800 Now that we validate JSC options, the badly named JSC_timeout env var causes the bots to have a bad time. 1152816 1 268307 mark.lam 2016-01-05 12:30:47 -0800 Created attachment 268307 proposed patch. 1152839 2 268307 ggaren 2016-01-05 12:41:55 -0800 Comment on attachment 268307 proposed patch. r=me 1152850 3 mark.lam 2016-01-05 12:57:54 -0800 Thanks for the review. Landed in r194601: <http://trac.webkit.org/r194601>. 1156376 4 ossy 2016-01-18 03:10:43 -0800 (In reply to comment #0) > Now that we validate JSC options, the badly named JSC_timeout env var causes > the bots to have a bad time. I don't understand this change at all. I can't find any references to JSCTEST_timeout in the source code. jsc still uses JSC_timeout environment variable. That's why we have many stucked jsc processes on the ARM64 Linux tester bot. I already set JSC_timeout locally to avoid stucked processes. But we need a proper fix, for example changing jsc behaviour too or rolling out this patch. 1156379 5 ossy 2016-01-18 04:27:33 -0800 I got the goal of this change, and uploaded the fix in bug153204 . 268307 2016-01-05 12:30:47 -0800 2016-01-05 12:41:55 -0800 proposed patch. bug-152748.patch text/plain 3953 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NDU5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTAxLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZW5hbWUgYmFkbHkgbmFtZWQgSlNDX3RpbWVvdXQgZW52IHZhciB0byBKU0NURVNU X3RpbWVvdXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTI3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBOb3cgdGhhdCB3ZSB2YWxpZGF0ZSBKU0Mgb3B0aW9ucywgdGhlIGJhZGx5IG5hbWVkIEpTQ190 aW1lb3V0IGVudiB2YXIgY2F1c2VzIHRoZQorICAgICAgICBib3RzIHRvIGhhdmUgYSBiYWQgdGlt ZS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzOgorICAgICAg ICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6CisKIDIwMTYtMDEtMDQgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFsbG93 IHRvIHNhdmUgYW5kIHJlc3RvcmUgc2Vzc2lvbgpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tamF2 YXNjcmlwdGNvcmUtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNj cmlwdGNvcmUtdGVzdHMJKHJldmlzaW9uIDE5NDU5MCkKKysrIFRvb2xzL1NjcmlwdHMvcnVuLWph dmFzY3JpcHRjb3JlLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xNjIsNyArMTYyLDcgQEAgaWYg KGRlZmluZWQoJGdtYWxsb2NQYXRoKSkgewogCiBteSAkcHJvZHVjdERpciA9IGpzY1Byb2R1Y3RE aXIoKTsKICRFTlZ7RFlMRF9GUkFNRVdPUktfUEFUSH0gPSAkcHJvZHVjdERpcjsKLSRFTlZ7SlND X3RpbWVvdXR9ID0gNjAgdW5sZXNzICRFTlZ7SlNDX3RpbWVvdXR9OyAjIFNldCBhIDYwIHNlY29u ZCB0aW1lb3V0IG9uIGFsbCBqc2MgdGVzdHMgKGlmIGVudmlyb25tZW50IHZhcmlhYmxlIG5vdCBk ZWZpbmVkIGFscmVhZHkpLgorJEVOVntKU0NURVNUX3RpbWVvdXR9ID0gNjAgdW5sZXNzICRFTlZ7 SlNDVEVTVF90aW1lb3V0fTsgIyBTZXQgYSA2MCBzZWNvbmQgdGltZW91dCBvbiBhbGwganNjIHRl c3RzIChpZiBlbnZpcm9ubWVudCB2YXJpYWJsZSBub3QgZGVmaW5lZCBhbHJlYWR5KS4KICRFTlZ7 VFp9PSJVUy9QYWNpZmljIjsgIyBTb21lIHRlc3RzIGZhaWwgaWYgdGhlIHRpbWUgem9uZSBpcyBu b3Qgc2V0IHRvIFVTL1BhY2lmaWMgKDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzYzNjM+KQogc2V0 UGF0aEZvclJ1bm5pbmdXZWJLaXRBcHAoXCVFTlYpIGlmIGlzQ3lnd2luKCk7CiAKSW5kZXg6IFRv b2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNpb24gMTk0NTkwKQorKysgVG9vbHMvU2Ny aXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtNjA2LDcgKzYwNiw3 IEBAIGNsYXNzIFBsYW4KICAgICAgICAgc2NyaXB0ICs9ICJjZCAucnVubmVyXG4iCiAKICAgICAg ICAgc2NyaXB0ICs9ICJleHBvcnQgRFlMRF9GUkFNRVdPUktfUEFUSD0kKGNkICN7JHRlc3RpbmdG cmFtZXdvcmtQYXRoLmRpcm5hbWV9OyBwd2QpXG4iCi0gICAgICAgIHNjcmlwdCArPSAiZXhwb3J0 IEpTQ190aW1lb3V0PSN7U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShFTlZbJ0pTQ190aW1lb3V0J10p fVxuIgorICAgICAgICBzY3JpcHQgKz0gImV4cG9ydCBKU0NURVNUX3RpbWVvdXQ9I3tTaGVsbHdv cmRzLnNoZWxsZXNjYXBlKEVOVlsnSlNDVEVTVF90aW1lb3V0J10pfVxuIgogICAgICAgICAkZW52 VmFycy5lYWNoIHsgfHZhcnwgc2NyaXB0ICs9ICJleHBvcnQgIiA8PCB2YXIgPDwgIlxuIiB9CiAg ICAgICAgIHNjcmlwdCArPSAiI3tzaGVsbENvbW1hbmR9IHx8IGV4aXQgMSIKICAgICAgICAgImVj aG8gI3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBlKHNjcmlwdCl9ID4gI3tTaGVsbHdvcmRzLnNoZWxs ZXNjYXBlKChQYXRobmFtZS5uZXcoIi4uIikgKyBAbmFtZSkudG9fcyl9IgpAQCAtMTcxNSw3ICsx NzE1LDcgQEAgZGVmIHJ1blRlc3RSdW5uZXIKICAgICAgICAgcmVtb3RlU2NyaXB0ICs9ICJjZCAj eyRvdXRwdXREaXIuYmFzZW5hbWV9Ly5ydW5uZXIgJiYgIgogICAgICAgICByZW1vdGVTY3JpcHQg Kz0gImV4cG9ydCBEWUxEX0ZSQU1FV09SS19QQVRIPVxcXCJcXCQoY2QgI3skdGVzdGluZ0ZyYW1l d29ya1BhdGguZGlybmFtZX07IHB3ZClcXFwiICYmICIKICAgICAgICAgcmVtb3RlU2NyaXB0ICs9 ICJleHBvcnQgTERfTElCUkFSWV9QQVRIPSN7JHJlbW90ZURpcmVjdG9yeX0vI3skb3V0cHV0RGly LmJhc2VuYW1lfS8jeyRqc2NQYXRoLmRpcm5hbWV9ICYmICIKLSAgICAgICAgcmVtb3RlU2NyaXB0 ICs9ICJleHBvcnQgSlNDX3RpbWVvdXQ9I3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBlKEVOVlsnSlND X3RpbWVvdXQnXSl9ICYmICIKKyAgICAgICAgcmVtb3RlU2NyaXB0ICs9ICJleHBvcnQgSlNDVEVT VF90aW1lb3V0PSN7U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShFTlZbJ0pTQ1RFU1RfdGltZW91dCdd KX0gJiYgIgogICAgICAgICAkZW52VmFycy5lYWNoIHsgfHZhcnwgcmVtb3RlU2NyaXB0ICs9ICJl eHBvcnQgIiA8PCB2YXIgPDwgIlxuIiB9CiAgICAgICAgIHJlbW90ZVNjcmlwdCArPSAiI3t0ZXN0 UnVubmVyQ29tbWFuZH1cIiIKICAgICAgICAgcnVuQW5kTW9uaXRvclRlc3RSdW5uZXJDb21tYW5k KCJzc2giLCAiLXAiLCAkcmVtb3RlUG9ydC50b19zLCAiI3skcmVtb3RlVXNlcn1AI3skcmVtb3Rl SG9zdH0iLCByZW1vdGVTY3JpcHQpCkBAIC0xNzc1LDE2ICsxNzc1LDE2IEBAIGlmICEkbnVtQ2hp bGRQcm9jZXNzZXMKICAgICBlbmQKIGVuZAogCi1pZiAkZW5hYmxlRlRMIGFuZCBFTlZbIkpTQ190 aW1lb3V0Il0KK2lmICRlbmFibGVGVEwgYW5kIEVOVlsiSlNDVEVTVF90aW1lb3V0Il0KICAgICAj IEN1cnJlbnRseSwgdXNpbmcgdGhlIEZUTCBpcyBhIHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24gcGFy dGljdWxhcmx5IGluIHJlYWwKICAgICAjIChpLmUuIG5vbi1sb29weSkgYmVuY2htYXJrcy4gQWNj b3VudCBmb3IgdGhpcyBpbiB0aGUgdGltZW91dC4KLSAgICBFTlZbIkpTQ190aW1lb3V0Il0gPSAo RU5WWyJKU0NfdGltZW91dCJdLnRvX2kgKiAyKS50b19zCisgICAgRU5WWyJKU0NURVNUX3RpbWVv dXQiXSA9IChFTlZbIkpTQ1RFU1RfdGltZW91dCJdLnRvX2kgKiAyKS50b19zCiBlbmQKIAotaWYg RU5WWyJKU0NfdGltZW91dCJdCitpZiBFTlZbIkpTQ1RFU1RfdGltZW91dCJdCiAgICAgIyBJbiB0 aGUgd29yc3QgY2FzZSwgdGhlIHByb2Nlc3NvcnMganVzdCBpbnRlcmZlcmUgd2l0aCBlYWNoIG90 aGVyLgogICAgICMgSW5jcmVhc2UgdGhlIHRpbWVvdXQgcHJvcG9ydGlvbmFsbHkgdG8gdGhlIG51 bWJlciBvZiBwcm9jZXNzb3JzLgotICAgIEVOVlsiSlNDX3RpbWVvdXQiXSA9IChFTlZbIkpTQ190 aW1lb3V0Il0udG9faS50b19mICogTWF0aC5zcXJ0KCRudW1DaGlsZFByb2Nlc3NlcykpLnRvX2ku dG9fcworICAgIEVOVlsiSlNDVEVTVF90aW1lb3V0Il0gPSAoRU5WWyJKU0NURVNUX3RpbWVvdXQi XS50b19pLnRvX2YgKiBNYXRoLnNxcnQoJG51bUNoaWxkUHJvY2Vzc2VzKSkudG9faS50b19zCiBl bmQKIAogZGVmIHJ1bkJ1bmRsZQo=