15242 2007-09-19 17:30:46 -0700 Needs test: Improperly Linked CSS document (404) still loads contained styles 2024-05-30 19:09:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) Mac OS X 10.4 ASSIGNED InRadar P2 Normal --- 1 petey31 webkit-unassigned ahmad.saleem792 ap b30r4 ddkilzer eric mal mitz petey31 webkit oldest_to_newest 278 0 petey31 2007-09-19 17:30:46 -0700 Observed behavior: A CSS file is included on a page with an invalid path. A 404 html page is given in response by the server. The CSS styles on the 404 html page will be used on the original page. Expected behavior: The contents of the returned 404 page are ignored. 276 1 16329 petey31 2007-09-19 17:34:18 -0700 Created attachment 16329 Example of improper loading of css styles from 404 document A 404 page is loaded as a CSS document. Observed behavior: "Normal" link is blue (browser default), "u link" is green, "l link" is grey Expected behavior: All links are the browser default color 261 2 ap 2007-09-20 02:06:26 -0700 Confirmed with r25667 (and with shipping Safari/WebKit). 247 3 mrowe 2007-09-20 06:36:36 -0700 <rdar://problem/5494250> 231 4 ddkilzer 2007-09-20 12:51:51 -0700 (In reply to comment #1) > Created an attachment (id=16329) [edit] > Example of improper loading of css styles from 404 document > > A 404 page is loaded as a CSS document. > > Observed behavior: > "Normal" link is blue (browser default), "u link" is green, "l link" is grey Note that this test only works if http://webkit.org/ is not in your browser history! You'll either need to change the "http://webkit.org/" URL in the test to a URL that isn't in your browser history, or you need to clear your browser history through "Reset Safari" in the "Safari" menu. 228 5 mitz 2007-09-20 13:02:27 -0700 (In reply to comment #4) > You'll either need to change the "http://webkit.org/" URL in the test > to a URL that isn't in your browser history, or you need to clear your browser > history through "Reset Safari" in the "Safari" menu. You can delete individual history items in Safari's bookmarks viewer. 64969 6 18035 mal 2007-12-21 10:53:33 -0800 Created attachment 18035 Another test case for interpreting styles in a 404 page I confirmed this on Windows (Safari 3.0.4 523/13). I created a test case before finding this bug already filed. I've attached it FWIW (it uses a span.nav instead of an A, so it doesn't depend on your visited link history). Curiously, the body{} style in the 404 response does not seem to get applied. Google's 404 reponse contains <style><!-- body {font-family: arial,sans-serif} div.nav {margin-top: 1ex} div.nav A {font-size: 10pt; font-family: arial,sans-serif} span.nav {font-size: 10pt; font-family: arial,sans-serif; font-weight: bold} div.nav A,span.big {font-size: 12pt; color: #0000cc} div.nav A {font-size: 10pt; color: black} A.l:link {color: #6f6f6f} A.u:link {color: green} //--></style> I haven't tested all the rules, but I've confirmed that span.nav gets applied but body does not. 69401 7 18920 hyatt 2008-02-04 15:05:01 -0800 Created attachment 18920 Patch that fixes this bug Not really sure if it is a good way to do it or not. I just stop the feeding of data to the CachedResource when a 404 happens. 69404 8 mitz 2008-02-04 15:10:15 -0800 Should probably apply to other 4xx and 5xx codes. 69405 9 18920 darin 2008-02-04 15:11:06 -0800 Comment on attachment 18920 Patch that fixes this bug Why handle 404 different from other 4xx errors? What about 3xx and 5xx? 69410 10 18920 darin 2008-02-04 15:30:09 -0800 Comment on attachment 18920 Patch that fixes this bug I think the approach in this patch is OK, but it should be for all 4xx and 5xx, not specifically 404. I also think that instead of calling data() and finish(), you should call error(). 82736 11 webkit 2008-06-09 04:54:52 -0700 I've tested the bug in Webkit r34382 on OS X and, to my surprise, the issue is not replicable in this build. This test https://bugs.webkit.org/attachment.cgi?id=18035 passes in the Webkit but still fails in stock Safari 3.1.1 for OS X. Any confirmations? 82739 12 ap 2008-06-09 06:14:59 -0700 I also cannot reproduce with this nightly. I think that it would make sense to isolate the revision that fixed this, and possibly to land a test case, if there isn't one already. 82749 13 mitz 2008-06-09 07:55:05 -0700 I think this was fixed by Hyatt for Acid3. 82820 14 webkit 2008-06-10 03:14:58 -0700 (In reply to comment #13) > I think this was fixed by Hyatt for Acid3. > Indeed, it was fixed in http://trac.webkit.org/changeset/30438 as part of fixing a bug: https://bugs.webkit.org/show_bug.cgi?id=16760 For LayoutTests I suggest to import these tests: http://biesi.damowmow.com/object/ 118484 15 b30r4 2009-04-23 01:58:21 -0700 *** Bug 25326 has been marked as a duplicate of this bug. *** 2038941 16 ahmad.saleem792 2024-05-30 19:09:33 -0700 This started passing in 2008 and also from Comment 14, we only have this copy available: https://web.archive.org/web/20050924094554/http://biesi.damowmow.com:80/object/002.html Do we still want to add these test or they might be already covered one? 16329 2007-09-19 17:34:18 -0700 2007-09-19 17:34:18 -0700 Example of improper loading of css styles from 404 document test.html text/html 289 petey31 PGh0bWw+Cgk8aGVhZD4KCQk8dGl0bGU+dGVzdCBjc3MgZXJyb3I8L3RpdGxlPgoJCTxsaW5rIHR5 cGU9InRleHQvY3NzIiBocmVmPSJodHRwOi8vd3d3Lmdvb2dsZS5jb20vYXNkYXNmYXNmIiAvPgoJ PC9oZWFkPgoJPGJvZHk+CgkJPGEgaHJlZj0iaHR0cDovL3dlYmtpdC5vcmciPk5vcm1hbDwvYT4K CQk8YSBjbGFzcz0idSIgaHJlZj0iaHR0cDovL3dlYmtpdC5vcmciPnUgbGluazwvYT4KCQk8YSBj bGFzcz0ibCIgaHJlZj0iaHR0cDovL3dlYmtpdC5vcmciPmwgbGluazwvYT4KCTwvYm9keT4KPC9o dG1sPg== 18035 2007-12-21 10:53:33 -0800 2007-12-21 10:53:33 -0800 Another test case for interpreting styles in a 404 page 404test.html text/html 1749 mal PGh0bWw+IA0KPGhlYWQ+IA0KICA8bGluayByZWw9c3R5bGVzaGVldCBocmVmPSJodHRwOi8vd3d3 Lmdvb2dsZS5jb20vbWlzc2luZy5jc3MiIHR5cGU9InRleHQvY3NzIj4NCiAgPHNjcmlwdD4NCiAg dmFyIHBhc3NlZCA9IHRydWU7DQogIGZ1bmN0aW9uIHNob3dSZXN1bHRzKCkgew0KICAgIHZhciBl bCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzdHlsZWQnKTsNCiAgICB2YXIgY1N0eWxlID0g ZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShlbCxudWxsKTsNCiAgICB2YXIg YlN0eWxlID0gZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5i b2R5LCBudWxsKQ0KDQogICAgdmFyIHJlcyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1 bHRzJyk7DQogICAgdmFyIHJlc3RhYmxlID0gIjxicj48dGFibGUgYm9yZGVyPTEgY2VsbHBhZGRp bmc9NCBjZWxsc3BhY2luZz0wPiI7DQogICAgcmVzdGFibGUgKz0gIjx0ciBzdHlsZT0nYmFja2dy b3VuZDogcmdiKDI0MCwyNDAsMjQwKSc+PHRkPlByb3BlcnR5PC90ZD48dGQ+Q29tcHV0ZWQ8L3Rk Pjx0ZD5FeHBlY3RlZDwvdGQ+PC90cj4iOw0KICAgIHJlc3RhYmxlICs9IHRhYmxlUm93KGJTdHls ZSwgY1N0eWxlLCAiRm9udCIsICJmb250LWZhbWlseSIpOw0KICAgIHJlc3RhYmxlICs9IHRhYmxl Um93KGJTdHlsZSwgY1N0eWxlLCAiV2VpZ2h0IiwgImZvbnQtd2VpZ2h0Iik7DQogICAgcmVzdGFi bGUgKz0gdGFibGVSb3coYlN0eWxlLCBjU3R5bGUsICJTaXplIiwgImZvbnQtc2l6ZSIpOw0KICAg IHJlc3RhYmxlICs9ICI8L3RhYmxlPjxoMiBpZD0nUkVTVUxUJz4iOw0KICAgIHJlc3RhYmxlICs9 IChwYXNzZWQgPyAiUEFTUyIgOiAiRkFJTCIpICsgIjwvaDI+IjsNCiAgICByZXMuaW5uZXJIVE1M ID0gcmVzdGFibGU7DQogICAgDQogIH0NCiAgZnVuY3Rpb24gdGFibGVSb3coYlN0eWxlLCBjU3R5 bGUsIG5hbWUsIGNzc05hbWUpIHsNCiAgICAgIHZhciBiID0gIndoaXRlIjsNCiAgICAgIGlmIChj U3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShjc3NOYW1lKQ0KICAgICAgICE9IGJTdHlsZS5nZXRQcm9w ZXJ0eVZhbHVlKGNzc05hbWUpKSB7DQogICAgICAgIGIgPSAicmdiKDI1NSwxOTIsMTkyKSI7DQog ICAgICAgIHBhc3NlZCA9IGZhbHNlOw0KICAgICAgfQ0KICAgIHJldHVybiAoIjx0cj48dGQ+IiAr IG5hbWUgKyAiPC90ZD4iDQogICAgICArICI8dGQgc3R5bGU9J2JhY2tncm91bmQ6ICIgKyBiICsg Iic+IiANCiAgICAgICsgY1N0eWxlLmdldFByb3BlcnR5VmFsdWUoY3NzTmFtZSkNCiAgICAgICsg IjwvdGQ+PHRkPiINCiAgICAgICsgYlN0eWxlLmdldFByb3BlcnR5VmFsdWUoY3NzTmFtZSkNCiAg ICAgICsgIjwvdGQ+PC90cj4iKTsNCiAgfQ0KICA8L3NjcmlwdD4NCjwvaGVhZD4gDQo8Ym9keSBp ZD0nYmR5JyBvbmxvYWQ9InNob3dSZXN1bHRzKCkiPg0KICA8c3BhbiBpZD0ic3R5bGVkIiBjbGFz cz0ibmF2Ij5UaGVzZSBsaW5lcyBzaG91bGQgYmUgaWRlbnRpY2FsLiBJZiBhIGNvbXB1dGVkIHN0 eWxlIGlzIHJlZCwgdGhlIHRlc3QgZmFpbGVkLjwvc3Bhbj4NCiAgPGJyLz4NCiAgPHNwYW4gaWQ9 InVuc3R5bGVkIj5UaGVzZSBsaW5lcyBzaG91bGQgYmUgaWRlbnRpY2FsLiBJZiBhIGNvbXB1dGVk IHN0eWxlIGlzIHJlZCwgdGhlIHRlc3QgZmFpbGVkLjwvc3Bhbj4NCiAgPGJyLz4NCiAgPGRpdiBp ZD0ncmVzdWx0cyc+PC9kaXY+DQo8L2JvZHk+DQo8L2h0bWw+IA0K 18920 2008-02-04 15:05:01 -0800 2010-06-11 14:44:11 -0700 Patch that fixes this bug patch.txt text/plain 1080 hyatt SW5kZXg6IGxvYWRlci9sb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxvYWRlci9sb2FkZXIuY3Bw CShyZXZpc2lvbiAyOTk0MykKKysrIGxvYWRlci9sb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMTIsOCArMTEyLDEyIEBAIHZvaWQgTG9hZGVyOjpkaWRGaW5pc2hMb2FkaW5nKFN1YnJlc291 cmMKIAogICAgIENhY2hlZFJlc291cmNlKiBvYmplY3QgPSByZXEtPmNhY2hlZFJlc291cmNlKCk7 CiAKKyAgICAvLyBOZXZlciBkZWxpdmVyIDQwNCBkYXRhIHRvIENhY2hlZFJlc291cmNlcy4KICAg ICBkb2NMb2FkZXItPnNldExvYWRJblByb2dyZXNzKHRydWUpOwotICAgIG9iamVjdC0+ZGF0YShs b2FkZXItPnJlc291cmNlRGF0YSgpLCB0cnVlKTsKKyAgICBpZiAob2JqZWN0LT5yZXNwb25zZSgp Lmh0dHBTdGF0dXNDb2RlKCkgIT0gNDA0KQorICAgICAgICBvYmplY3QtPmRhdGEobG9hZGVyLT5y ZXNvdXJjZURhdGEoKSwgdHJ1ZSk7CisgICAgZWxzZQorICAgICAgICBvYmplY3QtPmRhdGEoMCwg dHJ1ZSk7CiAgICAgZG9jTG9hZGVyLT5zZXRMb2FkSW5Qcm9ncmVzcyhmYWxzZSk7CiAgICAgb2Jq ZWN0LT5maW5pc2goKTsKIApAQCAtMTk3LDcgKzIwMSwxMSBAQCB2b2lkIExvYWRlcjo6ZGlkUmVj ZWl2ZURhdGEoU3VicmVzb3VyY2VMCiAgICAgICAgIHJldHVybjsKIAogICAgIENhY2hlZFJlc291 cmNlKiBvYmplY3QgPSByZXF1ZXN0LT5jYWNoZWRSZXNvdXJjZSgpOyAgICAKLQorICAgIAorICAg IC8vIE5ldmVyIGRlbGl2ZXIgNDA0IGVycm9yIHBhZ2VzIHRvIGFueSBDYWNoZWRSZXNvdXJjZXMu CisgICAgaWYgKG9iamVjdC0+cmVzcG9uc2UoKS5odHRwU3RhdHVzQ29kZSgpID09IDQwNCkKKyAg ICAgICAgcmV0dXJuOworICAgICAgICAKICAgICAvLyBTZXQgdGhlIGRhdGEuCiAgICAgaWYgKHJl cXVlc3QtPmlzTXVsdGlwYXJ0KCkpIHsKICAgICAgICAgLy8gVGhlIGxvYWRlciBkZWxpdmVycyB0 aGUgZGF0YSBpbiBhIG11bHRpcGFydCBzZWN0aW9uIGFsbCBhdCBvbmNlLCBzZW5kIGVvZi4K