152319 2015-12-15 17:25:36 -0800 Legacy style scrollbars do not change color when you mouse over them if you are scrolled 2015-12-16 15:54:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin cgarcia commit-queue esprehn+autocc glenn kondapallykalyan mcatanzaro simon.fraser thorton yoon oldest_to_newest 1149460 0 bdakin 2015-12-15 17:25:36 -0800 Legacy style scrollbars do not change color when you mouse over them if you are scrolled rdar://problem/23317668 1149495 1 267427 bdakin 2015-12-15 20:24:26 -0800 Created attachment 267427 Patch 1149626 2 267427 darin 2015-12-16 09:22:52 -0800 Comment on attachment 267427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267427&action=review Any chance we can find a way of covering this with a regression test? > Source/WebCore/rendering/RenderView.cpp:209 > + Scrollbar* frameScrollbar = frameView().scrollbarAtPoint(windowPoint); > if (frameScrollbar) { I would probably put the definition inside the if statement. 1149653 3 bdakin 2015-12-16 10:00:05 -0800 (In reply to comment #2) > Comment on attachment 267427 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267427&action=review > > Any chance we can find a way of covering this with a regression test? > We have still not figured out how to test scrollbar platform appearance in regression tests, but I absolutely think we need to figure out a way. These behaviors have a way of regressing quietly and we only notice after an all-too-long time. I need to think about how we could actually do this. ScrollAnimatorMac is the place in the code that can know if the right thing is happening, but it doesn't currently have any mechanism to share that information. If we can think of what to share it to, we might be able to figure out test infrastructure. > > Source/WebCore/rendering/RenderView.cpp:209 > > + Scrollbar* frameScrollbar = frameView().scrollbarAtPoint(windowPoint); > > if (frameScrollbar) { > > I would probably put the definition inside the if statement. Okay! Thanks Darin! 1149659 4 bdakin 2015-12-16 10:10:00 -0800 http://trac.webkit.org/changeset/194155 267427 2015-12-15 20:24:26 -0800 2015-12-16 09:22:52 -0800 Patch for-review.txt text/plain 3646 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDEyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE1LTEyLTE1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBMZWdhY3kgc3R5bGUgc2Nyb2xsYmFy cyBkbyBub3QgY2hhbmdlIGNvbG9yIHdoZW4geW91IG1vdXNlIG92ZXIgdGhlbSBpZiB5b3UgCisg ICAgICAgIGFyZSBzY3JvbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyMzE5CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAg cmRhcjovL3Byb2JsZW0vMjMzMTc2NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgc2Nyb2xsYmFy4oCZcyBmcmFtZVJlY3QgaXMgaW4gd2luZG93 IGNvb3JkaW5hdGVzLCBzbyB3ZSBuZWVkIHRvIGNvbXBhcmUgYSAKKyAgICAgICAgcG9pbnQgaW4g d2luZG93IGNvb3JkaW5hdGVzIHdoZW4gd2UgdGVzdCB0aGlzLgorCisgICAgICAgIFRoZSBjYWxs IHRvIGNvbnZlcnRGcm9tQ29udGFpbmluZ1dpbmRvdyBkb2VzIG5vdCByZXR1cm4gYSBwb2ludCBp biB2aWV3IAorICAgICAgICBjb29yZGluYXRlcywgc28gd2Ugc2hvdWxkIG5vdCBjYWxsIHRoZSB2 YXJpYWJsZSB2aWV3UG9pbnQuIFdlIGRvIHN0aWxsIG5lZWQgCisgICAgICAgIHRvIGNhbGwgaXQg Zm9yIHN1YmZyYW1lcy4gY29udmVydEZyb21Db250YWluaW5nV2luZG93IGRvZXNu4oCZdCBkbyBh bnl0aGluZyBmb3IgCisgICAgICAgIHRoZSByb290IFNjcm9sbFZpZXcgKGZvciBNYWMgV0syIGF0 IGxlYXN0KS4KKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbFZpZXc6OnNjcm9sbGJhckF0UG9pbnQpOgorCisgICAgICAgIEhpdFRlc3RM b2NhdGlvbiBpcyBpbiBjb250ZW50cyBjb29yZGluYXRlcy4gSXQgbmVlZHMgdG8gYmUgY29udmVy dGVkIHRvIAorICAgICAgICB3aW5kb3cgY29vcmRpbmF0ZXMKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWV3OjpoaXRUZXN0KToK KwogMjAxNS0xMi0xNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTWFjXSBHZXN0dXJlIEV2ZW50cyBzaG91bGQgbm90IGhhdmUgbmVnYXRpdmUgc2Nh bGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCShyZXZpc2lvbiAx OTQxMTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtOTk2LDEwICs5OTYsMTIgQEAgU2Nyb2xsYmFyKiBTY3JvbGxWaWV3OjpzY3Jv bGxiYXJBdFBvaW50KAogICAgIGlmIChwbGF0Zm9ybVdpZGdldCgpKQogICAgICAgICByZXR1cm4g MDsKIAotICAgIEludFBvaW50IHZpZXdQb2ludCA9IGNvbnZlcnRGcm9tQ29udGFpbmluZ1dpbmRv dyh3aW5kb3dQb2ludCk7Ci0gICAgaWYgKG1faG9yaXpvbnRhbFNjcm9sbGJhciAmJiBtX2hvcml6 b250YWxTY3JvbGxiYXItPnNob3VsZFBhcnRpY2lwYXRlSW5IaXRUZXN0aW5nKCkgJiYgbV9ob3Jp em9udGFsU2Nyb2xsYmFyLT5mcmFtZVJlY3QoKS5jb250YWlucyh2aWV3UG9pbnQpKQorICAgIC8v IGNvbnZlcnRGcm9tQ29udGFpbmluZ1dpbmRvdyBkb2Vzbid0IGRvIHdoYXQgaXQgc291bmRzIGxp a2UgaXQgZG9lcy4gV2UgbmVlZCBpdCBoZXJlIGp1c3QgdG8gZ2V0IHRoaXMKKyAgICAvLyBwb2lu dCBpbnRvIHRoZSByaWdodCBjb29yZGluYXRlcyBpZiB0aGlzIGlzIHRoZSBTY3JvbGxWaWV3IG9m IGEgc3ViLWZyYW1lLgorICAgIEludFBvaW50IGNvbnZlcnRlZFBvaW50ID0gY29udmVydEZyb21D b250YWluaW5nV2luZG93KHdpbmRvd1BvaW50KTsKKyAgICBpZiAobV9ob3Jpem9udGFsU2Nyb2xs YmFyICYmIG1faG9yaXpvbnRhbFNjcm9sbGJhci0+c2hvdWxkUGFydGljaXBhdGVJbkhpdFRlc3Rp bmcoKSAmJiBtX2hvcml6b250YWxTY3JvbGxiYXItPmZyYW1lUmVjdCgpLmNvbnRhaW5zKGNvbnZl cnRlZFBvaW50KSkKICAgICAgICAgcmV0dXJuIG1faG9yaXpvbnRhbFNjcm9sbGJhci5nZXQoKTsK LSAgICBpZiAobV92ZXJ0aWNhbFNjcm9sbGJhciAmJiBtX3ZlcnRpY2FsU2Nyb2xsYmFyLT5zaG91 bGRQYXJ0aWNpcGF0ZUluSGl0VGVzdGluZygpICYmIG1fdmVydGljYWxTY3JvbGxiYXItPmZyYW1l UmVjdCgpLmNvbnRhaW5zKHZpZXdQb2ludCkpCisgICAgaWYgKG1fdmVydGljYWxTY3JvbGxiYXIg JiYgbV92ZXJ0aWNhbFNjcm9sbGJhci0+c2hvdWxkUGFydGljaXBhdGVJbkhpdFRlc3RpbmcoKSAm JiBtX3ZlcnRpY2FsU2Nyb2xsYmFyLT5mcmFtZVJlY3QoKS5jb250YWlucyhjb252ZXJ0ZWRQb2lu dCkpCiAgICAgICAgIHJldHVybiBtX3ZlcnRpY2FsU2Nyb2xsYmFyLmdldCgpOwogICAgIHJldHVy biAwOwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAkocmV2 aXNpb24gMTk0MTExKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yMDQsNyArMjA0LDggQEAgYm9vbCBSZW5kZXJWaWV3OjpoaXRU ZXN0KGNvbnN0IEhpdFRlc3RSZQogICAgIGlmIChyZXF1ZXN0LmFsbG93c0ZyYW1lU2Nyb2xsYmFy cygpKSB7CiAgICAgICAgIC8vIFNjcm9sbFZpZXcgc2Nyb2xsYmFycyBhcmUgbm90IHRoZSBzYW1l IGFzIFJlbmRlckxheWVyIHNjcm9sbGJhcnMgdGVzdGVkIGJ5IFJlbmRlckxheWVyOjpoaXRUZXN0 T3ZlcmZsb3dDb250cm9scywKICAgICAgICAgLy8gc28gd2UgbmVlZCB0byB0ZXN0IFNjcm9sbFZp ZXcgc2Nyb2xsYmFycyBzZXBhcmF0ZWx5IGhlcmUuCi0gICAgICAgIFNjcm9sbGJhciogZnJhbWVT Y3JvbGxiYXIgPSBmcmFtZVZpZXcoKS5zY3JvbGxiYXJBdFBvaW50KGxvY2F0aW9uLnJvdW5kZWRQ b2ludCgpKTsKKyAgICAgICAgSW50UG9pbnQgd2luZG93UG9pbnQgPSBmcmFtZVZpZXcoKS5jb250 ZW50c1RvV2luZG93KGxvY2F0aW9uLnJvdW5kZWRQb2ludCgpKTsKKyAgICAgICAgU2Nyb2xsYmFy KiBmcmFtZVNjcm9sbGJhciA9IGZyYW1lVmlldygpLnNjcm9sbGJhckF0UG9pbnQod2luZG93UG9p bnQpOwogICAgICAgICBpZiAoZnJhbWVTY3JvbGxiYXIpIHsKICAgICAgICAgICAgIHJlc3VsdC5z ZXRTY3JvbGxiYXIoZnJhbWVTY3JvbGxiYXIpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7Cg==