152235 2015-12-13 17:44:14 -0800 Web Inspector: Make TimelineOverview's graph container a subview 2015-12-13 23:24:31 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1148867 0 mattbaker 2015-12-13 17:44:14 -0800 * SUMMARY Make TimelineOverview's graph container a subview. Using a vanilla DOM element prevents TimelineOverview graph elements from being part of the view hierarchy. 1148868 1 267276 mattbaker 2015-12-13 17:49:17 -0800 Created attachment 267276 [Patch] Proposed Fix 1148895 2 267276 bburg 2015-12-13 22:37:03 -0800 Comment on attachment 267276 [Patch] Proposed Fix r=me 1148901 3 267276 commit-queue 2015-12-13 23:24:26 -0800 Comment on attachment 267276 [Patch] Proposed Fix Clearing flags on attachment: 267276 Committed r194029: <http://trac.webkit.org/changeset/194029> 1148902 4 commit-queue 2015-12-13 23:24:31 -0800 All reviewed patches have been landed. Closing bug. 267276 2015-12-13 17:49:17 -0800 2015-12-13 23:24:26 -0800 [Patch] Proposed Fix bug-152235-20151213174843.patch text/plain 4323 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0MDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 ZWVlODcwY2RjMGMxMmY0NWI0NzMyMDMwNDhmMGYxODVmMzNkMzZmLi4zNmE3NDg5YjY4MjViMTEx YjczZGQ4MzE0YmYxNTYzNzM4NzNmZTM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNS0xMi0xMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBUaW1lbGluZU92ZXJ2aWV3J3MgZ3JhcGgg Y29udGFpbmVyIGEgc3VidmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyMjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldyk6CisgICAgICAgIENyZWF0ZSBn cmFwaCBjb250YWluZXIgc3Vidmlldy4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92 ZXJ2aWV3LnByb3RvdHlwZS5faW5zdHJ1bWVudEFkZGVkKToKKyAgICAgICAgQWRkIG92ZXJ2aWV3 IHRvIHRoZSBncmFwaCBjb250YWluZXIgdmlldy4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1l bGluZU92ZXJ2aWV3LnByb3RvdHlwZS5faW5zdHJ1bWVudFJlbW92ZWQpOgorICAgICAgICBSZW1v dmUgb3ZlcnZpZXcgZnJvbSB0aGUgZ3JhcGggY29udGFpbmVyIHZpZXcuCisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVPdmVydmlldy5wcm90b3R5cGUubGF5b3V0KToKKyAgICAgICAgTm8g bG9uZ2VyIG5lY2Vzc2FyeSB0byBtYW51YWxseSBsYXkgb3V0IG92ZXJ2aWV3IGdyYXBocy4KKyAg ICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LnByb3RvdHlwZS5fbmVlZHNMYXlv dXQpOiBEZWxldGVkLgorICAgICAgICBSZW1vdmVkIGRlYWQgY29kZS4KKwogMjAxNS0xMi0xMiAg TWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyIGhhbmRsZXMgc3ltYm9scyBpbiBj bGFzcyBkZWZpbml0aW9ucyBpbmNvcnJlY3RseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKaW5k ZXggZTIwYTUxZjU0OWY2OWYwMDJkZmVhYjZkMTJjMGYzYThjNWVjN2ZlZi4uN2M4NzVlZmYzODc0 NzI3OWVjODc0MzUzZWEyMjhmZjcwZmFiOWM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3Lmpz CkBAIC00Myw5ICs0Myw5IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3ID0gY2xhc3Mg VGltZWxpbmVPdmVydmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAgICAgIHRoaXMu ZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJnZXN0dXJlY2hhbmdlIiwgdGhpcy5faGFuZGxlR2Vz dHVyZUNoYW5nZS5iaW5kKHRoaXMpKTsKICAgICAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlz dGVuZXIoImdlc3R1cmVlbmQiLCB0aGlzLl9oYW5kbGVHZXN0dXJlRW5kLmJpbmQodGhpcykpOwog Ci0gICAgICAgIHRoaXMuX2dyYXBoc0NvbnRhaW5lckVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJkaXYiKTsKLSAgICAgICAgdGhpcy5fZ3JhcGhzQ29udGFpbmVyRWxlbWVudC5jbGFz c0xpc3QuYWRkKCJncmFwaHMtY29udGFpbmVyIik7Ci0gICAgICAgIHRoaXMuZWxlbWVudC5hcHBl bmRDaGlsZCh0aGlzLl9ncmFwaHNDb250YWluZXJFbGVtZW50KTsKKyAgICAgICAgdGhpcy5fZ3Jh cGhzQ29udGFpbmVyVmlldyA9IG5ldyBXZWJJbnNwZWN0b3IuVmlldzsKKyAgICAgICAgdGhpcy5f Z3JhcGhzQ29udGFpbmVyVmlldy5lbGVtZW50LmNsYXNzTGlzdC5hZGQoImdyYXBocy1jb250YWlu ZXIiKTsKKyAgICAgICAgdGhpcy5hZGRTdWJ2aWV3KHRoaXMuX2dyYXBoc0NvbnRhaW5lclZpZXcp OwogCiAgICAgICAgIHRoaXMuX3RpbWVsaW5lT3ZlcnZpZXdHcmFwaHNNYXAgPSBuZXcgTWFwOwog CkBAIC0zNzgsNyArMzc4LDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcgPSBjbGFz cyBUaW1lbGluZU92ZXJ2aWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAgICAgICAgICAg IHRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5zdGFydFRpbWUgPSBzY3JvbGxTdGFydFRpbWU7CiAgICAg ICAgICAgICB0aW1lbGluZU92ZXJ2aWV3R3JhcGguY3VycmVudFRpbWUgPSB0aGlzLl9jdXJyZW50 VGltZTsKICAgICAgICAgICAgIHRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5lbmRUaW1lID0gc2Nyb2xs U3RhcnRUaW1lICsgdmlzaWJsZUR1cmF0aW9uOwotICAgICAgICAgICAgdGltZWxpbmVPdmVydmll d0dyYXBoLnVwZGF0ZUxheW91dCgpOwogICAgICAgICB9CiAgICAgfQogCkBAIC0zOTEsMTcgKzM5 MCw2IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3ID0gY2xhc3MgVGltZWxpbmVPdmVy dmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAgICAgICAgICBlbGVtZW50LnN0eWxl LndpZHRoID0gbmV3V2lkdGggKyAicHgiOwogICAgIH0KIAotICAgIF9uZWVkc0xheW91dCgpCi0g ICAgewotICAgICAgICBpZiAoIXRoaXMuX3Zpc2libGUpCi0gICAgICAgICAgICByZXR1cm47Ci0K LSAgICAgICAgaWYgKHRoaXMuX3NjaGVkdWxlZExheW91dFVwZGF0ZUlkZW50aWZpZXIpCi0gICAg ICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgdGhpcy5fc2NoZWR1bGVkTGF5b3V0VXBkYXRlSWRl bnRpZmllciA9IHJlcXVlc3RBbmltYXRpb25GcmFtZSh0aGlzLnVwZGF0ZUxheW91dC5iaW5kKHRo aXMpKTsKLSAgICB9Ci0KICAgICBfaGFuZGxlU2Nyb2xsRXZlbnQoZXZlbnQpCiAgICAgewogICAg ICAgICBpZiAodGhpcy5faWdub3JlTmV4dFNjcm9sbEV2ZW50KSB7CkBAIC01MjEsOCArNTA5LDcg QEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcgPSBjbGFzcyBUaW1lbGluZU92ZXJ2aWV3 IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAgICAgICAgb3ZlcnZpZXdHcmFwaC5hZGRFdmVu dExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3R3JhcGguRXZlbnQuUmVjb3Jk U2VsZWN0ZWQsIHRoaXMuX3JlY29yZFNlbGVjdGVkLCB0aGlzKTsKICAgICAgICAgdGhpcy5fdGlt ZWxpbmVPdmVydmlld0dyYXBoc01hcC5zZXQodGltZWxpbmUsIG92ZXJ2aWV3R3JhcGgpOwogCi0g ICAgICAgIC8vIEZJWE1FOiB1c2UgVmlldy5wcm90b3R5cGUuYWRkU3VidmlldyhvdmVydmlld0dy YXBoKSBvbmNlIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTA5ODI+IGlzIGZpeGVkLgotICAgICAg ICB0aGlzLl9ncmFwaHNDb250YWluZXJFbGVtZW50LmFwcGVuZENoaWxkKG92ZXJ2aWV3R3JhcGgu ZWxlbWVudCk7CisgICAgICAgIHRoaXMuX2dyYXBoc0NvbnRhaW5lclZpZXcuYWRkU3Vidmlldyhv dmVydmlld0dyYXBoKTsKICAgICB9CiAKICAgICBfaW5zdHJ1bWVudFJlbW92ZWQoZXZlbnQpCkBA IC01MzgsNyArNTI1LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcgPSBjbGFzcyBU aW1lbGluZU92ZXJ2aWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAogICAgICAgICBsZXQg b3ZlcnZpZXdHcmFwaCA9IHRoaXMuX3RpbWVsaW5lT3ZlcnZpZXdHcmFwaHNNYXAudGFrZSh0aW1l bGluZSk7CiAgICAgICAgIG92ZXJ2aWV3R3JhcGgucmVtb3ZlRXZlbnRMaXN0ZW5lcihXZWJJbnNw ZWN0b3IuVGltZWxpbmVPdmVydmlld0dyYXBoLkV2ZW50LlJlY29yZFNlbGVjdGVkLCB0aGlzLl9y ZWNvcmRTZWxlY3RlZCwgdGhpcyk7Ci0gICAgICAgIG92ZXJ2aWV3R3JhcGguZWxlbWVudC5yZW1v dmUoKTsKKyAgICAgICAgdGhpcy5fZ3JhcGhzQ29udGFpbmVyVmlldy5yZW1vdmVTdWJ2aWV3KG92 ZXJ2aWV3R3JhcGgpOwogICAgIH0KIAogICAgIF9tYXJrZXJBZGRlZChldmVudCkK