152122 2015-12-10 05:52:04 -0800 [B3] Fix unused-but-set-variable warning 2015-12-14 04:56:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 152248 1 ossy ossy benjamin commit-queue fpizlo ggaren keith_miller mark.lam msaboff ossy saam oldest_to_newest 1148143 0 ossy 2015-12-10 05:52:04 -0800 ../../Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp: In member function 'void JSC::FTL::{anonymous}::LowerDFGToLLVM::lower()': ../../Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:207:14: error: variable 'hasVarargs' set but not used [-Werror=unused-but-set-variable] hasVarargs variable is set unconditionally, but used only if FTL_USES_B3 is false. 1148144 1 267098 ossy 2015-12-10 05:53:34 -0800 Created attachment 267098 Patch 1148168 2 267098 mark.lam 2015-12-10 07:22:25 -0800 Comment on attachment 267098 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267098&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:271 > + (void) hasVarargs; I think you should use UNUSED_PARAM(hasVarargs) instead. 1148172 3 ossy 2015-12-10 07:25:04 -0800 (In reply to comment #2) > Comment on attachment 267098 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267098&action=review > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:271 > > + (void) hasVarargs; > > I think you should use UNUSED_PARAM(hasVarargs) instead. We could ... it was my first idea too. But I thought that the name of UNUSED_PARAM is confusing, because it isn't parameter, but a local variable. 1148173 4 267108 ossy 2015-12-10 07:26:53 -0800 Created attachment 267108 Patch OK, let's use UNUSED_PARAM 1148174 5 mark.lam 2015-12-10 07:28:58 -0800 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 267098 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=267098&action=review > > > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:271 > > > + (void) hasVarargs; > > > > I think you should use UNUSED_PARAM(hasVarargs) instead. > > We could ... it was my first idea too. > > But I thought that the name of UNUSED_PARAM is confusing, > because it isn't parameter, but a local variable. I agree regarding the naming, but we have been using that macro for this purpose all this time. Perhaps it can be renamed to UNUSED_VAR() or UNUSED_VALUE(). I don't know if others have any opinion on this. 1148175 6 mark.lam 2015-12-10 07:30:12 -0800 (In reply to comment #5) > ... Perhaps it can be renamed ... I mean in a separate patch if you want to take on renaming it. Or add a new macro for non-param values? Not sure which is best. 1148183 7 267108 commit-queue 2015-12-10 08:08:19 -0800 Comment on attachment 267108 Patch Clearing flags on attachment: 267108 Committed r193905: <http://trac.webkit.org/changeset/193905> 1148184 8 commit-queue 2015-12-10 08:08:23 -0800 All reviewed patches have been landed. Closing bug. 267098 2015-12-10 05:53:34 -0800 2015-12-10 07:26:47 -0800 Patch bug-152122-20151210145302.patch text/plain 1223 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 OTc1NGFlMmYzM2I4OTQ4ODE0ZTZiNDk0MjZiM2JiYzZlYzI5MTYxLi5hNjY3ZmUzZTMzNTMxNDQ2 YTZkNTliN2RjNTBmNWMwOThiNTllYzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNSBAQAogMjAxNS0xMi0xMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgogCisgICAgICAgIFtCM10gRml4IHVudXNlZC1idXQtc2V0LXZhcmlhYmxlIHdhcm5pbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjEyMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZnRsL0ZU TExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9M TFZNOjpsb3dlcik6CisKKzIwMTUtMTItMTAgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKwogICAgICAgICBTb3VyY2UvSmF2YVNjcmlwdENvcmUvY3JlYXRlX2hhc2hfdGFi bGUgc2hvdWxkbid0IGJlIHRvbyB2ZXJib3NlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE4NjEKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAppbmRleCA0OTU3MmMxMTlkY2RlYTM2YzAxZGIyYjY2 YjA4ZDQxMjU0ZmRhZDI2Li5iMDg2YWFhZjQzNmJlODY3NTQ0ZjU5MDRjMjdlNzU1ZjVhMjc5YzNh IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZN LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNw cApAQCAtMjY4LDYgKzI2OCw3IEBAIHB1YmxpYzoKICAgICAgICAgfQogCiAjaWYgRlRMX1VTRVNf QjMKKyAgICAgICAgKHZvaWQpIGhhc1ZhcmFyZ3M7CiAgICAgICAgIC8vIEZJWE1FCiAjZWxzZQog ICAgICAgICBpZiAoaGFzVmFyYXJncykgewo= 267108 2015-12-10 07:26:53 -0800 2015-12-10 08:08:19 -0800 Patch bug-152122-20151210162620.patch text/plain 1230 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 OTc1NGFlMmYzM2I4OTQ4ODE0ZTZiNDk0MjZiM2JiYzZlYzI5MTYxLi5hNjY3ZmUzZTMzNTMxNDQ2 YTZkNTliN2RjNTBmNWMwOThiNTllYzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNSBAQAogMjAxNS0xMi0xMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgogCisgICAgICAgIFtCM10gRml4IHVudXNlZC1idXQtc2V0LXZhcmlhYmxlIHdhcm5pbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjEyMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZnRsL0ZU TExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9M TFZNOjpsb3dlcik6CisKKzIwMTUtMTItMTAgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKwogICAgICAgICBTb3VyY2UvSmF2YVNjcmlwdENvcmUvY3JlYXRlX2hhc2hfdGFi bGUgc2hvdWxkbid0IGJlIHRvbyB2ZXJib3NlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE4NjEKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAppbmRleCA0OTU3MmMxMTlkY2RlYTM2YzAxZGIyYjY2 YjA4ZDQxMjU0ZmRhZDI2Li5kZWI2MzdjMDM0YTBjMjBlODJlMDgzYjBhNTJkNmRiNzFhNDNlYjVj IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZN LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNw cApAQCAtMjY4LDYgKzI2OCw3IEBAIHB1YmxpYzoKICAgICAgICAgfQogCiAjaWYgRlRMX1VTRVNf QjMKKyAgICAgICAgVU5VU0VEX1BBUkFNKGhhc1ZhcmFyZ3MpOwogICAgICAgICAvLyBGSVhNRQog I2Vsc2UKICAgICAgICAgaWYgKGhhc1ZhcmFyZ3MpIHsK