152096 2015-12-09 14:43:32 -0800 Modern IDB: storage/indexeddb/intversion-close-between-events.html fails 2015-12-10 09:04:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 150882 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1147957 0 beidson 2015-12-09 14:43:32 -0800 Modern IDB: storage/indexeddb/intversion-close-between-events.html fails JSIDBDatabase::transaction incorrectly handles DOMStringLists 1147964 1 267048 beidson 2015-12-09 14:51:44 -0800 Created attachment 267048 Patch v1 1147979 2 267048 commit-queue 2015-12-09 15:40:39 -0800 Comment on attachment 267048 Patch v1 Clearing flags on attachment: 267048 Committed r193875: <http://trac.webkit.org/changeset/193875> 1147980 3 commit-queue 2015-12-09 15:40:42 -0800 All reviewed patches have been landed. Closing bug. 1148039 4 267048 darin 2015-12-09 19:27:35 -0800 Comment on attachment 267048 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=267048&action=review > Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp:102 > + scope = Vector<String>(*domStringList); I’m surprised the cast here is needed. Wouldn’t the assignment work without the constructor syntax? 1148205 5 beidson 2015-12-10 09:04:49 -0800 (In reply to comment #4) > Comment on attachment 267048 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267048&action=review > > > Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp:102 > > + scope = Vector<String>(*domStringList); > > I’m surprised the cast here is needed. Wouldn’t the assignment work without > the constructor syntax? Followed up in https://trac.webkit.org/changeset/193909 267048 2015-12-09 14:51:44 -0800 2015-12-09 15:40:39 -0800 Patch v1 patch text/plain 3308 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3OTgxMzJjLi5kOGYxMGUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTUtMTIt MDkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIE1vZGVybiBJ REI6IHN0b3JhZ2UvaW5kZXhlZGRiL2ludHZlcnNpb24tY2xvc2UtYmV0d2Vlbi1ldmVudHMuaHRt bCBmYWlscy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MjA5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zOgorCisyMDE1LTEyLTA5ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBNb2Rlcm4gSURCOiBzdG9y YWdlL2luZGV4ZWRkYi9jcmVhdGVJbmRleC1hZnRlci1mYWlsdXJlLmh0bWwgZmFpbHMuCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIwNzgKIApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGY5Yjgz ZDkuLjE4YzE4MmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTEwMCw3ICsxMDAsNiBAQCBzdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1iYXNp Y3MuaHRtbCBbIEZhaWx1cmUgXQogc3RvcmFnZS9pbmRleGVkZGIvaW5kZXgtY291bnQuaHRtbCBb IEZhaWx1cmUgXQogc3RvcmFnZS9pbmRleGVkZGIvaW5kZXgtZHVwbGljYXRlLWtleXBhdGhzLmh0 bWwgWyBGYWlsdXJlIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL2ludHZlcnNpb24tYWJvcnQtaW4taW5p dGlhbC11cGdyYWRlbmVlZGVkLmh0bWwgWyBGYWlsdXJlIF0KLXN0b3JhZ2UvaW5kZXhlZGRiL2lu dHZlcnNpb24tY2xvc2UtYmV0d2Vlbi1ldmVudHMuaHRtbCBbIEZhaWx1cmUgXQogc3RvcmFnZS9p bmRleGVkZGIvaW50dmVyc2lvbi1jbG9zZS1pbi1vbmNvbXBsZXRlLmh0bWwgWyBGYWlsdXJlIF0K IHN0b3JhZ2UvaW5kZXhlZGRiL2ludHZlcnNpb24tY2xvc2UtaW4tdXBncmFkZW5lZWRlZC5odG1s IFsgRmFpbHVyZSBdCiBzdG9yYWdlL2luZGV4ZWRkYi9pbnR2ZXJzaW9uLWdhdGVkLW9uLWRlbGV0 ZS5odG1sIFsgRmFpbHVyZSBdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzM5MWY5NC4uN2IzNDE1MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTA5ICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KKworICAgICAgICBNb2Rlcm4gSURCOiBzdG9yYWdlL2luZGV4ZWRkYi9pbnR2 ZXJzaW9uLWNsb3NlLWJldHdlZW4tZXZlbnRzLmh0bWwgZmFpbHMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTIwOTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKEF0IGxlYXN0IG9u ZSBmYWlsaW5nIHRlc3Qgbm93IHBhc3NlcykuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0lE QkRhdGFiYXNlQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTSURCRGF0YWJhc2U6OnRy YW5zYWN0aW9uKTogSW4gYWRkaXRpb24gdG8gSlNBcnJheXMsIHRyZWF0IERPTVN0cmluZ0xpc3Rz IGFzIGEgdmFsaWQgc3RyaW5nIHNlcXVlbmNlLgorICAgIAogMjAxNS0xMi0wOSAgWGFiaWVyIFJv ZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTdHJlYW1z IEFQSV0gcGlwZVRocm91Z2ggdGVzdCBmYWlsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0lEQkRhdGFiYXNlQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTSURCRGF0YWJhc2VDdXN0b20uY3BwCmluZGV4IDEwNjg1ZGMuLjUwMDBlMTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCRGF0YWJhc2VDdXN0 b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCRGF0YWJhc2VDdXN0 b20uY3BwCkBAIC0zNiw2ICszNiw3IEBACiAjaW5jbHVkZSAiSURCS2V5UGF0aC5oIgogI2luY2x1 ZGUgIklEQk9iamVjdFN0b3JlLmgiCiAjaW5jbHVkZSAiSlNET01CaW5kaW5nLmgiCisjaW5jbHVk ZSAiSlNET01TdHJpbmdMaXN0LmgiCiAjaW5jbHVkZSAiSlNJREJPYmplY3RTdG9yZS5oIgogI2lu Y2x1ZGUgPHJ1bnRpbWUvRXJyb3IuaD4KICNpbmNsdWRlIDxydW50aW1lL0pTU3RyaW5nLmg+CkBA IC05MywxMSArOTQsMTMgQEAgSlNWYWx1ZSBKU0lEQkRhdGFiYXNlOjp0cmFuc2FjdGlvbihFeGVj U3RhdGUmIGV4ZWMpCiAKICAgICBWZWN0b3I8U3RyaW5nPiBzY29wZTsKICAgICBKU1ZhbHVlIHNj b3BlQXJnKGV4ZWMuYXJndW1lbnQoMCkpOwotICAgIGlmIChzY29wZUFyZy5pc09iamVjdCgpICYm IGlzSlNBcnJheShzY29wZUFyZykpIHsKLSAgICAgICAgc2NvcGUgPSB0b05hdGl2ZUFycmF5PFN0 cmluZz4oJmV4ZWMsIHNjb3BlQXJnKTsKLSAgICAgICAgaWYgKGV4ZWMuaGFkRXhjZXB0aW9uKCkp Ci0gICAgICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKLSAgICB9IGVsc2UgeworICAgIGF1 dG8gZG9tU3RyaW5nTGlzdCA9IEpTRE9NU3RyaW5nTGlzdDo6dG9XcmFwcGVkKCZleGVjLCBzY29w ZUFyZyk7CisgICAgaWYgKGV4ZWMuaGFkRXhjZXB0aW9uKCkpCisgICAgICAgIHJldHVybiBqc1Vu ZGVmaW5lZCgpOworCisgICAgaWYgKGRvbVN0cmluZ0xpc3QpCisgICAgICAgIHNjb3BlID0gVmVj dG9yPFN0cmluZz4oKmRvbVN0cmluZ0xpc3QpOworICAgIGVsc2UgewogICAgICAgICBzY29wZS5h cHBlbmQoc2NvcGVBcmcudG9TdHJpbmcoJmV4ZWMpLT52YWx1ZSgmZXhlYykpOwogICAgICAgICBp ZiAoZXhlYy5oYWRFeGNlcHRpb24oKSkKICAgICAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgp Owo=