151860 2015-12-04 04:30:50 -0800 [B3] Typo fix after r193386 to fix the build 2015-12-14 04:56:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 151809 152248 1 ossy ossy benjamin commit-queue fpizlo keith_miller mark.lam msaboff ossy saam oldest_to_newest 1146271 0 ossy 2015-12-04 04:30:50 -0800 ../../Source/JavaScriptCore/b3/B3StackmapSpecial.cpp:189:48: error: 'JSC::B3::Air::Arg::Arg' names the constructor, not the type ../../Source/JavaScriptCore/b3/B3StackmapSpecial.cpp:189:6: error: prototype for 'bool JSC::B3::StackmapSpecial::isArgValidForValue(const int&, JSC::B3::Value*)' does not match any in class 'JSC::B3::StackmapSpecial' In file included from ../../Source/JavaScriptCore/b3/B3StackmapSpecial.cpp:27:0: ../../Source/JavaScriptCore/b3/B3StackmapSpecial.h:74:17: error: candidate is: static bool JSC::B3::StackmapSpecial::isArgValidForValue(const JSC::B3::Air::Arg&, JSC::B3::Value*) Arg::Arg must be a typo, it should be Air::Arg similar to the header. 1146272 1 266622 ossy 2015-12-04 04:31:52 -0800 Created attachment 266622 Patch 1146781 2 ossy 2015-12-07 01:50:29 -0800 ping? 1146872 3 266622 commit-queue 2015-12-07 09:29:16 -0800 Comment on attachment 266622 Patch Clearing flags on attachment: 266622 Committed r193631: <http://trac.webkit.org/changeset/193631> 1146873 4 commit-queue 2015-12-07 09:29:20 -0800 All reviewed patches have been landed. Closing bug. 266622 2015-12-04 04:31:52 -0800 2015-12-07 09:29:16 -0800 Patch bug-151860-20151204133126.patch text/plain 1386 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDgzMWVjOWU0NWYzZmU3Y2FiMWU5ZjVhMTllNzJjODVkMjBhNzllLi4yMmFlNjA3NzcwODA5OTY0 ZmYyYTNhN2M3Y2E2N2I3MWI2ZjU0ZGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0xMi0wNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtCM10gVHlwbyBmaXggYWZ0ZXIgcjE5MzM4NiB0byBmaXggdGhlIGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE4 NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGIz L0IzU3RhY2ttYXBTcGVjaWFsLmNwcDoKKyAgICAgICAgKEpTQzo6QjM6OlN0YWNrbWFwU3BlY2lh bDo6aXNBcmdWYWxpZEZvclZhbHVlKToKKwogMjAxNS0xMi0wMyAgRmlsaXAgUGl6bG8gIDxmcGl6 bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEIzIFBhdGNocG9pbnQgYW5kIENoZWNrIG9wY29kZXMg c2hvdWxkIGJlIGFibGUgdG8gc3BlY2lmeSBXYXJtQW55LCBDb2xkQW55LCBhbmQgTGF0ZUNvbGRB bnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1N0YWNrbWFwU3BlY2lh bC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNTdGFja21hcFNwZWNpYWwuY3BwCmlu ZGV4IDc3MGNiYTVhNmVlMWI3NGE3M2Q3ZTc4MjkwMzYwMjc2ZjU2ZDUyNDIuLjVjZDdlYmE0ZWFl MDQxNzNhZWIzMzI0MDFhNmE1NWQwOWU1MzVlZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9iMy9CM1N0YWNrbWFwU3BlY2lhbC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2IzL0IzU3RhY2ttYXBTcGVjaWFsLmNwcApAQCAtMTg2LDcgKzE4Niw3IEBAIHZvaWQgU3Rh Y2ttYXBTcGVjaWFsOjphcHBlbmRSZXBzSW1wbCgKICAgICAgICAgcmVzdWx0LmFwcGVuZChyZXBG b3JBcmcoKmNvbnRleHQuY29kZSwgaW5zdC5hcmdzW2ldKSk7CiB9CiAKLWJvb2wgU3RhY2ttYXBT cGVjaWFsOjppc0FyZ1ZhbGlkRm9yVmFsdWUoY29uc3QgQXJnOjpBcmcmIGFyZywgVmFsdWUqIHZh bHVlKQorYm9vbCBTdGFja21hcFNwZWNpYWw6OmlzQXJnVmFsaWRGb3JWYWx1ZShjb25zdCBBaXI6 OkFyZyYgYXJnLCBWYWx1ZSogdmFsdWUpCiB7CiAgICAgc3dpdGNoIChhcmcua2luZCgpKSB7CiAg ICAgY2FzZSBBcmc6OlRtcDoK