151752 2015-12-02 10:12:43 -0800 Modern IDB: IDBTransaction::error is not exposed 2015-12-02 20:44:15 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 151753 149117 150882 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1145599 0 beidson 2015-12-02 10:12:43 -0800 Modern IDB: IDBTransaction::error is not exposed There's at least 3 layout tests that hit this, so I'll get all three of those running. 1145644 1 266458 beidson 2015-12-02 11:40:14 -0800 Created attachment 266458 Patch v1 1145668 2 266458 commit-queue 2015-12-02 12:32:53 -0800 Comment on attachment 266458 Patch v1 Clearing flags on attachment: 266458 Committed r192956: <http://trac.webkit.org/changeset/192956> 1145669 3 commit-queue 2015-12-02 12:32:55 -0800 All reviewed patches have been landed. Closing bug. 1145779 4 266458 darin 2015-12-02 17:01:37 -0800 Comment on attachment 266458 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=266458&action=review > Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:119 > RefPtr<DOMError> IDBTransaction::error() const Why does this return a RefPtr? Should just return a DOMError*, not a RefPtr. Unless it manufactures a new error object. 1145847 5 beidson 2015-12-02 20:44:15 -0800 (In reply to comment #4) > Comment on attachment 266458 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266458&action=review > > > Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:119 > > RefPtr<DOMError> IDBTransaction::error() const > > Why does this return a RefPtr? Should just return a DOMError*, not a RefPtr. > Unless it manufactures a new error object. All of the abstract bindings left behind from Legacy IDB inappropriately return RefPtrs like this. And, sadly, sometimes LegacyIDB does (incorrectly) manufacture a new object each call instead of retaining the same one for repeated calls. Instead of trying to clean up that mess while both implementations live side by side, I consider fixing it to be part of "Remove LegacyIDB" 266458 2015-12-02 11:40:14 -0800 2015-12-02 12:32:53 -0800 Patch v1 patch text/plain 12736 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNDU4NWU1Li45ZmI3NjQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMTIt MDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybiBJ REI6IElEQlRyYW5zYWN0aW9uOjplcnJvciBpcyBub3QgZXhwb3NlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTc1MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMS9UZXN0 RXhwZWN0YXRpb25zOgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9iYXNpYy1h ZGQuaHRtbDoKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vZG91YmxlLWFib3J0 LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaW5kZXgt My5odG1sOgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy90cmFuc2FjdGlv bi1lcnJvci5qczoKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi90cmFuc2FjdGlvbi1lcnJv ci1leHBlY3RlZC50eHQ6CisKIDIwMTUtMTItMDIgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBOdWxsIGRlcmVmZXJlbmNlIGxvYWRpbmcgQmxpbmsgbGF5b3V0 IHRlc3QgZmFzdC9sb2FkZXIvdW5sb2FkLW11dGF0aW9uLWNyYXNoLmh0bWwKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxY2FmMWZiLi42MzFj NzUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3Rh dGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25z CkBAIC03OCw2ICs3OCw5IEBAIHN0b3JhZ2UvaW5kZXhlZGRiL2N1cnNvci1jYXN0Lmh0bWwgWyBQ YXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL2N1cnNvci1maW5pc2hlZC5odG1sIFsgUGFzcyBdCiBz dG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4gWyBQYXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL21vemls bGEgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL3RyYW5zYWN0aW9uLWFib3J0Lmh0bWwgWyBQ YXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL3RyYW5zYWN0aW9uLWVycm9yLmh0bWwgWyBQYXNzIF0K K3N0b3JhZ2UvaW5kZXhlZGRiL3RyYW5zYWN0aW9uLWV2ZW50LXByb3BhZ2F0aW9uLmh0bWwgWyBQ YXNzIF0KIAogIyBObyB3b3JrZXJzIHN1cHBvcnQgaW4gTW9kZXJuIElEQiB5ZXQKIHN0b3JhZ2Uv aW5kZXhlZGRiL2Jhc2ljcy13b3JrZXJzLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9iYXNpYy1hZGQuaHRtbCBiL0xheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL21vZGVybi9iYXNpYy1hZGQuaHRtbAppbmRleCBmN2M5ZWE0Li4zOTFlMGNi IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vYmFzaWMt YWRkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2Jhc2lj LWFkZC5odG1sCkBAIC01Nyw2ICs1Nyw3IEBAIHJlcXVlc3Qub251cGdyYWRlbmVlZGVkID0gZnVu Y3Rpb24oZXZlbnQpIHsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgZXZlbnQuc3RvcFBy b3BhZ2F0aW9uKCk7CisgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgfQogICAg ICAgICAKICAgICB0eC5vbmFib3J0ID0gZnVuY3Rpb24oZXZlbnQpIHsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9kb3VibGUtYWJvcnQtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2RvdWJsZS1hYm9ydC1l eHBlY3RlZC50eHQKaW5kZXggMTczNDk4Zi4uNGVmMjJjZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2RvdWJsZS1hYm9ydC1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2RvdWJsZS1hYm9ydC1leHBl Y3RlZC50eHQKQEAgLTEsNSArMSw1IEBACiBBTEVSVDogSW5pdGlhbCB1cGdyYWRlIG5lZWRlZDog T2xkIHZlcnNpb24gLSAwIE5ldyB2ZXJzaW9uIC0gMQotQUxFUlQ6IFNlY29uZCBhYm9ydCBmYWls ZWQ6IEVycm9yOiBJbnZhbGlkU3RhdGVFcnJvcjogRE9NIEV4Y2VwdGlvbiAxMQorQUxFUlQ6IFNl Y29uZCBhYm9ydCBmYWlsZWQ6IEVycm9yOiBJbnZhbGlkU3RhdGVFcnJvcjogRE9NIElEQkRhdGFi YXNlIEV4Y2VwdGlvbiAxMQogQUxFUlQ6IEluaXRpYWwgdXBncmFkZSB2ZXJzaW9uY2hhbmdlIHRy YW5zYWN0aW9uIGFib3J0ZWQKIEFMRVJUOiBEb25lCiBUaGlzIHRlc3QgYWJvcnRzIHRoZSBzYW1l IHRyYW5zYWN0aW9uIHR3aWNlLCBtYWtpbmcgdGhlIGFwcHJvcHJpYXRlIGV4Y2VwdGlvbiBpcyB0 aHJvd24uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4v aW5kZXgtMy5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2luZGV4 LTMuaHRtbAppbmRleCA0MDAyMjdiLi40ZjllMDhlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaW5kZXgtMy5odG1sCisrKyBiL0xheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9pbmRleC0zLmh0bWwKQEAgLTc2LDYgKzc2LDcgQEAgY3Jl YXRlUmVxdWVzdC5vbnVwZ3JhZGVuZWVkZWQgPSBmdW5jdGlvbihldmVudCkgewogICAgIHJlcXVl c3QyLm9uZXJyb3IgPSBmdW5jdGlvbihlKSB7CiAgICAgICAgIGxvZygiU2Vjb25kIHB1dCBmYWls dXJlIik7CiAgICAgICAgIGUuc3RvcFByb3BhZ2F0aW9uKCk7CisgICAgICAgIGUucHJldmVudERl ZmF1bHQoKTsKICAgICB9CiAgICAgCiAgICAgY2hlY2tPYmplY3RTdG9yZSgpOwpAQCAtOTAsNiAr OTEsNyBAQCBjcmVhdGVSZXF1ZXN0Lm9udXBncmFkZW5lZWRlZCA9IGZ1bmN0aW9uKGV2ZW50KSB7 CiAgICAgcmVxdWVzdDMub25lcnJvciA9IGZ1bmN0aW9uKGUpIHsKICAgICAgICAgbG9nKCJUaGly ZCBwdXQgZmFpbHVyZSIpOwogICAgICAgICBlLnN0b3BQcm9wYWdhdGlvbigpOworICAgICAgICBl LnByZXZlbnREZWZhdWx0KCk7CiAgICAgfQogICAgIAogICAgIGNoZWNrT2JqZWN0U3RvcmUoKTsK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy90cmFu c2FjdGlvbi1lcnJvci5qcyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNl cy90cmFuc2FjdGlvbi1lcnJvci5qcwppbmRleCBmMGM4MzlmLi5kZDlkZDU3IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvdHJhbnNhY3Rpb24tZXJy b3IuanMKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL3RyYW5z YWN0aW9uLWVycm9yLmpzCkBAIC01Myw4ICs1Myw2IEBAIGZ1bmN0aW9uIHRlc3RFcnJvckZyb21S ZXF1ZXN0KCkKICAgICB0cmFucy5vbmFib3J0ID0gZnVuY3Rpb24oKSB7CiAgICAgICAgIGRlYnVn KCJUcmFuc2FjdGlvbiByZWNlaXZlZCBhYm9ydCBldmVudC4iKTsKICAgICAgICAgc2hvdWxkQmVO b25OdWxsKCJ0cmFucy5lcnJvciIpOwotICAgICAgICBkZWJ1ZygidHJhbnMuZXJyb3IubWVzc2Fn ZSA9ICIgKyB0cmFucy5lcnJvci5tZXNzYWdlKTsKLSAgICAgICAgc2hvdWxkQmVOb25OdWxsKCJ0 cmFucy5lcnJvci5tZXNzYWdlIik7CiAgICAgICAgIHNob3VsZEJlKCJ0cmFucy5lcnJvciIsICJy ZXF1ZXN0X2Vycm9yIik7CiAgICAgICAgIHRlc3RFcnJvckZyb21FeGNlcHRpb24oKTsKICAgICB9 OwpAQCAtODUsOCArODMsNiBAQCBmdW5jdGlvbiB0ZXN0RXJyb3JGcm9tRXhjZXB0aW9uKCkKICAg ICAgICAgc2VsZi5vbmVycm9yID0gc2VsZi5vcmlnaW5hbFdpbmRvd09uRXJyb3I7CiAKICAgICAg ICAgc2hvdWxkQmVOb25OdWxsKCJ0cmFucy5lcnJvciIpOwotICAgICAgICBkZWJ1ZygidHJhbnMu ZXJyb3IubWVzc2FnZSA9ICIgKyB0cmFucy5lcnJvci5tZXNzYWdlKTsKLSAgICAgICAgc2hvdWxk QmVOb25OdWxsKCJ0cmFucy5lcnJvci5tZXNzYWdlIik7CiAgICAgICAgIHNob3VsZEJlKCJ0cmFu cy5lcnJvci5uYW1lIiwgIidBYm9ydEVycm9yJyIpOwogICAgICAgICB0ZXN0RXJyb3JGcm9tQ29t bWl0KCk7CiAgICAgfTsKQEAgLTExNywxMCArMTEzLDcgQEAgZnVuY3Rpb24gdGVzdEVycm9yRnJv bUNvbW1pdCgpCiAgICAgICAgICAgICAgICAgZGVidWcoIlRyYW5zYWN0aW9uIHJlY2VpdmVkIGFi b3J0IGV2ZW50LiIpOwogICAgICAgICAgICAgICAgIHNob3VsZEJlTm9uTnVsbCgidHJhbnMuZXJy b3IiKTsKICAgICAgICAgICAgICAgICBzaG91bGRCZSgidHJhbnMuZXJyb3IubmFtZSIsICInQ29u c3RyYWludEVycm9yJyIpOwotICAgICAgICAgICAgICAgIGRlYnVnKCJ0cmFucy5lcnJvci5tZXNz YWdlID0gIiArIHRyYW5zLmVycm9yLm1lc3NhZ2UpOwotICAgICAgICAgICAgICAgIHNob3VsZEJl Tm9uTnVsbCgidHJhbnMuZXJyb3IubWVzc2FnZSIpOwogICAgICAgICAgICAgICAgIGRlYnVnKCJO b3RlOiBUaGlzIGZhaWxzIGJlY2F1c2Ugb2YgaHR0cDovL3drYi51Zy8zNzMyNyIpOwotICAgICAg ICAgICAgICAgIHNob3VsZE5vdEJlKCJ0cmFucy5lcnJvci5tZXNzYWdlLmluZGV4T2YoaW5kZXhO YW1lKSIsICItMSIpOwogICAgICAgICAgICAgICAgIGRlYnVnKCIiKTsKICAgICAgICAgICAgICAg ICBmaW5pc2hKU1Rlc3QoKTsKICAgICAgICAgICAgIH07CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9zdG9yYWdlL2luZGV4ZWRkYi90cmFuc2FjdGlvbi1lcnJvci1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi90cmFuc2FjdGlvbi1lcnJvci1leHBlY3RlZC50eHQK aW5kZXggN2VlYzFjZi4uNTI4ZDM0NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvdHJhbnNhY3Rpb24tZXJyb3ItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL3RyYW5zYWN0aW9uLWVycm9yLWV4cGVjdGVkLnR4dApAQCAtMSw0 ICsxLDQgQEAKLUNPTlNPTEUgRVJST1I6IGxpbmUgNzg6IFVuY2F1Z2h0IEVycm9yOiBUaGlzIHNo b3VsZCAqTk9UKiBiZSBjYXVnaHQhCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgNzY6IEVycm9yOiBU aGlzIHNob3VsZCAqTk9UKiBiZSBjYXVnaHQhCiBUZXN0IElEQlRyYW5zYWN0aW9uLmVycm9yIGNh c2VzLgogCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3Nh Z2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCkBAIC0zMSw4ICszMSw2IEBAIFBBU1Mg cmVxdWVzdC5lcnJvci5uYW1lIGlzICdDb25zdHJhaW50RXJyb3InCiByZXF1ZXN0X2Vycm9yID0g cmVxdWVzdC5lcnJvcgogVHJhbnNhY3Rpb24gcmVjZWl2ZWQgYWJvcnQgZXZlbnQuCiBQQVNTIHRy YW5zLmVycm9yIGlzIG5vbi1udWxsLgotdHJhbnMuZXJyb3IubWVzc2FnZSA9IEtleSBhbHJlYWR5 IGV4aXN0cyBpbiB0aGUgb2JqZWN0IHN0b3JlLgotUEFTUyB0cmFucy5lcnJvci5tZXNzYWdlIGlz IG5vbi1udWxsLgogUEFTUyB0cmFucy5lcnJvciBpcyByZXF1ZXN0X2Vycm9yCiAKIElmIHRoZSB0 cmFuc2FjdGlvbiBpcyBhYm9ydGVkIGR1ZSB0byBhbiBleGNlcHRpb24gdGhyb3duIGZyb20gZXZl bnQgY2FsbGJhY2ssIElEQlRyYW5zYWN0aW9uLmVycm9yIHNob3VsZCBiZSBBYm9ydEVycm9yOgpA QCAtNDIsOCArNDAsNiBAQCBQQVNTIHJlcXVlc3QuZXJyb3IubmFtZSBpcyAnQ29uc3RyYWludEVy cm9yJwogVGhyb3dpbmcgZXhjZXB0aW9uLi4uCiBUcmFuc2FjdGlvbiByZWNlaXZlZCBhYm9ydCBl dmVudC4KIFBBU1MgdHJhbnMuZXJyb3IgaXMgbm9uLW51bGwuCi10cmFucy5lcnJvci5tZXNzYWdl ID0gVW5jYXVnaHQgZXhjZXB0aW9uIGluIGV2ZW50IGhhbmRsZXIuCi1QQVNTIHRyYW5zLmVycm9y Lm1lc3NhZ2UgaXMgbm9uLW51bGwuCiBQQVNTIHRyYW5zLmVycm9yLm5hbWUgaXMgJ0Fib3J0RXJy b3InCiAKIElmIHRoZSB0cmFuc2FjdGlvbiBpcyBhYm9ydGVkIGR1ZSB0byBhbiBlcnJvciBkdXJp bmcgY29tbWl0LCBJREJUcmFuc2FjdGlvbi5lcnJvciBzaG91bGQgcmVmbGVjdCB0aGF0IGVycm9y OgpAQCAtNTgsMTAgKzU0LDcgQEAgdHJhbnMub2JqZWN0U3RvcmUoJ3N0b3JlTmFtZScpLmNyZWF0 ZUluZGV4KGluZGV4TmFtZSwgJ2lkJywge3VuaXF1ZTogdHJ1ZX0pCiBUcmFuc2FjdGlvbiByZWNl aXZlZCBhYm9ydCBldmVudC4KIFBBU1MgdHJhbnMuZXJyb3IgaXMgbm9uLW51bGwuCiBQQVNTIHRy YW5zLmVycm9yLm5hbWUgaXMgJ0NvbnN0cmFpbnRFcnJvcicKLXRyYW5zLmVycm9yLm1lc3NhZ2Ug PSBVbmFibGUgdG8gYWRkIGtleSB0byBpbmRleCAnQWxzbyB0ZXN0IHV0Zjg6IOa8oic6IGF0IGxl YXN0IG9uZSBrZXkgZG9lcyBub3Qgc2F0aXNmeSB0aGUgdW5pcXVlbmVzcyByZXF1aXJlbWVudHMu Ci1QQVNTIHRyYW5zLmVycm9yLm1lc3NhZ2UgaXMgbm9uLW51bGwuCiBOb3RlOiBUaGlzIGZhaWxz IGJlY2F1c2Ugb2YgaHR0cDovL3drYi51Zy8zNzMyNwotUEFTUyB0cmFucy5lcnJvci5tZXNzYWdl LmluZGV4T2YoaW5kZXhOYW1lKSBpcyBub3QgLTEKIAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkwMmRlNy4uNGE0NGRjMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSw1ICsxLDI2IEBACiAyMDE1LTEyLTAyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KIAorICAgICAgICBNb2Rlcm4gSURCOiBJREJUcmFuc2FjdGlvbjo6ZXJyb3IgaXMgbm90IGV4 cG9zZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTE3NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMgKEF0IGxlYXN0IDMgZmFpbGluZyB0ZXN0cyBub3cgcGFzcywgcGx1cyBjaGFu Z2VzIHRvIG90aGVyIGZhdWx0eSB0ZXN0cykuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRk Yi9jbGllbnQvSURCUmVxdWVzdEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50 OjpJREJSZXF1ZXN0OjpkaXNwYXRjaEV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OklEQkNsaWVu dDo6SURCUmVxdWVzdDo6dW5jYXVnaHRFeGNlcHRpb25JbkV2ZW50SGFuZGxlcik6CisgICAgICAg ICogTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmg6CisgICAgICAgIAor ICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJUcmFuc2FjdGlvbkltcGwuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpJREJUcmFuc2FjdGlvbjo6ZXJyb3IpOgor ICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpJREJUcmFuc2FjdGlvbjo6YWJvcnREdWVUb0Zh aWxlZFJlcXVlc3QpOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpJREJUcmFuc2FjdGlv bjo6YWJvcnQpOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpJREJUcmFuc2FjdGlvbjo6 ZGlkQ3JlYXRlSW5kZXhPblNlcnZlcik6CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvY2xp ZW50L0lEQlRyYW5zYWN0aW9uSW1wbC5oOgorCisyMDE1LTEyLTAyICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBNb2Rlcm4gSURCOiBHZXQgcmlkIG9mIElEQkV4 Y2VwdGlvbkNvZGUuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTE3NTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVk ZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5k ZXhlZGRiL2NsaWVudC9JREJSZXF1ZXN0SW1wbC5jcHAKaW5kZXggMGVlN2EyNC4uYjk1MDkwOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJl cXVlc3RJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGll bnQvSURCUmVxdWVzdEltcGwuY3BwCkBAIC0yNzgsOSArMjc4LDIyIEBAIGJvb2wgSURCUmVxdWVz dDo6ZGlzcGF0Y2hFdmVudChFdmVudCYgZXZlbnQpCiAgICAgaWYgKG1fdHJhbnNhY3Rpb24gJiYg IW1fcGVuZGluZ0N1cnNvcikKICAgICAgICAgbV90cmFuc2FjdGlvbi0+cmVtb3ZlUmVxdWVzdCgq dGhpcyk7CiAKKyAgICBpZiAoZG9udFByZXZlbnREZWZhdWx0ICYmIGV2ZW50LnR5cGUoKSA9PSBl dmVudE5hbWVzKCkuZXJyb3JFdmVudCAmJiBtX3RyYW5zYWN0aW9uICYmICFtX3RyYW5zYWN0aW9u LT5pc0ZpbmlzaGVkT3JGaW5pc2hpbmcoKSkgeworICAgICAgICBBU1NFUlQobV9kb21FcnJvcik7 CisgICAgICAgIG1fdHJhbnNhY3Rpb24tPmFib3J0RHVlVG9GYWlsZWRSZXF1ZXN0KCptX2RvbUVy cm9yKTsKKyAgICB9CisKICAgICByZXR1cm4gZG9udFByZXZlbnREZWZhdWx0OwogfQogCit2b2lk IElEQlJlcXVlc3Q6OnVuY2F1Z2h0RXhjZXB0aW9uSW5FdmVudEhhbmRsZXIoKQoreworICAgIExP RyhJbmRleGVkREIsICJJREJSZXF1ZXN0Ojp1bmNhdWdodEV4Y2VwdGlvbkluRXZlbnRIYW5kbGVy Iik7CisKKyAgICBpZiAobV90cmFuc2FjdGlvbiAmJiBtX2lkYkVycm9yLmNvZGUoKSAhPSBJREJE YXRhYmFzZUV4Y2VwdGlvbjo6QWJvcnRFcnJvcikKKyAgICAgICAgbV90cmFuc2FjdGlvbi0+YWJv cnREdWVUb0ZhaWxlZFJlcXVlc3QoRE9NRXJyb3I6OmNyZWF0ZShJREJEYXRhYmFzZUV4Y2VwdGlv bjo6Z2V0RXJyb3JOYW1lKElEQkRhdGFiYXNlRXhjZXB0aW9uOjpBYm9ydEVycm9yKSkpOworfQor CiB2b2lkIElEQlJlcXVlc3Q6OnNldFJlc3VsdChjb25zdCBJREJLZXlEYXRhKiBrZXlEYXRhKQog ewogICAgIGlmICgha2V5RGF0YSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCUmVxdWVzdEltcGwuaAppbmRleCBmM2ZjZDgxLi42Zjdi ZGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQv SURCUmVxdWVzdEltcGwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9j bGllbnQvSURCUmVxdWVzdEltcGwuaApAQCAtMTE0LDYgKzExNCw3IEBAIHByb3RlY3RlZDoKICAg ICAvLyBFdmVudFRhcmdldC4KICAgICB2aXJ0dWFsIHZvaWQgcmVmRXZlbnRUYXJnZXQoKSBvdmVy cmlkZSBmaW5hbCB7IFJlZkNvdW50ZWQ8SURCUmVxdWVzdD46OnJlZigpOyB9CiAgICAgdmlydHVh bCB2b2lkIGRlcmVmRXZlbnRUYXJnZXQoKSBvdmVycmlkZSBmaW5hbCB7IFJlZkNvdW50ZWQ8SURC UmVxdWVzdD46OmRlcmVmKCk7IH0KKyAgICB2aXJ0dWFsIHZvaWQgdW5jYXVnaHRFeGNlcHRpb25J bkV2ZW50SGFuZGxlcigpIG92ZXJyaWRlIGZpbmFsOwogCiAgICAgdmlydHVhbCBib29sIGlzT3Bl bkRCUmVxdWVzdCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJUcmFuc2FjdGlvbkltcGwuY3Bw IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlRyYW5zYWN0aW9u SW1wbC5jcHAKaW5kZXggZDEwZTViZi4uMjkzMDAwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlRyYW5zYWN0aW9uSW1wbC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlRyYW5zYWN0aW9uSW1w bC5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJET01FcnJvci5oIgogI2luY2x1ZGUg IkV2ZW50UXVldWUuaCIKICNpbmNsdWRlICJJREJDdXJzb3JXaXRoVmFsdWVJbXBsLmgiCisjaW5j bHVkZSAiSURCRGF0YWJhc2VFeGNlcHRpb24uaCIKICNpbmNsdWRlICJJREJEYXRhYmFzZUltcGwu aCIKICNpbmNsdWRlICJJREJFcnJvci5oIgogI2luY2x1ZGUgIklEQkV2ZW50RGlzcGF0Y2hlci5o IgpAQCAtMTE3LDggKzExOCw3IEBAIElEQkNvbm5lY3Rpb25Ub1NlcnZlciYgSURCVHJhbnNhY3Rp b246OnNlcnZlckNvbm5lY3Rpb24oKQogCiBSZWZQdHI8RE9NRXJyb3I+IElEQlRyYW5zYWN0aW9u OjplcnJvcigpIGNvbnN0CiB7Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJu IG51bGxwdHI7CisgICAgcmV0dXJuIG1fZG9tRXJyb3I7CiB9CiAKIFJlZlB0cjxXZWJDb3JlOjpJ REJPYmplY3RTdG9yZT4gSURCVHJhbnNhY3Rpb246Om9iamVjdFN0b3JlKGNvbnN0IFN0cmluZyYg b2JqZWN0U3RvcmVOYW1lLCBFeGNlcHRpb25Db2RlJiBlYykKQEAgLTE2NSwxMiArMTY1LDIzIEBA IFJlZlB0cjxXZWJDb3JlOjpJREJPYmplY3RTdG9yZT4gSURCVHJhbnNhY3Rpb246Om9iamVjdFN0 b3JlKGNvbnN0IFN0cmluZyYgb2JqZWN0CiAgICAgcmV0dXJuIGFkb3B0UmVmKCZvYmplY3RTdG9y ZS5sZWFrUmVmKCkpOwogfQogCisKK3ZvaWQgSURCVHJhbnNhY3Rpb246OmFib3J0RHVlVG9GYWls ZWRSZXF1ZXN0KERPTUVycm9yJiBlcnJvcikKK3sKKyAgICBMT0coSW5kZXhlZERCLCAiSURCVHJh bnNhY3Rpb246OmFib3J0RHVlVG9GYWlsZWRSZXF1ZXN0Iik7CisgICAgQVNTRVJUKCFpc0Zpbmlz aGVkT3JGaW5pc2hpbmcoKSk7CisKKyAgICBtX2RvbUVycm9yID0gJmVycm9yOworICAgIEV4Y2Vw dGlvbkNvZGUgZWM7CisgICAgYWJvcnQoZWMpOworfQorCiB2b2lkIElEQlRyYW5zYWN0aW9uOjph Ym9ydChFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBMT0coSW5kZXhlZERCLCAiSURCVHJhbnNh Y3Rpb246OmFib3J0Iik7CiAKICAgICBpZiAoaXNGaW5pc2hlZE9yRmluaXNoaW5nKCkpIHsKLSAg ICAgICAgZWMgPSBJTlZBTElEX1NUQVRFX0VSUjsKKyAgICAgICAgZWMgPSBJREJEYXRhYmFzZUV4 Y2VwdGlvbjo6SW52YWxpZFN0YXRlRXJyb3I7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAg LTQ4MSw4ICs0OTIsNyBAQCB2b2lkIElEQlRyYW5zYWN0aW9uOjpkaWRDcmVhdGVJbmRleE9uU2Vy dmVyKGNvbnN0IElEQlJlc3VsdERhdGEmIHJlc3VsdERhdGEpCiAgICAgICAgIHJldHVybjsKIAog ICAgIC8vIE90aGVyd2lzZSwgZmFpbHVyZSB0byBjcmVhdGUgYW4gaW5kZXggZm9yY2VkIGFib3J0 aW9uIG9mIHRoZSB0cmFuc2FjdGlvbi4KLSAgICBFeGNlcHRpb25Db2RlIGVjOwotICAgIGFib3J0 KGVjKTsKKyAgICBhYm9ydER1ZVRvRmFpbGVkUmVxdWVzdChET01FcnJvcjo6Y3JlYXRlKElEQkRh dGFiYXNlRXhjZXB0aW9uOjpnZXRFcnJvck5hbWUocmVzdWx0RGF0YS5lcnJvcigpLmNvZGUoKSkp KTsKIH0KIAogUmVmPElEQlJlcXVlc3Q+IElEQlRyYW5zYWN0aW9uOjpyZXF1ZXN0T3BlbkN1cnNv cihTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBJREJPYmplY3RTdG9yZSYgb2JqZWN0 U3RvcmUsIGNvbnN0IElEQkN1cnNvckluZm8mIGluZm8pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCVHJhbnNhY3Rpb25JbXBsLmggYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCVHJhbnNhY3Rpb25JbXBsLmgK aW5kZXggNDhhYzI5Ni4uYThlNDVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvY2xpZW50L0lEQlRyYW5zYWN0aW9uSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJUcmFuc2FjdGlvbkltcGwuaApAQCAtMTE2 LDYgKzExNiw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGFkZFJlcXVlc3QoSURCUmVxdWVzdCYpOwog ICAgIHZvaWQgcmVtb3ZlUmVxdWVzdChJREJSZXF1ZXN0Jik7CiAKKyAgICB2b2lkIGFib3J0RHVl VG9GYWlsZWRSZXF1ZXN0KERPTUVycm9yJik7CisKICAgICBJREJDb25uZWN0aW9uVG9TZXJ2ZXIm IHNlcnZlckNvbm5lY3Rpb24oKTsKIAogICAgIHZvaWQgYWN0aXZhdGUoKTsKQEAgLTE5MSw2ICsx OTMsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9zdGFydGVkT25TZXJ2ZXIgeyBmYWxzZSB9Owog CiAgICAgSURCRXJyb3IgbV9pZGJFcnJvcjsKKyAgICBSZWZQdHI8RE9NRXJyb3I+IG1fZG9tRXJy b3I7CiAKICAgICBUaW1lciBtX29wZXJhdGlvblRpbWVyOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxU aW1lcj4gbV9hY3RpdmF0aW9uVGltZXI7Cg==