151620 2015-11-26 05:35:36 -0800 Fix the ENABLE(B3_JIT) build with GCC in B3Procedure.h 2015-12-14 04:56:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 152248 1 ossy ossy commit-queue fpizlo ggaren keith_miller mark.lam msaboff ossy saam oldest_to_newest 1144493 0 ossy 2015-11-26 05:35:36 -0800 build log: ----------- In file included from /usr/include/c++/4.9/memory:81:0, from ../../Source/WTF/wtf/StdLibExtras.h:31, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/JavaScriptCore/config.h:54, from ../../Source/JavaScriptCore/b3/B3LowerMacros.cpp:26: /usr/include/c++/4.9/bits/unique_ptr.h: In instantiation of 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = JSC::B3::OpaqueByproducts]': /usr/include/c++/4.9/bits/unique_ptr.h:236:16: required from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = JSC::B3::OpaqueByproducts; _Dp = std::default_delete<JSC::B3::OpaqueByproducts>]' ../../Source/JavaScriptCore/b3/B3Procedure.h:222:87: required from here /usr/include/c++/4.9/bits/unique_ptr.h:74:22: error: invalid application of 'sizeof' to incomplete type 'JSC::B3::OpaqueByproducts' ninja: build stopped: subcommand failed. 1144494 1 266180 ossy 2015-11-26 05:38:40 -0800 Created attachment 266180 Patch 1144511 2 266180 mark.lam 2015-11-26 06:50:25 -0800 Comment on attachment 266180 Patch I don't see any use of OpaqueByproducts in B3Procedure.h other than as a pointer. Which files are failing to build without this change? Should they be #including B3OpaqueByproducts.h themselves? 1144515 3 ossy 2015-11-26 07:03:34 -0800 (In reply to comment #2) > Comment on attachment 266180 [details] > Patch > > I don't see any use of OpaqueByproducts in B3Procedure.h other than as a > pointer. Which files are failing to build without this change? Should they > be #including B3OpaqueByproducts.h themselves? I got the cited error for almost all cpp files. I don't think if we should include this header everywhere explicitly. 1144516 4 266180 mark.lam 2015-11-26 07:04:35 -0800 Comment on attachment 266180 Patch r=me 1144576 5 266180 commit-queue 2015-11-27 05:01:31 -0800 Comment on attachment 266180 Patch Clearing flags on attachment: 266180 Committed r192777: <http://trac.webkit.org/changeset/192777> 1144577 6 commit-queue 2015-11-27 05:01:36 -0800 All reviewed patches have been landed. Closing bug. 266180 2015-11-26 05:38:40 -0800 2015-11-27 05:01:31 -0800 Patch bug-151620-20151126143822.patch text/plain 1252 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NDRkNzZiNzBkZjdhNGIyN2Q0YmI4OTVhYTg1ZTM5NWE5MWE3MDNlLi4yY2YzYzQzZTUwZmYwMmE3 Y2NlYjUwMDZiZWIzZmU1NjVmM2U2MTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0xMS0yNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCB0aGUgRU5BQkxFKEIzX0pJVCkgYnVpbGQgd2l0aCBHQ0MgaW4g QjNQcm9jZWR1cmUuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUxNjIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBiMy9CM1Byb2NlZHVyZS5oOgorCiAyMDE1LTExLTI0ICBDYWl0bGluIFBvdHRlciAg PGNhaXRwQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pTQ10gc3VwcG9ydCBDb21wdXRlZCBQcm9w ZXJ0eSBOYW1lcyBpbiBkZXN0cnVjdHVyaW5nIFBhdHRlcm5zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYjMvQjNQcm9jZWR1cmUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My9CM1Byb2NlZHVyZS5oCmluZGV4IDg5N2I0ZTk2NDdkYTRiZjQ3ZDQ0YjMwZjU0ZGE2OGU5YmQ3 NGZiZDAuLjgyOTAzZDk0MGVmZTZhZDkxYzA3Yjk5YmZlYzQ4ZmRlYTZmZjczNDIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1Byb2NlZHVyZS5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9iMy9CM1Byb2NlZHVyZS5oCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpZiBF TkFCTEUoQjNfSklUKQogCisjaW5jbHVkZSAiQjNPcGFxdWVCeXByb2R1Y3RzLmgiCiAjaW5jbHVk ZSAiQjNPcmlnaW4uaCIKICNpbmNsdWRlICJCM1R5cGUuaCIKICNpbmNsdWRlICJQdXJlTmFOLmgi CkBAIC00Myw3ICs0NCw2IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgQjMgewogCiBjbGFz cyBCYXNpY0Jsb2NrOwogY2xhc3MgQmxvY2tJbnNlcnRpb25TZXQ7Ci1jbGFzcyBPcGFxdWVCeXBy b2R1Y3RzOwogY2xhc3MgVmFsdWU7CiAKIG5hbWVzcGFjZSBBaXIgeyBjbGFzcyBDb2RlOyB9Cg==