151619 2015-11-26 05:07:57 -0800 [cmake] Add testb3 to the build system 2015-12-14 04:56:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 152248 1 ossy ossy commit-queue fpizlo ggaren ossy oldest_to_newest 1144490 0 ossy 2015-11-26 05:07:57 -0800 SSIA 1144491 1 266178 ossy 2015-11-26 05:13:34 -0800 Created attachment 266178 Patch 1144545 2 266178 gyuyoung.kim 2015-11-26 18:55:43 -0800 Comment on attachment 266178 Patch LGTM. 1144572 3 ossy 2015-11-27 04:19:31 -0800 (In reply to comment #1) > Created attachment 266178 [details] > Patch Windows build fails with the following error: testb3.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) void __cdecl WTF::printInternal(class WTF::PrintStream &,char const *)" (__imp_?printInternal@WTF@@YAXAAVPrintStream@1@PBD@Z) referenced in function "public: void __thiscall WTF::PrintStream::print<char [24]>(char const (&)[24])" (??$print@$$BY0BI@D@PrintStream@WTF@@QAEXAAY0BI@$$CBD@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\JavaScriptCore\shell\testb3.vcxproj] testb3.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) class WTF::FilePrintStream & __cdecl WTF::dataFile(void)" (__imp_?dataFile@WTF@@YAAAVFilePrintStream@1@XZ) referenced in function "void __cdecl WTF::dataLog<char [24]>(char const (&)[24])" (??$dataLog@$$BY0BI@D@WTF@@YAXAAY0BI@$$CBD@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\JavaScriptCore\shell\testb3.vcxproj] C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\testb3.exe : fatal error LNK1120: 2 unresolved externals [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\JavaScriptCore\shell\testb3.vcxproj] Windows doesn't support FTL JIT yet, not to mention B3, so I'm going to disable building testb3 on it. 1144573 4 266197 ossy 2015-11-27 04:26:10 -0800 Created attachment 266197 Patch patch for landing with Windows build fix 1144589 5 266197 commit-queue 2015-11-27 06:16:40 -0800 Comment on attachment 266197 Patch Clearing flags on attachment: 266197 Committed r192781: <http://trac.webkit.org/changeset/192781> 1144590 6 commit-queue 2015-11-27 06:16:43 -0800 All reviewed patches have been landed. Closing bug. 266178 2015-11-26 05:13:34 -0800 2015-11-27 04:26:06 -0800 Patch bug-151619-20151126141315.patch text/plain 2334 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NDRkNzZiNzBkZjdhNGIyN2Q0YmI4OTVhYTg1ZTM5NWE5MWE3MDNlLi5hNWEwYjc4ZWE1OTcwNzJi NjZiMTkwZjEwN2ZjNWRkZmI5ZDZiNjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0xMS0yNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtjbWFrZV0gQWRkIHRlc3RiMyB0byB0aGUgYnVpbGQgc3lzdGVtCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE2MTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNoZWxsL0NN YWtlTGlzdHMudHh0OgorCiAyMDE1LTExLTI0ICBDYWl0bGluIFBvdHRlciAgPGNhaXRwQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0pTQ10gc3VwcG9ydCBDb21wdXRlZCBQcm9wZXJ0eSBOYW1lcyBp biBkZXN0cnVjdHVyaW5nIFBhdHRlcm5zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvc2hlbGwvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvc2hlbGwvQ01h a2VMaXN0cy50eHQKaW5kZXggODhhMmY1NjcxMjU3ZDVmNTQ4ZTA3MTNiNTkzZTRlMmFmMmQyYzQy ZC4uZDgxN2RkM2E4MWMxN2Y3YzFkYTg1ZjA4NWI5NjhkYmJjN2I1YmE1YiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFrZUxpc3RzLnR4dApAQCAtMzksMyArMzksMTAgQEAgZW5k aWYgKCkKIGlmIChXSU4zMikKICAgICBhZGRfZGVwZW5kZW5jaWVzKGpzYyBqc2NMaWIpCiBlbmRp ZiAoKQorCitzZXQoVEVTVEIzX1NPVVJDRVMKKyAgICAuLi9iMy90ZXN0YjMuY3BwCispCisKK2Fk ZF9leGVjdXRhYmxlKHRlc3RiMyAke1RFU1RCM19TT1VSQ0VTfSkKK3RhcmdldF9saW5rX2xpYnJh cmllcyh0ZXN0YjMgJHtKU0NfTElCUkFSSUVTfSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZDk1Mzk3NzQ3ZjNjN2ZkYTYxNWIxYzA0YWRlZjg5 NWNjMjU3Y2ZiLi5iNjc1MzdkZWY1MzY2Yjg0NDljMDg3NjZhMjgwMjVkMDRkMGJhN2NhIDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTUtMTEtMjYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K KworICAgICAgICBbY21ha2VdIEFkZCB0ZXN0YjMgdG8gdGhlIGJ1aWxkIHN5c3RlbQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNjE5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxk LWpzYzoKKwogMjAxNS0xMS0yMiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAg ICAgICAgVGVhY2ggTWluaUJyb3dzZXIgaG93IHRvIGVuYWJsZSB0aGUgbW9jayBjb250ZW50IGZp bHRlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MgYi9Ub29scy9TY3JpcHRz L2J1aWxkLWpzYwppbmRleCA2YjZhNGFlMjZjMTc1ZDk2MzA3YmViZDc4NjE3YmQwMjhiMmZhZmNh Li43ZDNiODAwOTkwMjAyNmFkODhkNjNhNmYxNzRiMjc4YjhlNWM4ZTQ5IDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL2J1aWxkLWpzYworKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwpAQCAt MTA2LDcgKzEwNiw3IEBAIGlmIChpc0NNYWtlQnVpbGQoKSkgewogICAgIHVubGVzcyAoaXNBbnlX aW5kb3dzKCkpIHsKICAgICAgICAgIyBCeSBkZWZhdWx0IHdlIGJ1aWxkIHVzaW5nIGFsbCBvZiB0 aGUgYXZhaWxhYmxlIENQVXMKICAgICAgICAgJG1ha2VBcmdzIC49ICgkbWFrZUFyZ3MgPyAiICIg OiAiIikgLiAiLWoiIC4gbnVtYmVyT2ZDUFVzKCkgaWYgJG1ha2VBcmdzICF+IC8talxzKlxkKy87 Ci0gICAgICAgICRidWlsZFRhcmdldCA9ICJqc2MgJG1ha2VBcmdzIjsKKyAgICAgICAgJGJ1aWxk VGFyZ2V0ID0gImpzYyB0ZXN0YjMgJG1ha2VBcmdzIjsKICAgICB9IGVsc2lmIChjYW5Vc2VOaW5q YSgpKSB7CiAgICAgICAgICRidWlsZFRhcmdldCAuPSAianNjIHRlc3RhcGkiOwogICAgIH0K 266197 2015-11-27 04:26:10 -0800 2015-11-27 06:16:40 -0800 Patch bug-151619-20151127042551.patch text/plain 2351 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 OWY2ODc4NWQ5N2U5Nzc2Njg0M2Y4ZTMzMmI2NTE4YTBiNTUwNmM4Li4yOGIwZDhkOWIyNWIyZDNm OWMxMDlmYThlZjIyZWVjODlmYjE0ZGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0xMS0yNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtjbWFrZV0gQWRkIHRlc3RiMyB0byB0aGUgYnVpbGQgc3lzdGVtCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE2MTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBHeXV5b3VuZyBLaW0uCisKKyAgICAgICAgKiBzaGVsbC9DTWFr ZUxpc3RzLnR4dDoKKwogMjAxNS0xMS0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dMSUJdIEltcGxlbWVudCBnYXJiYWdlIGNvbGxlY3Rv ciB0aW1lcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFrZUxp c3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFrZUxpc3RzLnR4dAppbmRl eCA4OGEyZjU2NzEyNTdkNWY1NDhlMDcxM2I1OTNlNGUyYWYyZDJjNDJkLi41NmMwNzJkMjA1Yjg3 MmU1NTcyYzBhOTM0MjgxODdmOGM0ODI4ZDllIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvc2hlbGwvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3No ZWxsL0NNYWtlTGlzdHMudHh0CkBAIC0zOSwzICszOSwxMiBAQCBlbmRpZiAoKQogaWYgKFdJTjMy KQogICAgIGFkZF9kZXBlbmRlbmNpZXMoanNjIGpzY0xpYikKIGVuZGlmICgpCisKK2lmIChOT1Qg V0lOMzIpCisgICAgc2V0KFRFU1RCM19TT1VSQ0VTCisgICAgICAgIC4uL2IzL3Rlc3RiMy5jcHAK KyAgICApCisKKyAgICBhZGRfZXhlY3V0YWJsZSh0ZXN0YjMgJHtURVNUQjNfU09VUkNFU30pCisg ICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKHRlc3RiMyAke0pTQ19MSUJSQVJJRVN9KQorZW5kaWYg KCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBj OTIwZjBhY2U0MmU2MGQ1NTkyNzY5ZmI4ZDE0NGVkYmRlMzFiOGRjLi5mZjNlMmYyYTQzZDk0NDgz OTkxYmZhNmYwMDdhNzljZjdiNDEyYzJmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMTEtMjcgIENzYWJhIE9z enRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbY21ha2VdIEFkZCB0ZXN0 YjMgdG8gdGhlIGJ1aWxkIHN5c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUxNjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcgS2lt LgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC1qc2M6CisKIDIwMTUtMTEtMjYgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFeHRyYWN0IHByZXBlbmRUb0Vu dmlyb25tZW50VmFyaWFibGVMaXN0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpz YyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IDZiNmE0YWUyNmMxNzVkOTYzMDdiZWJk Nzg2MTdiZDAyOGIyZmFmY2EuLjdkM2I4MDA5OTAyMDI2YWQ4OGQ2M2E2ZjE3NGIyNzhiOGU1Yzhl NDkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xzL1Njcmlw dHMvYnVpbGQtanNjCkBAIC0xMDYsNyArMTA2LDcgQEAgaWYgKGlzQ01ha2VCdWlsZCgpKSB7CiAg ICAgdW5sZXNzIChpc0FueVdpbmRvd3MoKSkgewogICAgICAgICAjIEJ5IGRlZmF1bHQgd2UgYnVp bGQgdXNpbmcgYWxsIG9mIHRoZSBhdmFpbGFibGUgQ1BVcwogICAgICAgICAkbWFrZUFyZ3MgLj0g KCRtYWtlQXJncyA/ICIgIiA6ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFy Z3MgIX4gLy1qXHMqXGQrLzsKLSAgICAgICAgJGJ1aWxkVGFyZ2V0ID0gImpzYyAkbWFrZUFyZ3Mi OworICAgICAgICAkYnVpbGRUYXJnZXQgPSAianNjIHRlc3RiMyAkbWFrZUFyZ3MiOwogICAgIH0g ZWxzaWYgKGNhblVzZU5pbmphKCkpIHsKICAgICAgICAgJGJ1aWxkVGFyZ2V0IC49ICJqc2MgdGVz dGFwaSI7CiAgICAgfQo=