151515 2015-11-20 14:15:39 -0800 [ARM64] stress/op_div.js is failing on some divide by 0 cases. 2015-11-30 08:57:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 108645 1 mark.lam mark.lam benjamin fpizlo ggaren keith_miller msaboff ossy saam webkit-bug-importer oldest_to_newest 1143816 0 mark.lam 2015-11-20 14:15:39 -0800 This newly added is exposing a latent bug somewhere in the ARM64 JITs. 1143818 1 webkit-bug-importer 2015-11-20 14:16:52 -0800 <rdar://problem/23636074> 1143861 2 mark.lam 2015-11-20 15:47:37 -0800 The test has been temporarily skipped in r192708: <http://trac.webkit.org/r192708>. 1144517 3 266186 mark.lam 2015-11-26 07:10:30 -0800 Created attachment 266186 proposed patch. 1144615 4 266186 saam 2015-11-27 16:45:01 -0800 Comment on attachment 266186 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=266186&action=review LGTM > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3560 > + speculationCheck(Overflow, JSValueRegs(), 0, m_jit.branchTest32(MacroAssembler::Zero, op2GPR)); Style: I think this is nicer to read with "0 => nullptr" 1144770 5 mark.lam 2015-11-30 08:57:45 -0800 Thanks for the review. I've changed the "0" to "nullptr". Landed in r192795: <http://trac.webkit.org/r192795>. 266186 2015-11-26 07:10:30 -0800 2015-11-27 16:45:01 -0800 proposed patch. bug-151515.patch text/plain 1983 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNzczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTExLTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBb QVJNNjRdIHN0cmVzcy9vcF9kaXYuanMgaXMgZmFpbGluZyBvbiBzb21lIGRpdmlkZSBieSAwIGNh c2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUx NTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBk ZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZl SklUOjpjb21waWxlQXJpdGhEaXYpOgorICAgICAgICAtIEFkZGVkIGEgY2hlY2sgZm9yIHRoZSBk aXZpZGUgYnkgemVybyBjYXNlLgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9vcF9kaXYuanM6Cisg ICAgICAgIC0gVW4tc2tpcHBlZCB0aGUgdGVzdC4KKwogMjAxNS0xMS0yNiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dMSUJdIEltcGxlbWVu dCBnYXJiYWdlIGNvbGxlY3RvciB0aW1lcnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAxOTI3NjcpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzU1Niw2ICszNTU2LDkgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUFyaXRo RGl2KE5vZAogICAgICAgICAgICAgbnVtZXJhdG9yTm9uWmVyby5saW5rKCZtX2ppdCk7CiAgICAg ICAgIH0KIAorICAgICAgICBpZiAoc2hvdWxkQ2hlY2tPdmVyZmxvdyhub2RlLT5hcml0aE1vZGUo KSkpCisgICAgICAgICAgICBzcGVjdWxhdGlvbkNoZWNrKE92ZXJmbG93LCBKU1ZhbHVlUmVncygp LCAwLCBtX2ppdC5icmFuY2hUZXN0MzIoTWFjcm9Bc3NlbWJsZXI6Olplcm8sIG9wMkdQUikpOwor CiAgICAgICAgIG1faml0LmFzc2VtYmxlcigpLnNkaXY8MzI+KHF1b3RpZW50LmdwcigpLCBvcDFH UFIsIG9wMkdQUik7CiAKICAgICAgICAgLy8gQ2hlY2sgdGhhdCB0aGVyZSB3YXMgbm8gcmVtYWlu ZGVyLiBJZiB0aGVyZSBoYWQgYmVlbiwgdGhlbiB3ZSdkIGJlIG9ibGlnYXRlZCB0bwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vcF9kaXYuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vcF9kaXYuanMJKHJldmlzaW9u IDE5Mjc2NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb3BfZGl2Lmpz CSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNCBAQAotLy9AIHNraXAKLS8vIEZJWE1FOiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTE1CisvL0AgcnVuRlRMTm9D SklUCiAKIC8vIElmIGFsbCBnb2VzIHdlbGwsIHRoaXMgdGVzdCBtb2R1bGUgd2lsbCB0ZXJtaW5h dGUgc2lsZW50bHkuIElmIG5vdCwgaXQgd2lsbCBwcmludAogLy8gZXJyb3JzLiBTZWUgYmluYXJ5 LW9wLXRlc3QuanMgZm9yIGRlYnVnZ2luZyBvcHRpb25zIGlmIG5lZWRlZC4K