151490 2015-11-20 05:00:34 -0800 [GTK] Some unit tests fail when using the network process 2015-11-22 01:00:58 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply oldest_to_newest 1143623 0 cgarcia 2015-11-20 05:00:34 -0800 /webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT /webkit2/WebKitWebResource/get-data: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached /webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT 1143633 1 cgarcia 2015-11-20 06:33:30 -0800 (In reply to comment #0) > /webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT This works with the web process only because all request started are done before the first subresource is processed by the server, something that doesn't happen when using the network process. We are using mutexes in the same main thread, the soup server should run in a separate thread for this to work properly. > /webkit2/WebKitWebResource/get-data: ** > ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void > ResourcesTest::checkResourceData(WebKitWebResource*): code should not be > reached I haven't investigated this yet, but running the soup server in a thread also fixed this one. > /webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT No idea about this one, yet. I'll submit a patch to fix the other two for now. 1143635 2 265952 cgarcia 2015-11-20 06:39:07 -0800 Created attachment 265952 Patch 1144012 3 cgarcia 2015-11-22 00:56:42 -0800 (In reply to comment #0) > /webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT > > /webkit2/WebKitWebResource/get-data: ** > ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void > ResourcesTest::checkResourceData(WebKitWebResource*): code should not be > reached > > /webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT This one is timing out for me locally even when using the web process, so it's ot related. 1144013 4 cgarcia 2015-11-22 01:00:58 -0800 Committed r192729: <http://trac.webkit.org/changeset/192729> 265952 2015-11-20 06:39:07 -0800 2015-11-20 09:30:39 -0800 Patch wk2-test-resources-network-process.diff text/plain 5464 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYWIx MTI2Li4wNjhkYWRjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTUtMTEtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFNvbWUgdW5pdCB0ZXN0cyBm YWlsIHdoZW4gdXNpbmcgdGhlIG5ldHdvcmsgcHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUnVuIHRoZSBzb3VwIHNlcnZlciBpbiBhIHNlcGFy YXRlIHRocmVhZCBpbiBUZXN0UmVzb3VyY2VzIHRlc3QgdG8KKyAgICAgICAgYXZvaWQgZGVhZGxv Y2tzLgorCisgICAgICAgIFRoaXMgZml4ZXMgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9zeW5jLXJl cXVlc3Qtb24tbWF4LWNvbm5zIGFuZAorICAgICAgICAvd2Via2l0Mi9XZWJLaXRXZWJSZXNvdXJj ZS9nZXQtZGF0YSB3aGVuIHVzaW5nIHRoZSBuZXR3b3JrIHByb2Nlc3MuCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdFJlc291cmNlcy5jcHA6CisgICAgICAg IChiZWZvcmVBbGwpOiBDcmVhdGUgdGhlIFdlYktpdFRlc3RTZXJ2ZXIgd2l0aCBTZXJ2ZXJSdW5J blRocmVhZCBmbGFnLgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvZ3RrL1dlYktpdDJHdGsvV2Vi S2l0VGVzdFNlcnZlci5jcHA6CisgICAgICAgIChXZWJLaXRUZXN0U2VydmVyOjpXZWJLaXRUZXN0 U2VydmVyKTogV2hlbiBTZXJ2ZXJSdW5JblRocmVhZCBpcworICAgICAgICBwcmVzZW50LCBjcmVh dGUgYSBXb3JrUXVldWUgdG8gcnVuIHRoZSBzZXJ2ZXIuCisgICAgICAgIChXZWJLaXRUZXN0U2Vy dmVyOjpydW4pOiBSdW4gdGhlIHNlcnZlciBpbiB0aGUgd29yayBxdWV1ZSBpZiBpdAorICAgICAg ICBoYXMgYmVlbiBjcmVhdGVkLgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvZ3RrL1dlYktpdDJH dGsvV2ViS2l0VGVzdFNlcnZlci5oOiBDb252ZXJ0IHNlcnZlcgorICAgICAgICB0eXBlIGludG8g c2VydmVyIG9wdGlvbnMgYXMgZmxhZ3MuCisKIDIwMTUtMTEtMjAgIEFsZXggQ2hyaXN0ZW5zZW4g IDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgdGhlIG5vbi1OZXR3 b3JrUHJvY2VzcyBjb25maWd1cmF0aW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RSZXNvdXJjZXMuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RSZXNvdXJjZXMuY3BwCmluZGV4IDQ3ZjY2NmEuLjlmOTdi NWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0 UmVzb3VyY2VzLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsv VGVzdFJlc291cmNlcy5jcHAKQEAgLTgzNSw3ICs4MzUsNyBAQCBzdGF0aWMgdm9pZCBzZXJ2ZXJD YWxsYmFjayhTb3VwU2VydmVyKiBzZXJ2ZXIsIFNvdXBNZXNzYWdlKiBtZXNzYWdlLCBjb25zdCBj aGFyKgogCiB2b2lkIGJlZm9yZUFsbCgpCiB7Ci0gICAga1NlcnZlciA9IG5ldyBXZWJLaXRUZXN0 U2VydmVyKCk7CisgICAga1NlcnZlciA9IG5ldyBXZWJLaXRUZXN0U2VydmVyKFdlYktpdFRlc3RT ZXJ2ZXI6OlNlcnZlck9wdGlvbnM6OlNlcnZlclJ1bkluVGhyZWFkKTsKICAgICBrU2VydmVyLT5y dW4oc2VydmVyQ2FsbGJhY2spOwogCiAgICAgUmVzb3VyY2VzVGVzdDo6YWRkKCJXZWJLaXRXZWJW aWV3IiwgInJlc291cmNlcyIsIHRlc3RXZWJWaWV3UmVzb3VyY2VzKTsKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvZ3RrL1dlYktpdDJHdGsvV2ViS2l0VGVzdFNlcnZlci5jcHAgYi9U b29scy9UZXN0V2ViS2l0QVBJL2d0ay9XZWJLaXQyR3RrL1dlYktpdFRlc3RTZXJ2ZXIuY3BwCmlu ZGV4IDVjNzUxNDMuLmRlOTQ2NmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ3Rr L1dlYktpdDJHdGsvV2ViS2l0VGVzdFNlcnZlci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9ndGsvV2ViS2l0Mkd0ay9XZWJLaXRUZXN0U2VydmVyLmNwcApAQCAtMjEsMTMgKzIxLDE5IEBA CiAjaW5jbHVkZSAiV2ViS2l0VGVzdFNlcnZlci5oIgogCiAjaW5jbHVkZSAiVGVzdE1haW4uaCIK KyNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0 ci5oPgogCi1XZWJLaXRUZXN0U2VydmVyOjpXZWJLaXRUZXN0U2VydmVyKFNlcnZlclR5cGUgdHlw ZSkKK1dlYktpdFRlc3RTZXJ2ZXI6OldlYktpdFRlc3RTZXJ2ZXIoU2VydmVyT3B0aW9ucyBvcHRp b25zKQogeworICAgIGlmIChvcHRpb25zICYgU2VydmVyUnVuSW5UaHJlYWQpIHsKKyAgICAgICAg V1RGOjppbml0aWFsaXplVGhyZWFkaW5nKCk7CisgICAgICAgIG1fcXVldWUgPSBXb3JrUXVldWU6 OmNyZWF0ZSgiV2ViS2l0VGVzdFNlcnZlciIpOworICAgIH0KKwogICAgIEdVbmlxdWVQdHI8Y2hh cj4gc3NsQ2VydGlmaWNhdGVGaWxlOwogICAgIEdVbmlxdWVQdHI8Y2hhcj4gc3NsS2V5RmlsZTsK LSAgICBpZiAodHlwZSA9PSBTZXJ2ZXJIVFRQUykgeworICAgIGlmIChvcHRpb25zICYgU2VydmVy SFRUUFMpIHsKICAgICAgICAgQ1N0cmluZyByZXNvdXJjZXNEaXIgPSBUZXN0OjpnZXRSZXNvdXJj ZXNEaXIoKTsKICAgICAgICAgc3NsQ2VydGlmaWNhdGVGaWxlLnJlc2V0KGdfYnVpbGRfZmlsZW5h bWUocmVzb3VyY2VzRGlyLmRhdGEoKSwgInRlc3QtY2VydC5wZW0iLCBOVUxMKSk7CiAgICAgICAg IHNzbEtleUZpbGUucmVzZXQoZ19idWlsZF9maWxlbmFtZShyZXNvdXJjZXNEaXIuZGF0YSgpLCAi dGVzdC1rZXkucGVtIiwgTlVMTCkpOwpAQCAtMzcsOSArNDMsMTAgQEAgV2ViS2l0VGVzdFNlcnZl cjo6V2ViS2l0VGVzdFNlcnZlcihTZXJ2ZXJUeXBlIHR5cGUpCiAgICAgc291cF9hZGRyZXNzX3Jl c29sdmVfc3luYyhhZGRyZXNzLmdldCgpLCAwKTsKIAogICAgIG1fc291cFNlcnZlciA9IGFkb3B0 R1JlZihzb3VwX3NlcnZlcl9uZXcoU09VUF9TRVJWRVJfSU5URVJGQUNFLCBhZGRyZXNzLmdldCgp LAorICAgICAgICBTT1VQX1NFUlZFUl9BU1lOQ19DT05URVhULCBtX3F1ZXVlID8gbV9xdWV1ZS0+ cnVuTG9vcCgpLm1haW5Db250ZXh0KCkgOiBudWxscHRyLAogICAgICAgICBTT1VQX1NFUlZFUl9T U0xfQ0VSVF9GSUxFLCBzc2xDZXJ0aWZpY2F0ZUZpbGUuZ2V0KCksCiAgICAgICAgIFNPVVBfU0VS VkVSX1NTTF9LRVlfRklMRSwgc3NsS2V5RmlsZS5nZXQoKSwgbnVsbHB0cikpOwotICAgIG1fYmFz ZVVSSSA9IHR5cGUgPT0gU2VydmVySFRUUFMgPyBzb3VwX3VyaV9uZXcoImh0dHBzOi8vMTI3LjAu MC4xLyIpIDogc291cF91cmlfbmV3KCJodHRwOi8vMTI3LjAuMC4xLyIpOworICAgIG1fYmFzZVVS SSA9IG9wdGlvbnMgJiBTZXJ2ZXJIVFRQUyA/IHNvdXBfdXJpX25ldygiaHR0cHM6Ly8xMjcuMC4w LjEvIikgOiBzb3VwX3VyaV9uZXcoImh0dHA6Ly8xMjcuMC4wLjEvIik7CiAgICAgc291cF91cmlf c2V0X3BvcnQobV9iYXNlVVJJLCBzb3VwX3NlcnZlcl9nZXRfcG9ydChtX3NvdXBTZXJ2ZXIuZ2V0 KCkpKTsKIH0KIApAQCAtNTAsOCArNTcsMTUgQEAgV2ViS2l0VGVzdFNlcnZlcjo6fldlYktpdFRl c3RTZXJ2ZXIoKQogCiB2b2lkIFdlYktpdFRlc3RTZXJ2ZXI6OnJ1bihTb3VwU2VydmVyQ2FsbGJh Y2sgc2VydmVyQ2FsbGJhY2spCiB7Ci0gICAgc291cF9zZXJ2ZXJfcnVuX2FzeW5jKG1fc291cFNl cnZlci5nZXQoKSk7Ci0gICAgc291cF9zZXJ2ZXJfYWRkX2hhbmRsZXIobV9zb3VwU2VydmVyLmdl dCgpLCAwLCBzZXJ2ZXJDYWxsYmFjaywgMCwgMCk7CisgICAgaWYgKG1fcXVldWUpIHsKKyAgICAg ICAgbV9xdWV1ZS0+ZGlzcGF0Y2goW3RoaXMsIHNlcnZlckNhbGxiYWNrXSB7CisgICAgICAgICAg ICBzb3VwX3NlcnZlcl9ydW5fYXN5bmMobV9zb3VwU2VydmVyLmdldCgpKTsKKyAgICAgICAgICAg IHNvdXBfc2VydmVyX2FkZF9oYW5kbGVyKG1fc291cFNlcnZlci5nZXQoKSwgbnVsbHB0ciwgc2Vy dmVyQ2FsbGJhY2ssIG51bGxwdHIsIG51bGxwdHIpOworICAgICAgICB9KTsKKyAgICB9IGVsc2Ug eworICAgICAgICBzb3VwX3NlcnZlcl9ydW5fYXN5bmMobV9zb3VwU2VydmVyLmdldCgpKTsKKyAg ICAgICAgc291cF9zZXJ2ZXJfYWRkX2hhbmRsZXIobV9zb3VwU2VydmVyLmdldCgpLCBudWxscHRy LCBzZXJ2ZXJDYWxsYmFjaywgbnVsbHB0ciwgbnVsbHB0cik7CisgICAgfQogfQogCiBDU3RyaW5n IFdlYktpdFRlc3RTZXJ2ZXI6OmdldFVSSUZvclBhdGgoY29uc3QgY2hhciogcGF0aCkKZGlmZiAt LWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ3RrL1dlYktpdDJHdGsvV2ViS2l0VGVzdFNlcnZl ci5oIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9ndGsvV2ViS2l0Mkd0ay9XZWJLaXRUZXN0U2VydmVy LmgKaW5kZXggMjM1ZDZjOS4uNThmMDE5ZiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9ndGsvV2ViS2l0Mkd0ay9XZWJLaXRUZXN0U2VydmVyLmgKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9ndGsvV2ViS2l0Mkd0ay9XZWJLaXRUZXN0U2VydmVyLmgKQEAgLTIyLDE4ICsyMiwyMCBA QAogCiAjaW5jbHVkZSA8bGlic291cC9zb3VwLmg+CiAjaW5jbHVkZSA8d2Via2l0Mi93ZWJraXQy Lmg+CisjaW5jbHVkZSA8d3RmL1dvcmtRdWV1ZS5oPgogI2luY2x1ZGUgPHd0Zi9nbGliL0dSZWZQ dHIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIGNsYXNzIFdlYktpdFRlc3RT ZXJ2ZXIgewogcHVibGljOgogCi0gICAgZW51bSBTZXJ2ZXJUeXBlIHsKLSAgICAgICAgU2VydmVy SFRUUCwKLSAgICAgICAgU2VydmVySFRUUFMKKyAgICBlbnVtIFNlcnZlck9wdGlvbnMgeworICAg ICAgICBTZXJ2ZXJIVFRQID0gMCwKKyAgICAgICAgU2VydmVySFRUUFMgPSAxIDw8IDEsCisgICAg ICAgIFNlcnZlclJ1bkluVGhyZWFkID0gMSA8PCAyLAogICAgIH07CiAKLSAgICBXZWJLaXRUZXN0 U2VydmVyKFNlcnZlclR5cGUgPSBTZXJ2ZXJIVFRQKTsKKyAgICBXZWJLaXRUZXN0U2VydmVyKFNl cnZlck9wdGlvbnMgPSBTZXJ2ZXJIVFRQKTsKICAgICB2aXJ0dWFsIH5XZWJLaXRUZXN0U2VydmVy KCk7CiAKICAgICBTb3VwVVJJKiBiYXNlVVJJKCkgeyByZXR1cm4gbV9iYXNlVVJJOyB9CkBAIC00 NCw2ICs0Niw3IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgR1JlZlB0cjxTb3VwU2VydmVyPiBt X3NvdXBTZXJ2ZXI7CiAgICAgU291cFVSSSogbV9iYXNlVVJJOworICAgIFJlZlB0cjxXb3JrUXVl dWU+IG1fcXVldWU7CiB9OwogCiAjZW5kaWYgLy8gV2ViS2l0VGVzdFNlcnZlcl9oCg==