151340 2015-11-16 22:09:23 -0800 [EFL] http/tests/navigation/useragent test failed after r192459. 2015-11-19 10:31:32 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 151250 1 hs85.jeong hs85.jeong cgarcia commit-queue darin gyuyoung.kim lucas.de.marchi oldest_to_newest 1142477 0 hs85.jeong 2015-11-16 22:09:23 -0800 https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25581/steps/layout-test/logs/stdio http/tests/navigation/useragent.php [ Failure ] 16 line in http/tests/navigation/useragent.php : document.write("UserAgent should match the " + userAgentTemplate + " template: " + !!userAgent.match(userAgentTemplateRegExp) + "<br>"); "!!userAgent.match(userAgentTemplateRegExp)" value is false after r192459. I checked the useragent value at whatsmyuseragent.com using miniBrowser. Result is "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/WEBKIT_MAJOR_VERSION.WEBKIT_MINOR_VERSION (KHTML, like Gecko) Version/8.0 Safari/601.2.7" 1142765 1 265733 hs85.jeong 2015-11-17 22:01:32 -0800 Created attachment 265733 Patch 1142766 2 hs85.jeong 2015-11-17 22:02:10 -0800 I think cause is that WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION are recognized as string in #define MAKE_VERSION. So we need one more convert process that predefined value changes to string. 1142768 3 265734 hs85.jeong 2015-11-17 22:04:14 -0800 Created attachment 265734 Patch 1142769 4 265734 gyuyoung.kim 2015-11-17 22:11:11 -0800 Comment on attachment 265734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265734&action=review > Source/WebCore/platform/efl/UserAgentEfl.cpp:61 > +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) I'm surprised we need to have additional step to convert from number to string. LGTM. However Darin might want to have a final look this fix before landing. 1142778 5 hs85.jeong 2015-11-18 00:16:29 -0800 (In reply to comment #4) > Comment on attachment 265734 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265734&action=review > > > Source/WebCore/platform/efl/UserAgentEfl.cpp:61 > > +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) > > I'm surprised we need to have additional step to convert from number to > string. LGTM. > > However Darin might want to have a final look this fix before landing. GTK already fixed it in http://trac.webkit.org/changeset/192566. But we can't fix this issue with KaLs' patch because EFL use the WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION. 1142830 6 265734 darin 2015-11-18 08:28:36 -0800 Comment on attachment 265734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265734&action=review >>> Source/WebCore/platform/efl/UserAgentEfl.cpp:61 >>> +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) >> >> I'm surprised we need to have additional step to convert from number to string. LGTM. >> >> However Darin might want to have a final look this fix before landing. > > GTK already fixed it in http://trac.webkit.org/changeset/192566. > But we can't fix this issue with KaLs' patch because EFL use the WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION. I am not surprised. I remember needing to do this in the past. This patch looks right to me. > Source/WebCore/platform/gtk/UserAgentGtk.cpp:120 > -#define MAKE_VERSION(major, minor) #major "." #minor > +#define MAKE_STRING(value) #value > +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) > return MAKE_VERSION(USER_AGENT_GTK_MAJOR_VERSION, USER_AGENT_GTK_MINOR_VERSION); > +#undef MAKE_STRING > #undef MAKE_VERSION This change isn’t needed; the GTK fix is fine for them. 1142831 7 265734 darin 2015-11-18 08:29:22 -0800 Comment on attachment 265734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265734&action=review >>>> Source/WebCore/platform/efl/UserAgentEfl.cpp:61 >>>> +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) >>> >>> I'm surprised we need to have additional step to convert from number to string. LGTM. >>> >>> However Darin might want to have a final look this fix before landing. >> >> GTK already fixed it in http://trac.webkit.org/changeset/192566. >> But we can't fix this issue with KaLs' patch because EFL use the WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION. > > I am not surprised. I remember needing to do this in the past. This patch looks right to me. I think maybe this can be done without the MAKE_VERSION macro. Might work just to do: return MAKE_STRING(WEBKIT_MAJOR_VERSION) "." MAKE_STRING(WEBKIT_MINOR_VERSION); Please give it a try! 1142839 8 265734 cgarcia 2015-11-18 08:56:41 -0800 Comment on attachment 265734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265734&action=review >> Source/WebCore/platform/gtk/UserAgentGtk.cpp:120 >> -#define MAKE_VERSION(major, minor) #major "." #minor >> +#define MAKE_STRING(value) #value >> +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) >> return MAKE_VERSION(USER_AGENT_GTK_MAJOR_VERSION, USER_AGENT_GTK_MINOR_VERSION); >> +#undef MAKE_STRING >> #undef MAKE_VERSION > > This change isn’t needed; the GTK fix is fine for them. Yes, please, don't changed this. 1142844 9 265734 darin 2015-11-18 09:28:05 -0800 Comment on attachment 265734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265734&action=review >>>>> Source/WebCore/platform/efl/UserAgentEfl.cpp:61 >>>>> +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) >>>> >>>> I'm surprised we need to have additional step to convert from number to string. LGTM. >>>> >>>> However Darin might want to have a final look this fix before landing. >>> >>> GTK already fixed it in http://trac.webkit.org/changeset/192566. >>> But we can't fix this issue with KaLs' patch because EFL use the WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION. >> >> I am not surprised. I remember needing to do this in the past. This patch looks right to me. > > I think maybe this can be done without the MAKE_VERSION macro. Might work just to do: > > return MAKE_STRING(WEBKIT_MAJOR_VERSION) "." MAKE_STRING(WEBKIT_MINOR_VERSION); > > Please give it a try! I looked this up and we definitely need two levels of macros. To quote the a gcc documentation page about this: “If you want to stringify the result of expansion of a macro argument, you have to use two levels of macros.” Too bad we got this wrong without testing it the first time. GTK didn’t need to change theirs to use strings :-( 1143084 10 gyuyoung.kim 2015-11-18 16:43:54 -0800 (In reply to comment #9) > Too bad we got this wrong without testing it the first time. GTK didn’t need > to change theirs to use strings :-( Yes, I should check if original change passes the test. Sorry about that. 1143093 11 265812 hs85.jeong 2015-11-18 17:01:03 -0800 Created attachment 265812 Patch 1143094 12 hs85.jeong 2015-11-18 17:02:24 -0800 (In reply to comment #9) > Comment on attachment 265734 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265734&action=review > > >>>>> Source/WebCore/platform/efl/UserAgentEfl.cpp:61 > >>>>> +#define MAKE_VERSION(major, minor) MAKE_STRING(major) "." MAKE_STRING(minor) > >>>> > >>>> I'm surprised we need to have additional step to convert from number to string. LGTM. > >>>> > >>>> However Darin might want to have a final look this fix before landing. > >>> > >>> GTK already fixed it in http://trac.webkit.org/changeset/192566. > >>> But we can't fix this issue with KaLs' patch because EFL use the WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION. > >> > >> I am not surprised. I remember needing to do this in the past. This patch looks right to me. > > > > I think maybe this can be done without the MAKE_VERSION macro. Might work just to do: > > > > return MAKE_STRING(WEBKIT_MAJOR_VERSION) "." MAKE_STRING(WEBKIT_MINOR_VERSION); > > > > Please give it a try! > > I looked this up and we definitely need two levels of macros. To quote the a > gcc documentation page about this: “If you want to stringify the result of > expansion of a macro argument, you have to use two levels of macros.” > I change it to use the two levels of macro. 1143336 13 265812 commit-queue 2015-11-19 10:31:27 -0800 Comment on attachment 265812 Patch Clearing flags on attachment: 265812 Committed r192634: <http://trac.webkit.org/changeset/192634> 1143337 14 commit-queue 2015-11-19 10:31:32 -0800 All reviewed patches have been landed. Closing bug. 265733 2015-11-17 22:01:32 -0800 2015-11-17 22:04:07 -0800 Patch bug-151340-20151118150121.patch text/plain 2075 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjU2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTE3ICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBodHRwL3Rl c3RzL25hdmlnYXRpb24vdXNlcmFnZW50IHRlc3QgZmFpbGVkIGFmdGVyIHIxOTI0NTkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEzNDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBuZWVkIHRoZSBj b252ZXJ0IHByb2dyZXNzIHRoZSBwcmVkaWZpbmVkIHZhbHVlIHRvIHN0cmluZy4gCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnZl cnNpb25Gb3JVQVN0cmluZyk6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5j cHA6CisgICAgICAgIChXZWJDb3JlOjp2ZXJzaW9uRm9yVUFTdHJpbmcpOgorCiAyMDE1LTExLTE3 ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2ltcGxlIGxpbmUg bGF5b3V0OiBBZGQgbGV0dGVyLXNwYWNpbmcgc3VwcG9ydC4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwCShyZXZpc2lvbiAxOTI1NjMpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNTcsOCArNTcsMTAgQEAgc3RhdGljIFN0cmluZyBwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0 cmluZwogCiBzdGF0aWMgY29uc3QgY2hhciogdmVyc2lvbkZvclVBU3RyaW5nKCkKIHsKLSNkZWZp bmUgTUFLRV9WRVJTSU9OKG1ham9yLCBtaW5vcikgI21ham9yICIuIiAjbWlub3IKKyNkZWZpbmUg TUFLRV9TVFJJTkcodmFsdWUpICN2YWx1ZQorI2RlZmluZSBNQUtFX1ZFUlNJT04obWFqb3IsIG1p bm9yKSBNQUtFX1NUUklORyhtYWpvcikgIi4iIE1BS0VfU1RSSU5HKG1pbm9yKQogICAgIHJldHVy biBNQUtFX1ZFUlNJT04oV0VCS0lUX01BSk9SX1ZFUlNJT04sIFdFQktJVF9NSU5PUl9WRVJTSU9O KTsKKyN1bmRlZiBNQUtFX1NUUklORwogI3VuZGVmIE1BS0VfVkVSU0lPTgogfQogCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAkocmV2aXNpb24g MTkyNTYzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTExMyw4ICsxMTMsMTAgQEAgc3RhdGljIGNvbnN0IFN0cmluZyBw bGF0Zm9ybVZlcnNpb25Gb3JVQQogCiBzdGF0aWMgY29uc3QgY2hhciogdmVyc2lvbkZvclVBU3Ry aW5nKCkKIHsKLSNkZWZpbmUgTUFLRV9WRVJTSU9OKG1ham9yLCBtaW5vcikgI21ham9yICIuIiAj bWlub3IKKyNkZWZpbmUgTUFLRV9TVFJJTkcodmFsdWUpICN2YWx1ZQorI2RlZmluZSBNQUtFX1ZF UlNJT04obWFqb3IsIG1pbm9yKSBNQUtFX1NUUklORyhtYWpvcikgIi4iIE1BS0VfU1RSSU5HKG1p bm9yKQogICAgIHJldHVybiBNQUtFX1ZFUlNJT04oVVNFUl9BR0VOVF9HVEtfTUFKT1JfVkVSU0lP TiwgVVNFUl9BR0VOVF9HVEtfTUlOT1JfVkVSU0lPTik7CisjdW5kZWYgTUFLRV9TVFJJTkcKICN1 bmRlZiBNQUtFX1ZFUlNJT04KIH0KIAo= 265734 2015-11-17 22:04:14 -0800 2015-11-18 17:00:56 -0800 Patch bug-151340-20151118150402.patch text/plain 2074 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjU2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTE3ICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBodHRwL3Rl c3RzL25hdmlnYXRpb24vdXNlcmFnZW50IHRlc3QgZmFpbGVkIGFmdGVyIHIxOTI0NTkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEzNDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBuZWVkIHRoZSBj b252ZXJ0IHByb2Nlc3MgdGhlIHByZWRpZmluZWQgdmFsdWUgdG8gc3RyaW5nLiAKKworICAgICAg ICAqIHBsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dmVy c2lvbkZvclVBU3RyaW5nKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnZlcnNpb25Gb3JVQVN0cmluZyk6CisKIDIwMTUtMTEtMTcg IFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGUgbGluZSBs YXlvdXQ6IEFkZCBsZXR0ZXItc3BhY2luZyBzdXBwb3J0LgpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHAJKHJldmlzaW9uIDE5MjU2MykKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Vc2VyQWdlbnRFZmwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01Nyw4ICs1NywxMCBAQCBzdGF0aWMgU3RyaW5nIHBsYXRmb3JtVmVyc2lvbkZvclVBU3Ry aW5nCiAKIHN0YXRpYyBjb25zdCBjaGFyKiB2ZXJzaW9uRm9yVUFTdHJpbmcoKQogewotI2RlZmlu ZSBNQUtFX1ZFUlNJT04obWFqb3IsIG1pbm9yKSAjbWFqb3IgIi4iICNtaW5vcgorI2RlZmluZSBN QUtFX1NUUklORyh2YWx1ZSkgI3ZhbHVlCisjZGVmaW5lIE1BS0VfVkVSU0lPTihtYWpvciwgbWlu b3IpIE1BS0VfU1RSSU5HKG1ham9yKSAiLiIgTUFLRV9TVFJJTkcobWlub3IpCiAgICAgcmV0dXJu IE1BS0VfVkVSU0lPTihXRUJLSVRfTUFKT1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04p OworI3VuZGVmIE1BS0VfU1RSSU5HCiAjdW5kZWYgTUFLRV9WRVJTSU9OCiB9CiAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCShyZXZpc2lvbiAx OTI1NjMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTEzLDggKzExMywxMCBAQCBzdGF0aWMgY29uc3QgU3RyaW5nIHBs YXRmb3JtVmVyc2lvbkZvclVBCiAKIHN0YXRpYyBjb25zdCBjaGFyKiB2ZXJzaW9uRm9yVUFTdHJp bmcoKQogewotI2RlZmluZSBNQUtFX1ZFUlNJT04obWFqb3IsIG1pbm9yKSAjbWFqb3IgIi4iICNt aW5vcgorI2RlZmluZSBNQUtFX1NUUklORyh2YWx1ZSkgI3ZhbHVlCisjZGVmaW5lIE1BS0VfVkVS U0lPTihtYWpvciwgbWlub3IpIE1BS0VfU1RSSU5HKG1ham9yKSAiLiIgTUFLRV9TVFJJTkcobWlu b3IpCiAgICAgcmV0dXJuIE1BS0VfVkVSU0lPTihVU0VSX0FHRU5UX0dUS19NQUpPUl9WRVJTSU9O LCBVU0VSX0FHRU5UX0dUS19NSU5PUl9WRVJTSU9OKTsKKyN1bmRlZiBNQUtFX1NUUklORwogI3Vu ZGVmIE1BS0VfVkVSU0lPTgogfQogCg== 265812 2015-11-18 17:01:03 -0800 2015-11-19 10:31:27 -0800 Patch bug-151340-20151119100051.patch text/plain 1361 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjU5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTExLTE4ICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBodHRwL3Rl c3RzL25hdmlnYXRpb24vdXNlcmFnZW50IHRlc3QgZmFpbGVkIGFmdGVyIHIxOTI0NTkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEzNDAKKworICAg ICAgICBSZXZpZXdlZCBieSBHeXV5b3VuZyBLaW0uCisKKyAgICAgICAgV2UgbmVlZCB0aGUgY29u dmVydCBwcm9jZXNzIHRoZSBwcmVkaWZpbmVkIHZhbHVlIHRvIHN0cmluZy4gCisKKyAgICAgICAg KiBwbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnZlcnNp b25Gb3JVQVN0cmluZyk6CisKIDIwMTUtMTEtMTggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBw bGUuY29tPgogCiAgICAgICAgIFJlc291cmNlVXNhZ2VPdmVybGF5IHNob3VsZCBoYXZlIGJldHRl ciBhY2NvdW50aW5nIGZvciByZWNsYWltYWJsZSBtZW1vcnkuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcAkocmV2aXNpb24gMTkyNTk5KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTU3LDggKzU3LDEwIEBAIHN0YXRpYyBTdHJpbmcgcGxhdGZvcm1WZXJzaW9uRm9yVUFT dHJpbmcKIAogc3RhdGljIGNvbnN0IGNoYXIqIHZlcnNpb25Gb3JVQVN0cmluZygpCiB7Ci0jZGVm aW5lIE1BS0VfVkVSU0lPTihtYWpvciwgbWlub3IpICNtYWpvciAiLiIgI21pbm9yCisjZGVmaW5l IE1BS0VfU1RSSU5HKHZhbHVlKSAjdmFsdWUKKyNkZWZpbmUgTUFLRV9WRVJTSU9OKG1ham9yLCBt aW5vcikgTUFLRV9TVFJJTkcobWFqb3IpICIuIiBNQUtFX1NUUklORyhtaW5vcikKICAgICByZXR1 cm4gTUFLRV9WRVJTSU9OKFdFQktJVF9NQUpPUl9WRVJTSU9OLCBXRUJLSVRfTUlOT1JfVkVSU0lP Tik7CisjdW5kZWYgTUFLRV9TVFJJTkcKICN1bmRlZiBNQUtFX1ZFUlNJT04KIH0KIAo=