151250 2015-11-13 00:51:20 -0800 [EFL][GTK] Remove use of String::format() in versionForUAString() 2019-02-03 11:11:17 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 30342 151340 1 gyuyoung.kim gyuyoung.kim commit-queue lucas.de.marchi oldest_to_newest 1141793 0 gyuyoung.kim 2015-11-13 00:51:20 -0800 As String::format() will be deprecated due to security problem, reimplement versionForUAString() using a macro. 1141795 1 265473 gyuyoung.kim 2015-11-13 00:52:51 -0800 Created attachment 265473 Patch 1141844 2 265473 darin 2015-11-13 09:27:20 -0800 Comment on attachment 265473 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265473&action=review > Source/WebCore/platform/efl/UserAgentEfl.cpp:64 > static const String& versionForUAString() > { > - static NeverDestroyed<String> version(String::format("%i.%i", WEBKIT_MAJOR_VERSION, WEBKIT_MINOR_VERSION)); > +#define MAKE_VERSION(major, minor) #major "." #minor > + const String& version = MAKE_VERSION(WEBKIT_MAJOR_VERSION, WEBKIT_MINOR_VERSION); > return version; > +#undef MAKE_VERSION > } This is wrong. It will return a reference to an already-destroyed string object. 1141847 3 265473 darin 2015-11-13 09:29:07 -0800 Comment on attachment 265473 Patch Here’s how to do it: static const char* versionForUAString() { #define MAKE_VERSION(major, minor) #major "." #minor return MAKE_VERSION(USER_AGENT_GTK_MAJOR_VERSION, USER_AGENT_GTK_MINOR_VERSION); #undef MAKE_VERSION } In the EFL case we also need to change the type from const String& to const char*. 1142048 4 265541 gyuyoung.kim 2015-11-14 07:32:30 -0800 Created attachment 265541 Patch 1142049 5 gyuyoung.kim 2015-11-14 07:33:51 -0800 (In reply to comment #3) > Comment on attachment 265473 [details] > Patch > > Here’s how to do it: > > static const char* versionForUAString() > { > #define MAKE_VERSION(major, minor) #major "." #minor > return MAKE_VERSION(USER_AGENT_GTK_MAJOR_VERSION, > USER_AGENT_GTK_MINOR_VERSION); > #undef MAKE_VERSION > } > > In the EFL case we also need to change the type from const String& to const > char*. I see. I update the patch as well as platformVersionForUAString() is modified. 1142075 6 265541 darin 2015-11-14 16:51:16 -0800 Comment on attachment 265541 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265541&action=review > Source/WebCore/platform/gtk/UserAgentGtk.cpp:106 > + return MAKE_VERSION(name.sysname, name.machine); This won’t work. I believe this will yield the string: "name.sysnamename.machine" This change should not be made. Testing would have shown this is incorrect. > Source/WebCore/platform/gtk/UserAgentGtk.cpp:109 > + return MAKE_VERSION(cpuDescriptionForUAString(), "Mac OS X"); This won’t work. I believe this will yield the string: "cpuDescriptionForUAString()Mac OS X" This change should not be made. Testing would have shown this is incorrect. 1142080 7 265548 gyuyoung.kim 2015-11-14 18:16:54 -0800 Created attachment 265548 Patch 1142081 8 265548 darin 2015-11-14 18:46:34 -0800 Comment on attachment 265548 Patch standardUserAgent in UserAgentEfl.cpp can still be improved so it doesn’t convert the const char* returned by versionForUAString to a String for the local variable version every time it’s called 1142089 9 265549 gyuyoung.kim 2015-11-14 19:24:10 -0800 Created attachment 265549 Patch 1142090 10 gyuyoung.kim 2015-11-14 19:25:39 -0800 (In reply to comment #8) > Comment on attachment 265548 [details] > Patch > > standardUserAgent in UserAgentEfl.cpp can still be improved so it doesn’t > convert the const char* returned by versionForUAString to a String for the > local variable version every time it’s called const char* is converted to a String using ASCIILiteral in new patch. 1142108 11 265549 commit-queue 2015-11-14 23:56:58 -0800 Comment on attachment 265549 Patch Clearing flags on attachment: 265549 Committed r192459: <http://trac.webkit.org/changeset/192459> 1142109 12 commit-queue 2015-11-14 23:57:03 -0800 All reviewed patches have been landed. Closing bug. 265473 2015-11-13 00:52:51 -0800 2015-11-14 07:32:24 -0800 Patch bug-151250-20151113175244.patch text/plain 2576 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVlOTNhNzZjMzIyNzQ3 ZmYyMzliZGMzYWI3MDAzN2Q3YTI4NTZiMC4uYmUwNWY1ZTJhYzQwOTVlODQxMjEzOTRhZDBlNzhl ZjAyZjA2MGRmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTExLTEzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXVtHVEtd IFJlbW92ZSB1c2Ugb2YgU3RyaW5nOjpmb3JtYXQoKSBpbiB2ZXJzaW9uRm9yVUFTdHJpbmcoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjUwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgU3RyaW5n Ojpmb3JtYXQoKSB3aWxsIGJlIGRlcHJlY2F0ZWQgZHVlIHRvIHRoZSBzZWN1cml0eSBwcm9ibGVt LCByZWltcGxlbWVudAorICAgICAgICB2ZXJzaW9uRm9yVUFTdHJpbmcoKSB1c2luZyBhIG1hY3Jv LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjp2ZXJzaW9uRm9yVUFTdHJpbmcpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2Vy QWdlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dmVyc2lvbkZvclVBU3RyaW5nKToKKwog MjAxNS0xMS0xMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg TW9kZXJuIElEQjogUGlwZSB0aHJvdWdoIGN1cnNvciBmdW5jdGlvbnMgZnJvbSBjbGllbnQgdG8g c2VydmVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1VzZXJBZ2Vu dEVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcApp bmRleCA4MjUxYjk4MGMzYWE4ZTVlZjMzMjFkMDEwYWRkOTUyNjVlNzk5ZDQ0Li5kN2Y0Njk3MTRk ZDdlZmYyZjkyNmMxOTI3ZWVjODI0M2ZjN2JhNWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcApAQCAtNTcsOCArNTcsMTAgQEAgc3RhdGljIFN0cmlu ZyBwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpCiAKIHN0YXRpYyBjb25zdCBTdHJpbmcmIHZl cnNpb25Gb3JVQVN0cmluZygpCiB7Ci0gICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFN0cmluZz4g dmVyc2lvbihTdHJpbmc6OmZvcm1hdCgiJWkuJWkiLCBXRUJLSVRfTUFKT1JfVkVSU0lPTiwgV0VC S0lUX01JTk9SX1ZFUlNJT04pKTsKKyNkZWZpbmUgTUFLRV9WRVJTSU9OKG1ham9yLCBtaW5vcikg I21ham9yICIuIiAjbWlub3IKKyAgICBjb25zdCBTdHJpbmcmIHZlcnNpb24gPSBNQUtFX1ZFUlNJ T04oV0VCS0lUX01BSk9SX1ZFUlNJT04sIFdFQktJVF9NSU5PUl9WRVJTSU9OKTsKICAgICByZXR1 cm4gdmVyc2lvbjsKKyN1bmRlZiBNQUtFX1ZFUlNJT04KIH0KIAogU3RyaW5nIHN0YW5kYXJkVXNl ckFnZW50KGNvbnN0IFN0cmluZyYgYXBwbGljYXRpb25OYW1lLCBjb25zdCBTdHJpbmcmIGFwcGxp Y2F0aW9uVmVyc2lvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9V c2VyQWdlbnRHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0 ay5jcHAKaW5kZXggOTE2NDFkY2E2NDdlMDUxMjgxZjI4N2Y3ODcyOTY4MDUxZGRmODVmZi4uMWY0 ZjJiODkyODE2ODRiMTdmNWE1NzdjMzYyNWRkMjdiNGMzNGJiYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKQEAgLTExMyw4ICsxMTMsMTAgQEAgc3Rh dGljIGNvbnN0IFN0cmluZyBwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpCiAKIHN0YXRpYyBj b25zdCBTdHJpbmcgdmVyc2lvbkZvclVBU3RyaW5nKCkKIHsKLSAgICBzdGF0aWMgTmV2ZXJEZXN0 cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YVZlcnNpb24oU3RyaW5nOjpmb3JtYXQoIiVpLiVpIiwgVVNF Ul9BR0VOVF9HVEtfTUFKT1JfVkVSU0lPTiwgVVNFUl9BR0VOVF9HVEtfTUlOT1JfVkVSU0lPTikp OwotICAgIHJldHVybiB1YVZlcnNpb247CisjZGVmaW5lIE1BS0VfVkVSU0lPTihtYWpvciwgbWlu b3IpICNtYWpvciAiLiIgI21pbm9yCisgICAgY29uc3QgU3RyaW5nJiB2ZXJzaW9uID0gTUFLRV9W RVJTSU9OKFVTRVJfQUdFTlRfR1RLX01BSk9SX1ZFUlNJT04sIFVTRVJfQUdFTlRfR1RLX01JTk9S X1ZFUlNJT04pOworICAgIHJldHVybiB2ZXJzaW9uOworI3VuZGVmIE1BS0VfVkVSU0lPTgogfQog CiBzdGF0aWMgU3RyaW5nIGJ1aWxkVXNlckFnZW50U3RyaW5nKGNvbnN0IFVzZXJBZ2VudFF1aXJr cyYgcXVpcmtzKQo= 265541 2015-11-14 07:32:30 -0800 2015-11-14 18:16:48 -0800 Patch bug-151250-20151115003222.patch text/plain 3474 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk3N2UyMTI0MjJjYTIy MmUzZDI2ZjIwYWY0NDkzYzAwN2MzN2MyYi4uN2Q3MDIwMjMwMGY4Mjg0MWY5Mjc4YTRmZmJiMWFm ZGMyNDQ2NzAwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTE0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXVtHVEtd IFJlbW92ZSB1c2Ugb2YgU3RyaW5nOjpmb3JtYXQoKSBpbiB2ZXJzaW9uRm9yVUFTdHJpbmcoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjUwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgU3RyaW5n Ojpmb3JtYXQoKSB3aWxsIGJlIGRlcHJlY2F0ZWQgZHVlIHRvIHRoZSBzZWN1cml0eSBwcm9ibGVt LCByZWltcGxlbWVudAorICAgICAgICB2ZXJzaW9uRm9yVUFTdHJpbmcoKSBhbmQgcGxhdGZvcm1W ZXJzaW9uRm9yVUFTdHJpbmcoKSB1c2luZyBhIG1hY3JvLgorCisgICAgICAgICogcGxhdGZvcm0v ZWZsL1VzZXJBZ2VudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2ZXJzaW9uRm9yVUFTdHJp bmcpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwOgorICAgICAgICAo V2ViQ29yZTo6cGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcpOgorICAgICAgICAoV2ViQ29yZTo6 dmVyc2lvbkZvclVBU3RyaW5nKToKKwogMjAxNS0xMS0xNCAgTmFuIFdhbmcgIDxuX3dhbmdAYXBw bGUuY29tPgogCiAgICAgICAgIEFYOiBhZGQgYSBuZXcgdHJhaXQgZm9yIGVsZW1lbnRzIGluIGZp ZWxkc2V0IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Vz ZXJBZ2VudEVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZs LmNwcAppbmRleCA4MjUxYjk4MGMzYWE4ZTVlZjMzMjFkMDEwYWRkOTUyNjVlNzk5ZDQ0Li5lNTk3 ZDk4NTgyNjJjMzUxNmU5MzRmMzAxNGQzNjFlYTVkMGEzOWU0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcApAQCAtNTUsMTAgKzU1LDExIEBAIHN0YXRp YyBTdHJpbmcgcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcoKQogICAgIHJldHVybiB2ZXJzaW9u OwogfQogCi1zdGF0aWMgY29uc3QgU3RyaW5nJiB2ZXJzaW9uRm9yVUFTdHJpbmcoKQorc3RhdGlj IGNvbnN0IGNoYXIqIHZlcnNpb25Gb3JVQVN0cmluZygpCiB7Ci0gICAgc3RhdGljIE5ldmVyRGVz dHJveWVkPFN0cmluZz4gdmVyc2lvbihTdHJpbmc6OmZvcm1hdCgiJWkuJWkiLCBXRUJLSVRfTUFK T1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04pKTsKLSAgICByZXR1cm4gdmVyc2lvbjsK KyNkZWZpbmUgTUFLRV9WRVJTSU9OKG1ham9yLCBtaW5vcikgI21ham9yICIuIiAjbWlub3IKKyAg ICByZXR1cm4gTUFLRV9WRVJTSU9OKFVTRVJfQUdFTlRfR1RLX01BSk9SX1ZFUlNJT04sIFVTRVJf QUdFTlRfR1RLX01JTk9SX1ZFUlNJT04pOworI3VuZGVmIE1BS0VfVkVSU0lPTgogfQogCiBTdHJp bmcgc3RhbmRhcmRVc2VyQWdlbnQoY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlvbk5hbWUsIGNvbnN0 IFN0cmluZyYgYXBwbGljYXRpb25WZXJzaW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvVXNlckFnZW50R3RrLmNwcAppbmRleCA5MTY0MWRjYTY0N2UwNTEyODFmMjg3Zjc4NzI5Njgw NTFkZGY4NWZmLi40NTI2Y2I5YmM4NzliOGJkNzk2OGFhN2JjOGEyODA1NzczNzEwYjE1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcApAQCAtOTcsMjQg Kzk3LDI1IEBAIHN0YXRpYyBjb25zdCBjaGFyKiBwbGF0Zm9ybUZvclVBU3RyaW5nKCkKICNlbmRp ZgogfQogCi1zdGF0aWMgY29uc3QgU3RyaW5nIHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkK K3N0YXRpYyBjb25zdCBjaGFyKiBwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpCiB7CisjZGVm aW5lIE1BS0VfVkVSU0lPTihtYWpvciwgbWlub3IpICNtYWpvciAiLiIgI21pbm9yCiAjaWYgT1Mo VU5JWCkKICAgICBzdHJ1Y3QgdXRzbmFtZSBuYW1lOwogICAgIHVuYW1lKCZuYW1lKTsKLSAgICBz dGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YU9TVmVyc2lvbihTdHJpbmc6OmZv cm1hdCgiJXMgJXMiLCBuYW1lLnN5c25hbWUsIG5hbWUubWFjaGluZSkpOwotICAgIHJldHVybiB1 YU9TVmVyc2lvbjsKKyAgICByZXR1cm4gTUFLRV9WRVJTSU9OKG5hbWUuc3lzbmFtZSwgbmFtZS5t YWNoaW5lKTsKICNlbHNlCiAgICAgLy8gV2Ugd2lsbCBhbHdheXMgY2xhaW0gdG8gYmUgU2FmYXJp IGluIE1hYyBPUyBYLCBzaW5jZSBTYWZhcmkgaW4gTGludXggdHJpZ2dlcnMgdGhlIGlPUyBwYXRo IG9uIHNvbWUgd2Vic2l0ZXMuCi0gICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmlu Zz4gdWFPU1ZlcnNpb24oU3RyaW5nOjpmb3JtYXQoIiVzIE1hYyBPUyBYIiwgY3B1RGVzY3JpcHRp b25Gb3JVQVN0cmluZygpKSk7Ci0gICAgcmV0dXJuIHVhT1NWZXJzaW9uOworICAgIHJldHVybiBN QUtFX1ZFUlNJT04oY3B1RGVzY3JpcHRpb25Gb3JVQVN0cmluZygpLCAiTWFjIE9TIFgiKTsKICNl bmRpZgorI3VuZGVmIE1BS0VfVkVSU0lPTgogfQogCi1zdGF0aWMgY29uc3QgU3RyaW5nIHZlcnNp b25Gb3JVQVN0cmluZygpCitzdGF0aWMgY29uc3QgY2hhciogdmVyc2lvbkZvclVBU3RyaW5nKCkK IHsKLSAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YVZlcnNpb24oU3Ry aW5nOjpmb3JtYXQoIiVpLiVpIiwgVVNFUl9BR0VOVF9HVEtfTUFKT1JfVkVSU0lPTiwgVVNFUl9B R0VOVF9HVEtfTUlOT1JfVkVSU0lPTikpOwotICAgIHJldHVybiB1YVZlcnNpb247CisjZGVmaW5l IE1BS0VfVkVSU0lPTihtYWpvciwgbWlub3IpICNtYWpvciAiLiIgI21pbm9yCisgICAgcmV0dXJu IE1BS0VfVkVSU0lPTihVU0VSX0FHRU5UX0dUS19NQUpPUl9WRVJTSU9OLCBVU0VSX0FHRU5UX0dU S19NSU5PUl9WRVJTSU9OKTsKKyN1bmRlZiBNQUtFX1ZFUlNJT04KIH0KIAogc3RhdGljIFN0cmlu ZyBidWlsZFVzZXJBZ2VudFN0cmluZyhjb25zdCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykK 265548 2015-11-14 18:16:54 -0800 2015-11-14 19:24:03 -0800 Patch bug-151250-20151115111645.patch text/plain 2670 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk3N2UyMTI0MjJjYTIy MmUzZDI2ZjIwYWY0NDkzYzAwN2MzN2MyYi4uNDgwNDg1ZDdlYzYyNDExYzU1NGVjZmM2OWMwYzhi MjVmOGY5ZWVlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTE0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXVtHVEtd IFJlbW92ZSB1c2Ugb2YgU3RyaW5nOjpmb3JtYXQoKSBpbiB2ZXJzaW9uRm9yVUFTdHJpbmcoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjUwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgU3RyaW5n Ojpmb3JtYXQoKSB3aWxsIGJlIGRlcHJlY2F0ZWQgZHVlIHRvIHRoZSBzZWN1cml0eSBwcm9ibGVt LCByZWltcGxlbWVudAorICAgICAgICB2ZXJzaW9uRm9yVUFTdHJpbmcoKSB1c2luZyBhIG1hY3Jv LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjp2ZXJzaW9uRm9yVUFTdHJpbmcpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2Vy QWdlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJp bmcpOgorICAgICAgICAoV2ViQ29yZTo6dmVyc2lvbkZvclVBU3RyaW5nKToKKwogMjAxNS0xMS0x NCAgTmFuIFdhbmcgIDxuX3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBhZGQgYSBuZXcg dHJhaXQgZm9yIGVsZW1lbnRzIGluIGZpZWxkc2V0IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcAppbmRleCA4MjUxYjk4MGMzYWE4ZTVlZjMzMjFk MDEwYWRkOTUyNjVlNzk5ZDQ0Li43OTcxMDc2ZTFlMTBmZTAwNGY1ZjNjMDNiZmU1MWMxMmFkMjI5 MmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZs LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcApA QCAtNTUsMTAgKzU1LDExIEBAIHN0YXRpYyBTdHJpbmcgcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJp bmcoKQogICAgIHJldHVybiB2ZXJzaW9uOwogfQogCi1zdGF0aWMgY29uc3QgU3RyaW5nJiB2ZXJz aW9uRm9yVUFTdHJpbmcoKQorc3RhdGljIGNvbnN0IGNoYXIqIHZlcnNpb25Gb3JVQVN0cmluZygp CiB7Ci0gICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFN0cmluZz4gdmVyc2lvbihTdHJpbmc6OmZv cm1hdCgiJWkuJWkiLCBXRUJLSVRfTUFKT1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04p KTsKLSAgICByZXR1cm4gdmVyc2lvbjsKKyNkZWZpbmUgTUFLRV9WRVJTSU9OKG1ham9yLCBtaW5v cikgI21ham9yICIuIiAjbWlub3IKKyAgICByZXR1cm4gTUFLRV9WRVJTSU9OKFdFQktJVF9NQUpP Ul9WRVJTSU9OLCBXRUJLSVRfTUlOT1JfVkVSU0lPTik7CisjdW5kZWYgTUFLRV9WRVJTSU9OCiB9 CiAKIFN0cmluZyBzdGFuZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFt ZSwgY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlvblZlcnNpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCmluZGV4IDkxNjQxZGNhNjQ3ZTA1MTI4MWYyODdm Nzg3Mjk2ODA1MWRkZjg1ZmYuLjE4NTBkZDU1YzcwZjVlYzM2NzBlNGYzNmFlMDhiMGM4MzAwMDli YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCkBA IC0xMTEsMTAgKzExMSwxMSBAQCBzdGF0aWMgY29uc3QgU3RyaW5nIHBsYXRmb3JtVmVyc2lvbkZv clVBU3RyaW5nKCkKICNlbmRpZgogfQogCi1zdGF0aWMgY29uc3QgU3RyaW5nIHZlcnNpb25Gb3JV QVN0cmluZygpCitzdGF0aWMgY29uc3QgY2hhciogdmVyc2lvbkZvclVBU3RyaW5nKCkKIHsKLSAg ICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YVZlcnNpb24oU3RyaW5nOjpm b3JtYXQoIiVpLiVpIiwgVVNFUl9BR0VOVF9HVEtfTUFKT1JfVkVSU0lPTiwgVVNFUl9BR0VOVF9H VEtfTUlOT1JfVkVSU0lPTikpOwotICAgIHJldHVybiB1YVZlcnNpb247CisjZGVmaW5lIE1BS0Vf VkVSU0lPTihtYWpvciwgbWlub3IpICNtYWpvciAiLiIgI21pbm9yCisgICAgcmV0dXJuIE1BS0Vf VkVSU0lPTihVU0VSX0FHRU5UX0dUS19NQUpPUl9WRVJTSU9OLCBVU0VSX0FHRU5UX0dUS19NSU5P Ul9WRVJTSU9OKTsKKyN1bmRlZiBNQUtFX1ZFUlNJT04KIH0KIAogc3RhdGljIFN0cmluZyBidWls ZFVzZXJBZ2VudFN0cmluZyhjb25zdCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykK 265549 2015-11-14 19:24:10 -0800 2015-11-14 23:56:58 -0800 Patch bug-151250-20151115122401.patch text/plain 3453 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk3N2UyMTI0MjJjYTIy MmUzZDI2ZjIwYWY0NDkzYzAwN2MzN2MyYi4uODY0Njc2ZGUwOTQ0NDQ0ZWEzYTYzMjEzMTJiYmZl MDJkMDE0NjExNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTE0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXVtHVEtd IFJlbW92ZSB1c2Ugb2YgU3RyaW5nOjpmb3JtYXQoKSBpbiB2ZXJzaW9uRm9yVUFTdHJpbmcoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjUwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQXMgU3RyaW5nOjpm b3JtYXQoKSB3aWxsIGJlIGRlcHJlY2F0ZWQgZHVlIHRvIHRoZSBzZWN1cml0eSBwcm9ibGVtLCBy ZWltcGxlbWVudAorICAgICAgICB2ZXJzaW9uRm9yVUFTdHJpbmcoKSB1c2luZyBhIG1hY3JvLgor CisgICAgICAgICogcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHA6CisgICAgICAgIChXZWJD b3JlOjp2ZXJzaW9uRm9yVUFTdHJpbmcpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2VyQWdl bnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcp OgorICAgICAgICAoV2ViQ29yZTo6dmVyc2lvbkZvclVBU3RyaW5nKToKKwogMjAxNS0xMS0xNCAg TmFuIFdhbmcgIDxuX3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBhZGQgYSBuZXcgdHJh aXQgZm9yIGVsZW1lbnRzIGluIGZpZWxkc2V0IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZWZsL1VzZXJBZ2VudEVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcAppbmRleCA4MjUxYjk4MGMzYWE4ZTVlZjMzMjFkMDEw YWRkOTUyNjVlNzk5ZDQ0Li41ZDFlZWVmYmQxZmQ5OTYzNjgzNjc0NzEzMTVkODBlNDk3YzFjYzZk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvVXNlckFnZW50RWZsLmNwcApAQCAt NTUsMTUgKzU1LDE2IEBAIHN0YXRpYyBTdHJpbmcgcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmco KQogICAgIHJldHVybiB2ZXJzaW9uOwogfQogCi1zdGF0aWMgY29uc3QgU3RyaW5nJiB2ZXJzaW9u Rm9yVUFTdHJpbmcoKQorc3RhdGljIGNvbnN0IGNoYXIqIHZlcnNpb25Gb3JVQVN0cmluZygpCiB7 Ci0gICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFN0cmluZz4gdmVyc2lvbihTdHJpbmc6OmZvcm1h dCgiJWkuJWkiLCBXRUJLSVRfTUFKT1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04pKTsK LSAgICByZXR1cm4gdmVyc2lvbjsKKyNkZWZpbmUgTUFLRV9WRVJTSU9OKG1ham9yLCBtaW5vcikg I21ham9yICIuIiAjbWlub3IKKyAgICByZXR1cm4gTUFLRV9WRVJTSU9OKFdFQktJVF9NQUpPUl9W RVJTSU9OLCBXRUJLSVRfTUlOT1JfVkVSU0lPTik7CisjdW5kZWYgTUFLRV9WRVJTSU9OCiB9CiAK IFN0cmluZyBzdGFuZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFtZSwg Y29uc3QgU3RyaW5nJiBhcHBsaWNhdGlvblZlcnNpb24pCiB7Ci0gICAgY29uc3QgU3RyaW5nJiB2 ZXJzaW9uID0gdmVyc2lvbkZvclVBU3RyaW5nKCk7CisgICAgY29uc3QgU3RyaW5nJiB2ZXJzaW9u ID0gQVNDSUlMaXRlcmFsKHZlcnNpb25Gb3JVQVN0cmluZygpKTsKICAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8U3RyaW5nPiBzdGFuZGFyZFVzZXJBZ2VudFN0cmluZyA9IG1ha2VTdHJpbmcoIk1v emlsbGEvNS4wICgiLCBwbGF0Zm9ybUZvclVBU3RyaW5nKCksICI7ICIsIHBsYXRmb3JtVmVyc2lv bkZvclVBU3RyaW5nKCksCiAgICAgICAgICIpIEFwcGxlV2ViS2l0LyIsIHZlcnNpb24sICIgKEtI VE1MLCBsaWtlIEdlY2tvKSBWZXJzaW9uLzguMCBTYWZhcmkvNjAxLjIuNyIpOwogCkBAIC03Miw3 ICs3Myw3IEBAIFN0cmluZyBzdGFuZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcmIGFwcGxpY2F0 aW9uTmFtZSwgY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlvCiAKICAgICBTdHJpbmcgZmluYWxBcHBs aWNhdGlvblZlcnNpb24gPSBhcHBsaWNhdGlvblZlcnNpb247CiAgICAgaWYgKGZpbmFsQXBwbGlj YXRpb25WZXJzaW9uLmlzRW1wdHkoKSkKLSAgICAgICAgZmluYWxBcHBsaWNhdGlvblZlcnNpb24g PSB2ZXJzaW9uRm9yVUFTdHJpbmcoKTsKKyAgICAgICAgZmluYWxBcHBsaWNhdGlvblZlcnNpb24g PSBBU0NJSUxpdGVyYWwodmVyc2lvbkZvclVBU3RyaW5nKCkpOwogCiAgICAgcmV0dXJuIHN0YW5k YXJkVXNlckFnZW50U3RyaW5nICsgJyAnICsgYXBwbGljYXRpb25OYW1lICsgJy8nICsgZmluYWxB cHBsaWNhdGlvblZlcnNpb247CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvVXNlckFnZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2Vy QWdlbnRHdGsuY3BwCmluZGV4IDkxNjQxZGNhNjQ3ZTA1MTI4MWYyODdmNzg3Mjk2ODA1MWRkZjg1 ZmYuLjE4NTBkZDU1YzcwZjVlYzM2NzBlNGYzNmFlMDhiMGM4MzAwMDliYTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCkBAIC0xMTEsMTAgKzExMSwx MSBAQCBzdGF0aWMgY29uc3QgU3RyaW5nIHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkKICNl bmRpZgogfQogCi1zdGF0aWMgY29uc3QgU3RyaW5nIHZlcnNpb25Gb3JVQVN0cmluZygpCitzdGF0 aWMgY29uc3QgY2hhciogdmVyc2lvbkZvclVBU3RyaW5nKCkKIHsKLSAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YVZlcnNpb24oU3RyaW5nOjpmb3JtYXQoIiVpLiVpIiwg VVNFUl9BR0VOVF9HVEtfTUFKT1JfVkVSU0lPTiwgVVNFUl9BR0VOVF9HVEtfTUlOT1JfVkVSU0lP TikpOwotICAgIHJldHVybiB1YVZlcnNpb247CisjZGVmaW5lIE1BS0VfVkVSU0lPTihtYWpvciwg bWlub3IpICNtYWpvciAiLiIgI21pbm9yCisgICAgcmV0dXJuIE1BS0VfVkVSU0lPTihVU0VSX0FH RU5UX0dUS19NQUpPUl9WRVJTSU9OLCBVU0VSX0FHRU5UX0dUS19NSU5PUl9WRVJTSU9OKTsKKyN1 bmRlZiBNQUtFX1ZFUlNJT04KIH0KIAogc3RhdGljIFN0cmluZyBidWlsZFVzZXJBZ2VudFN0cmlu Zyhjb25zdCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykK