150943 2015-11-05 13:57:53 -0800 Layout Test js/intl-collator.html is crashing on win 7 debug 2015-11-05 21:53:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=147601 P2 Normal --- 1 ryanhaddad sukolsak ap benjamin commit-queue darin sukolsak oldest_to_newest 1139743 0 ryanhaddad 2015-11-05 13:57:53 -0800 Layout Test js/intl-collator.html is crashing on win 7 debug Run: <https://build.webkit.org/builders/Apple%20Win%207%20Debug%20(Tests)/builds/68184> Results: <https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r192057%20(68184)/results.html> Flakiness Dashboard: <http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fintl-collator.html> 1139745 1 ryanhaddad 2015-11-05 14:02:14 -0800 Marked as a crash on win debug in <https://trac.webkit.org/r192074> 1139864 2 sukolsak 2015-11-05 19:34:54 -0800 From the error log (https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r192057%20(68184)/js/intl-collator-crash-log.txt), this seems to cause the crash: 05 002dc548 5ab475d9 WTF!WTF::String::String(char * characters = 0x00524c98 "standard", unsigned int length = 0xcccccccc)+0x36 [c:\cygwin\home\buildbot\slave\win-debug\build\source\wtf\wtf\text\wtfstring.cpp @ 69] 06 002dc5d0 5ab523ff JavaScriptCore!JSC::sortLocaleData(class WTF::String * locale = 0x002dc7a0, class WTF::String * key = 0x065f9978)+0xf9 [c:\cygwin\home\buildbot\slave\win-debug\build\source\javascriptcore\runtime\intlcollatorconstructor.cpp @ 78] These are lines 76 - 78 of runtime/IntlCollatorConstructor.cpp: int32_t length; while ((keywordValue = uenum_next(enumeration, &length, &status)) && U_SUCCESS(status)) { String collation(keywordValue, length); It seems that uenum_next() returned a string "standard" but incorrectly set the length to 0xcccccccc or probably didn't set the length at all. This looks like a bug in an old version of ICU. I tried to find it in the ICU repo but couldn't. uenum_next() returns a null-terminated string anyway. We don't need to use the length. 1139865 3 264915 sukolsak 2015-11-05 19:59:32 -0800 Created attachment 264915 Patch 1139866 4 264915 ggaren 2015-11-05 20:14:22 -0800 Comment on attachment 264915 Patch r=me 1139882 5 264915 commit-queue 2015-11-05 21:53:36 -0800 Comment on attachment 264915 Patch Clearing flags on attachment: 264915 Committed r192092: <http://trac.webkit.org/changeset/192092> 1139883 6 commit-queue 2015-11-05 21:53:40 -0800 All reviewed patches have been landed. Closing bug. 264915 2015-11-05 19:59:32 -0800 2015-11-05 21:53:36 -0800 Patch bug-150943-20151105200102.patch text/plain 3702 sukolsak U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyMDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh ZmI2MzExYzBjOWFhM2IxZmE1NWI0NGE4MTYxNjVjNTEzMGQzY2E2Li5lNzUxZTJmM2YwY2ZmNmM0 MzA1MTdhZTViNjVmZGU4NmVhNjM4MjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0xMS0wNSAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdt YWlsLmNvbT4KKworICAgICAgICBMYXlvdXQgVGVzdCBqcy9pbnRsLWNvbGxhdG9yLmh0bWwgaXMg Y3Jhc2hpbmcgb24gd2luIDcgZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1MDk0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBzdHJpbmcgbGVuZ3RoIHJldHVybmVkIGJ5IElDVSdzIHVlbnVt X25leHQgc2VlbXMgdG8gYmUgdW5yZWxpYWJsZQorICAgICAgICBvbiBhbiBvbGQgdmVyc2lvbiBv ZiBJQ1UuIFNpbmNlIHVlbnVtX25leHQgcmV0dXJucyBhIG51bGwtdGVybWluYXRlZAorICAgICAg ICBzdHJpbmcgYW55d2F5LCB0aGlzIHBhdGNoIHJlbW92ZXMgdGhlIHVzZSBvZiB0aGUgbGVuZ3Ro LgorCisgICAgICAgICogcnVudGltZS9JbnRsQ29sbGF0b3JDb25zdHJ1Y3Rvci5jcHA6CisgICAg ICAgIChKU0M6OnNvcnRMb2NhbGVEYXRhKToKKwogMjAxNS0xMS0wNSAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFkZCBGSVhNRXMgcmVmZXJl bmNpbmcgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDk1OCBhbmQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxDb2xsYXRvckNv bnN0cnVjdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxDb2xsYXRv ckNvbnN0cnVjdG9yLmNwcAppbmRleCBhZWI4MjY1MDM3MGIxMjJjYmE1NDI5ZTcyY2ZlODEwNWQ5 Y2ZmNjAyLi40ZTI3NTBhM2Y2OTEyNDRkZTc3ZTA1MGFhZDFkN2ZjMmY2MTYyMjY3IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsQ29sbGF0b3JDb25zdHJ1Y3Rv ci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bENvbGxhdG9yQ29u c3RydWN0b3IuY3BwCkBAIC03Myw5ICs3Myw4IEBAIHN0YXRpYyBWZWN0b3I8U3RyaW5nPiBzb3J0 TG9jYWxlRGF0YShjb25zdCBTdHJpbmcmIGxvY2FsZSwgY29uc3QgU3RyaW5nJiBrZXkpCiAgICAg ICAgIFVFbnVtZXJhdGlvbiogZW51bWVyYXRpb24gPSB1Y29sX2dldEtleXdvcmRWYWx1ZXNGb3JM b2NhbGUoImNvbGxhdGlvbiIsIGxvY2FsZS51dGY4KCkuZGF0YSgpLCBUUlVFLCAmc3RhdHVzKTsK ICAgICAgICAgaWYgKFVfU1VDQ0VTUyhzdGF0dXMpKSB7CiAgICAgICAgICAgICBjb25zdCBjaGFy KiBrZXl3b3JkVmFsdWU7Ci0gICAgICAgICAgICBpbnQzMl90IGxlbmd0aDsKLSAgICAgICAgICAg IHdoaWxlICgoa2V5d29yZFZhbHVlID0gdWVudW1fbmV4dChlbnVtZXJhdGlvbiwgJmxlbmd0aCwg JnN0YXR1cykpICYmIFVfU1VDQ0VTUyhzdGF0dXMpKSB7Ci0gICAgICAgICAgICAgICAgU3RyaW5n IGNvbGxhdGlvbihrZXl3b3JkVmFsdWUsIGxlbmd0aCk7CisgICAgICAgICAgICB3aGlsZSAoKGtl eXdvcmRWYWx1ZSA9IHVlbnVtX25leHQoZW51bWVyYXRpb24sIG51bGxwdHIsICZzdGF0dXMpKSAm JiBVX1NVQ0NFU1Moc3RhdHVzKSkgeworICAgICAgICAgICAgICAgIFN0cmluZyBjb2xsYXRpb24o a2V5d29yZFZhbHVlKTsKIAogICAgICAgICAgICAgICAgIC8vIDEwLjIuMyAiVGhlIHZhbHVlcyAi c3RhbmRhcmQiIGFuZCAic2VhcmNoIiBtdXN0IG5vdCBiZSB1c2VkIGFzIGVsZW1lbnRzIGluIGFu eSBbW3NvcnRMb2NhbGVEYXRhXV1bbG9jYWxlXS5jbyBhbmQgW1tzZWFyY2hMb2NhbGVEYXRhXV1b bG9jYWxlXS5jbyBhcnJheS4iCiAgICAgICAgICAgICAgICAgaWYgKGNvbGxhdGlvbiA9PSAic3Rh bmRhcmQiIHx8IGNvbGxhdGlvbiA9PSAic2VhcmNoIikKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjZjNhNGEyNWU5MTZhMmMx MzY2NmYxM2MzNGIyYjQ1ODAyN2M3NjUzLi4wNGQ2OWFiMjhkOTdlY2NjYzYxODg4ODkxMWQyZWI5 OTdhNzhkYTBlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMTEtMDUgIFN1a29sc2FrIFNh a3NodXdvbmcgIDxzdWtvbHNha0BnbWFpbC5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QganMv aW50bC1jb2xsYXRvci5odG1sIGlzIGNyYXNoaW5nIG9uIHdpbiA3IGRlYnVnCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA5NDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9UZXN0 RXhwZWN0YXRpb25zOgorCiAyMDE1LTExLTA1ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBw bGUuY29tPgogCiAgICAgICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9z ZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC9tZWRpYS1lbGVtZW50cy9ldmVudF9sb2FkZWRkYXRh Lmh0bWwgaXMgYSBmbGFreSB0aW1vdXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L3dpbi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggMThmYTFhMzY4NTQxOWQ1OTVmYjI3ZjFkNjZmMmE1MzRmYzkwNGEzMS4u MDAwM2ViNjQ0ZGQzNGU3ODc1NmRkOWNhNjY2NzlmZmExZmE5MDA0NCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI0NTMsOCArMjQ1Myw2IEBAIHdlYmtp dC5vcmcvYi8xNDA5NDcganMvc2xvdy1zdHJlc3MvSW50MzJBcnJheS1hbGxvYy1sYXJnZS1sb25n LWxpdmVkLmh0bWwgWyBTa2lwCiAKICMgVGhlIGZvbGxvd2luZyBmYWlscyBkdWUgdG8gRE9NIGV4 Y2VwdGlvbiAxOC4KIGpzL2RvbS9jYWxsYmFjay1mdW5jdGlvbi13aXRoLWhhbmRsZS1ldmVudC5o dG1sIFsgU2tpcCBdICMgIFsgVGltZW91dCBdCi0KLXdlYmtpdC5vcmcvYi8xNTA5NDMgWyBEZWJ1 ZyBdIGpzL2ludGwtY29sbGF0b3IuaHRtbCBbIENyYXNoIF0KICMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjCiAjIyMjIyMjIyMjIyMjIyMjIyAgICAgICAgRW5kIEphdmFTY3JpcHQgSXNzdWVzICAgICAg ICAgICAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIwogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMK