150765 2015-10-31 20:35:44 -0700 Update to match text-orientation spec 2015-11-03 09:14:20 -0800 1 1 1 Unclassified WebKit Text Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150766 150822 1 mmaxfield mmaxfield commit-queue kojii oldest_to_newest 1138263 0 mmaxfield 2015-10-31 20:35:44 -0700 We currently have implemented an old version of the CSS Writing Modes [1] spec. We should update it. AFAICT, this is the state of things: 1. Our "vertical-right" value matches the spec's "mixed" value 2. Our "upright" value matches the spec 3. Our "sideways-right" value matches the spec 4. We need to implement "sideways-left" 5. We need to update "sideways" to correctly match sideways-right / sideways-left [1] http://www.w3.org/TR/css-writing-modes-3 1138502 1 kojii 2015-11-02 02:18:25 -0800 A few comments: * text-orientation: sideways-left is gone, no worry for that. writing-mode: sideways-lr, sideways-rl were added instead, so that we don't have to flip baseline within a single BFC. They're at risk though. * text-combine was updated in both property name and value name, great if you could take care of this change too. 1138750 2 mmaxfield 2015-11-02 16:07:06 -0800 (In reply to comment #1) > A few comments: > * text-orientation: sideways-left is gone, no worry for that. writing-mode: > sideways-lr, sideways-rl were added instead, so that we don't have to flip > baseline within a single BFC. They're at risk though. > * text-combine was updated in both property name and value name, great if > you could take care of this change too. Thanks, Koji! I wasn't reading the dev version of the spec. I should make "sideways" a simple alias to "sideways-right". Updating "writing-mode" to match the spec is a different bug. https://bugs.webkit.org/show_bug.cgi?id=150820 Same thing for text-combine: https://bugs.webkit.org/show_bug.cgi?id=150821 1138821 3 264661 mmaxfield 2015-11-02 21:09:01 -0800 Created attachment 264661 Patch 1138939 4 264661 commit-queue 2015-11-03 09:14:17 -0800 Comment on attachment 264661 Patch Clearing flags on attachment: 264661 Committed r191953: <http://trac.webkit.org/changeset/191953> 1138940 5 commit-queue 2015-11-03 09:14:20 -0800 All reviewed patches have been landed. Closing bug. 264661 2015-11-02 21:09:01 -0800 2015-11-03 09:14:17 -0800 Patch bug-150765-20151102210804.patch text/plain 6421 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxOTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY4OWRkMWVmODJiZWQ4 Y2YyZjdmZTNhZTgzYWRiZjAxMjQ2OWEyMi4uZDQyN2EwYWQwYjkyODlkZmI2NDVmNGE1ZTEwMzZm Y2FlYjYxMzA3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE1LTExLTAyICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgVXBkYXRlIHRv IG1hdGNoIHRleHQtb3JpZW50YXRpb24gc3BlYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIENTUyBzcGVjIGhhcyByZW1vdmVkIHRoZSAic2lkZXdh eXMtcmlnaHQiIHZhbHVlIG9mIHRleHQtb3JpZW50YXRpb24gaW4gZmF2b3IKKyAgICAgICAgb2Yg InNpZGV3YXlzLiIgVGhpcyBwYXRjaCBtYWtlcyB0aGUgcGFyc2VyIHRyZWF0ICJzaWRld2F5cy1y aWdodCIgdGhlIHNhbWUgYXMKKyAgICAgICAgInNpZGV3YXlzLiIKKworICAgICAgICBUZXN0OiBm YXN0L3RleHQvb3JpZW50YXRpb24tc2lkZXdheXMtcmlnaHQuaHRtbAorCisgICAgICAgICogY3Nz L0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByaW1p dGl2ZVZhbHVlOjpvcGVyYXRvciBUZXh0T3JpZW50YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKTogRGVsZXRlZC4KKyAgICAgICAg KiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyU3R5bGU6OmZvbnRBbmRHbHlwaE9yaWVudGF0aW9uKTogRGVsZXRlZC4KKyAgICAgICAgKiBy ZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGVDb25zdGFudHMuaDoKKworMjAxNS0xMS0wMiAgTXls ZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgorCiAgICAgICAgIFtWZXJ0aWNh bCBXcml0aW5nIE1vZGVdIFJlbmFtZSAidmVydGljYWwtcmlnaHQiIENTUyB2YWx1ZSB0byBtYXRj aCBzcGVjCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTA3NjYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVl TWFwcGluZ3MuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdz LmgKaW5kZXggZGM4YjRkNWE3Y2Y2OTQxMGZkODZhYjcyMTUzMDAzZTcwNGI5MjJjYS4uNTMyNTI4 MDFkNGNlZWY1ZTMxNjk4ODJjZmViN2Y0NTViYzBjYmM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCkBAIC0zMzM0LDkgKzMzMzQsNiBAQCB0 ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUoVGV4 dE9yaWVudGF0aW9uIGUpCiAgICAgY2FzZSBUZXh0T3JpZW50YXRpb246OlNpZGV3YXlzOgogICAg ICAgICBtX3ZhbHVlLnZhbHVlSUQgPSBDU1NWYWx1ZVNpZGV3YXlzOwogICAgICAgICBicmVhazsK LSAgICBjYXNlIFRleHRPcmllbnRhdGlvbjo6U2lkZXdheXNSaWdodDoKLSAgICAgICAgbV92YWx1 ZS52YWx1ZUlEID0gQ1NTVmFsdWVTaWRld2F5c1JpZ2h0OwotICAgICAgICBicmVhazsKICAgICBj YXNlIFRleHRPcmllbnRhdGlvbjo6TWl4ZWQ6CiAgICAgICAgIG1fdmFsdWUudmFsdWVJRCA9IENT U1ZhbHVlTWl4ZWQ7CiAgICAgICAgIGJyZWFrOwpAQCAtMzM1NCw3ICszMzUxLDcgQEAgdGVtcGxh dGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9yIFRleHRPcmllbnRhdGlvbigp IGNvbnN0CiAgICAgY2FzZSBDU1NWYWx1ZVNpZGV3YXlzOgogICAgICAgICByZXR1cm4gVGV4dE9y aWVudGF0aW9uOjpTaWRld2F5czsKICAgICBjYXNlIENTU1ZhbHVlU2lkZXdheXNSaWdodDoKLSAg ICAgICAgcmV0dXJuIFRleHRPcmllbnRhdGlvbjo6U2lkZXdheXNSaWdodDsKKyAgICAgICAgcmV0 dXJuIFRleHRPcmllbnRhdGlvbjo6U2lkZXdheXM7CiAgICAgY2FzZSBDU1NWYWx1ZVZlcnRpY2Fs UmlnaHQ6CiAgICAgICAgIHJldHVybiBUZXh0T3JpZW50YXRpb246Ok1peGVkOwogICAgIGNhc2Ug Q1NTVmFsdWVNaXhlZDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVy U3R5bGUuY3BwCmluZGV4IGZlY2JiNTkyZDI2M2I2NmIzMDQwYzM2NzBjYjgzZjc5ODBhNjBhMmEu LjJiNGM2ZjYzZWFmYTBmMzM5OTJlNmJlZDk2ODQyN2JlMjgzMjAyZTMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcApAQCAtMTgzMyw4ICsxODMz LDYgQEAgc3RkOjpwYWlyPEZvbnRPcmllbnRhdGlvbiwgTm9uQ0pLR2x5cGhPcmllbnRhdGlvbj4g UmVuZGVyU3R5bGU6OmZvbnRBbmRHbHlwaE9yaWUKICAgICAgICAgcmV0dXJuIHsgVmVydGljYWws IE5vbkNKS0dseXBoT3JpZW50YXRpb246OlVwcmlnaHQgfTsKICAgICBjYXNlIFRleHRPcmllbnRh dGlvbjo6U2lkZXdheXM6CiAgICAgICAgIHJldHVybiB7IEhvcml6b250YWwsIE5vbkNKS0dseXBo T3JpZW50YXRpb246Ok1peGVkIH07Ci0gICAgY2FzZSBUZXh0T3JpZW50YXRpb246OlNpZGV3YXlz UmlnaHQ6Ci0gICAgICAgIHJldHVybiB7IEhvcml6b250YWwsIE5vbkNKS0dseXBoT3JpZW50YXRp b246Ok1peGVkIH07CiAgICAgZGVmYXVsdDoKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 CiAgICAgICAgIHJldHVybiB7IEhvcml6b250YWwsIE5vbkNKS0dseXBoT3JpZW50YXRpb246Ok1p eGVkIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVy U3R5bGVDb25zdGFudHMuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJT dHlsZUNvbnN0YW50cy5oCmluZGV4IGNjNGM1NDExNTU1ODE2NjQ4MTAwM2Q1MWFlZDY3YTIxZDBj MGQxNmQuLjczYjUzZGIxNjc2OWEyM2NkZjgxNjU1ZjA5MGZjNmZhNTQxODgxN2UgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50 cy5oCkBAIC01ODYsNyArNTg2LDcgQEAgZW51bSBUZXh0RW1waGFzaXNQb3NpdGlvbnMgewogfTsK IHR5cGVkZWYgdW5zaWduZWQgVGV4dEVtcGhhc2lzUG9zaXRpb247CiAKLWVudW0gY2xhc3MgVGV4 dE9yaWVudGF0aW9uIHsgTWl4ZWQsIFVwcmlnaHQsIFNpZGV3YXlzLCBTaWRld2F5c1JpZ2h0IH07 CitlbnVtIGNsYXNzIFRleHRPcmllbnRhdGlvbiB7IE1peGVkLCBVcHJpZ2h0LCBTaWRld2F5cyB9 OwogCiBlbnVtIFRleHRPdmVyZmxvdyB7IFRleHRPdmVyZmxvd0NsaXAgPSAwLCBUZXh0T3ZlcmZs b3dFbGxpcHNpcyB9OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGJhZjZiMDkzZjY5NDhlNDM5MjNhODQ3ZjhlZTA4ZWNm Mjc2OTFmYS4uY2EwMjVmNzNjMDU2MjRkNjY5MmVlYjJiYzI1ZjU4YTNhODhmOWFlNSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDE1IEBACiAyMDE1LTExLTAyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVs ZEBhcHBsZS5jb20+CiAKKyAgICAgICAgVXBkYXRlIHRvIG1hdGNoIHRleHQtb3JpZW50YXRpb24g c3BlYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUw NzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L3RleHQvb3JpZW50YXRpb24tc2lkZXdheXMtcmlnaHQtZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogZmFzdC90ZXh0L29yaWVudGF0aW9uLXNpZGV3YXlzLXJpZ2h0Lmh0bWw6IEFk ZGVkLgorCisyMDE1LTExLTAyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5j b20+CisKICAgICAgICAgW1ZlcnRpY2FsIFdyaXRpbmcgTW9kZV0gUmVuYW1lICJ2ZXJ0aWNhbC1y aWdodCIgQ1NTIHZhbHVlIHRvIG1hdGNoIHNwZWMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDc2NgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L3RleHQvb3JpZW50YXRpb24tc2lkZXdheXMtcmlnaHQtZXhwZWN0ZWQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvdGV4dC9vcmllbnRhdGlvbi1zaWRld2F5cy1yaWdodC1leHBlY3RlZC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmI2YWJlNTc0YjU3NGQ3MzVjOGNhNGE5YzE1MTEyM2JmYjNiZjYyMTIKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvb3JpZW50YXRpb24tc2lkZXdh eXMtcmlnaHQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDE3IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4KK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRo YXQgdGV4dC1vcmllbnRhdGlvbjogc2lkZXdheXMgaXMgdHJlYXRlZCB0aGUgc2FtZSBhcyB0ZXh0 LW9yaWVudGF0aW9uOiBzaWRld2F5cy1yaWdodC4KKzxkaXYgaWQ9InBsYWNlaG9sZGVyIj48L2Rp dj4KKzxkaXYgc3R5bGU9InRleHQtb3JpZW50YXRpb246IHVwcmlnaHQ7Ij4KKzxkaXYgaWQ9InQi IHN0eWxlPSItd2Via2l0LXdyaXRpbmctbW9kZTogdmVydGljYWwtcmw7IC13ZWJraXQtdGV4dC1v cmllbnRhdGlvbjogc2lkZXdheXM7Ij5hYmNkPC9kaXY+Cis8L2Rpdj4KKzxzY3JpcHQ+Cit2YXIg dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0Iik7Cit2YXIgcmVjZWl2ZXIgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgicGxhY2Vob2xkZXIiKTsKK3JlY2VpdmVyLnRleHRDb250ZW50ID0g d2luZG93LmdldENvbXB1dGVkU3R5bGUodCkuZ2V0UHJvcGVydHlWYWx1ZSgiLXdlYmtpdC10ZXh0 LW9yaWVudGF0aW9uIik7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5l IGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQvb3JpZW50 YXRpb24tc2lkZXdheXMtcmlnaHQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9vcmllbnRh dGlvbi1zaWRld2F5cy1yaWdodC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc4NWIyNDg4YWM0YTgyN2FkZGYw YzEyZGZjOGRjMjQxZDFjNDc0MTkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L3RleHQvb3JpZW50YXRpb24tc2lkZXdheXMtcmlnaHQuaHRtbApAQCAtMCwwICsxLDE3IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4KK1RoaXMgdGVz dCBtYWtlcyBzdXJlIHRoYXQgdGV4dC1vcmllbnRhdGlvbjogc2lkZXdheXMgaXMgdHJlYXRlZCB0 aGUgc2FtZSBhcyB0ZXh0LW9yaWVudGF0aW9uOiBzaWRld2F5cy1yaWdodC4KKzxkaXYgaWQ9InBs YWNlaG9sZGVyIj48L2Rpdj4KKzxkaXYgc3R5bGU9InRleHQtb3JpZW50YXRpb246IHVwcmlnaHQ7 Ij4KKzxkaXYgaWQ9InQiIHN0eWxlPSItd2Via2l0LXdyaXRpbmctbW9kZTogdmVydGljYWwtcmw7 IC13ZWJraXQtdGV4dC1vcmllbnRhdGlvbjogc2lkZXdheXMtcmlnaHQ7Ij5hYmNkPC9kaXY+Cis8 L2Rpdj4KKzxzY3JpcHQ+Cit2YXIgdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0Iik7Cit2 YXIgcmVjZWl2ZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGxhY2Vob2xkZXIiKTsKK3Jl Y2VpdmVyLnRleHRDb250ZW50ID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUodCkuZ2V0UHJvcGVy dHlWYWx1ZSgiLXdlYmtpdC10ZXh0LW9yaWVudGF0aW9uIik7Cis8L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==