150688 2015-10-29 13:01:26 -0700 Air::handleCalleeSaves shouldn't save/restore the frame pointer 2015-10-29 18:47:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150279 1 fpizlo fpizlo oldest_to_newest 1137623 0 fpizlo 2015-10-29 13:01:26 -0700 Patch forthcoming. 1137717 1 264366 fpizlo 2015-10-29 16:55:03 -0700 Created attachment 264366 the patch 1137728 2 264366 saam 2015-10-29 17:27:31 -0700 Comment on attachment 264366 the patch r=me 1137729 3 264366 msaboff 2015-10-29 17:31:40 -0700 Comment on attachment 264366 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=264366&action=review r- > Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.cpp:55 > usedCalleeSaves.filter(RegisterSet::calleeSaveRegisters()); > + usedCalleeSaves.exclude(RegisterSet::stackRegisters()); // We don't need to save FP here. RegisterSet::calleeSaveRegisters() already contains the frame pointer. In all cases, it uses the native register name. 1137731 4 264366 msaboff 2015-10-29 17:33:38 -0700 Comment on attachment 264366 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=264366&action=review r+ >> Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.cpp:55 >> usedCalleeSaves.filter(RegisterSet::calleeSaveRegisters()); >> + usedCalleeSaves.exclude(RegisterSet::stackRegisters()); // We don't need to save FP here. > > RegisterSet::calleeSaveRegisters() already contains the frame pointer. In all cases, it uses the native register name. Sorry, didn't see the .filter for RegisterSet::calleeSaveRegisters(). 1137745 5 fpizlo 2015-10-29 18:47:20 -0700 Landed in http://trac.webkit.org/changeset/191771 264366 2015-10-29 16:55:03 -0700 2015-10-29 17:33:38 -0700 the patch blah.patch text/plain 1338 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxNzY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE1LTEwLTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QWlyOjpoYW5kbGVDYWxsZWVTYXZlcyBzaG91bGRuJ3Qgc2F2ZS9yZXN0b3JlIHRoZSBmcmFtZSBw b2ludGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTA2ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZSBzYXZlL3Jlc3RvcmUgdGhlIEZQIGluc2lkZSBBaXI6OmdlbmVyYXRlKCkuCisKKyAgICAgICAg KiBiMy9haXIvQWlySGFuZGxlQ2FsbGVlU2F2ZXMuY3BwOgorICAgICAgICAoSlNDOjpCMzo6QWly OjpoYW5kbGVDYWxsZWVTYXZlcyk6CisKIDIwMTUtMTAtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBCMzo6TG93ZXJUb0Fpcjo6aW1tKCkgc2hvdWxkIHdvcmsg Zm9yIGJvdGggMzItYml0IGFuZCA2NC1iaXQgaW1tZWRpYXRlcwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL2Fpci9BaXJIYW5kbGVDYWxsZWVTYXZlcy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJIYW5kbGVDYWxsZWVTYXZlcy5jcHAJKHJl dmlzaW9uIDE5MTc2MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlySGFuZGxl Q2FsbGVlU2F2ZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Miw2ICs1Miw3IEBAIHZvaWQgaGFu ZGxlQ2FsbGVlU2F2ZXMoQ29kZSYgY29kZSkKIAogICAgIC8vIE5vdyB3ZSBmaWx0ZXIgdG8gcmVh bGx5IGdldCB0aGUgY2FsbGVlIHNhdmVzLgogICAgIHVzZWRDYWxsZWVTYXZlcy5maWx0ZXIoUmVn aXN0ZXJTZXQ6OmNhbGxlZVNhdmVSZWdpc3RlcnMoKSk7CisgICAgdXNlZENhbGxlZVNhdmVzLmV4 Y2x1ZGUoUmVnaXN0ZXJTZXQ6OnN0YWNrUmVnaXN0ZXJzKCkpOyAvLyBXZSBkb24ndCBuZWVkIHRv IHNhdmUgRlAgaGVyZS4KIAogICAgIGlmICghdXNlZENhbGxlZVNhdmVzLm51bWJlck9mU2V0UmVn aXN0ZXJzKCkpCiAgICAgICAgIHJldHVybjsK