150500 2015-10-23 08:11:03 -0700 [GTK][Mac] disable OBJC JSC API 2015-10-30 01:21:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126492 1 pnormand pnormand achristensen commit-queue oldest_to_newest 1136036 0 pnormand 2015-10-23 08:11:03 -0700 The Mac flavour of the GTK port can't really support this it seems. 1136037 1 263925 pnormand 2015-10-23 08:13:43 -0700 Created attachment 263925 Patch 1136045 2 263927 pnormand 2015-10-23 08:51:33 -0700 Created attachment 263927 Patch 1136046 3 263927 pnormand 2015-10-23 08:53:21 -0700 Comment on attachment 263927 Patch oops 1137771 4 263925 achristensen 2015-10-29 20:38:32 -0700 Comment on attachment 263925 Patch Sure, why not. 1137784 5 263925 commit-queue 2015-10-29 21:31:15 -0700 Comment on attachment 263925 Patch Clearing flags on attachment: 263925 Committed r191775: <http://trac.webkit.org/changeset/191775> 1137785 6 commit-queue 2015-10-29 21:31:18 -0700 All reviewed patches have been landed. Closing bug. 1137817 7 achristensen 2015-10-29 23:15:50 -0700 (In reply to comment #4) > Comment on attachment 263925 [details] > Patch > > Sure, why not. Just so nobody thinks I'm carelessly throwing things into the API, I am aware that this will break compiling any third party applications that use the JSC ObjC API and have BUILDING_GTK__ defined for some reason. I think that's worth having, though, to support GTK development. Why can't GTK on Mac support this, though? 1137832 8 pnormand 2015-10-30 01:21:26 -0700 (In reply to comment #7) > (In reply to comment #4) > > Comment on attachment 263925 [details] > > Patch > > > > Sure, why not. > Just so nobody thinks I'm carelessly throwing things into the API, I am > aware that this will break compiling any third party applications that use > the JSC ObjC API and have BUILDING_GTK__ defined for some reason. I think > that's worth having, though, to support GTK development. > > Why can't GTK on Mac support this, though? I suppose it would be possible to support. All I want for now is a basic build of GTK for Mac. If more people are interested we enable the OBJC API later on. 263925 2015-10-23 08:13:43 -0700 2015-10-29 21:31:15 -0700 Patch bug-150500-20151023171257.patch text/plain 1704 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MjcyNjUyZGE3ZjIwNmFiYjgzOTljMjFmOWNlNTA1ZTY2M2VkY2ViLi4zNDY1NGEwMmE4ZTNiNjJi NWEwNzUwOThiYmU0OGRhN2I1OWI3NTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0xMC0yMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS11bTWFjXSBkaXNhYmxlIE9CSkMgSlNDIEFQSQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNTAwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBUEkvSlNCYXNlLmg6 IERpc2FibGUgdGhlIE9iamVjdGl2ZS1DIEFQSSBvbiBNYWMgZm9yIHRoZSBHVEsgcG9ydC4KKwog MjAxNS0wNi0xOSAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNvbT4K IAogICAgICAgICB3ZWJraXQtZ3RrLTIuMy40IGZhaWxzIHRvIGxpbmsgSmF2YVNjcmlwdENvcmUs IG1pc3Npbmcgc3ltYm9scyBhZGRfaGlzdG9yeSBhbmQgcmVhZGxpbmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTQmFzZS5oCmluZGV4IDRjOTYwODgyOGVmMDk0Y2UyZmI4YzcwYjA5MzQ0YjRkOWIxNzM5 NjIuLjRhMWEyNTdhMjc4ZGFjYTcxZWQ1MTI3ODhjMzYzYzMxMmViNjU3Y2IgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0FQSS9KU0Jhc2UuaApAQCAtMTM2LDcgKzEzNiw3IEBAIEpTX0VYUE9SVCB2b2lkIEpT R2FyYmFnZUNvbGxlY3QoSlNDb250ZXh0UmVmIGN0eCk7CiAKIC8qIEVuYWJsZSB0aGUgT2JqZWN0 aXZlLUMgQVBJIGZvciBwbGF0Zm9ybXMgd2l0aCBhIG1vZGVybiBydW50aW1lLiAqLwogI2lmICFk ZWZpbmVkKEpTQ19PQkpDX0FQSV9FTkFCTEVEKQotI2RlZmluZSBKU0NfT0JKQ19BUElfRU5BQkxF RCAoZGVmaW5lZChfX2NsYW5nX18pICYmIGRlZmluZWQoX19BUFBMRV9fKSAmJiAoKGRlZmluZWQo X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCkgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMDkwICYmICFkZWZpbmVkKF9faTM4Nl9fKSkgfHwgKGRlZmluZWQoVEFS R0VUX09TX0lQSE9ORSkgJiYgVEFSR0VUX09TX0lQSE9ORSkpKQorI2RlZmluZSBKU0NfT0JKQ19B UElfRU5BQkxFRCAoZGVmaW5lZChfX2NsYW5nX18pICYmIGRlZmluZWQoX19BUFBMRV9fKSAmJiAh ZGVmaW5lZChCVUlMRElOR19HVEtfXykgJiYgKChkZWZpbmVkKF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5MCAm JiAhZGVmaW5lZChfX2kzODZfXykpIHx8IChkZWZpbmVkKFRBUkdFVF9PU19JUEhPTkUpICYmIFRB UkdFVF9PU19JUEhPTkUpKSkKICNlbmRpZgogCiAjZW5kaWYgLyogSlNCYXNlX2ggKi8K 263927 2015-10-23 08:51:33 -0700 2015-10-23 08:53:21 -0700 Patch bug-150500-20151023175047.patch text/plain 1299 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA5MzUyYjcwOWQ1ODU4NTcyOTk5OWI1 ZDVmMjNjMzkyOTExNGNiOTIuLmIyZTIxZTg4YmM1YTgxZDc1NWY5OGFiOGU1ZWU3NmEyOThlMzdl YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMTAtMjMgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW01hY10gZGlzYWJsZSBPQkpDIEpT QyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 MDUwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog d3RmL0NNYWtlTGlzdHMudHh0OiBBZGQgQ29tbW9uQ3J5cHRvU1BJLmggaW4gdGhlIGhlYWRlcnMu CisKIDIwMTUtMDYtMTkgIFBoaWxpcCBDaGltZW50byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5j b20+CiAKICAgICAgICAgW0dUS10gRml4IGNvbWJpbmF0aW9ucyBvZiBQTEFURk9STShHVEspIGFu ZCBPUyhEQVJXSU4pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3RzLnR4dCBi L1NvdXJjZS9XVEYvd3RmL0NNYWtlTGlzdHMudHh0CmluZGV4IDgyNjUwOWE4YWMxYWVmZGEzN2Jj NDc5ZjEwMmViNTgxMjIwOWRkOWMuLmNlZjhhMDc3YzBjYTlkYzRjZjk0NTJlYzIyNDcxNWE2M2Jl ZjcxZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9XVEYvd3RmL0NNYWtlTGlzdHMudHh0CkBAIC0yMzQsNiArMjM0LDE1IEBAIHNldChXVEZf TElCUkFSSUVTCiAgICAgJHtDTUFLRV9ETF9MSUJTfQogKQogCitpZiAoQ01BS0VfU1lTVEVNX05B TUUgTUFUQ0hFUyAiRGFyd2luIikKKyAgICBsaXN0KEFQUEVORCBXVEZfSEVBREVSUworICAgICAg ICBzcGkvZGFyd2luL0NvbW1vbkNyeXB0b1NQSS5oCisgICAgKQorICAgIGxpc3QoQVBQRU5EIFdU Rl9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAgICAgICIke1dURl9ESVJ9L3d0Zi9zcGkvZGFyd2lu IgorICAgICkKK2VuZGlmICgpCisKICMgRklYTUU6IFBvcnQgYm1hbGxvYyB0byBXaW5kb3dzLiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMzEwCiBpZiAoTk9UIFdJ TjMyKQogICAgIGxpc3QoQVBQRU5EIFdURl9MSUJSQVJJRVMgYm1hbGxvYykK