150382 2015-10-20 18:48:07 -0700 Single tapping clickable elements in unscalable pages should show a tap highlight 2015-10-21 15:31:39 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 149968 1 wenson_hsieh wenson_hsieh webkit-bug-importer oldest_to_newest 1135092 0 wenson_hsieh 2015-10-20 18:48:07 -0700 Single tapping clickable elements in unscalable pages should show a tap highlight. Currently, tap highlights are broken for fast clicking in pages that are unscalable because WKContentView assumes that the tap highlight geometry will arrive from the web process before the single tap is committed by the gesture recognizer. However, when the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is committed before the geometries come in. 1135093 1 wenson_hsieh 2015-10-20 18:50:02 -0700 <rdar://problem/23172720> 1135383 2 263733 wenson_hsieh 2015-10-21 14:14:32 -0700 Created attachment 263733 Patch 1135411 3 263733 simon.fraser 2015-10-21 14:58:12 -0700 Comment on attachment 263733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263733&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1254 > + _isExpectingFastSingleTapCommit = ![_doubleTapGestureRecognizer isEnabled]; dot syntax? 1135429 4 263733 wenson_hsieh 2015-10-21 15:29:19 -0700 Comment on attachment 263733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263733&action=review >> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1254 >> + _isExpectingFastSingleTapCommit = ![_doubleTapGestureRecognizer isEnabled]; > > dot syntax? Fixed! 1135431 5 wenson_hsieh 2015-10-21 15:31:39 -0700 Committed r191409: <http://trac.webkit.org/changeset/191409> 263733 2015-10-21 14:14:32 -0700 2015-10-21 14:58:12 -0700 Patch bug-150382-20151021141348.patch text/plain 4213 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDA0ZGNhNzVhMTUxMzBl NDA1OTBjMDM2YjA0ODIyOGI1YzBkM2Q1YS4uNDNmZGYyODhkYTJkNmEwZjJmMmRjOWRhZjgyYzli Y2JhNDNhYjgwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTEwLTIxICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFNpbmdsZSB0YXBw aW5nIGNsaWNrYWJsZSBlbGVtZW50cyBpbiB1bnNjYWxhYmxlIHBhZ2VzIHNob3VsZCBzaG93IGEg dGFwIGhpZ2hsaWdodAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUwMzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2hlbiB0aGUgZG91YmxlIHRhcCBnZXN0dXJlIHJlY29nbml6ZXIgaXMgZGlzYWJsZWQg YWhlYWQgb2YgdGltZSAoYXMgaW4gdGhlIGNhc2Ugb2YgdW5zY2FsYWJsZSBwYWdlcykgdGhlIHRh cCBpcworICAgICAgICBjb21taXR0ZWQgYmVmb3JlIHRoZSBnZW9tZXRyaWVzIGNvbWUgaW4uIFRv IGZpeCB0aGlzLCB3ZSBpbnRyb2R1Y2UgYSBmbGFnIHRoYXQgYWxsb3dzIHRoZSBzaW5nbGUgdGFw IHRvIGJlCisgICAgICAgIGNvbW1pdHRlZCBiZWZvcmUgdGhlIHRhcCBoaWdobGlnaHQgYXJyaXZl cy4gVGhpcyBhbGxvd3MgdGhlIHRhcCBoaWdobGlnaHQgdG8gYmUgaW1tZWRpYXRlbHkgYW5pbWF0 ZWQgd2hlbiByZWNlaXZpbmcKKyAgICAgICAgdGhlIHRhcCBoaWdobGlnaHQgZ2VvbWV0cmllcyBv bmx5IGluIHRoZSBjYXNlIHdoZXJlIGRvdWJsZSB0YXBwaW5nIGlzIGRpc2FibGVkIHdoZW4gcmVj b2duaXppbmcgdGhlIHNpbmdsZSB0YXAuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHNldHVwSW50ZXJh Y3Rpb25dKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjbGVhbnVwSW50ZXJhY3Rpb25dKToK KyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZGlkR2V0VGFwSGlnaGxpZ2h0Rm9yUmVxdWVzdDpj b2xvcjpxdWFkczp0b3BMZWZ0UmFkaXVzOnRvcFJpZ2h0UmFkaXVzOmJvdHRvbUxlZnRSYWRpdXM6 Ym90dG9tUmlnaHRSYWRpdXM6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3NpbmdsZVRh cFJlY29nbml6ZWQ6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3NpbmdsZVRhcENvbW1p dGVkOl0pOgorCiAyMDE1LTEwLTE5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIEltcGxlbWVudCB0b3VjaC1hY3Rpb246IG1hbmlwdWxhdGlvbjsgZm9y IGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLmgKaW5kZXggZjA3ZDg0MzMyYWEzZmRmMGMwMjJmZWM0MWRiN2ZiMWM5 NzBhMjYwYS4uY2VhMjgyNjcyNjQxNWU2MzlhZTY0YzVjNjVkMjhkYzNjNzI3YmRjMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5oCkBAIC0xNTgsNiArMTU4LDcgQEAgc3RydWN0IFdLQXV0b0NvcnJlY3Rpb25EYXRh IHsKICAgICBCT09MIF91c2luZ0dlc3R1cmVGb3JTZWxlY3Rpb247CiAgICAgQk9PTCBfaW5zcGVj dG9yTm9kZVNlYXJjaEVuYWJsZWQ7CiAgICAgQk9PTCBfZGlkQWNjZXNzb3J5VGFiSW5pdGlhdGVG b2N1czsKKyAgICBCT09MIF9pc0V4cGVjdGluZ0Zhc3RTaW5nbGVUYXBDb21taXQ7CiB9CiAKIEBl bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYTAzNDg4OTkwYjgzNDBiOWU3NmVjOTg4OWEyZGY0MmJh OTFlNzcyNC4uYWViYzk3M2M3MTY2NmMzZWIwZDJmYWU0ODBhMDIwNzc4YjQ0NmIwMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0KQEAgLTQ1Myw2ICs0NTMsNyBAQCAtICh2b2lkKXNldHVwSW50ZXJhY3Rpb24K ICAgICBfYWN0aW9uU2hlZXRBc3Npc3RhbnQgPSBhZG9wdE5TKFtbV0tBY3Rpb25TaGVldEFzc2lz dGFudCBhbGxvY10gaW5pdFdpdGhWaWV3OnNlbGZdKTsKICAgICBbX2FjdGlvblNoZWV0QXNzaXN0 YW50IHNldERlbGVnYXRlOnNlbGZdOwogICAgIF9zbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVy ID0gc3RkOjptYWtlX3VuaXF1ZTxTbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyPihzZWxmKTsK KyAgICBfaXNFeHBlY3RpbmdGYXN0U2luZ2xlVGFwQ29tbWl0ID0gTk87CiB9CiAKIC0gKHZvaWQp Y2xlYW51cEludGVyYWN0aW9uCkBAIC00NjIsNiArNDYzLDcgQEAgLSAodm9pZCljbGVhbnVwSW50 ZXJhY3Rpb24KICAgICBfYWN0aW9uU2hlZXRBc3Npc3RhbnQgPSBuaWw7CiAgICAgX3NtYXJ0TWFn bmlmaWNhdGlvbkNvbnRyb2xsZXIgPSBuaWw7CiAgICAgX2RpZEFjY2Vzc29yeVRhYkluaXRpYXRl Rm9jdXMgPSBOTzsKKyAgICBfaXNFeHBlY3RpbmdGYXN0U2luZ2xlVGFwQ29tbWl0ID0gTk87CiAg ICAgW19mb3JtSW5wdXRTZXNzaW9uIGludmFsaWRhdGVdOwogICAgIF9mb3JtSW5wdXRTZXNzaW9u ID0gbmlsOwogICAgIFtfaGlnaGxpZ2h0VmlldyByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKQEAgLTg0 OSw2ICs4NTEsMTEgQEAgLSAodm9pZClfZGlkR2V0VGFwSGlnaGxpZ2h0Rm9yUmVxdWVzdDoodWlu dDY0X3QpcmVxdWVzdElEIGNvbG9yOihjb25zdCBXZWJDb3JlOjoKICAgICB9CiAKICAgICBbc2Vs ZiBfc2hvd1RhcEhpZ2hsaWdodF07CisgICAgaWYgKF9pc0V4cGVjdGluZ0Zhc3RTaW5nbGVUYXBD b21taXQpIHsKKyAgICAgICAgW3NlbGYgX2ZpbmlzaEludGVyYWN0aW9uXTsKKyAgICAgICAgaWYg KCFfcG90ZW50aWFsVGFwSW5Qcm9ncmVzcykKKyAgICAgICAgICAgIF9pc0V4cGVjdGluZ0Zhc3RT aW5nbGVUYXBDb21taXQgPSBOTzsKKyAgICB9CiB9CiAKIC0gKENHRmxvYXQpX2Zhc3RDbGlja1pv b21UaHJlc2hvbGQKQEAgLTEyNDQsNiArMTI1MSw3IEBAIC0gKHZvaWQpX3NpbmdsZVRhcFJlY29n bml6ZWQ6KFVJVGFwR2VzdHVyZVJlY29nbml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgogICAgIF9w YWdlLT5wb3RlbnRpYWxUYXBBdFBvc2l0aW9uKGdlc3R1cmVSZWNvZ25pemVyLmxvY2F0aW9uLCAr K19sYXRlc3RUYXBJRCk7CiAgICAgX3BvdGVudGlhbFRhcEluUHJvZ3Jlc3MgPSBZRVM7CiAgICAg X2lzVGFwSGlnaGxpZ2h0SURWYWxpZCA9IFlFUzsKKyAgICBfaXNFeHBlY3RpbmdGYXN0U2luZ2xl VGFwQ29tbWl0ID0gIVtfZG91YmxlVGFwR2VzdHVyZVJlY29nbml6ZXIgaXNFbmFibGVkXTsKIH0K IAogc3RhdGljIHZvaWQgY2FuY2VsUG90ZW50aWFsVGFwSWZOZWNlc3NhcnkoV0tDb250ZW50Vmll dyogY29udGVudFZpZXcpCkBAIC0xMjk3LDcgKzEzMDUsOCBAQCAtICh2b2lkKV9zaW5nbGVUYXBD b21taXRlZDooVUlUYXBHZXN0dXJlUmVjb2duaXplciAqKWdlc3R1cmVSZWNvZ25pemVyCiAKICAg ICBfcGFnZS0+Y29tbWl0UG90ZW50aWFsVGFwKCk7CiAKLSAgICBbc2VsZiBfZmluaXNoSW50ZXJh Y3Rpb25dOworICAgIGlmICghX2lzRXhwZWN0aW5nRmFzdFNpbmdsZVRhcENvbW1pdCkKKyAgICAg ICAgW3NlbGYgX2ZpbmlzaEludGVyYWN0aW9uXTsKIH0KIAogLSAodm9pZClfZG91YmxlVGFwUmVj b2duaXplZDooVUlUYXBHZXN0dXJlUmVjb2duaXplciAqKWdlc3R1cmVSZWNvZ25pemVyCg==