150321 2015-10-19 03:02:13 -0700 Fix the !ENABLE(CSS_GRID_LAYOUT) build after r191128 2015-10-20 10:17:01 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 19660 1 ossy ossy bfulgham commit-queue dino hyatt ossy oldest_to_newest 1134527 0 ossy 2015-10-19 03:02:13 -0700 https://trac.webkit.org/changeset/191128 broke the --minimal build (at least on EFL): /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:1540.31-34: warning: unused value: $3 [-Wother] | VARFUNCTION maybe_space expr closing_parenthesis { ^^^^ /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: error: shift/reduce conflicts: 38 found, 37 expected Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84. ninja: build stopped: subcommand failed. 1134534 1 263465 ossy 2015-10-19 03:34:13 -0700 Created attachment 263465 Patch 1134546 2 ossy 2015-10-19 04:00:20 -0700 (In reply to comment #0) > https://trac.webkit.org/changeset/191128 broke the --minimal build (at least > on EFL): > > /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: > 1540.31-34: warning: unused value: $3 [-Wother] > | VARFUNCTION maybe_space expr closing_parenthesis { > ^^^^ This warning is not so critical, build works fine without fixing it, so I filed a new bug report to fix the warning: bug150325. > /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: > error: shift/reduce conflicts: 38 found, 37 expected > Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84. > ninja: build stopped: subcommand failed. The proposed patch fixes only the build failure. 1134826 3 ossy 2015-10-20 01:01:33 -0700 ping? 1134911 4 263465 commit-queue 2015-10-20 10:16:56 -0700 Comment on attachment 263465 Patch Clearing flags on attachment: 263465 Committed r191344: <http://trac.webkit.org/changeset/191344> 1134912 5 commit-queue 2015-10-20 10:17:01 -0700 All reviewed patches have been landed. Closing bug. 263465 2015-10-19 03:34:13 -0700 2015-10-20 10:16:56 -0700 Patch bug-150321-20151019033331.patch text/plain 1120 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjNjMWFhYzhiM2FiMTE1 NDM3NTFlZWY2NWUyOWQ0NGUzMzI3Nzc4ZS4uZjRmOGU3YTM4NTQzMWEyNDMwYTUzNzhkYTFlYWI4 YTk1ODliYWJlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTEwLTE5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKENTU19HUklEX0xBWU9VVCkgYnVpbGQgYWZ0ZXIgcjE5MTEyOAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzIxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvQ1NTR3JhbW1hci55LmluOiBU eXBvIGZpeC4KKwogMjAxNS0xMC0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIFNjcmlwdCBlbGVtZW50IHdpdGggYW4gZW1wdHkgZm9yIG9yIGV2ZW50IGF0dHJp YnV0ZXMgc2hvdWxkIG5vdCBleGVjdXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTR3JhbW1hci55LmluIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbgppbmRl eCA1MDczMWIwYWQwMzE3ZTU5YzFlM2QwYmQ5MDNjN2EzOTI0NWExN2QyLi41OTNmZDU5MjAyYzUx Y2I0NzY5ZjFkN2Q1NGQ3ZGU3ZGVkNjY5ODVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTR3JhbW1hci55LmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnku aW4KQEAgLTEyNyw3ICsxMjcsNyBAQCBzdGF0aWMgYm9vbCBzZWxlY3Rvckxpc3REb2VzTm90TWF0 Y2hBbnlQc2V1ZG9FbGVtZW50KGNvbnN0IFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdAogI2lmIEVOQUJM RV9DU1NfR1JJRF9MQVlPVVQKICVleHBlY3QgMzkKICNlbHNlCi0lZXhwZWN0IDM3CislZXhwZWN0 IDM4CiAjZW5kaWYKIAogJW5vbmFzc29jIExPV0VTVF9QUkVDCg==