150172 2015-10-15 08:35:50 -0700 Fix the ENABLE(SECCOMP_FILTERS) build after r187030 2015-10-18 23:50:15 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142980 1 ossy ossy mcatanzaro ossy zan oldest_to_newest 1133478 0 ossy 2015-10-15 08:35:50 -0700 ../../Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp:68:44: error: missing binary operator before token "(" #if defined(__has_builtin) && __has_builtin(__builtin_strlen) ^ ---> We should use nested #if's, because GCC's preprocessor don't like this construction at all. ../../Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp: In function 'void WebKit::reportUnexpectedSyscall(unsigned int)': ../../Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp:78:31: error: ignoring return value of 'ssize_t write(int, const void*, size_t)', declared with attribute warn_unused_result [-Werror=unused-result] ---> We should suppress this warning. 1133480 1 263162 ossy 2015-10-15 08:52:57 -0700 Created attachment 263162 Patch 1133539 2 mcatanzaro 2015-10-15 11:41:39 -0700 LGTM 1134476 3 263162 ossy 2015-10-18 23:50:09 -0700 Comment on attachment 263162 Patch Clearing flags on attachment: 263162 Committed r191278: <http://trac.webkit.org/changeset/191278> 1134477 4 ossy 2015-10-18 23:50:15 -0700 All reviewed patches have been landed. Closing bug. 263162 2015-10-15 08:52:57 -0700 2015-10-18 23:50:09 -0700 Patch bug-150172-20151015175218.patch text/plain 1981 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmE4OTNkMDZmNDNhNDkz NWU1ZmU2Y2ZkNzA0N2QzN2ZmMmIxODEzYS4uMThlM2EzOGFlOTRjYzI3YjdiYjZkZDA4ZmU2NTZh NzdjMDcxMTdjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBFTkFC TEUoU0VDQ09NUF9GSUxURVJTKSBidWlsZCBhZnRlciByMTg3MDMwCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAxNzIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9saW51eC9TZWNjb21wRmls dGVycy9TeXNjYWxsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6cmVwb3J0VW5leHBlY3RlZFN5c2Nh bGwpOgorCiAyMDE1LTEwLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBUZXN0IFdlYktpdDIuUmVzdG9yZVNlc3Npb25TdGF0ZUNv bnRhaW5pbmdGb3JtRGF0YSBmYWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVk L2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1N5c2NhbGwuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVk L2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1N5c2NhbGwuY3BwCmluZGV4IDg5ZTUwZDA0MDFmOWYzYTMx MzE0Yjk4MjZiYTZlODcyMDY3MmQ3NWYuLjI1ZGFjODM5ZWNlNDUzODg4YzEwNWJiMWZjMDRhNjQ2 YjU5YmNiMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51eC9TZWNjb21w RmlsdGVycy9TeXNjYWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgvU2Vj Y29tcEZpbHRlcnMvU3lzY2FsbC5jcHAKQEAgLTY1LDE1ICs2NSwxOCBAQCBzdGF0aWMgdm9pZCB3 cml0ZVVuc2lnbmVkSW50KGNoYXIqIGJ1ZiwgdW5zaWduZWQgdmFsKQogc3RhdGljIHZvaWQgcmVw b3J0VW5leHBlY3RlZFN5c2NhbGwodW5zaWduZWQgc3lzY2FsbCkKIHsKICAgICBjaGFyIGJ1Zlsx MjhdOwotI2lmIGRlZmluZWQoX19oYXNfYnVpbHRpbikgJiYgX19oYXNfYnVpbHRpbihfX2J1aWx0 aW5fc3RybGVuKQorI2lmIGRlZmluZWQoX19oYXNfYnVpbHRpbikKKyNpZiBfX2hhc19idWlsdGlu KF9fYnVpbHRpbl9zdHJsZW4pCiAgICAgLy8gQnVmZmVyIG11c3QgYmUgYmlnIGVub3VnaCBmb3Ig dGhlIGxpdGVyYWwsIHBsdXMgdGhlIG51bWJlciBvZiBkaWdpdHMgaW4gdGhlIGxhcmdlc3QgcG9z c2libGUKICAgICAvLyB1bnNpZ25lZCBpbnQsIHBsdXMgb25lIGZvciB0aGUgbmV3bGluZSwgcGx1 cyBvbmUgbW9yZSBmb3IgdGhlIHRyYWlsaW5nIG51bGwuCiAgICAgc3RhdGljX2Fzc2VydChfX2J1 aWx0aW5fc3RybGVuKG1lc3NhZ2UpICsgc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46OmRp Z2l0czEwICsgMiA8IHNpemVvZihidWYpLCAiQnVmZmVyIHRvbyBzbWFsbCIpOwogI2VuZGlmCisj ZW5kaWYKICAgICBzdHJjcHkoYnVmLCBtZXNzYWdlKTsKICAgICB3cml0ZVVuc2lnbmVkSW50KGJ1 ZiArIHN0cmxlbihidWYpLCBzeXNjYWxsKTsKICAgICBzdHJjYXQoYnVmLCAiXG4iKTsKLSAgICB3 cml0ZShTVERFUlJfRklMRU5PLCBidWYsIHN0cmxlbihidWYpKTsKKyAgICBpbnQgdW51c2VkIF9f YXR0cmlidXRlX18oKHVudXNlZCkpOworICAgIHVudXNlZCA9IHdyaXRlKFNUREVSUl9GSUxFTk8s IGJ1Ziwgc3RybGVuKGJ1ZikpOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8U3lzY2FsbD4gU3lzY2Fs bDo6Y3JlYXRlRnJvbUNvbnRleHQodWNvbnRleHRfdCogdWNvbnRleHQpCg==