149782 2015-10-02 18:46:26 -0700 ShadowRoot with leading or trailing white space cause a crash 2015-10-05 15:50:02 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148695 1 rniwa rniwa cdumez kling koivisto thorton oldest_to_newest 1130406 0 rniwa 2015-10-02 18:46:26 -0700 We're missing a null pointer check. 1130407 1 262375 rniwa 2015-10-02 18:48:39 -0700 Created attachment 262375 Fixes the crash 1130738 2 rniwa 2015-10-05 14:29:49 -0700 ping? 1130740 3 262375 cdumez 2015-10-05 14:33:50 -0700 Comment on attachment 262375 Fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=262375&action=review r=me with comments. > Source/WebCore/style/RenderTreePosition.cpp:66 > + if (PseudoElement* before = parent->beforePseudoElement()) auto* > LayoutTests/fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html:14 > +host.attachShadow({mode: 'closed'}).innerHTML = ` <slot></slot> `; Why are the quotes around the value so weird? 1130775 4 rniwa 2015-10-05 15:50:02 -0700 Committed r190585: <http://trac.webkit.org/changeset/190585> 262375 2015-10-02 18:48:39 -0700 2015-10-05 14:33:50 -0700 Fixes the crash bug-149782-20151002184812.patch text/plain 3661 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDUzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEwLTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNoYWRvd1Jvb3Qgd2l0aCBsZWFk aW5nIG9yIHRyYWlsaW5nIHdoaXRlIHNwYWNlIGNhdXNlIGEgY3Jhc2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTc4MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHRoZSBjcmFzaCBieSBhZGRp bmcgYSBudWxsIHBvaW50ZXIgY2hlY2sgc2luY2UgYSBUZXh0Tm9kZSB0aGF0IGFwcGVhcnMgYXMg YSBkaXJlY3QgY2hpbGQKKyAgICAgICAgb2YgYSBTaGFkb3dSb290IGRvZXNuJ3QgaGF2ZSBhIHBh cmVudCBlbGVtZW50LgorCisgICAgICAgIFRlc3Q6IGZhc3Qvc2hhZG93LWRvbS9zaGFkb3ctcm9v dC13aXRoLWNoaWxkLXdoaXRlc3BhY2UtdGV4dC1jcmFzaC5odG1sCisKKyAgICAgICAgKiBzdHls ZS9SZW5kZXJUcmVlUG9zaXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVHJlZVBv c2l0aW9uOjpwcmV2aW91c1NpYmxpbmdSZW5kZXJlcik6CisKIDIwMTUtMTAtMDIgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEluc2VydGluZyBhIGNoaWxkIHRv IGEgc2xvdCBhc3NpZ25lZCBub2RlIGRvZXNuJ3QgdHJpZ2dlciByZXBhaW50CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9zdHlsZS9SZW5kZXJUcmVlUG9zaXRpb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3N0eWxlL1JlbmRlclRyZWVQb3NpdGlvbi5jcHAJKHJldmlzaW9uIDE5MDUz NSkKKysrIFNvdXJjZS9XZWJDb3JlL3N0eWxlL1JlbmRlclRyZWVQb3NpdGlvbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTYyLDggKzYyLDEwIEBAIFJlbmRlck9iamVjdCogUmVuZGVyVHJlZVBvc2l0 aW9uOjpwcmV2aW8KICAgICAgICAgaWYgKHJlbmRlcmVyICYmICFSZW5kZXJUcmVlUG9zaXRpb246 OmlzUmVuZGVyZXJSZXBhcmVudGVkKCpyZW5kZXJlcikpCiAgICAgICAgICAgICByZXR1cm4gcmVu ZGVyZXI7CiAgICAgfQotICAgIGlmIChQc2V1ZG9FbGVtZW50KiBiZWZvcmUgPSB0ZXh0Tm9kZS5w YXJlbnRFbGVtZW50KCktPmJlZm9yZVBzZXVkb0VsZW1lbnQoKSkKLSAgICAgICAgcmV0dXJuIGJl Zm9yZS0+cmVuZGVyZXIoKTsKKyAgICBpZiAoYXV0byogcGFyZW50ID0gdGV4dE5vZGUucGFyZW50 RWxlbWVudCgpKSB7CisgICAgICAgIGlmIChQc2V1ZG9FbGVtZW50KiBiZWZvcmUgPSBwYXJlbnQt PmJlZm9yZVBzZXVkb0VsZW1lbnQoKSkKKyAgICAgICAgICAgIHJldHVybiBiZWZvcmUtPnJlbmRl cmVyKCk7CisgICAgfQogICAgIHJldHVybiBudWxscHRyOwogfQogCkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biAxOTA1MzUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNSBAQAorMjAxNS0xMC0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K KworICAgICAgICBTaGFkb3dSb290IHdpdGggbGVhZGluZyBvciB0cmFpbGluZyB3aGl0ZSBzcGFj ZSBjYXVzZSBhIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDk3ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBhIHJlZ3Jlc3Npb24gdGVzdC4KKworICAgICAgICAqIGZhc3Qvc2hhZG93 LWRvbS9zaGFkb3ctcm9vdC13aXRoLWNoaWxkLXdoaXRlc3BhY2UtdGV4dC1jcmFzaC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9zaGFkb3ctcm9vdC13aXRo LWNoaWxkLXdoaXRlc3BhY2UtdGV4dC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxNS0xMC0wMiAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBOZXcgYmFz ZWxpbmVzIGZvciBzb21lIGNvbXBvc2l0aW5nIHRlc3RzLgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9zaGFkb3ctZG9tL3NoYWRvdy1yb290LXdpdGgtY2hpbGQtd2hpdGVzcGFjZS10ZXh0LWNyYXNo LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20v c2hhZG93LXJvb3Qtd2l0aC1jaGlsZC13aGl0ZXNwYWNlLXRleHQtY3Jhc2gtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL3NoYWRvdy1yb290 LXdpdGgtY2hpbGQtd2hpdGVzcGFjZS10ZXh0LWNyYXNoLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDMgQEAKK1RoaXMgdGVzdHMgY3JlYXRpbmcgYSBzaGFkb3cgcm9vdCB3 aXRoIGxlYWRpbmcgYW5kIHRyYWlsaW5nIHdoaXRlIHNwYWNlcy4gV2ViS2l0IHNob3VsZCBub3Qg Y3Jhc2guIFlvdSBzaG91bGQgc2VlIFBBU1MgYmVsb3cuCisKK1BBU1MKSW5kZXg6IExheW91dFRl c3RzL2Zhc3Qvc2hhZG93LWRvbS9zaGFkb3ctcm9vdC13aXRoLWNoaWxkLXdoaXRlc3BhY2UtdGV4 dC1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9z aGFkb3ctcm9vdC13aXRoLWNoaWxkLXdoaXRlc3BhY2UtdGV4dC1jcmFzaC5odG1sCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL3NoYWRvdy1yb290LXdpdGgtY2hp bGQtd2hpdGVzcGFjZS10ZXh0LWNyYXNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwx NyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+CitUaGlzIHRlc3RzIGNy ZWF0aW5nIGEgc2hhZG93IHJvb3Qgd2l0aCBsZWFkaW5nIGFuZCB0cmFpbGluZyB3aGl0ZSBzcGFj ZXMuCitXZWJLaXQgc2hvdWxkIG5vdCBjcmFzaC4gWW91IHNob3VsZCBzZWUgUEFTUyBiZWxvdy4K KzwvcD4KKzxkaXYgaWQ9Imhvc3QiPlBBU1M8L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRl c3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKK3ZhciBob3N0ID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2hvc3QnKTsKK2hvc3QuYXR0YWNoU2hhZG93KHttb2RlOiAn Y2xvc2VkJ30pLmlubmVySFRNTCA9IGAgPHNsb3Q+PC9zbG90PiBgOworPC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==