149703 2015-10-01 04:56:26 -0700 [GTK] DOM operations could behave unexpectedly with certain fonts or font sizes 2017-09-10 21:18:15 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Major --- 176351 1 tpopela tpopela andrea.vai bugs-noreply cgarcia d.lesca lantw44 mcatanzaro mrobinson nekohayo yoon oldest_to_newest 1129898 0 262248 tpopela 2015-10-01 04:56:26 -0700 Created attachment 262248 test-case There is a bug in ?freetype/cairo/webkit? that for some fonts and font sizes the DOM operations does not behave as it should. The cause is well document in https://bugs.webkit.org/show_bug.cgi?id=102374 . As it is mentioned in https://bugs.webkit.org/show_bug.cgi?id=102374#c44 and https://bugs.webkit.org/show_bug.cgi?id=102374#c45 things should be fixed for freetype >= 2.4.6, but the truth is that the change in freetype was reverted later ( as you can read in http://lists.nongnu.org/archive/html/freetype-devel/2013-01/msg00070.html ). I'm attaching a test case that will fail on trunk as well as on WK1 (it the background should be red and caret should be on the end of the first line instead of second line). Actually this is what we are using in Evolution and it is broken for someone ( https://bugzilla.gnome.org/show_bug.cgi?id=749712 ). I think that there are two ways of solving it. Do it like EFL: basically enabling subpixel layout (applying http://trac.webkit.org/changeset/140111 ) or what I've tried on current master is to apply the proposed patch from https://bugs.webkit.org/show_bug.cgi?id=102374#c44 . With the latter the test case succeeded. What are your opinions? Especially Martin's as he was quite active around it. 1130955 1 mrobinson 2015-10-06 08:07:29 -0700 I think it is worth testing subpixel layout. Do you have a sense for how many test results change? 1131263 2 tpopela 2015-10-07 04:47:57 -0700 (In reply to comment #0) > I think that there are two ways of solving it. Do it like EFL: basically > enabling subpixel layout (applying http://trac.webkit.org/changeset/140111 ) OK, so I was wrong as I thought that enabling subpixel layout fixes it. I compiled EFL port and they are also affected. I will ask some EFL developer to confirm it. 1131269 3 ossy 2015-10-07 05:39:05 -0700 I checked it on EFL, the background is red and the caret is at the end of the first line. 1132756 4 d.lesca 2015-10-13 05:39:05 -0700 I use Gnome Evolution 3.16.5 on Fedora 22, and I have found many undu/redo bugs into html email, especially when I reply to and the message have indent text. This is my rpm situation: [lesca@dodo ~]$ rpm -qa |grep -i webki webkitgtk4-2.8.5-2.fc22.x86_64 webkitgtk-2.4.9-2.fc22.x86_64 kdelibs-webkit-4.14.12-1.fc22.x86_64 qtwebkit-devel-2.3.4-6.fc22.x86_64 webkitgtk3-2.4.9-2.fc22.x86_64 qtwebkit-2.3.4-6.fc22.x86_64 pywebkitgtk-1.1.8-9.fc22.x86_64 qt5-qtwebkit-5.5.0-4.fc22.x86_64 I must report all problem found in this bug? Thanks 1132757 5 tpopela 2015-10-13 05:46:51 -0700 (In reply to comment #4) > I use Gnome Evolution 3.16.5 on Fedora 22, and I have found many undu/redo > bugs into html email, especially when I reply to and the message have indent > text. > > This is my rpm situation: > [lesca@dodo ~]$ rpm -qa |grep -i webki > webkitgtk4-2.8.5-2.fc22.x86_64 > webkitgtk-2.4.9-2.fc22.x86_64 > kdelibs-webkit-4.14.12-1.fc22.x86_64 > qtwebkit-devel-2.3.4-6.fc22.x86_64 > webkitgtk3-2.4.9-2.fc22.x86_64 > qtwebkit-2.3.4-6.fc22.x86_64 > pywebkitgtk-1.1.8-9.fc22.x86_64 > qt5-qtwebkit-5.5.0-4.fc22.x86_64 > > I must report all problem found in this bug? > > Thanks No, report these bugs agains Evolution component in Gnome bugzilla. The consequences of this bug in Evolution are already mentioned in comment #0 and there is no need to repeat them again. 1346250 6 tpopela 2017-09-07 02:09:35 -0700 Fixed with bug 176351 (requiring freetype 2.8) 1346737 7 tpopela 2017-09-08 00:00:01 -0700 Reopen this bug as I want to add a new layout test for this bug. 1346747 8 320250 tpopela 2017-09-08 01:05:00 -0700 Created attachment 320250 Patch 1346885 9 320250 mcatanzaro 2017-09-08 11:26:34 -0700 Comment on attachment 320250 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320250&action=review It's not often that people contribute regression tests except when trying to get a functional change into WebKit. Thanks! Also good to see the test passes the Apple EWS bots on the first try. > LayoutTests/fast/dom/Document/CaretRangeFromPoint/restore-selection-from-point.html:56 > + <div style="width: 72ch; word-wrap: normal;" >12</div> > + <div style="width: 72ch; word-wrap: normal;" >34<span id="selection-start"></span><span id="selection-end"></span></div> The 12 and 34 are arbitrary, right? That's a bit confusing. 1347347 10 tpopela 2017-09-10 21:11:33 -0700 (In reply to Michael Catanzaro from comment #9) > > LayoutTests/fast/dom/Document/CaretRangeFromPoint/restore-selection-from-point.html:56 > > + <div style="width: 72ch; word-wrap: normal;" >12</div> > > + <div style="width: 72ch; word-wrap: normal;" >34<span id="selection-start"></span><span id="selection-end"></span></div> > > The 12 and 34 are arbitrary, right? That's a bit confusing. Yes, they are.. Before landing I will rework it so it takes the current content of the second line and it does not hardcode the content. 1347348 11 tpopela 2017-09-10 21:18:15 -0700 Committed r221843: <http://trac.webkit.org/changeset/221843> 262248 2015-10-01 04:56:26 -0700 2015-10-01 04:56:26 -0700 test-case evo_undo_redo.html text/html 1619 tpopela PGh0bWw+CjxoZWFkPgogIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgIHZhciB4 PTA7CiAgICB2YXIgeT0wOwoKICAgIGZ1bmN0aW9uIHNhdmVPZmZzZXQoZWxlbWVudCkgewogICAg ICB2YXIgdG1wPWVsZW1lbnQ7CiAgICAgIHdoaWxlICh0bXAgIT09IGRvY3VtZW50LmJvZHkpIHsK ICAgICAgICB4Kz10bXAub2Zmc2V0TGVmdDsKICAgICAgICB5Kz10bXAub2Zmc2V0VG9wOwogICAg ICAgIHRtcD10bXAub2Zmc2V0UGFyZW50OwogICAgICB9CiAgICAgIGNvbnNvbGUubG9nKHgsIHkp OwogICAgfQoKICAgIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpewogICAgICBzdGFydD1kb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiLXgtZXZvLXNlbGVjdGlvbi1zdGFydC1tYXJrZXIiKQogICAg ICBlbmQ9ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIi14LWV2by1zZWxlY3Rpb24tZW5kLW1hcmtl ciIpCgogICAgICByYW5nZT1kb2N1bWVudC5jcmVhdGVSYW5nZSgpCiAgICAgIHJhbmdlLnNldFN0 YXJ0QWZ0ZXIoc3RhcnQpCiAgICAgIHNhdmVPZmZzZXQoc3RhcnQpCiAgICAgIHN0YXJ0LnJlbW92 ZSgpCiAgICAgIHJhbmdlLnNldEVuZEJlZm9yZShlbmQpCiAgICAgIGVuZC5yZW1vdmUoKQogICAg ICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkucmVtb3ZlQWxsUmFuZ2VzKCkKICAgICAgd2luZG93Lmdl dFNlbGVjdGlvbigpLmFkZFJhbmdlKHJhbmdlKQoKICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo IlNlbGVjdEFsbCIsIGZhbHNlLCAiIikKCiAgICAgIGlmIChkb2N1bWVudC5jYXJldFJhbmdlRnJv bVBvaW50KQogICAgICAgIHJhbmdlPWRvY3VtZW50LmNhcmV0UmFuZ2VGcm9tUG9pbnQoeCx5KQog ICAgICBlbHNlCiAgICAgICAgcmFuZ2U9ZG9jdW1lbnQuY2FyZXRQb3NpdGlvbkZyb21Qb2ludCh4 LHkpCiAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5yZW1vdmVBbGxSYW5nZXMoKQogICAgICB3 aW5kb3cuZ2V0U2VsZWN0aW9uKCkuYWRkUmFuZ2UocmFuZ2UpCgogICAgICBpZiAod2luZG93Lmdl dFNlbGVjdGlvbigpLmFuY2hvck5vZGUudGV4dENvbnRlbnQgIT0gJzM0JykKICAgICAgICBkb2N1 bWVudC5ib2R5LmJnQ29sb3I9J3JlZCcKICAgIH0KCiAgPC9zY3JpcHQ+CiAgPHN0eWxlIG1lZGlh PSJzY3JlZW4iIHR5cGU9InRleHQvY3NzIj4KICAgIGJvZHkgewogICAgICBmb250LWZhbWlseTog J01vbm9zcGFjZSc7CiAgICAgIGZvbnQtc2l6ZTogMTFwdDsKICAgICAgZm9udC13ZWlnaHQ6IDQw MDsKICAgICAgZm9udC1zdHlsZTogbm9ybWFsOwogICAgICAtd2Via2l0LWxpbmUtYnJlYWs6IGFm dGVyLXdoaXRlLXNwYWNlOwogICAgfQogIDwvc3R5bGU+CjwvaGVhZD4KPGJvZHkgc3BlbGxjaGVj az0idHJ1ZSIgY29udGVudGVkaXRhYmxlPgogIDxkaXYgc3R5bGU9IndpZHRoOiA3MmNoOyB3b3Jk LXdyYXA6IG5vcm1hbDsgIiA+MTI8L2Rpdj4KICA8ZGl2IHN0eWxlPSJ3aWR0aDogNzJjaDsgd29y ZC13cmFwOiBub3JtYWw7ICIgPjM0PHNwYW4gaWQ9Ii14LWV2by1zZWxlY3Rpb24tc3RhcnQtbWFy a2VyIj48L3NwYW4+PHNwYW4gaWQ9Ii14LWV2by1zZWxlY3Rpb24tZW5kLW1hcmtlciI+PC9zcGFu PjwvZGl2Pgo8L2JvZHk+PC9odG1sPgo= 320250 2017-09-08 01:05:00 -0700 2017-09-08 11:26:34 -0700 Patch bug-149703-20170908100459.patch text/plain 3922 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNzc5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjMzMWMwYjk5YzFiOTUzYWM5NDQ2 ZDFjZTdjNWMzYmJlZmM1YWE2Mi4uYTMzMjlmNjNhYjUxNjFlOTdhZDMwNTc1NTIyOGM2YjJiNDQ3 OTA3MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA5LTA4ICBUb21hcyBQb3BlbGEgIDx0 cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gRE9NIG9wZXJhdGlvbnMgY291bGQg YmVoYXZlIHVuZXhwZWN0ZWRseSB3aXRoIGNlcnRhaW4gZm9udHMgb3IgZm9udCBzaXplcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NzAzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3JlIHIyMjE2 NzAgKEZyZWVUeXBlIHJlYmFzZSkgdGhpcyB0ZXN0IGNhc2Ugd291bGQgZmFpbCBkdWUgdG8KKyAg ICAgICAgYnVnIGluIEZyZWVUeXBlIHdoZXJlIGl0IHdhcyBwcm92aWRpbmcgd3JvbmcgZm9udCBl eHRlbnRzIGZvciBzcGVjaWZpYworICAgICAgICBmb250cyBhbmQgc2l6ZXMuIEJlZm9yZSB0aGUg cmViYXNlIHRoZSBzZWxlY3Rpb24gd2FzIGluY29ycmVjdGx5CisgICAgICAgIHJlc3RvcmVkIG9u IHRoZSBlbmQgb2YgdGhlIGZpcnN0IGxpbmUuIEFkZGluZyB0aGlzIG5ldyB0ZXN0IHRvIGNhdGNo CisgICAgICAgIGFueSBwb3NzaWJsZSByZWdyZXNzaW9uIGluIHRoZSBGcmVlVHlwZS4KKworICAg ICAgICAqIGZhc3QvZG9tL0RvY3VtZW50L0NhcmV0UmFuZ2VGcm9tUG9pbnQvcmVzdG9yZS1zZWxl Y3Rpb24tZnJvbS1wb2ludC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9t L0RvY3VtZW50L0NhcmV0UmFuZ2VGcm9tUG9pbnQvcmVzdG9yZS1zZWxlY3Rpb24tZnJvbS1wb2lu dC5odG1sOiBBZGRlZC4KKwogMjAxNy0wOS0wNyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgUmVnRXhwIG5hbWVkIGNhcHR1cmUg Z3JvdXBzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9Eb2N1bWVudC9DYXJldFJh bmdlRnJvbVBvaW50L3Jlc3RvcmUtc2VsZWN0aW9uLWZyb20tcG9pbnQtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9kb20vRG9jdW1lbnQvQ2FyZXRSYW5nZUZyb21Qb2ludC9yZXN0b3Jl LXNlbGVjdGlvbi1mcm9tLXBvaW50LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZWYyMmU5YTQz MWFkMDI3MjcxM2I3MWZkYzg3OTQwMTZjOGVmMTJmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9kb20vRG9jdW1lbnQvQ2FyZXRSYW5nZUZyb21Qb2ludC9yZXN0b3JlLXNlbGVj dGlvbi1mcm9tLXBvaW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9Eb2N1bWVudC9DYXJldFJhbmdlRnJvbVBvaW50L3Jl c3RvcmUtc2VsZWN0aW9uLWZyb20tcG9pbnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0Rv Y3VtZW50L0NhcmV0UmFuZ2VGcm9tUG9pbnQvcmVzdG9yZS1zZWxlY3Rpb24tZnJvbS1wb2ludC5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjJhODc3NDA5MTgyODFlY2ZlYzEyYTlhMDA1ZTM3YWYxZmFjNGIyOGMK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9Eb2N1bWVudC9DYXJldFJh bmdlRnJvbVBvaW50L3Jlc3RvcmUtc2VsZWN0aW9uLWZyb20tcG9pbnQuaHRtbApAQCAtMCwwICsx LDU4IEBACis8aHRtbD4KKzxoZWFkPgorICAgIDxzdHlsZT4KKyAgICAgICAgYm9keSB7CisgICAg ICAgICAgICBmb250LWZhbWlseTogJ01vbm9zcGFjZSc7CisgICAgICAgICAgICBmb250LXNpemU6 IDExcHQ7CisgICAgICAgICAgICBmb250LXdlaWdodDogNDAwOworICAgICAgICAgICAgZm9udC1z dHlsZTogbm9ybWFsOworICAgICAgICAgICAgLXdlYmtpdC1saW5lLWJyZWFrOiBhZnRlci13aGl0 ZS1zcGFjZTsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgICAg aWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCk7CisKKyAgICAgICAgdmFyIHggPSAwOworICAgICAgICB2YXIgeSA9IDA7CisKKyAgICAgICAg ZnVuY3Rpb24gc2F2ZU9mZnNldChlbGVtZW50KQorICAgICAgICB7CisgICAgICAgICAgICB2YXIg b2Zmc2V0UGFyZW50ID0gZWxlbWVudDsKKyAgICAgICAgICAgIHdoaWxlIChvZmZzZXRQYXJlbnQg IT09IGRvY3VtZW50LmJvZHkpIHsKKyAgICAgICAgICAgICAgICB4ICs9IG9mZnNldFBhcmVudC5v ZmZzZXRMZWZ0OworICAgICAgICAgICAgICAgIHkgKz0gb2Zmc2V0UGFyZW50Lm9mZnNldFRvcDsK KyAgICAgICAgICAgICAgICBvZmZzZXRQYXJlbnQgPSBvZmZzZXRQYXJlbnQub2Zmc2V0UGFyZW50 OworICAgICAgICAgICAgfQorICAgICAgICB9CisKKyAgICAgICAgd2luZG93Lm9ubG9hZCA9IGZ1 bmN0aW9uKCkKKyAgICAgICAgeworICAgICAgICAgICAgdmFyIHN0YXJ0ID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInNlbGVjdGlvbi1zdGFydCIpCisgICAgICAgICAgICB2YXIgZW5kID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlbGVjdGlvbi1lbmQiKQorCisgICAgICAgICAgICB2YXIg cmFuZ2UgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpCisgICAgICAgICAgICByYW5nZS5zZXRTdGFy dEFmdGVyKHN0YXJ0KQorICAgICAgICAgICAgc2F2ZU9mZnNldChzdGFydCkKKyAgICAgICAgICAg IHN0YXJ0LnJlbW92ZSgpCisgICAgICAgICAgICByYW5nZS5zZXRFbmRCZWZvcmUoZW5kKQorICAg ICAgICAgICAgZW5kLnJlbW92ZSgpCisgICAgICAgICAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCku cmVtb3ZlQWxsUmFuZ2VzKCkKKyAgICAgICAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5hZGRS YW5nZShyYW5nZSkKKworICAgICAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlNlbGVjdEFs bCIsIGZhbHNlLCAiIikKKworICAgICAgICAgICAgcmFuZ2UgPSBkb2N1bWVudC5jYXJldFJhbmdl RnJvbVBvaW50KHgseSkKKyAgICAgICAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5yZW1vdmVB bGxSYW5nZXMoKQorICAgICAgICAgICAgd2luZG93LmdldFNlbGVjdGlvbigpLmFkZFJhbmdlKHJh bmdlKQorCisgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICh3aW5kb3cuZ2V0 U2VsZWN0aW9uKCkuYW5jaG9yTm9kZS50ZXh0Q29udGVudCA9PSAnMzQnKSA/CisgICAgICAgICAg ICAgICAgIlBBU1MiIDogIkZBSUwgLSBzZWxlY3Rpb24gd2FzIHJlc3RvcmVkIG9uIHdyb25nIGxp bmUgLSBzZWUgPGEgaHJlZj1cImh0dHBzOi8vYnVncy53ZWJraXQub3JnLzE0OTcwM1wiPmJ1ZyAx NDk3MDM8L2E+IgorICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBjb250 ZW50ZWRpdGFibGU+CisgICAgPGRpdiBzdHlsZT0id2lkdGg6IDcyY2g7IHdvcmQtd3JhcDogbm9y bWFsOyIgPjEyPC9kaXY+CisgICAgPGRpdiBzdHlsZT0id2lkdGg6IDcyY2g7IHdvcmQtd3JhcDog bm9ybWFsOyIgPjM0PHNwYW4gaWQ9InNlbGVjdGlvbi1zdGFydCI+PC9zcGFuPjxzcGFuIGlkPSJz ZWxlY3Rpb24tZW5kIj48L3NwYW4+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==