149151 2015-09-14 21:45:51 -0700 [GTK] Extend default timeout value for release build. 2015-09-21 01:12:02 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 149112 1 changseok changseok cgarcia commit-queue glenn gustavo mrobinson pnormand zan oldest_to_newest 1125882 0 changseok 2015-09-14 21:45:51 -0700 Currently the default value of timeout for release build is 6000ms. But this is too short to pass some media tests. For example, ./LayoutTests/media/media-controls-timeline-updates.html and mine posted in bug149112. Those tests wait until a video play is done. However, the used video's runtime is 6.02 second so it fails with timeout. Thus, I propose to extend the default value to 7000ms. 1125884 1 261170 changseok 2015-09-14 21:50:04 -0700 Created attachment 261170 Patch 1125907 2 pnormand 2015-09-14 23:55:17 -0700 This seems more like a workaround. Shouldn't the test be fixed instead? 1125908 3 pnormand 2015-09-14 23:56:05 -0700 Instead of waiting normal playback is finished you should seek to video.duration - someSmallValue. 1125909 4 changseok 2015-09-15 00:16:43 -0700 (In reply to comment #3) > Instead of waiting normal playback is finished you should seek to > video.duration - someSmallValue. Well, it could be. but it sounds more like a workaround. The video has been used for a long time. there are many testes using it already. IMHO, fixing the test itself is not a good idea to avoid timeout for a specific port. Fixing the tests itself requires extra effort. Also, it is hard to believe for somebody working on other port to add some extra code manipulating runtime for gtk port in a his/her new test. 1125910 5 pnormand 2015-09-15 00:33:13 -0700 (In reply to comment #3) > Instead of waiting normal playback is finished you should seek to > video.duration - someSmallValue. This is (or used to be) a common technique in the media tests, fwiw. Doesn't feel like a workaround to me, we need tests to finish as fast as possible, waiting 6 or 7 seconds for a single test is bad if it can be easily avoided. 1126306 6 changseok 2015-09-16 00:43:59 -0700 (In reply to comment #5) > (In reply to comment #3) > > Instead of waiting normal playback is finished you should seek to > > video.duration - someSmallValue. > > This is (or used to be) a common technique in the media tests, fwiw. Doesn't > feel like a workaround to me, we need tests to finish as fast as possible, > waiting 6 or 7 seconds for a single test is bad if it can be easily avoided. O.K. I modified my test for bug149112. media-controls-timeline-updates.html should be changed later as well. 261170 2015-09-14 21:50:04 -0700 2015-09-21 01:12:02 -0700 Patch bug-149151-20150915134953.patch text/plain 2497 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NzM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTk1ZWM0MjAwNDNhNDZmZTAxZmJlYWM0MjE0NjlmNjk3 ZDRmZjUwMS4uOGI3MmNmY2IwNmI1YTQwYTc1YWNlY2RhM2IyYTg4OTdiOWU1ZmIyMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE1LTA5LTE0ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbR1RLXSBFeHRlbmQgZGVmYXVsdCB0aW1lb3V0IHZhbHVlIGZvciByZWxl YXNlIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ5MTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ3VycmVudGx5IHRoZSBkZWZhdWx0IHZhbHVlIG9mIHRpbWVvdXQgZm9yIHJlbGVhc2UgYnVp bGQgaXMgNjAwMG1zLiBCdXQgdGhpcyBpcyB0b28gc2hvcnQKKyAgICAgICAgdG8gcGFzcyBzb21l IG1lZGlhIHRlc3RzIHN1Y2ggYXMgbWVkaWEtY29udHJvbHMtdGltZWxpbmUtdXBkYXRlcy5odG1s LmkgU28gSSBwcm9wb3NlCisgICAgICAgIHRvIGV4dGVuZCB0aGUgdmFsdWUgdG8gNzAwMG1zLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weToKKyAgICAgICAgKEd0a1Bv cnQuZGVmYXVsdF90aW1lb3V0X21zKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQv Z3RrX3VuaXR0ZXN0LnB5OgorICAgICAgICAoR3RrUG9ydFRlc3QudGVzdF9kZWZhdWx0X3RpbWVv dXRfbXMpOgorCiAyMDE1LTA5LTEyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBs ZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBBbGxvdyB0ZXN0aW5nIHdpdGggdGhlIHN5c3RlbSBs YW5ndWFnZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkKaW5kZXggMDg2MTZhZmNlNjc0NzU3 NGIyZjljNWEzNGI4YWIzMTkwMDlkNjRkZS4uNTQ1NjM2MmUzZGJkMTRiMGZmMzY3OTE3YzEwNDQ1 YTAwNjRhYTEwNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CkBAIC05MCw3ICs5MCw3 IEBAIGNsYXNzIEd0a1BvcnQoUG9ydCk6CiAgICAgICAgIG11bHRpcGxpZXIgPSAxMCBpZiBzZWxm LmdldF9vcHRpb24oImxlYWtzIikgZWxzZSAxCiAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbign Y29uZmlndXJhdGlvbicpID09ICdEZWJ1Zyc6CiAgICAgICAgICAgICByZXR1cm4gbXVsdGlwbGll ciAqIDEyICogMTAwMAotICAgICAgICByZXR1cm4gbXVsdGlwbGllciAqIDYgKiAxMDAwCisgICAg ICAgIHJldHVybiBtdWx0aXBsaWVyICogNyAqIDEwMDAKIAogICAgIGRlZiBkcml2ZXJfc3RvcF90 aW1lb3V0KHNlbGYpOgogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oImxlYWtzIik6CmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrX3VuaXR0ZXN0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0a191bml0dGVzdC5weQppbmRleCA0MWYyNDYwNDA3 ZGZhOTY0YjExZWVlOGRkMTE0MDdkNWQyYmI5NThiLi5hMWYxMDEwYzdiMmY4NTZhY2FmYzk3MTc4 NTRmYmJhZTMyZTNiNjk5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv Z3RrX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGtfdW5p dHRlc3QucHkKQEAgLTY4LDcgKzY4LDcgQEAgY2xhc3MgR3RrUG9ydFRlc3QocG9ydF90ZXN0Y2Fz ZS5Qb3J0VGVzdENhc2UpOgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMo c2VsZiwgcG9ydC5zaG93X3Jlc3VsdHNfaHRtbF9maWxlLCBbInRlc3QuaHRtbCJdLCBleHBlY3Rl ZF9sb2dzPWV4cGVjdGVkX2xvZ3MpCiAKICAgICBkZWYgdGVzdF9kZWZhdWx0X3RpbWVvdXRfbXMo c2VsZik6Ci0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5tYWtlX3BvcnQob3B0aW9ucz1N b2NrT3B0aW9ucyhjb25maWd1cmF0aW9uPSdSZWxlYXNlJykpLmRlZmF1bHRfdGltZW91dF9tcygp LCA2MDAwKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYubWFrZV9wb3J0KG9wdGlvbnM9 TW9ja09wdGlvbnMoY29uZmlndXJhdGlvbj0nUmVsZWFzZScpKS5kZWZhdWx0X3RpbWVvdXRfbXMo KSwgNzAwMCkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWxmLm1ha2VfcG9ydChvcHRpb25z PU1vY2tPcHRpb25zKGNvbmZpZ3VyYXRpb249J0RlYnVnJykpLmRlZmF1bHRfdGltZW91dF9tcygp LCAxMjAwMCkKIAogICAgIGRlZiB0ZXN0X2dldF9jcmFzaF9sb2coc2VsZik6Cg==