149044 2015-09-10 13:44:04 -0700 REGRESSION(r189575): Appears to break ARM64 linux builds 2015-09-11 04:43:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Other Linux RESOLVED FIXED P2 Normal --- 108645 148666 1 msaboff msaboff ossy oldest_to_newest 1125006 0 msaboff 2015-09-10 13:44:04 -0700 Looking at build bot output, it appears that r189575 broke ARM64 linux builds. Like this is fixed by replacing 4 occurrences of "fp" with "x29" in llintLowLevelInterpreter.asm. Build output at https://build.webkit.org/builders/EFL%20Linux%20AArch64%20Release/builds/3263/steps/compile-webkit/logs/stdio: FAILED: /usr/lib/icecc/bin_aarch64/aarch64-linux-gnu-g++ -w --sysroot=/ -I/usr/include -I/usr/include/aarch64-linux-gnu -DBUILDING_EFL__=1 -DBUILDING_JavaScriptCore -DBUILDING_WITH_CMAKE=1 -DDATA_DIR=\"/usr/local/share/ewebkit2-1\" -DDEFAULT_THEME_DIR=\"/home/oszi/slaves/efl-arm64/buildslave/efl-linux-aarch64-release/build/WebKitBuild/Release/WebCore/platform/efl/DefaultTheme\" -DHAVE_CONFIG_H=1 -DJavaScriptCore_EXPORTS -DSTATICALLY_LINKED_WITH_WTF -DUSE_CROSS_PLATFORM_CONTEXT_MENUS=1 -DUSE_GSTREAMER_MPEGTS -DUSE_WEBAUDIO_GSTREAMER=1 -DWEBKIT_EXEC_PATH=\"/home/oszi/slaves/efl-arm64/buildslave/efl-linux-aarch64-release/build/WebKitBuild/Release/bin\" -DWEB_INSPECTOR_DIR=\"/home/oszi/slaves/efl-arm64/buildslave/efl-linux-aarch64-release/build/WebKitBuild/Release/share/ewebkit2-1/inspector\" -std=c++11 -std=c++11 -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-rtti -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-rtti -fPIC -I. -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/.. -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/ForwardingHeaders -I../../Source/JavaScriptCore/assembler -I../../Source/JavaScriptCore/bindings -I../../Source/JavaScriptCore/builtins -I../../Source/JavaScriptCore/bytecode -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/dfg -I../../Source/JavaScriptCore/disassembler -I../../Source/JavaScriptCore/ftl -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/debugger -I../../Source/JavaScriptCore/inspector -I../../Source/JavaScriptCore/inspector/agents -I../../Source/JavaScriptCore/inspector/augmentable -I../../Source/JavaScriptCore/inspector/remote -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit -I../../Source/JavaScriptCore/llint -I../../Source/JavaScriptCore/llvm -I../../Source/JavaScriptCore/parser -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/replay -I../../Source/JavaScriptCore/runtime -I../../Source/JavaScriptCore/tools -I../../Source/JavaScriptCore/wasm -I../../Source/JavaScriptCore/yarr -IDerivedSources -IDerivedSources/ForwardingHeaders -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector -I../../Source/JavaScriptCore/disassembler/udis86 -I../DependenciesEFL/Root/include/efl-1 -I../DependenciesEFL/Root/include/ecore-1 -I../DependenciesEFL/Root/include/glib-2.0 -I../DependenciesEFL/Root/lib/glib-2.0/include -I../DependenciesEFL/Root/include/eina-1 -I../DependenciesEFL/Root/include/eina-1/eina -I../DependenciesEFL/Root/include/eo-1 -I../../Source/WTF -I../../Source/WTF/wtf/efl -isystem /usr/include/aarch64-linux-gnu -Werror -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings -MMD -MT Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o -MF "Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o.d" -o Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o -c ../../Source/JavaScriptCore/llint/LowLevelInterpreter.cpp /tmp/ccjhCOrJ.s: Assembler messages: /tmp/ccjhCOrJ.s:664: Error: integer 64-bit register expected at operand 3 -- `stp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:665: Error: integer 64-bit register expected at operand 3 -- `stp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:719: Error: integer 64-bit register expected at operand 3 -- `stp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:720: Error: integer 64-bit register expected at operand 3 -- `stp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:774: Error: integer 64-bit register expected at operand 3 -- `stp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:775: Error: integer 64-bit register expected at operand 3 -- `stp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:834: Error: integer 64-bit register expected at operand 3 -- `stp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:835: Error: integer 64-bit register expected at operand 3 -- `stp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:912: Error: integer 64-bit register expected at operand 3 -- `stp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:913: Error: integer 64-bit register expected at operand 3 -- `stp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:991: Error: integer 64-bit register expected at operand 3 -- `stp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:992: Error: integer 64-bit register expected at operand 3 -- `stp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:1111: Error: integer 64-bit register expected at operand 3 -- `stp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:1112: Error: integer 64-bit register expected at operand 3 -- `stp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:4445: Error: integer 64-bit register expected at operand 3 -- `ldp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:4446: Error: integer 64-bit register expected at operand 3 -- `ldp x27,x28,[fp,#-16]' /tmp/ccjhCOrJ.s:4558: Error: integer 64-bit register expected at operand 3 -- `ldp xzr,x26,[fp,#-32]' /tmp/ccjhCOrJ.s:4559: Error: integer 64-bit register expected at operand 3 -- `ldp x27,x28,[fp,#-16]' ninja: build stopped: subcommand failed. program finished with exit code 1 1125008 1 260948 msaboff 2015-09-10 13:48:32 -0700 Created attachment 260948 Patch with speculative fix for ARM64 Linux 1125009 2 msaboff 2015-09-10 13:50:40 -0700 Committed r189588: <http://trac.webkit.org/changeset/189588> 1125039 3 ossy 2015-09-10 15:00:53 -0700 (In reply to comment #2) > Committed r189588: <http://trac.webkit.org/changeset/189588> Thanks for the fix. 260948 2015-09-10 13:48:32 -0700 2015-09-10 13:49:20 -0700 Patch with speculative fix for ARM64 Linux 149044.patch text/plain 1757 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5NTg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTA5LTEwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjE4OTU3NSk6IEFwcGVhcnMgdG8gYnJlYWsgQVJNNjQgbGludXggYnVp bGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkw NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu Z2VkIHRoZSB1c2Ugb2YgdGhlIEFSTTY0ICJmcCIsIGEgcmVnaXN0ZXIgYWxpYXMsIHRvIGJlICJ4 MjkiLCB0aGUgcmVhbCByZWdpc3RlciBuYW1lLgorCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlci5hc206CisKIDIwMTUtMDktMDkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBUaGVyZSBzaG91bGQgYmUgb25lIHN0dWIgaGFuZ2luZyBvZmYgYW4g aW5saW5lIGNhY2hlIHRoYXQgY29udGFpbnMgY29kZSBmb3IgYWxsIG9mIHRoZSBjYXNlcywgcmF0 aGVyIHRoYW4gZm9ybWluZyBhIGxpbmtlZCBsaXN0IGNvbnNpc3Rpbmcgb2Ygb25lIHN0dWIgcGVy IGNhc2UKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl dGVyLmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlci5hc20JKHJldmlzaW9uIDE4OTU4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkod29ya2luZyBjb3B5KQpAQCAtNTE3 LDggKzUxNyw4IEBAIG1hY3JvIHByZXNlcnZlQ2FsbGVlU2F2ZXNVc2VkQnlMTEludCgpCiAgICAg ZWxzaWYgQVJNIG9yIEFSTXY3X1RSQURJVElPTkFMCiAgICAgZWxzaWYgQVJNdjcKICAgICBlbHNp ZiBBUk02NAotICAgICAgICBlbWl0ICJzdHAgeDI3LCB4MjgsIFtmcCwgIy0xNl0iCi0gICAgICAg IGVtaXQgInN0cCB4enIsIHgyNiwgW2ZwLCAjLTMyXSIKKyAgICAgICAgZW1pdCAic3RwIHgyNywg eDI4LCBbeDI5LCAjLTE2XSIKKyAgICAgICAgZW1pdCAic3RwIHh6ciwgeDI2LCBbeDI5LCAjLTMy XSIKICAgICBlbHNpZiBNSVBTCiAgICAgZWxzaWYgU0g0CiAgICAgZWxzaWYgWDg2CkBAIC01Mzks OCArNTM5LDggQEAgbWFjcm8gcmVzdG9yZUNhbGxlZVNhdmVzVXNlZEJ5TExJbnQoKQogICAgIGVs c2lmIEFSTSBvciBBUk12N19UUkFESVRJT05BTAogICAgIGVsc2lmIEFSTXY3CiAgICAgZWxzaWYg QVJNNjQKLSAgICAgICAgZW1pdCAibGRwIHh6ciwgeDI2LCBbZnAsICMtMzJdIgotICAgICAgICBl bWl0ICJsZHAgeDI3LCB4MjgsIFtmcCwgIy0xNl0iCisgICAgICAgIGVtaXQgImxkcCB4enIsIHgy NiwgW3gyOSwgIy0zMl0iCisgICAgICAgIGVtaXQgImxkcCB4MjcsIHgyOCwgW3gyOSwgIy0xNl0i CiAgICAgZWxzaWYgTUlQUwogICAgIGVsc2lmIFNINAogICAgIGVsc2lmIFg4Ngo=