14891 2007-08-06 14:48:26 -0700 Decompilation of try block immediately following "else" fails 2007-08-07 22:36:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) All All CLOSED FIXED InRadar P2 Normal --- 13638 1 oliver webkit-unassigned gavin.sharp jwalden+bwo oldest_to_newest 2923 0 oliver 2007-08-06 14:48:26 -0700 Decompilation of function(){if (y) {} else try {} finally {}} incorrectly deompiles to if (y) { } elsetry { } finally { } Notice the absence of whitespace between else and try. 2915 1 15855 sam 2007-08-06 23:05:40 -0700 Created attachment 15855 patch 2914 2 15855 oliver 2007-08-06 23:09:01 -0700 Comment on attachment 15855 patch r&#65309;&#12417;&#65281; 2912 3 sam 2007-08-06 23:17:26 -0700 <rdar://problem/5391038> 2913 4 15855 aroben 2007-08-06 23:24:12 -0700 Comment on attachment 15855 patch + (TryNode::streamTo): Add newline before else. Looks to me like you added a newline before "try" 2910 5 sam 2007-08-06 23:26:50 -0700 Landed in r24904. 15855 2007-08-06 23:05:40 -0700 2007-08-06 23:09:01 -0700 patch tryElse.diff text/plain 3507 sam SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTAzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMDgtMDYgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0ODkxCisgICAgICAgIERlY29tcGlsYXRpb24gb2YgdHJ5IGJsb2NrIGltbWVkaWF0ZWx5 IGZvbGxvd2luZyAiZWxzZSIgZmFpbHMKKworICAgICAgICBUZXN0OiBmYXN0L2pzL3RvU3RyaW5n LXRyeS1lbHNlLmh0bWwKKworICAgICAgICAqIGtqcy9ub2RlczJzdHJpbmcuY3BwOgorICAgICAg ICAoVHJ5Tm9kZTo6c3RyZWFtVG8pOiBBZGQgbmV3bGluZSBiZWZvcmUgZWxzZS4KKwogMjAwNy0w OC0wNyAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE1hY2llai4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCShyZXZpc2lvbiAy NDg5OSkKKysrIEphdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC03NDUsNyArNzQ1LDcgQEAgdm9pZCBUaHJvd05vZGU6OnN0cmVhbVRvKFNvdXJjZVN0 cmVhbSAmcwogCiB2b2lkIFRyeU5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSAmcykgY29uc3QK IHsKLSAgcyA8PCAidHJ5ICIgPDwgdHJ5QmxvY2s7CisgIHMgPDwgU291cmNlU3RyZWFtOjpFbmRs IDw8ICJ0cnkgIiA8PCB0cnlCbG9jazsKICAgaWYgKGNhdGNoQmxvY2spCiAgICAgcyA8PCBTb3Vy Y2VTdHJlYW06OkVuZGwgPDwgImNhdGNoICgiIDw8IGV4Y2VwdGlvbklkZW50IDw8ICIpIiA8PCBj YXRjaEJsb2NrOwogICBpZiAoZmluYWxseUJsb2NrKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ5MDMp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBA QAorMjAwNy0wOC0wNiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgZm9yIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODkxCisgICAgICAgIERlY29tcGlsYXRpb24g b2YgdHJ5IGJsb2NrIGltbWVkaWF0ZWx5IGZvbGxvd2luZyAiZWxzZSIgZmFpbHMKKworICAgICAg ICAqIGZhc3QvanMvdG9TdHJpbmctdHJ5LWVsc2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2pzL3RvU3RyaW5nLXRyeS1lbHNlLmh0bWw6IEFkZGVkLgorCiAyMDA3LTA4LTA2 ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xp dmVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy90b1N0cmluZy10cnktZWxzZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy90b1N0cmluZy10cnktZWxz ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3RvU3Ry aW5nLXRyeS1lbHNlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAor VGhpcyB0ZXN0IGNoZWNrcyB0aGF0IHRvU3RyaW5nKCkgcm91bmQtdHJpcCBvbiBhIGZ1bmN0aW9u IHRoYXQgaGFzIGEgZWxzZSBjbGF1c2UgZGlyZWN0bHkgZm9sbG93ZWQgYnkgYW4gZWxzZSBjbGF1 c2UgcHV0cyB3aGl0ZXNwYWNlIGJldHdlZW4gdGhlIHR3byBvbiBkZWNvbXBpbGF0aW9uLgorCitP biBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xs b3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB1bmV2YWxmKGV2YWwodW5ldmFsZih0 ZXN0VHJ5RWxzZSkpKSBpcyB1bmV2YWxmKHRlc3RUcnlFbHNlKQorUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv anMvdG9TdHJpbmctdHJ5LWVsc2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L2pzL3RvU3RyaW5nLXRyeS1lbHNlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2pzL3RvU3RyaW5nLXRyeS1lbHNlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjkg QEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1s PgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9InJlc291cmNlcy9qcy10ZXN0 LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlk PSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigKKyAgICAiVGhp cyB0ZXN0IGNoZWNrcyB0aGF0IHRvU3RyaW5nKCkgcm91bmQtdHJpcCBvbiBhIGZ1bmN0aW9uIHRo YXQgaGFzIGEgZWxzZSBjbGF1c2UgZGlyZWN0bHkgXAorICAgIGZvbGxvd2VkIGJ5IGFuIGVsc2Ug Y2xhdXNlIHB1dHMgd2hpdGVzcGFjZSBiZXR3ZWVuIHRoZSB0d28gb24gZGVjb21waWxhdGlvbi4i CisgICAgKTsKKworCisgICAgZnVuY3Rpb24gdGVzdFRyeUVsc2UoKSB7IGlmICh4KSB7fSBlbHNl IHRyeSB7fSBmaW5hbGx5IHt9IH0KKworICAgIHVuZXZhbGYgPSBmdW5jdGlvbih4KSB7IHJldHVy biAnKCcgKyB4LnRvU3RyaW5nKCkgKyAnKSc7IH07CisgICAgCisgICAgLy8gVGVzdCByb3VuZCB0 cmlwLgorICAgIHNob3VsZEJlKCJ1bmV2YWxmKGV2YWwodW5ldmFsZih0ZXN0VHJ5RWxzZSkpKSIs ICJ1bmV2YWxmKHRlc3RUcnlFbHNlKSIpOworCisgICAgdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9 IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K