148792 2015-09-04 02:22:53 -0700 [ARM] Fix the ARM Traditional build after r189288 2015-09-04 04:16:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 148742 1 ossy ossy commit-queue fpizlo ggaren mark.lam zherczeg oldest_to_newest 1123381 0 ossy 2015-09-04 02:22:53 -0700 https://trac.webkit.org/changeset/189288 broke the ARM Traditional build. https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Traditional%20Release/builds/14916 build log: ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.h: In function 'void JSC::ctiPatchCallByReturnAddress(JSC::ReturnAddressPtr, JSC::FunctionPtr)': ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.h:1489:17: error: 'static void JSC::MacroAssemblerARM::repatchCall(JSC::CodeLocationCall, JSC::FunctionPtr)' is private ... I'm going to try to fix it in few days. 1123385 1 260581 ossy 2015-09-04 03:25:55 -0700 Created attachment 260581 Patch 1123393 2 260581 commit-queue 2015-09-04 04:16:10 -0700 Comment on attachment 260581 Patch Clearing flags on attachment: 260581 Committed r189342: <http://trac.webkit.org/changeset/189342> 1123394 3 commit-queue 2015-09-04 04:16:18 -0700 All reviewed patches have been landed. Closing bug. 260581 2015-09-04 03:25:55 -0700 2015-09-04 04:16:10 -0700 Patch bug-148792-20150904032554.patch text/plain 2267 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ODM4NDQ0YmExNDM2MjU3NTFmZTFkMTczY2FiZTIyN2E4ZTQ0ZDg3Li5kZTBlNWI3ZjQxMDJlYWVj OTk1ZGE4M2M5YmVlYTk3MTg0ZmZlZjVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wOS0wNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtBUk1dIEZpeCB0aGUgQVJNIFRyYWRpdGlvbmFsIGJ1aWxkIGFmdGVy IHIxODkyODgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0ODc5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6IE1ha2UgcmVwYXRjaENhbGwgcHVibGlj IHNpbWlsYXIgdG8gY2hhbmdlcyBpbiByMTg5Mjg4LgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2Vt YmxlckFSTTo6cmVwYXRjaENhbGwpOgorCiAyMDE1LTA5LTAzIEFsZWtzYW5kciBTa2FjaGtvdiAg IDxnc2thY2hrb3ZAZ21haWwuY29tPgogCiAgICAgICAgIFtFUzZdIEltcGxlbWVudCBFUzYgYXJy b3cgZnVuY3Rpb24gc3ludGF4LiBQcm90b3R5cGUgb2YgYXJyb3cgZnVuY3Rpb24gc2hvdWxkIGJl IHVuZGVmaW5lZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTS5oCmluZGV4IDkzZjVkODI5NGMzODc3OTFlY2ZiZGNjNWJkYjA5MDZmZDQw MzQwYWYuLjkxZmVmNGRkOTVmZTg1MWRmMmVjMDQ2ZjcyMTJiZjdmOWVlNTQwNzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgK QEAgLTE0MzIsNiArMTQzMiwxNiBAQCBwdWJsaWM6CiAgICAgICAgIFVOUkVBQ0hBQkxFX0ZPUl9Q TEFURk9STSgpOwogICAgIH0KIAorICAgIHN0YXRpYyB2b2lkIHJlcGF0Y2hDYWxsKENvZGVMb2Nh dGlvbkNhbGwgY2FsbCwgQ29kZUxvY2F0aW9uTGFiZWwgZGVzdGluYXRpb24pCisgICAgeworICAg ICAgICBBUk1Bc3NlbWJsZXI6OnJlbGlua0NhbGwoY2FsbC5kYXRhTG9jYXRpb24oKSwgZGVzdGlu YXRpb24uZXhlY3V0YWJsZUFkZHJlc3MoKSk7CisgICAgfQorCisgICAgc3RhdGljIHZvaWQgcmVw YXRjaENhbGwoQ29kZUxvY2F0aW9uQ2FsbCBjYWxsLCBGdW5jdGlvblB0ciBkZXN0aW5hdGlvbikK KyAgICB7CisgICAgICAgIEFSTUFzc2VtYmxlcjo6cmVsaW5rQ2FsbChjYWxsLmRhdGFMb2NhdGlv bigpLCBkZXN0aW5hdGlvbi5leGVjdXRhYmxlQWRkcmVzcygpKTsKKyAgICB9CisKICNpZiBFTkFC TEUoTUFTTV9QUk9CRSkKICAgICB2b2lkIHByb2JlKFByb2JlRnVuY3Rpb24sIHZvaWQqIGFyZzEg PSAwLCB2b2lkKiBhcmcyID0gMCk7CiAjZW5kaWYgLy8gRU5BQkxFKE1BU01fUFJPQkUpCkBAIC0x NDgxLDE1ICsxNDkxLDYgQEAgcHJpdmF0ZToKICAgICAgICAgQVJNQXNzZW1ibGVyOjpsaW5rQ2Fs bChjb2RlLCBjYWxsLm1fbGFiZWwsIGZ1bmN0aW9uLnZhbHVlKCkpOwogICAgIH0KIAotICAgIHN0 YXRpYyB2b2lkIHJlcGF0Y2hDYWxsKENvZGVMb2NhdGlvbkNhbGwgY2FsbCwgQ29kZUxvY2F0aW9u TGFiZWwgZGVzdGluYXRpb24pCi0gICAgewotICAgICAgICBBUk1Bc3NlbWJsZXI6OnJlbGlua0Nh bGwoY2FsbC5kYXRhTG9jYXRpb24oKSwgZGVzdGluYXRpb24uZXhlY3V0YWJsZUFkZHJlc3MoKSk7 Ci0gICAgfQotCi0gICAgc3RhdGljIHZvaWQgcmVwYXRjaENhbGwoQ29kZUxvY2F0aW9uQ2FsbCBj YWxsLCBGdW5jdGlvblB0ciBkZXN0aW5hdGlvbikKLSAgICB7Ci0gICAgICAgIEFSTUFzc2VtYmxl cjo6cmVsaW5rQ2FsbChjYWxsLmRhdGFMb2NhdGlvbigpLCBkZXN0aW5hdGlvbi5leGVjdXRhYmxl QWRkcmVzcygpKTsKLSAgICB9CiAKICNpZiBFTkFCTEUoTUFTTV9QUk9CRSkKICAgICBpbmxpbmUg VHJ1c3RlZEltbTMyIHRydXN0ZWRJbW0zMkZyb21QdHIodm9pZCogcHRyKQo=