148750 2015-09-03 14:19:13 -0700 Web Inspector: should crash on purpose if InjectedScriptSource.js is unparseable 2020-04-30 10:20:52 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210794 InRadar P2 Normal --- 147066 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1123162 0 bburg 2015-09-03 14:19:13 -0700 If the injected script cannot be parsed as a ScriptObject, the current behavior is to crash some time later. This patch adds a release assertion after trying to inject the script, and dumps the injected script source text that was embedded into the binary. 1123166 1 260523 bburg 2015-09-03 14:27:54 -0700 Created attachment 260523 Proposed Fix 1123185 2 260523 commit-queue 2015-09-03 15:29:01 -0700 Comment on attachment 260523 Proposed Fix Clearing flags on attachment: 260523 Committed r189295: <http://trac.webkit.org/changeset/189295> 1123186 3 commit-queue 2015-09-03 15:29:05 -0700 All reviewed patches have been landed. Closing bug. 1123235 4 webkit-bug-importer 2015-09-03 17:48:25 -0700 <rdar://problem/22569879> 260523 2015-09-03 14:27:54 -0700 2015-09-03 15:29:01 -0700 Proposed Fix bug-148750-20150903142753.patch text/plain 2092 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5Mjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZTg5NWY4YzIzODcxZWMzM2M1MDgxYWU3YTAwNTg1MzYyMjMwMjA1Li45NzQ3MDBiMzE1ZjE5ZmZh ODI2YmE3YWNkMTE5MDY1NjFjNzY4NGNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wOS0wMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBzaG91bGQgY3Jhc2ggb24gcHVycG9zZSBpZiBJbmplY3Rl ZFNjcmlwdFNvdXJjZS5qcyBpcyB1bnBhcnNlYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgYW4gaW5qZWN0ZWQgc2NyaXB0IGNhbm5vdCBiZSBw YXJzZWQgb3IgZXhlY3V0ZWQgd2l0aG91dCBleGNlcHRpb24sIHdlIHNob3VsZCBhYm9ydCBhcwor ICAgICAgICBzb29uIGFzIHBvc3NpYmxlLiBUaGlzIHBhdGNoIGFkZHMgYSByZWxlYXNlIGFzc2Vy dGlvbiBhZnRlciBjcmVhdGluZyB0aGUgaW5qZWN0ZWQKKyAgICAgICAgc2NyaXB0IGFuZCBkdW1w cyB0aGUgYmFkIGluamVjdGVkIHNjcmlwdCdzIHNvdXJjZSBhcyBpdCB3YXMgZW1iZWRkZWQgaW50 byB0aGUgYmluYXJ5LgorCisgICAgICAgICogaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0TWFuYWdl ci5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6OkluamVjdGVkU2NyaXB0TWFuYWdlcjo6aW5qZWN0 ZWRTY3JpcHRGb3IpOgorCiAyMDE1LTA5LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgR2V0IHJpZCBvZiBSZXBhdGNoQnVmZmVyIGFuZCByZXBsYWNlIGl0IHdp dGggc3RhdGljIGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9JbmplY3RlZFNjcmlwdE1hbmFnZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdE1hbmFnZXIuY3BwCmluZGV4IDFiYWMyZWNiZDJlZjA1 MmQxNjY2MWY0M2I1ZTcwZDkyNDkyZDNiNTguLjBhNzczNDk3OGViMGUzMjNhY2IzZjQ3MGJjMWY2 MThhY2I0NGQ1MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv SW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5z cGVjdG9yL0luamVjdGVkU2NyaXB0TWFuYWdlci5jcHAKQEAgLTE3Nyw2ICsxNzcsMTIgQEAgSW5q ZWN0ZWRTY3JpcHQgSW5qZWN0ZWRTY3JpcHRNYW5hZ2VyOjppbmplY3RlZFNjcmlwdEZvcihFeGVj U3RhdGUqIGluc3BlY3RlZEV4ZWMKIAogICAgIGludCBpZCA9IGluamVjdGVkU2NyaXB0SWRGb3Io aW5zcGVjdGVkRXhlY1N0YXRlKTsKICAgICBEZXByZWNhdGVkOjpTY3JpcHRPYmplY3QgaW5qZWN0 ZWRTY3JpcHRPYmplY3QgPSBjcmVhdGVJbmplY3RlZFNjcmlwdChpbmplY3RlZFNjcmlwdFNvdXJj ZSgpLCBpbnNwZWN0ZWRFeGVjU3RhdGUsIGlkKTsKKyAgICBpZiAoaW5qZWN0ZWRTY3JpcHRPYmpl Y3Quc2NyaXB0U3RhdGUoKSAhPSBpbnNwZWN0ZWRFeGVjU3RhdGUpIHsKKyAgICAgICAgV1RGTG9n QWx3YXlzKCJGYWlsZWQgdG8gcGFyc2UvZXhlY3V0ZSBJbmplY3RlZFNjcmlwdFNvdXJjZS5qcyEi KTsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCIlc1xuIiwgaW5qZWN0ZWRTY3JpcHRTb3VyY2UoKS5h c2NpaSgpLmRhdGEoKSk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7Cisg ICAgfQorCiAgICAgSW5qZWN0ZWRTY3JpcHQgcmVzdWx0KGluamVjdGVkU2NyaXB0T2JqZWN0LCAm bV9lbnZpcm9ubWVudCk7CiAgICAgbV9pZFRvSW5qZWN0ZWRTY3JpcHQuc2V0KGlkLCByZXN1bHQp OwogICAgIGRpZENyZWF0ZUluamVjdGVkU2NyaXB0KHJlc3VsdCk7Cg==