148728 2015-09-02 16:24:15 -0700 Web Inspector: jsmin.py mistakenly removes whitespace from template literal strings 2015-10-28 14:18:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=148726 InRadar P2 Normal --- 148730 148726 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1122950 0 260451 bburg 2015-09-02 16:24:15 -0700 Created attachment 260451 testcase Running the following on the test case: $ python ./Source/WebInspectorUI/Scripts/jsmin.py < ~/Desktop/testcases/console-log-template-literal-string.html Produces the following output: <!doctype html><html><body onload="runTest()"><script>function runTest() {let foo=42;console.log(`My favorite number is:${foo}`);}</script><p>To reproduce the bug,try to minify this page.</p></body></html> 1122951 1 webkit-bug-importer 2015-09-02 16:25:25 -0700 <rdar://problem/22548921> 1122961 2 bburg 2015-09-02 16:44:30 -0700 I tested upstream jsmin.py 2.1.4, and by adding '`' to quote_chars, there are no longer any test regressions caused by stripping whitespace from template literal strings. 1122979 3 260460 bburg 2015-09-02 17:51:08 -0700 Created attachment 260460 Proposed Fix Does not apply, depends on jsmin update. 1122984 4 260460 joepeck 2015-09-02 18:04:53 -0700 Comment on attachment 260460 Proposed Fix r=me 1137238 5 bburg 2015-10-28 13:13:44 -0700 Marked WONTFIX because upstream jsmin regresses and is unable to minify other inspector code. Looking for other alternative. 1137247 6 timothy 2015-10-28 13:25:30 -0700 Found a fix for our current jsmin.py. 1137248 7 264238 timothy 2015-10-28 13:28:22 -0700 Created attachment 264238 Patch 1137250 8 264238 joepeck 2015-10-28 13:31:40 -0700 Comment on attachment 264238 Patch r=me! 1137283 9 264238 commit-queue 2015-10-28 14:18:34 -0700 Comment on attachment 264238 Patch Clearing flags on attachment: 264238 Committed r191692: <http://trac.webkit.org/changeset/191692> 1137284 10 commit-queue 2015-10-28 14:18:38 -0700 All reviewed patches have been landed. Closing bug. 260451 2015-09-02 16:24:15 -0700 2015-09-02 16:24:15 -0700 testcase console-log-template-literal-string.html text/html 232 bburg PCFkb2N0eXBlIGh0bWw+CjxodG1sPgo8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+CjxzY3JpcHQ+ CgpmdW5jdGlvbiBydW5UZXN0KCkKewogICAgbGV0IGZvbyA9IDQyOwogICAgY29uc29sZS5sb2co YE15IGZhdm9yaXRlIG51bWJlciBpczogJHtmb299YCk7Cn0KCjwvc2NyaXB0PgoKPHA+VG8gcmVw cm9kdWNlIHRoZSBidWcsIHRyeSB0byBtaW5pZnkgdGhpcyBwYWdlLjwvcD4KCjwvYm9keT4KPC9o dG1sPg== 260460 2015-09-02 17:51:08 -0700 2015-10-28 13:28:19 -0700 Proposed Fix bug-148728-20150902175107.patch text/plain 2828 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 M2MxODNhMWYwZTBkOWQwNDBiOWQzZTVhZWQxMzljZGY5YTNiNjA1Li4yNGE4MjU3MDAxMTVkNzI3 MDg4M2Y4YzM1ZWI2ZWM1ODhmM2Y1MzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNSBAQAogMjAxNS0wOS0wMiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBqc21pbi5weSBtaXN0YWtlbmx5IHJlbW92ZXMgd2hpdGVz cGFjZSBmcm9tIHRlbXBsYXRlIGxpdGVyYWwgc3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Ivc2NyaXB0cy9qc21pbi5weToK KyAgICAgICAgKEphdmFzY3JpcHRNaW5pZnkuX19pbml0X18pOiBNYWtlIGJhY2t0aWNrIGEgcXVv dGluZyBjaGFyYWN0ZXIuCisKKzIwMTUtMDktMDIgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5j b20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXBkYXRlIGpzbWluLnB5IHRvIDIuMS40CiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg3MzAKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggOWNlYzBlNjc0ZTk5YjRlMzgwZjY5MWFhYmIyYWFk NTQ3MzRiZjY3OC4uNmRjYjk1NWUxZDljYzgwNzllM2Q3ODIzYzZiNGU5Y2RlMTQ1ZGRlYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTUtMDktMDIgIEJyaWFu IEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjoganNtaW4u cHkgbWlzdGFrZW5seSByZW1vdmVzIHdoaXRlc3BhY2UgZnJvbSB0ZW1wbGF0ZSBsaXRlcmFsIHN0 cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 ODcyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9qc21pbi5weToKKyAgICAgICAgKEphdmFzY3JpcHRNaW5pZnkuX19pbml0X18pOiBN YWtlIGJhY2t0aWNrIGEgcXVvdGluZyBjaGFyYWN0ZXIuCisKKzIwMTUtMDktMDIgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXBkYXRlIGpz bWluLnB5IHRvIDIuMS40CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDg3MzAKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9zY3JpcHRzL2pzbWluLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9z Y3JpcHRzL2pzbWluLnB5CmluZGV4IGViZDMxMzZiZGNkMTk0MmU3OTVjOGY4Yjg0NGYxMTM3OTdl ODUyNjQuLmFiM2Y3YzljODkxOWNhNzIzZGUxNjRiZjg3ODAxNTY3ZTUwNThjZmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9qc21pbi5weQorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvanNtaW4ucHkKQEAgLTY1 LDcgKzY1LDcgQEAgY2xhc3MgSmF2YXNjcmlwdE1pbmlmeShvYmplY3QpOgogICAgIHRvIGFuIG91 dHB1dCBzdHJlYW0KICAgICAiIiIKIAotICAgIGRlZiBfX2luaXRfXyhzZWxmLCBpbnN0cmVhbT1O b25lLCBvdXRzdHJlYW09Tm9uZSwgcXVvdGVfY2hhcnM9IidcImAiKToKKyAgICBkZWYgX19pbml0 X18oc2VsZiwgaW5zdHJlYW09Tm9uZSwgb3V0c3RyZWFtPU5vbmUsIHF1b3RlX2NoYXJzPSInXCIi KToKICAgICAgICAgc2VsZi5pbnMgPSBpbnN0cmVhbQogICAgICAgICBzZWxmLm91dHMgPSBvdXRz dHJlYW0KICAgICAgICAgc2VsZi5xdW90ZV9jaGFycyA9IHF1b3RlX2NoYXJzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9qc21pbi5weSBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9TY3JpcHRzL2pzbWluLnB5CmluZGV4IGViZDMxMzZiZGNkMTk0MmU3OTVjOGY4Yjg0 NGYxMTM3OTdlODUyNjQuLmFiM2Y3YzljODkxOWNhNzIzZGUxNjRiZjg3ODAxNTY3ZTUwNThjZmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2pzbWluLnB5CisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2pzbWluLnB5CkBAIC02NSw3ICs2NSw3IEBA IGNsYXNzIEphdmFzY3JpcHRNaW5pZnkob2JqZWN0KToKICAgICB0byBhbiBvdXRwdXQgc3RyZWFt CiAgICAgIiIiCiAKLSAgICBkZWYgX19pbml0X18oc2VsZiwgaW5zdHJlYW09Tm9uZSwgb3V0c3Ry ZWFtPU5vbmUsIHF1b3RlX2NoYXJzPSInXCJgIik6CisgICAgZGVmIF9faW5pdF9fKHNlbGYsIGlu c3RyZWFtPU5vbmUsIG91dHN0cmVhbT1Ob25lLCBxdW90ZV9jaGFycz0iJ1wiIik6CiAgICAgICAg IHNlbGYuaW5zID0gaW5zdHJlYW0KICAgICAgICAgc2VsZi5vdXRzID0gb3V0c3RyZWFtCiAgICAg ICAgIHNlbGYucXVvdGVfY2hhcnMgPSBxdW90ZV9jaGFycwo= 264238 2015-10-28 13:28:22 -0700 2015-10-28 14:18:34 -0700 Patch bug-148728-20151028132731.patch text/plain 2681 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NDY0OTE4YTFlZmI5YjMwOTdjYjZmMWE1ZjJiMDlhYzJlNjlhZDU0Li4yMTc1Y2M0Zjc3ZjYxMWMy YzY2YzUxMmIwMTg1MDI2ZDA2MWUxNDJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0xMC0yOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjoganNtaW4ucHkgbWlzdGFrZW5seSByZW1vdmVz IHdoaXRlc3BhY2UgZnJvbSB0ZW1wbGF0ZSBsaXRlcmFsIHN0cmluZ3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODcyOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9qc21pbi5weToKKyAg ICAgICAgKEphdmFzY3JpcHRNaW5pZnkubWluaWZ5KTogTWFrZSBiYWNrdGljayBhIHF1b3Rpbmcg Y2hhcmFjdGVyLgorCiAyMDE1LTEwLTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIFRpbWVsaW5lIE1hcmtET01D b250ZW50IGFuZCBNYXJrTG9hZCwgZGF0YSBpcyBhbHJlYWR5IGF2YWlsYWJsZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9DaGFuZ2VMb2cKaW5kZXggMzU5YTc5ZDM3N2UzYjg0OGE5NzY0YzExYTlkYmY2Nzk1ZDkyNzc1 NC4uZjA4MTYwY2JjMzViOGVmM2ExMDU2YTBkYjU4MThjZjFmMDdhZTAyYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMTAtMjggIFRpbW90aHkgSGF0Y2hl ciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGpzbWluLnB5 IG1pc3Rha2VubHkgcmVtb3ZlcyB3aGl0ZXNwYWNlIGZyb20gdGVtcGxhdGUgbGl0ZXJhbCBzdHJp bmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg3 MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvanNtaW4ucHk6CisgICAgICAgIChKYXZhc2NyaXB0TWluaWZ5Lm1pbmlmeSk6IE1ha2Ug YmFja3RpY2sgYSBxdW90aW5nIGNoYXJhY3Rlci4KKwogMjAxNS0xMC0yNyAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IGltYWdlIGdlbmVyYXRvcnMgYW5kIHVzZSBTVkcgZGlyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2pzbWluLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L1NjcmlwdHMvanNtaW4ucHkKaW5kZXggODNkMmE1MGFjOTVkOGEwYTcwOWU1M2RkZGI3YjhhNTVk ZmFiYTNjZC4uMzcyNDE4YjRkMmIwYTNjNmZhYzM2MjUxN2Q2OWFjOWM3YjA5OTY2OCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvanNtaW4ucHkKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvanNtaW4ucHkKQEAgLTIxNyw3ICsyMTcsNyBAQCBjbGFz cyBKYXZhc2NyaXB0TWluaWZ5KG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgIGRvX25ld2xp bmUgPSBGYWxzZQogCiAgICAgICAgICAgICAgICAgd3JpdGUobmV4dDEpCi0gICAgICAgICAgICAg ICAgaWYgbm90IGluX3JlIGFuZCBuZXh0MSBpbiAiJ1wiIjoKKyAgICAgICAgICAgICAgICBpZiBu b3QgaW5fcmUgYW5kIG5leHQxIGluICInXCJgIjoKICAgICAgICAgICAgICAgICAgICAgaW5fcXVv dGUgPSBuZXh0MQogICAgICAgICAgICAgICAgICAgICBxdW90ZV9idWYgPSBbXQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9qc21pbi5weSBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9TY3JpcHRzL2pzbWluLnB5CmluZGV4IDgzZDJhNTBhYzk1ZDhhMGE3MDllNTNk ZGRiN2I4YTU1ZGZhYmEzY2QuLjM3MjQxOGI0ZDJiMGEzYzZmYWMzNjI1MTdkNjlhYzljN2IwOTk2 NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2pzbWluLnB5Cisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2pzbWluLnB5CkBAIC0yMTcsNyArMjE3 LDcgQEAgY2xhc3MgSmF2YXNjcmlwdE1pbmlmeShvYmplY3QpOgogICAgICAgICAgICAgICAgICAg ICBkb19uZXdsaW5lID0gRmFsc2UKIAogICAgICAgICAgICAgICAgIHdyaXRlKG5leHQxKQotICAg ICAgICAgICAgICAgIGlmIG5vdCBpbl9yZSBhbmQgbmV4dDEgaW4gIidcIiI6CisgICAgICAgICAg ICAgICAgaWYgbm90IGluX3JlIGFuZCBuZXh0MSBpbiAiJ1wiYCI6CiAgICAgICAgICAgICAgICAg ICAgIGluX3F1b3RlID0gbmV4dDEKICAgICAgICAgICAgICAgICAgICAgcXVvdGVfYnVmID0gW10K IAo=