148679 2015-09-01 08:50:00 -0700 Web Inspector: protocol generator should not allow non-boolean values for "optional" key 2015-09-01 11:45:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=147664 InRadar P2 Normal --- 147067 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1122548 0 bburg 2015-09-01 08:50:00 -0700 Whoops 1122549 1 webkit-bug-importer 2015-09-01 08:50:49 -0700 <rdar://problem/22518956> 1122598 2 260375 bburg 2015-09-01 11:18:39 -0700 Created attachment 260375 Proposed Fix 1122599 3 commit-queue 2015-09-01 11:20:37 -0700 This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) 1122600 4 260375 joepeck 2015-09-01 11:22:42 -0700 Comment on attachment 260375 Proposed Fix r=me 1122608 5 260375 commit-queue 2015-09-01 11:45:20 -0700 Comment on attachment 260375 Proposed Fix Clearing flags on attachment: 260375 Committed r189222: <http://trac.webkit.org/changeset/189222> 1122609 6 commit-queue 2015-09-01 11:45:24 -0700 All reviewed patches have been landed. Closing bug. 260375 2015-09-01 11:18:39 -0700 2015-09-01 11:45:20 -0700 Proposed Fix bug-148679-20150901111820.patch text/plain 5468 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NjBjOTk3ZWJkMTIxMzU2YzFkNGZmYjY3NWI2NjJmYTI0YTExZTYzLi40ZDQzNjc3Y2I5ODBlMGRj M2E3OGUyMWM5OTg4ZmFmNjRhMzc5YTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNS0wOS0wMSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcm90b2NvbCBnZW5lcmF0b3Igc2hvdWxkIG5vdCBhbGxv dyBub24tYm9vbGVhbiB2YWx1ZXMgZm9yICJvcHRpb25hbCIga2V5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg2NzkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBQeXRob24sIHRoZSAnYm9vbCcgdHlw ZSBpbmhlcml0cyBmcm9tICdpbnQnLiBJbiB0aGUgcnVudGltZSwgVHJ1ZSBhbmQgRmFsc2UgYXJl CisgICAgICAgIGp1c3QgbnVtYmVycyB0byBQeXRob24uIFNvLCB0aGUgZXhpc3RpbmcgY2hlY2sg Zm9yIGJvb2xlYW4gbGl0ZXJhbHMgd2FzIG5vdCBxdWl0ZSByaWdodC4KKworICAgICAgICAqIGlu c3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vbW9kZWxzLnB5OiBVc2UgaXNpbnN0YW5jZSBpbnN0ZWFk LgorICAgICAgICAoVHlwZU1lbWJlci5fX2luaXRfXyk6CisgICAgICAgIChQYXJhbWV0ZXIuX19p bml0X18pOgorICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2ZhaWwt b24tbnVtYmVyLXR5cGVkLW9wdGlvbmFsLXBhcmFtZXRlci1mbGFnLmpzb24tZXJyb3I6IEFkZGVk LgorICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2ZhaWwtb24tbnVt YmVyLXR5cGVkLW9wdGlvbmFsLXR5cGUtbWVtYmVyLmpzb24tZXJyb3I6IEFkZGVkLgorICAgICAg ICAqIGluc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2ZhaWwtb24tbnVtYmVyLXR5cGVkLW9wdGlvbmFs LXBhcmFtZXRlci1mbGFnLmpzb246IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRz L3Rlc3RzL2ZhaWwtb24tbnVtYmVyLXR5cGVkLW9wdGlvbmFsLXR5cGUtbWVtYmVyLmpzb246IEFk ZGVkLgorCisyMDE1LTA5LTAxICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IHRpZ2h0ZW4gdXAgbGlmZXRpbWVzIGZvciBJbnNwZWN0b3JDb250 cm9sbGVyLW93bmVkIG9iamVjdHM7IGFkZCBicmFjZSBpbml0aWFsaXplcnMgdG8gYWdlbnRzCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg2MTIKIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVn ZW4vbW9kZWxzLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2Nv ZGVnZW4vbW9kZWxzLnB5CmluZGV4IDJkYWJkYzBjYTI5YTZhYmVkYzQ4NTZkNDQ5NGY3MTA4YjAx NDkzZDUuLmVjMTZhMTI5MTI5ODk0NjZkZmE3ZDU2MDE3ZjdkNjc0NzNhYmEzMjMgMTAwNzU1Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2VuL21vZGVs cy5weQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdl bi9tb2RlbHMucHkKQEAgLTUzOCw3ICs1MzgsNyBAQCBjbGFzcyBUeXBlTWVtYmVyOgogICAgICAg ICBzZWxmLmlzX29wdGlvbmFsID0gaXNfb3B0aW9uYWwKICAgICAgICAgc2VsZi5kZXNjcmlwdGlv biA9IGRlc2NyaXB0aW9uCiAKLSAgICAgICAgaWYgc2VsZi5pc19vcHRpb25hbCBub3QgaW4gW1Ry dWUsIEZhbHNlXToKKyAgICAgICAgaWYgbm90IGlzaW5zdGFuY2Uoc2VsZi5pc19vcHRpb25hbCwg Ym9vbCk6CiAgICAgICAgICAgICByYWlzZSBQYXJzZUV4Y2VwdGlvbigiVGhlICdvcHRpb25hbCcg ZmxhZyBmb3IgYSB0eXBlIG1lbWJlciBtdXN0IGJlIGEgYm9vbGVhbiBsaXRlcmFsLiIpCiAKICAg ICBkZWYgcmVzb2x2ZV90eXBlX3JlZmVyZW5jZXMoc2VsZiwgcHJvdG9jb2wsIGRvbWFpbik6CkBA IC01NTMsNyArNTUzLDcgQEAgY2xhc3MgUGFyYW1ldGVyOgogICAgICAgICBzZWxmLmlzX29wdGlv bmFsID0gaXNfb3B0aW9uYWwKICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbiA9IGRlc2NyaXB0aW9u CiAKLSAgICAgICAgaWYgc2VsZi5pc19vcHRpb25hbCBub3QgaW4gW1RydWUsIEZhbHNlXToKKyAg ICAgICAgaWYgbm90IGlzaW5zdGFuY2Uoc2VsZi5pc19vcHRpb25hbCwgYm9vbCk6CiAgICAgICAg ICAgICByYWlzZSBQYXJzZUV4Y2VwdGlvbigiVGhlICdvcHRpb25hbCcgZmxhZyBmb3IgYSBwYXJh bWV0ZXIgbXVzdCBiZSBhIGJvb2xlYW4gbGl0ZXJhbC4iKQogCiAgICAgZGVmIHJlc29sdmVfdHlw ZV9yZWZlcmVuY2VzKHNlbGYsIHByb3RvY29sLCBkb21haW4pOgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2ZhaWwtb24t bnVtYmVyLXR5cGVkLW9wdGlvbmFsLXBhcmFtZXRlci1mbGFnLmpzb24tZXJyb3IgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZmFpbC1vbi1u dW1iZXItdHlwZWQtb3B0aW9uYWwtcGFyYW1ldGVyLWZsYWcuanNvbi1lcnJvcgpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li45N2IyYWYwZTQ3ZTkzZjgwNDk3OTQ0NDcyNTdkZjMyNzIzZjA2ODI0Ci0tLSAvZGV2L251bGwK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVj dGVkL2ZhaWwtb24tbnVtYmVyLXR5cGVkLW9wdGlvbmFsLXBhcmFtZXRlci1mbGFnLmpzb24tZXJy b3IKQEAgLTAsMCArMSBAQAorRVJST1I6IFRoZSAnb3B0aW9uYWwnIGZsYWcgZm9yIGEgcGFyYW1l dGVyIG11c3QgYmUgYSBib29sZWFuIGxpdGVyYWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZmFpbC1vbi1udW1iZXIt dHlwZWQtb3B0aW9uYWwtdHlwZS1tZW1iZXIuanNvbi1lcnJvciBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9mYWlsLW9uLW51bWJlci10eXBl ZC1vcHRpb25hbC10eXBlLW1lbWJlci5qc29uLWVycm9yCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjg2ZGYzNzUwYzFh Nzc5Nzg5M2NiZmI3ZTI4NzZkOTJjY2VjYzJmOTEKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZmFpbC1vbi1u dW1iZXItdHlwZWQtb3B0aW9uYWwtdHlwZS1tZW1iZXIuanNvbi1lcnJvcgpAQCAtMCwwICsxIEBA CitFUlJPUjogVGhlICdvcHRpb25hbCcgZmxhZyBmb3IgYSB0eXBlIG1lbWJlciBtdXN0IGJlIGEg Ym9vbGVhbiBsaXRlcmFsLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9zY3JpcHRzL3Rlc3RzL2ZhaWwtb24tbnVtYmVyLXR5cGVkLW9wdGlvbmFsLXBhcmFtZXRl ci1mbGFnLmpzb24gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVz dHMvZmFpbC1vbi1udW1iZXItdHlwZWQtb3B0aW9uYWwtcGFyYW1ldGVyLWZsYWcuanNvbgpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi43MzA4ZGI5OTJkNjUyNTdmMmI1YzYzMjdlMGNhMzU0NTAyZDYxNTRhCi0tLSAvZGV2 L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3Rz L2ZhaWwtb24tbnVtYmVyLXR5cGVkLW9wdGlvbmFsLXBhcmFtZXRlci1mbGFnLmpzb24KQEAgLTAs MCArMSwxOCBAQAoreworICAgICJkb21haW4iOiAiRGF0YWJhc2UiLAorICAgICJ0eXBlcyI6IFsK KyAgICAgICAgeworICAgICAgICAgICAgImlkIjogIkRhdGFiYXNlSWQiLAorICAgICAgICAgICAg InR5cGUiOiAic3RyaW5nIiwKKyAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJVbmlxdWUgaWRl bnRpZmllciBvZiBEYXRhYmFzZSBvYmplY3QuIgorICAgICAgICB9CisgICAgXSwKKyAgICAiZXZl bnRzIjogWworICAgICAgICB7CisgICAgICAgICAgICAibmFtZSI6ICJkaWRFeGVjdXRlT3B0aW9u YWxQYXJhbWV0ZXJzIiwKKyAgICAgICAgICAgICJwYXJhbWV0ZXJzIjogWworICAgICAgICAgICAg ICAgIHsgIm5hbWUiOiAiY29sdW1uTmFtZXMiLCAidHlwZSI6ICJzdHJpbmciLCAib3B0aW9uYWwi OiAwIH0KKyAgICAgICAgICAgIF0KKyAgICAgICAgfQorICAgIF0KK30KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9mYWlsLW9uLW51bWJl ci10eXBlZC1vcHRpb25hbC10eXBlLW1lbWJlci5qc29uIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2ZhaWwtb24tbnVtYmVyLXR5cGVkLW9wdGlvbmFsLXR5 cGUtbWVtYmVyLmpzb24KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWZlYTU1NWVjNGZlMDg2NjI3OGUxZmNkNzMzNTQy NDJkZWZkMWJkNAotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNw ZWN0b3Ivc2NyaXB0cy90ZXN0cy9mYWlsLW9uLW51bWJlci10eXBlZC1vcHRpb25hbC10eXBlLW1l bWJlci5qc29uCkBAIC0wLDAgKzEsMTYgQEAKK1sKK3sKKyAgICAiZG9tYWluIjogIkRhdGFiYXNl IiwKKyAgICAidHlwZXMiOiBbCisgICAgICAgIHsKKyAgICAgICAgICAgICJpZCI6ICJFcnJvciIs CisgICAgICAgICAgICAidHlwZSI6ICJvYmplY3QiLAorICAgICAgICAgICAgImRlc2NyaXB0aW9u IjogIkRhdGFiYXNlIGVycm9yLiIsCisgICAgICAgICAgICAicHJvcGVydGllcyI6IFsKKyAgICAg ICAgICAgICAgICB7ICJuYW1lIjogIm1lc3NhZ2UiLCAidHlwZSI6ICJzdHJpbmciLCAiZGVzY3Jp cHRpb24iOiAiRXJyb3IgbWVzc2FnZS4iIH0sCisgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJj b2RlIiwgInR5cGUiOiAiaW50ZWdlciIsICJkZXNjcmlwdGlvbiI6ICJFcnJvciBjb2RlLiIsICJv cHRpb25hbCI6IDAgfQorICAgICAgICAgICAgXQorICAgICAgICB9CisgICAgXQorfQorXQo=