148607 2015-08-28 21:32:23 -0700 [GTK] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer 2015-10-26 22:16:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126492 1 philip.chimento webkit-unassigned cgarcia commit-queue mcatanzaro oldest_to_newest 1121954 0 philip.chimento 2015-08-28 21:32:23 -0700 [GTK] [Stable] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer 1121955 1 260212 philip.chimento 2015-08-28 21:35:48 -0700 Created attachment 260212 Patch 1121956 2 260212 philip.chimento 2015-08-28 21:36:39 -0700 Comment on attachment 260212 Patch Add a stub for the InstallMissingMediaPluginsPermissionRequest class for the case when video is disabled or not using GStreamer. It's OK that this class does nothing, because the associated C API contains an assert_not_reached if video is disabled. We just need to define the symbol so that the function signature will compile. I'll add this to the proposed merges for 2.9.92. 1125471 3 mcatanzaro 2015-09-13 07:06:07 -0700 FYI: we use [Stable] to indicate a patch that should not be committed to master (so it should not be used in combination with commit-queue). 1125474 4 philip.chimento 2015-09-13 10:12:54 -0700 OK, thanks for explaining. I meant this patch to be for both master and stable. My confusion arose because the instructions on http://trac.webkit.org/wiki/WebKitGTK/2.10.x say to use "[GTK] [Stable]" so I'll add a note there explaining what you just told me. 1136516 5 mcatanzaro 2015-10-26 08:01:38 -0700 Since this is a build fix, any committer can approve it, so if you attach a new patch with the "Reviewed by NOBODOY" line replaced with "Unreviewed" and request only commit-queue? but not review?, I will grant that. 1136755 6 264118 philip.chimento 2015-10-26 20:50:47 -0700 Created attachment 264118 Patch Thank you here as well! 1136764 7 264118 commit-queue 2015-10-26 22:16:37 -0700 Comment on attachment 264118 Patch Clearing flags on attachment: 264118 Committed r191618: <http://trac.webkit.org/changeset/191618> 1136765 8 commit-queue 2015-10-26 22:16:42 -0700 All reviewed patches have been landed. Closing bug. 260212 2015-08-28 21:35:48 -0700 2015-10-26 20:50:43 -0700 Patch bug-148607-20150828213535.patch text/plain 1814 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjE1ODg3MDBmMzJiMzA2 YmIwYTFlZGM1YzhkYjdmM2M2ZmRjOGM3Yy4uM2JlODJiNDA4NzEwZDAzZWExOTBmNzU2ZTEwNzhj YzQ4ZDdhNGE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA4LTI4ICBQaGls aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtd IFtTdGFibGVdIEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3Qgbm90 IGRlZmluZWQgd2hlbiBidWlsZGluZyB3aXRob3V0IEdTdHJlYW1lcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NjA3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3N0cmVhbWVyL0lu c3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QuaDoKKyAgICAgICAgQWRk IGEgc3R1YiBmb3IgdGhlIEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVl c3QgY2xhc3MKKyAgICAgICAgZm9yIHRoZSBjYXNlIHdoZW4gdmlkZW8gaXMgZGlzYWJsZWQgb3Ig bm90IHVzaW5nIEdTdHJlYW1lci4gSXQncyBPSworICAgICAgICB0aGF0IHRoaXMgY2xhc3MgZG9l cyBub3RoaW5nLCBiZWNhdXNlIHRoZSBhc3NvY2lhdGVkIEMgQVBJIGNvbnRhaW5zCisgICAgICAg IGFuIGFzc2VydF9ub3RfcmVhY2hlZCBpZiB2aWRlbyBpcyBkaXNhYmxlZC4gV2UganVzdCBuZWVk IHRvIGRlZmluZQorICAgICAgICB0aGUgc3ltYm9sIHNvIHRoYXQgdGhlIGZ1bmN0aW9uIHNpZ25h dHVyZSB3aWxsIGNvbXBpbGUuCisKIDIwMTUtMDgtMjggIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2Fy bHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gUmVzdHJ1Y3R1cmUgV2ViTWVkaWFTZXNz aW9uTWFuYWdlciBmb3IgdGVzdGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2dzdHJlYW1lci9JbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0 LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3N0cmVhbWVyL0luc3RhbGxNaXNzaW5nTWVk aWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QuaAppbmRleCBlMzgxNTg5NmNhZjA1NDFkOWMyNmQy MTJiNTZlZGY1ZjA3YmVmMDIwLi41NDE2MDE0Y2JkZTE0NzFhODk2MjFkYzBlY2I3ZGVjNmFmMjdi ZTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3N0cmVhbWVyL0luc3Rh bGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvZ3N0cmVhbWVyL0luc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlz c2lvblJlcXVlc3QuaApAQCAtNjMsNSArNjMsMTEgQEAgcHJpdmF0ZToKIAogfSAvLyBuYW1lc3Bh Y2UgV2ViS2l0CiAKKyNlbHNlCisKK25hbWVzcGFjZSBXZWJLaXQgeworY2xhc3MgSW5zdGFsbE1p c3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdDsKK30gLy8gbmFtZXNwYWNlIFdlYktp dAorCiAjZW5kaWYgLy8gRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVSKQogI2VuZGlmIC8v IEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3RfaAo= 264118 2015-10-26 20:50:47 -0700 2015-10-26 22:16:37 -0700 Patch bug-148607-20151026204958.patch text/plain 1822 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmQ3NzRhYTU5Y2M0ODA3 ZTc1ZTdlYmU5ZGI3NDkxNDVhYmU4NGQ0Yy4uZjAxNzZiZDdjM2EyMjljOGFkOWRhODdiYWU2YmJh OWJkOTI2MmQwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTEwLTI2ICBQaGls aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtd IFtTdGFibGVdIEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3Qgbm90 IGRlZmluZWQgd2hlbiBidWlsZGluZyB3aXRob3V0IEdTdHJlYW1lcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NjA3CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgYnVpbGQgZml4LgorCisgICAgICAgICogVUlQcm9jZXNzL2dzdHJlYW1lci9JbnN0YWxs TWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0Lmg6CisgICAgICAgIEFkZCBhIHN0 dWIgZm9yIHRoZSBJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0IGNs YXNzCisgICAgICAgIGZvciB0aGUgY2FzZSB3aGVuIHZpZGVvIGlzIGRpc2FibGVkIG9yIG5vdCB1 c2luZyBHU3RyZWFtZXIuIEl0J3MgT0sKKyAgICAgICAgdGhhdCB0aGlzIGNsYXNzIGRvZXMgbm90 aGluZywgYmVjYXVzZSB0aGUgYXNzb2NpYXRlZCBDIEFQSSBjb250YWlucworICAgICAgICBhbiBh c3NlcnRfbm90X3JlYWNoZWQgaWYgdmlkZW8gaXMgZGlzYWJsZWQuIFdlIGp1c3QgbmVlZCB0byBk ZWZpbmUKKyAgICAgICAgdGhlIHN5bWJvbCBzbyB0aGF0IHRoZSBmdW5jdGlvbiBzaWduYXR1cmUg d2lsbCBjb21waWxlLgorCiAyMDE1LTEwLTI2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgUGlwZSBjdXN0b20gY29udGV4dCBtZW51IGhhbmRsaW5nIHRo cm91Z2ggdG8gdGhlIFVJRGVsZWdhdGUgb2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3N0cmVhbWVyL0luc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lv blJlcXVlc3QuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9nc3RyZWFtZXIvSW5zdGFsbE1p c3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdC5oCmluZGV4IGUzODE1ODk2Y2FmMDU0 MWQ5YzI2ZDIxMmI1NmVkZjVmMDdiZWYwMjAuLjU0MTYwMTRjYmRlMTQ3MWE4OTYyMWRjMGVjYjdk ZWM2YWYyN2JlN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9nc3RyZWFt ZXIvSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdC5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9nc3RyZWFtZXIvSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdp bnNQZXJtaXNzaW9uUmVxdWVzdC5oCkBAIC02Myw1ICs2MywxMSBAQCBwcml2YXRlOgogCiB9IC8v IG5hbWVzcGFjZSBXZWJLaXQKIAorI2Vsc2UKKworbmFtZXNwYWNlIFdlYktpdCB7CitjbGFzcyBJ bnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0OworfSAvLyBuYW1lc3Bh Y2UgV2ViS2l0CisKICNlbmRpZiAvLyBFTkFCTEUoVklERU8pICYmIFVTRShHU1RSRUFNRVIpCiAj ZW5kaWYgLy8gSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdF9oCg==