148432 2015-08-25 07:38:08 -0700 Remove PassRefPtr style check rule 2015-08-25 21:30:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 147974 148463 1 gyuyoung.kim gyuyoung.kim aestes commit-queue glenn oldest_to_newest 1120586 0 gyuyoung.kim 2015-08-25 07:38:08 -0700 PassRefPtr is being removed. Thus style rule needs to be removed as well. If not, many style rule violations will happens whenever removal patch is uploaded. 1120587 1 259842 gyuyoung.kim 2015-08-25 07:39:02 -0700 Created attachment 259842 Patch 1120792 2 259842 commit-queue 2015-08-25 18:03:10 -0700 Comment on attachment 259842 Patch Clearing flags on attachment: 259842 Committed r188940: <http://trac.webkit.org/changeset/188940> 1120793 3 commit-queue 2015-08-25 18:03:13 -0700 All reviewed patches have been landed. Closing bug. 1120832 4 aestes 2015-08-25 21:28:26 -0700 Looks like this broke some webkitpy tests. From <https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/16667/steps/webkitpy-test/logs/stdio>: [933/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_pass_other_type_ptr_in_function failed: Traceback (most recent call last): File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3648, in test_pass_other_type_ptr_in_function 'Local variables should never be PassOtherTypePtr (see ' File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check self.perform_pass_ptr_check(code)) AssertionError: 'Local variables should never be PassOtherTypePtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]' != '' [1221/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_pass_ref_ptr_in_function failed: Traceback (most recent call last): File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3639, in test_pass_ref_ptr_in_function 'Local variables should never be PassRefPtr (see ' File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check self.perform_pass_ptr_check(code)) AssertionError: 'Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]' != '' [1226/1447] webkitpy.style.checkers.cpp_unittest.PassPtrTest.test_ref_ptr_parameter_value failed: Traceback (most recent call last): File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3682, in test_ref_ptr_parameter_value 'The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]') File "/Volumes/Data/slave/mavericks-release-tests-wk2/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 3631, in assert_pass_ptr_check self.perform_pass_ptr_check(code)) AssertionError: 'The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]' != '' 1120834 5 gyuyoung.kim 2015-08-25 21:30:04 -0700 (In reply to comment #4) > Looks like this broke some webkitpy tests. From Yes, I'm going to upload a fix to Bug 148463. https://bugs.webkit.org/show_bug.cgi?id=148463 259842 2015-08-25 07:39:02 -0700 2015-08-25 18:03:10 -0700 Patch patch.txt text/plain 4763 gyuyoung.kim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZGRk MmUwLi41ODk2OTE1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTUtMDgtMjUgIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBQYXNzUmVmUHRyIHN0eWxlIGNo ZWNrIHJ1bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0ODQzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFBhc3NSZWZQdHIgaXMgYmVpbmcgcmVtb3ZlZC4gVGh1cyBzdHlsZSBydWxlIG5lZWRzIHRvIGJl IHJlbW92ZWQgYXMgd2VsbC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5OgorICAgICAgICAoX2NoZWNrX3BhcmFtZXRlcl9uYW1lX2FnYWluc3RfdGV4 dCk6IERlbGV0ZWQuCisgICAgICAgIChjaGVja19mdW5jdGlvbl9kZWZpbml0aW9uX2FuZF9wYXNz X3B0cik6IERlbGV0ZWQuCisgICAgICAgIChjaGVja19mdW5jdGlvbl9kZWZpbml0aW9uKTogRGVs ZXRlZC4KKyAgICAgICAgKGNoZWNrX3Bhc3NfcHRyX3VzYWdlKTogRGVsZXRlZC4KKyAgICAgICAg KHByb2Nlc3NfbGluZSk6IERlbGV0ZWQuCisgICAgICAgIChDcHBDaGVja2VyKTogRGVsZXRlZC4K KwogMjAxNS0wOC0yNCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV2luXSBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCAzMmRlNjE0Li40ZWNlNGI4IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMTY0Miwy NCArMTY0Miw2IEBAIGRlZiBfY2hlY2tfcGFyYW1ldGVyX25hbWVfYWdhaW5zdF90ZXh0KHBhcmFt ZXRlciwgdGV4dCwgZXJyb3IpOgogICAgICAgICByZXR1cm4gRmFsc2UKICAgICByZXR1cm4gVHJ1 ZQogCi0KLWRlZiBjaGVja19mdW5jdGlvbl9kZWZpbml0aW9uX2FuZF9wYXNzX3B0cih0eXBlX3Rl eHQsIHJvdywgZXJyb3IpOgotICAgICIiIkNoZWNrIHRoYXQgZnVuY3Rpb24gZGVmaW5pdGlvbnMg Zm9yIHVzZSBQYXNzKlB0ciBpbnN0ZWFkIG9mICpQdHIuCi0KLSAgICBBcmdzOgotICAgICAgIHR5 cGVfdGV4dDogQSBzdHJpbmcgY29udGFpbmluZyB0aGUgdHlwZS4KLSAgICAgICByb3c6IFRoZSBy b3cgbnVtYmVyIG9mIHRoZSB0eXBlLgotICAgICAgIGVycm9yOiBUaGUgZnVuY3Rpb24gdG8gY2Fs bCB3aXRoIGFueSBlcnJvcnMgZm91bmQuCi0gICAgIiIiCi0gICAgbWF0Y2hfcmVmX3B0ciA9ICco Pz1cV3xeKVJlZlB0cig/PVxXKScKLSAgICBiYWRfdHlwZV91c2FnZSA9IHNlYXJjaChtYXRjaF9y ZWZfcHRyLCB0eXBlX3RleHQpCi0gICAgaWYgbm90IGJhZF90eXBlX3VzYWdlIG9yIHR5cGVfdGV4 dC5lbmRzd2l0aCgnJicpIG9yIHR5cGVfdGV4dC5lbmRzd2l0aCgnKicpOgotICAgICAgICByZXR1 cm4KLSAgICB0eXBlX25hbWUgPSBiYWRfdHlwZV91c2FnZS5ncm91cCgwKQotICAgIGVycm9yKHJv dywgJ3JlYWRhYmlsaXR5L3Bhc3NfcHRyJywgNSwKLSAgICAgICAgICAnVGhlIHBhcmFtZXRlciB0 eXBlIHNob3VsZCB1c2UgUGFzcyVzIGluc3RlYWQgb2YgJXMuJyAlICh0eXBlX25hbWUsIHR5cGVf bmFtZSkpCi0KLQogZGVmIGNoZWNrX2Z1bmN0aW9uX2RlZmluaXRpb24oZmlsZW5hbWUsIGZpbGVf ZXh0ZW5zaW9uLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZ1bmN0aW9uX3N0YXRlLCBlcnJv cik6CiAgICAgIiIiQ2hlY2sgdGhhdCBmdW5jdGlvbiBkZWZpbml0aW9ucyBmb3Igc3R5bGUgaXNz dWVzLgogCkBAIC0xNjc4LDggKzE2NjAsNiBAQCBkZWYgY2hlY2tfZnVuY3Rpb25fZGVmaW5pdGlv bihmaWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlcgogCiAg ICAgcGFyYW1ldGVyX2xpc3QgPSBmdW5jdGlvbl9zdGF0ZS5wYXJhbWV0ZXJfbGlzdCgpCiAgICAg Zm9yIHBhcmFtZXRlciBpbiBwYXJhbWV0ZXJfbGlzdDoKLSAgICAgICAgY2hlY2tfZnVuY3Rpb25f ZGVmaW5pdGlvbl9hbmRfcGFzc19wdHIocGFyYW1ldGVyLnR5cGUsIHBhcmFtZXRlci5yb3csIGVy cm9yKQotCiAgICAgICAgICMgRG8gY2hlY2tzIHNwZWNpZmljIHRvIGZ1bmN0aW9uIGRlY2xhcmF0 aW9ucyBhbmQgcGFyYW1ldGVyIG5hbWVzLgogICAgICAgICBpZiBub3QgZnVuY3Rpb25fc3RhdGUu aXNfZGVjbGFyYXRpb24gb3Igbm90IHBhcmFtZXRlci5uYW1lOgogICAgICAgICAgICAgY29udGlu dWUKQEAgLTE2OTUsMzIgKzE2NzUsNiBAQCBkZWYgY2hlY2tfZnVuY3Rpb25fZGVmaW5pdGlvbihm aWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlcgogICAgICAg ICAgICAgY29udGludWUgICMgU2luY2UgYW4gZXJyb3Igd2FzIG5vdGVkIGZvciB0aGlzIG5hbWUs IG1vdmUgdG8gdGhlIG5leHQgcGFyYW1ldGVyLgogCiAKLWRlZiBjaGVja19wYXNzX3B0cl91c2Fn ZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZ1bmN0aW9uX3N0YXRlLCBlcnJvcik6Ci0gICAg IiIiQ2hlY2sgZm9yIHByb3BlciB1c2FnZSBvZiBQYXNzKlB0ci4KLQotICAgIEN1cnJlbnRseSB0 aGlzIGlzIGxpbWl0ZWQgdG8gZGV0ZWN0aW5nIGRlY2xhcmF0aW9ucyBvZiBQYXNzKlB0cgotICAg IHZhcmlhYmxlcyBpbnNpZGUgb2YgZnVuY3Rpb25zLgotCi0gICAgQXJnczoKLSAgICAgIGNsZWFu X2xpbmVzOiBBIENsZWFuc2VkTGluZXMgaW5zdGFuY2UgY29udGFpbmluZyB0aGUgZmlsZS4KLSAg ICAgIGxpbmVfbnVtYmVyOiBUaGUgbnVtYmVyIG9mIHRoZSBsaW5lIHRvIGNoZWNrLgotICAgICAg ZnVuY3Rpb25fc3RhdGU6IEN1cnJlbnQgZnVuY3Rpb24gbmFtZSBhbmQgbGluZXMgaW4gYm9keSBz byBmYXIuCi0gICAgICBlcnJvcjogVGhlIGZ1bmN0aW9uIHRvIGNhbGwgd2l0aCBhbnkgZXJyb3Jz IGZvdW5kLgotICAgICIiIgotICAgIGlmIG5vdCBmdW5jdGlvbl9zdGF0ZS5pbl9hX2Z1bmN0aW9u OgotICAgICAgICByZXR1cm4KLQotICAgIGxpbmVzID0gY2xlYW5fbGluZXMubGluZXMKLSAgICBs aW5lID0gbGluZXNbbGluZV9udW1iZXJdCi0gICAgaWYgbGluZV9udW1iZXIgPiBmdW5jdGlvbl9z dGF0ZS5ib2R5X3N0YXJ0X3Bvc2l0aW9uLnJvdzoKLSAgICAgICAgbWF0Y2hlZF9wYXNzX3B0ciA9 IG1hdGNoKHInXlxzKlBhc3MoW0EtWl1bQS1aYS16XSopUHRyPCcsIGxpbmUpCi0gICAgICAgIGlm IG1hdGNoZWRfcGFzc19wdHI6Ci0gICAgICAgICAgICB0eXBlX25hbWUgPSAnUGFzcyVzUHRyJyAl IG1hdGNoZWRfcGFzc19wdHIuZ3JvdXAoMSkKLSAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVy LCAncmVhZGFiaWxpdHkvcGFzc19wdHInLCA1LAotICAgICAgICAgICAgICAgICAgJ0xvY2FsIHZh cmlhYmxlcyBzaG91bGQgbmV2ZXIgYmUgJXMgKHNlZSAnCi0gICAgICAgICAgICAgICAgICAnaHR0 cDovL3dlYmtpdC5vcmcvY29kaW5nL1JlZlB0ci5odG1sKS4nICUgdHlwZV9uYW1lKQotCi0KIGRl ZiBjaGVja19mb3JfbGVha3lfcGF0dGVybnMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmdW5j dGlvbl9zdGF0ZSwgZXJyb3IpOgogICAgICIiIkNoZWNrIGZvciBjb25zdHJ1Y3RzIGtub3duIHRv IGJlIGxlYWsgcHJvbmUuCiAgICAgQXJnczoKQEAgLTM3NTIsNyArMzcwNiw2IEBAIGRlZiBwcm9j ZXNzX2xpbmUoZmlsZW5hbWUsIGZpbGVfZXh0ZW5zaW9uLAogICAgIGlmIGFzbV9zdGF0ZS5pc19p bl9hc20oKTogICMgSWdub3JlIGZ1cnRoZXIgY2hlY2tzIGJlY2F1c2UgYXNtIGJsb2NrcyBmb3Jt YXR0ZWQgZGlmZmVyZW50bHkuCiAgICAgICAgIHJldHVybgogICAgIGNoZWNrX2Z1bmN0aW9uX2Rl ZmluaXRpb24oZmlsZW5hbWUsIGZpbGVfZXh0ZW5zaW9uLCBjbGVhbl9saW5lcywgbGluZSwgZnVu Y3Rpb25fc3RhdGUsIGVycm9yKQotICAgIGNoZWNrX3Bhc3NfcHRyX3VzYWdlKGNsZWFuX2xpbmVz LCBsaW5lLCBmdW5jdGlvbl9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfZm9yX2xlYWt5X3BhdHRl cm5zKGNsZWFuX2xpbmVzLCBsaW5lLCBmdW5jdGlvbl9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tf Zm9yX211bHRpbGluZV9jb21tZW50c19hbmRfc3RyaW5ncyhjbGVhbl9saW5lcywgbGluZSwgZXJy b3IpCiAgICAgY2hlY2tfc3R5bGUoY2xlYW5fbGluZXMsIGxpbmUsIGZpbGVfZXh0ZW5zaW9uLCBj bGFzc19zdGF0ZSwgZmlsZV9zdGF0ZSwgZW51bV9zdGF0ZSwgZXJyb3IpCkBAIC0zODY0LDcgKzM4 MTcsNiBAQCBjbGFzcyBDcHBDaGVja2VyKG9iamVjdCk6CiAgICAgICAgICdyZWFkYWJpbGl0eS9u YW1pbmcnLAogICAgICAgICAncmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2NvcmVzJywKICAgICAg ICAgJ3JlYWRhYmlsaXR5L251bGwnLAotICAgICAgICAncmVhZGFiaWxpdHkvcGFzc19wdHInLAog ICAgICAgICAncmVhZGFiaWxpdHkvc3RyZWFtcycsCiAgICAgICAgICdyZWFkYWJpbGl0eS90b2Rv JywKICAgICAgICAgJ3JlYWRhYmlsaXR5L3V0ZjgnLAo=