147636 2015-08-04 11:17:42 -0700 [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures. 2015-08-05 00:44:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham achristensen ap bfulgham commit-queue ossy peavo oldest_to_newest 1114658 0 bfulgham 2015-08-04 11:17:42 -0700 We started trying to capture build failures into our build log back in 2013, and added special logic for Visual Studio Express because the build driver was not emitting errors to stdout. However, in Bug 140845 we switched to MSBuild for all builds, which handles this output properly. Since MSBuild uses BuildOutput.htm directly, the file can be locked by MSBuild activity causing the overall build process to fail due to the 'die' command in the build-webkit Perl script. We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly. Remove this unneeded (and bug-prone) code to improve the build reliability. 1114660 1 258186 bfulgham 2015-08-04 11:20:32 -0700 Created attachment 258186 Patch 1114690 2 258186 achristensen 2015-08-04 12:05:18 -0700 Comment on attachment 258186 Patch r=me I was thinking about doing this last week Do you think this will help with https://bugs.webkit.org/show_bug.cgi?id=146628 1114697 3 258186 commit-queue 2015-08-04 12:11:04 -0700 Comment on attachment 258186 Patch Clearing flags on attachment: 258186 Committed r187874: <http://trac.webkit.org/changeset/187874> 1114698 4 commit-queue 2015-08-04 12:11:08 -0700 All reviewed patches have been landed. Closing bug. 1114704 5 bfulgham 2015-08-04 12:18:07 -0700 (In reply to comment #2) > Comment on attachment 258186 [details] > Patch > > r=me > I was thinking about doing this last week > Do you think this will help with > https://bugs.webkit.org/show_bug.cgi?id=146628 That's my hope. I'm trying to track down any errors or differences in EWS versus the other builds. 258186 2015-08-04 11:20:32 -0700 2015-08-04 12:11:04 -0700 Patch bug-147636-20150804112025.patch text/plain 1850 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4Nzg2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE1LTA4LTA0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIGJ1aWxkLXdlYmtpdCBhbmQgTVNCdWlsZCBmaWdodCBvdmVyIEJ1 aWxkT3V0cHV0Lmh0bSwgY2F1c2luZyBidWlsZCBmYWlsdXJlcy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzYzNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgV2Ugbm8gbG9uZ2VyIG5lZWQg YnVpbGQtd2Via2l0IHRvIG1hbnVhbGx5IHRyb2xsIHRoZSBsb2cgZGF0YSBhbmQgcGlwZSBpdCB0 byBzdGRvdXQ7IE1TQnVpbGQgaXMgYWxyZWFkeSBkb2luZyB0aGlzIHByb3Blcmx5LgorICAgICAg ICBTdG9wIHRoZSBidWlsZC13ZWJraXQgc2NyaXB0IGZyb20gaW50ZXJhY3Rpbmcgd2l0aCBCdWls ZE91dHB1dC5odG0sIHRoZXJlYnkgcHJldmVudGluZyBhIHBvdGVudGlhbCBidWlsZCBmYWlsdXJl IChlc3BlY2lhbGx5CisgICAgICAgIG9uIEVXUyBtYWNoaW5lcykKKworICAgICAgICAqIFNjcmlw dHMvYnVpbGQtd2Via2l0OgorCiAyMDE1LTA4LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBNYWtlIFNhYW0gQmFyYXRpIGEgV2ViS2l0IHJl dmlld2VyLgpJbmRleDogVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQJKHJldmlzaW9uIDE4Nzc0NCkKKysrIFRvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CSh3b3JraW5nIGNvcHkpCkBAIC0yNzMsMTMgKzI3Myw2IEBAIGZv ciBteSAkZGlyIChAcHJvamVjdHMpIHsKICAgICAgICAgICAgIG15ICR3ZWJraXRTb2x1dGlvblBh dGggPSAiU291cmNlL1dlYktpdC9XZWJLaXQudmN4cHJvai9XZWJLaXQuc2xuIjsKICAgICAgICAg ICAgICRyZXN1bHQgPSBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QoJHdlYmtpdFNvbHV0aW9uUGF0 aCwgJGNsZWFuKTsKICAgICAgICAgfQotICAgICAgICBpZiAodXNpbmdWaXN1YWxTdHVkaW9FeHBy ZXNzKCkpIHsKLSAgICAgICAgICAgICMgVmlzdWFsIFN0dWRpbyBFeHByZXNzIGlzIHNvIGxhbWUg aXQgY2FuJ3Qgc3Rkb3V0IGJ1aWxkIGZhaWx1cmVzLgotICAgICAgICAgICAgIyBTbyB3ZSBmaW5k IGl0cyBsb2dzIGFuZCBkdW1wIHRoZW0gdG8gdGhlIGNvbnNvbGUgb3Vyc2VsdmVzLgotICAgICAg ICAgICAgbXkgJHZzQ29uZmlndXJhdGlvbiA9IGNvbmZpZ3VyYXRpb24oKTsKLSAgICAgICAgICAg IG9wZW4obXkgJE9VVFBVVF9IQU5ETEUsICc8JywgIiRiYXNlUHJvZHVjdERpci8kdnNDb25maWd1 cmF0aW9uL0J1aWxkT3V0cHV0Lmh0bSIpIG9yIGRpZSAiQ291bGQgbm90IG9wZW4gYnVpbGQgbG9n IGZpbGUgYXQgJGJhc2VQcm9kdWN0RGlyLyR2c0NvbmZpZ3VyYXRpb24vQnVpbGRPdXRwdXQuaHRt IjsKLSAgICAgICAgICAgIHByaW50IHdoaWxlICg8JE9VVFBVVF9IQU5ETEU+KTsKLSAgICAgICAg fQogICAgIH0KICAgICAjIFZhcmlvdXMgYnVpbGQqIGNhbGxzIGFib3ZlIG1heSBjaGFuZ2UgdGhl IENXRC4KICAgICBjaGRpcldlYktpdCgpOwo=