147195 2015-07-22 11:01:58 -0700 jsc-tailcall: Disable tail calls when profiler is enabled 2015-09-04 13:15:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 148661 P2 Normal --- 146484 146477 1 basile_clement basile_clement msaboff oldest_to_newest 1111347 0 basile_clement 2015-07-22 11:01:58 -0700 The profiler relies on having pairs of op_profile_will_call / op_profile_did_call opcodes for function calls, which is not possible with tail calls since we never return from the tail call. So, we should temporarily disable tail calls when the profiler is enabled, until we figure out a way of handling them in the profiler. 1114665 1 258188 basile_clement 2015-08-04 11:28:38 -0700 Created attachment 258188 Patch 1114686 2 258188 msaboff 2015-08-04 11:59:01 -0700 Comment on attachment 258188 Patch r=me 1123574 3 basile_clement 2015-09-04 13:15:35 -0700 *** This bug has been marked as a duplicate of bug 148661 *** 258188 2015-08-04 11:28:38 -0700 2015-08-04 11:59:01 -0700 Patch bug-147195-20150804112831.patch text/plain 4503 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj Njk2MWNkNTAzN2FiY2Y4MDNlMzdlYTM1NThkYTA0MTYzOThiM2Q2Li44ZjVjOTY1M2UyMzkwYTAx NjFkYjgwOTUzZmEyYzZkYjkyZGU4OTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNS0wOC0wNCAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAganNjLXRhaWxjYWxsOiBEaXNhYmxlIHRhaWwgY2FsbHMgd2hl biBwcm9maWxlciBpcyBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDcxOTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW5jZSB0aGUgcHJvZmlsZXIgZXhwZWN0cyBwYWlycyBvZiBvcF9wcm9m aWxlX3dpbGxfY2FsbCBhbmQKKyAgICAgICAgb3BfcHJvZmlsZV9kaWRfY2FsbCBzdXJyb3VuZGlu ZyBhIGNhbGwsIHRoaXMgY2FuJ3Qgd29yayB3aXRoIHRhaWwKKyAgICAgICAgY2FsbHMuIFdlIGNv dWxkIGNoYW5nZSB0aGUgcHJvZmlsZXIgc28gdGhhdCBpdCBpcyB0aGUgcmVzcG9uc2liaWxpdHkg b2YKKyAgICAgICAgdGhlIGNhbGxlZSB0byBlbWl0IG9wX3Byb2ZpbGVfZGlkX2NhbGwgKGJlZm9y ZSBhIHJldHVybiksIGJ1dCBzaW5jZSB3ZQorICAgICAgICB3YW50IHRvIGdldCByaWQgb2YgdGhp cyBwcm9maWxlciBldmVudHVhbGx5IGl0IG1heSBub3QgYmUgd29ydGggaXQuCisKKyAgICAgICAg VGhpcyBhbHNvIG1lYW5zIHRoYXQgZm9yIG5vdywgZGV2ZWxvcGVycyB3aWxsIHN0aWxsIGhhdmUg Y29tcGxldGUgc3RhY2sKKyAgICAgICAgdHJhY2VzIGluIFdlYiBJbnNwZWN0b3Igc2luY2UgaXQg ZW5hYmxlcyB0aGUgcHJvZmlsZXIuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVH ZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdFRhaWxD YWxsKToKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRDYWxsKToKKyAgICAg ICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRUYWlsQ2FsbFZhcmFyZ3MpOgorICAgICAg ICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdENhbGxWYXJhcmdzKToKKwogMjAxNS0wNy0z MSAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBhcHBsZS5jb20+CiAKICAgICAgICAg anNjLXRhaWxjYWxsOiBJbXBsZW1lbnQgdGhlIHRhaWwgY2FsbCBvcGNvZGVzIGluIHRoZSBERkcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVH ZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29k ZUdlbmVyYXRvci5jcHAKaW5kZXggZGQyNWQ4N2VkY2EzYjZkZWJkOTg2YzgxNDY0NmFjNGJjNGU1 M2U4NS4uNGQyODFhOTJhY2Q1ODMwYjgwNTEzMjk1MmY3Y2IxYzYzZTAyODhhYiAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVy YXRvci5jcHAKQEAgLTE4NDQsNyArMTg0NCw4IEBAIFJlZ2lzdGVySUQqIEJ5dGVjb2RlR2VuZXJh dG9yOjplbWl0Q2FsbChSZWdpc3RlcklEKiBkc3QsIFJlZ2lzdGVySUQqIGZ1bmMsIEV4cGVjCiAK IFJlZ2lzdGVySUQqIEJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0VGFpbENhbGwoUmVnaXN0ZXJJRCog ZHN0LCBSZWdpc3RlcklEKiBmdW5jLCBFeHBlY3RlZEZ1bmN0aW9uIGV4cGVjdGVkRnVuY3Rpb24s IENhbGxBcmd1bWVudHMmIGNhbGxBcmd1bWVudHMsIGNvbnN0IEpTVGV4dFBvc2l0aW9uJiBkaXZv dCwgY29uc3QgSlNUZXh0UG9zaXRpb24mIGRpdm90U3RhcnQsIGNvbnN0IEpTVGV4dFBvc2l0aW9u JiBkaXZvdEVuZCkKIHsKLSAgICByZXR1cm4gZW1pdENhbGwob3BfdGFpbF9jYWxsLCBkc3QsIGZ1 bmMsIGV4cGVjdGVkRnVuY3Rpb24sIGNhbGxBcmd1bWVudHMsIGRpdm90LCBkaXZvdFN0YXJ0LCBk aXZvdEVuZCk7CisgICAgYXV0byBvcCA9IG1fc2hvdWxkRW1pdFByb2ZpbGVIb29rcyA/IG9wX2Nh bGwgOiBvcF90YWlsX2NhbGw7CisgICAgcmV0dXJuIGVtaXRDYWxsKG9wLCBkc3QsIGZ1bmMsIGV4 cGVjdGVkRnVuY3Rpb24sIGNhbGxBcmd1bWVudHMsIGRpdm90LCBkaXZvdFN0YXJ0LCBkaXZvdEVu ZCk7CiB9CiAKIFJlZ2lzdGVySUQqIEJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0Q2FsbEV2YWwoUmVn aXN0ZXJJRCogZHN0LCBSZWdpc3RlcklEKiBmdW5jLCBDYWxsQXJndW1lbnRzJiBjYWxsQXJndW1l bnRzLCBjb25zdCBKU1RleHRQb3NpdGlvbiYgZGl2b3QsIGNvbnN0IEpTVGV4dFBvc2l0aW9uJiBk aXZvdFN0YXJ0LCBjb25zdCBKU1RleHRQb3NpdGlvbiYgZGl2b3RFbmQpCkBAIC0xOTg2LDYgKzE5 ODcsNyBAQCBSZWdpc3RlcklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdENhbGwoT3Bjb2RlSUQg b3Bjb2RlSUQsIFJlZ2lzdGVySUQqIGRzdCwgUmVnaQogICAgICAgICBlbWl0TGFiZWwoZG9uZS5n ZXQoKSk7CiAKICAgICBpZiAobV9zaG91bGRFbWl0UHJvZmlsZUhvb2tzKSB7CisgICAgICAgIEFT U0VSVChvcGNvZGVJRCAhPSBvcF90YWlsX2NhbGwpOwogICAgICAgICBlbWl0T3Bjb2RlKG9wX3By b2ZpbGVfZGlkX2NhbGwpOwogICAgICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQoY2FsbEFyZ3Vt ZW50cy5wcm9maWxlSG9va1JlZ2lzdGVyKCktPmluZGV4KCkpOwogICAgIH0KQEAgLTIwMDAsNyAr MjAwMiw4IEBAIFJlZ2lzdGVySUQqIEJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0Q2FsbFZhcmFyZ3Mo UmVnaXN0ZXJJRCogZHN0LCBSZWdpc3RlcklEKiBmdW5jCiAKIFJlZ2lzdGVySUQqIEJ5dGVjb2Rl R2VuZXJhdG9yOjplbWl0VGFpbENhbGxWYXJhcmdzKFJlZ2lzdGVySUQqIGRzdCwgUmVnaXN0ZXJJ RCogZnVuYywgUmVnaXN0ZXJJRCogdGhpc1JlZ2lzdGVyLCBSZWdpc3RlcklEKiBhcmd1bWVudHMs IFJlZ2lzdGVySUQqIGZpcnN0RnJlZVJlZ2lzdGVyLCBpbnQzMl90IGZpcnN0VmFyQXJnT2Zmc2V0 LCBSZWdpc3RlcklEKiBwcm9maWxlSG9va1JlZ2lzdGVyLCBjb25zdCBKU1RleHRQb3NpdGlvbiYg ZGl2b3QsIGNvbnN0IEpTVGV4dFBvc2l0aW9uJiBkaXZvdFN0YXJ0LCBjb25zdCBKU1RleHRQb3Np dGlvbiYgZGl2b3RFbmQpCiB7Ci0gICAgcmV0dXJuIGVtaXRDYWxsVmFyYXJncyhvcF90YWlsX2Nh bGxfdmFyYXJncywgZHN0LCBmdW5jLCB0aGlzUmVnaXN0ZXIsIGFyZ3VtZW50cywgZmlyc3RGcmVl UmVnaXN0ZXIsIGZpcnN0VmFyQXJnT2Zmc2V0LCBwcm9maWxlSG9va1JlZ2lzdGVyLCBkaXZvdCwg ZGl2b3RTdGFydCwgZGl2b3RFbmQpOworICAgIGF1dG8gb3AgPSBtX3Nob3VsZEVtaXRQcm9maWxl SG9va3MgPyBvcF9jYWxsX3ZhcmFyZ3MgOiBvcF90YWlsX2NhbGxfdmFyYXJnczsKKyAgICByZXR1 cm4gZW1pdENhbGxWYXJhcmdzKG9wLCBkc3QsIGZ1bmMsIHRoaXNSZWdpc3RlciwgYXJndW1lbnRz LCBmaXJzdEZyZWVSZWdpc3RlciwgZmlyc3RWYXJBcmdPZmZzZXQsIHByb2ZpbGVIb29rUmVnaXN0 ZXIsIGRpdm90LCBkaXZvdFN0YXJ0LCBkaXZvdEVuZCk7CiB9CiAKIFJlZ2lzdGVySUQqIEJ5dGVj b2RlR2VuZXJhdG9yOjplbWl0Q29uc3RydWN0VmFyYXJncyhSZWdpc3RlcklEKiBkc3QsIFJlZ2lz dGVySUQqIGZ1bmMsIFJlZ2lzdGVySUQqIHRoaXNSZWdpc3RlciwgUmVnaXN0ZXJJRCogYXJndW1l bnRzLCBSZWdpc3RlcklEKiBmaXJzdEZyZWVSZWdpc3RlciwgaW50MzJfdCBmaXJzdFZhckFyZ09m ZnNldCwgUmVnaXN0ZXJJRCogcHJvZmlsZUhvb2tSZWdpc3RlciwgY29uc3QgSlNUZXh0UG9zaXRp b24mIGRpdm90LCBjb25zdCBKU1RleHRQb3NpdGlvbiYgZGl2b3RTdGFydCwgY29uc3QgSlNUZXh0 UG9zaXRpb24mIGRpdm90RW5kKQpAQCAtMjAzMSw2ICsyMDM0LDcgQEAgUmVnaXN0ZXJJRCogQnl0 ZWNvZGVHZW5lcmF0b3I6OmVtaXRDYWxsVmFyYXJncyhPcGNvZGVJRCBvcGNvZGUsIFJlZ2lzdGVy SUQqIGRzdCwKICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQoYXJyYXlQcm9maWxlKTsKICAgICBp bnN0cnVjdGlvbnMoKS5hcHBlbmQocHJvZmlsZSk7CiAgICAgaWYgKG1fc2hvdWxkRW1pdFByb2Zp bGVIb29rcykgeworICAgICAgICBBU1NFUlQob3Bjb2RlICE9IG9wX3RhaWxfY2FsbF92YXJhcmdz KTsKICAgICAgICAgZW1pdE9wY29kZShvcF9wcm9maWxlX2RpZF9jYWxsKTsKICAgICAgICAgaW5z dHJ1Y3Rpb25zKCkuYXBwZW5kKHByb2ZpbGVIb29rUmVnaXN0ZXItPmluZGV4KCkpOwogICAgIH0K