145915 2015-06-12 04:03:58 -0700 Fix cast-align warning in NetworkStateNotifierEfl.cpp 2015-07-22 09:09:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy commit-queue ossy oldest_to_newest 1101537 0 ossy 2015-06-12 04:03:58 -0700 ../../Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:138:75: warning: cast from 'char *' to 'struct nlmsghdr *' increases required alignment from 1 to 4 [-Wcast-align] nlh = ((length) -= ( (((nlh)->nlmsg_len)+4U -1) & ~(4U -1) ), (struct nlmsghdr*)(((char*)(nlh)) + ( (((nlh)->nlmsg_len)+4U -1) & ~(4U -1) ))); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. 1108179 1 ossy 2015-07-09 03:13:01 -0700 Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:138 -------------------------------------------------------------------- nlh = NLMSG_NEXT(nlh, length); --- NLMSG_NEXT is defined in /usr/include/linux/netlink.h system header, which guarantees proper alignment, so we should simply suppress it here. #define NLMSG_NEXT(nlh,len) ((len) -= NLMSG_ALIGN((nlh)->nlmsg_len), \ (struct nlmsghdr*)(((char*)(nlh)) + NLMSG_ALIGN((nlh)->nlmsg_len))) #define NLMSG_ALIGN(len) ( ((len)+NLMSG_ALIGNTO-1) & ~(NLMSG_ALIGNTO-1) ) 1108180 2 256477 ossy 2015-07-09 03:15:16 -0700 Created attachment 256477 Patch 1110970 3 257186 ossy 2015-07-21 11:07:21 -0700 Created attachment 257186 Patch 1111302 4 257186 commit-queue 2015-07-22 09:09:23 -0700 Comment on attachment 257186 Patch Clearing flags on attachment: 257186 Committed r187160: <http://trac.webkit.org/changeset/187160> 1111303 5 commit-queue 2015-07-22 09:09:26 -0700 All reviewed patches have been landed. Closing bug. 256477 2015-07-09 03:15:16 -0700 2015-07-21 11:07:16 -0700 Patch bug-145915-20150709031415.patch text/plain 1633 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGI5Zjk0Y2VjMGRlZTBk N2RiMTUyYjFiMGVlZWFhYzQ4MjMyNDhhNC4uODQwMTUwNTQxYzU1ZDcxNjljZmJhODVlNTI3NWQy YTJhM2YxZTM4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA3LTA5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNhc3QtYWxp Z24gd2FybmluZyBpbiBOZXR3b3JrU3RhdGVOb3RpZmllckVmbC5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTkxNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9lZmwv TmV0d29ya1N0YXRlTm90aWZpZXJFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya1N0 YXRlTm90aWZpZXI6OnJlYWRTb2NrZXRDYWxsYmFjayk6CisKIDIwMTUtMDctMDkgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogVm9pY2VPdmVyIGNh bm5vdCBnZXQgdG8gYW55IGNvbnRlbnQgaW4gWWFob28gTWFpbCBtZXNzYWdlcyB0YWJsZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9lZmwvTmV0d29ya1N0YXRl Tm90aWZpZXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9lZmwvTmV0 d29ya1N0YXRlTm90aWZpZXJFZmwuY3BwCmluZGV4IGZlYzNlMmY1NDllOTVmZGM4ODgyNDcwNTUw MDI5MTdmNzYyNjdmNzYuLjZiM2I5ZTdjOTE2MWE2OWZjNjI1NzE0NTc3ZmQ2YzFkNjAyZDUwN2Eg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvZWZsL05ldHdvcmtT dGF0ZU5vdGlmaWVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2VmbC9OZXR3b3JrU3RhdGVOb3RpZmllckVmbC5jcHAKQEAgLTEzNSw3ICsxMzUsMTUgQEAgRWlu YV9Cb29sIE5ldHdvcmtTdGF0ZU5vdGlmaWVyOjpyZWFkU29ja2V0Q2FsbGJhY2sodm9pZCogdXNl ckRhdGEsIEVjb3JlX0ZkX0hhbmQKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmICgobmxo LT5ubG1zZ190eXBlID09IFJUTV9ORVdBRERSICYmICFub3RpZmllci0+bV9pc09uTGluZSkgfHwg KG5saC0+bmxtc2dfdHlwZSA9PSBSVE1fREVMQUREUiAmJiBub3RpZmllci0+bV9pc09uTGluZSkp CiAgICAgICAgICAgICAgICAgZGV0ZWN0ZWRDaGFuZ2UgPSB0cnVlOworCisjaWYgQ09NUElMRVIo R0NDKQorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21hIEdDQyBkaWFnbm9zdGlj IGlnbm9yZWQgIi1XY2FzdC1hbGlnbiIKKyNlbmRpZgogICAgICAgICAgICAgbmxoID0gTkxNU0df TkVYVChubGgsIGxlbmd0aCk7CisjaWYgQ09NUElMRVIoR0NDKQorI3ByYWdtYSBHQ0MgZGlhZ25v c3RpYyBwb3AKKyNlbmRpZgogICAgICAgICB9CiAgICAgfQogCg== 257186 2015-07-21 11:07:21 -0700 2015-07-22 09:09:23 -0700 Patch bug-145915-20150721110607.patch text/plain 1640 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTEyMjUxMjYwMDJhZjIx Y2UyMGYyNGI1MDNhZDMzMzZkNjVkNTRiMi4uMWVmYjRiM2FkMmRiNWM2YWVlMjBhNjYwYTk2NzVm Yjc0ZDVhY2NhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA3LTIxICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNhc3QtYWxp Z24gd2FybmluZyBpbiBOZXR3b3JrU3RhdGVOb3RpZmllckVmbC5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTkxNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9lZmwv TmV0d29ya1N0YXRlTm90aWZpZXJFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya1N0 YXRlTm90aWZpZXI6OnJlYWRTb2NrZXRDYWxsYmFjayk6CisKIDIwMTUtMDctMjAgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04o cjE4NDM3Nik6IFtTT1VQXSBNdWx0aXBsZSBhc3NlcnRpb25zIHdoZW4gZG93bmxvYWRpbmcgZmls ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvZWZsL05ldHdv cmtTdGF0ZU5vdGlmaWVyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv ZWZsL05ldHdvcmtTdGF0ZU5vdGlmaWVyRWZsLmNwcAppbmRleCBmZWMzZTJmNTQ5ZTk1ZmRjODg4 MjQ3MDU1MDAyOTE3Zjc2MjY3Zjc2Li42YjNiOWU3YzkxNjFhNjlmYzYyNTcxNDU3N2ZkNmMxZDYw MmQ1MDdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2VmbC9O ZXR3b3JrU3RhdGVOb3RpZmllckVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9lZmwvTmV0d29ya1N0YXRlTm90aWZpZXJFZmwuY3BwCkBAIC0xMzUsNyArMTM1LDE1 IEBAIEVpbmFfQm9vbCBOZXR3b3JrU3RhdGVOb3RpZmllcjo6cmVhZFNvY2tldENhbGxiYWNrKHZv aWQqIHVzZXJEYXRhLCBFY29yZV9GZF9IYW5kCiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBp ZiAoKG5saC0+bmxtc2dfdHlwZSA9PSBSVE1fTkVXQUREUiAmJiAhbm90aWZpZXItPm1faXNPbkxp bmUpIHx8IChubGgtPm5sbXNnX3R5cGUgPT0gUlRNX0RFTEFERFIgJiYgbm90aWZpZXItPm1faXNP bkxpbmUpKQogICAgICAgICAgICAgICAgIGRldGVjdGVkQ2hhbmdlID0gdHJ1ZTsKKworI2lmIENP TVBJTEVSKEdDQykKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBHQ0MgZGlh Z25vc3RpYyBpZ25vcmVkICItV2Nhc3QtYWxpZ24iCisjZW5kaWYKICAgICAgICAgICAgIG5saCA9 IE5MTVNHX05FWFQobmxoLCBsZW5ndGgpOworI2lmIENPTVBJTEVSKEdDQykKKyNwcmFnbWEgR0ND IGRpYWdub3N0aWMgcG9wCisjZW5kaWYKICAgICAgICAgfQogICAgIH0KIAo=