145757 2015-06-08 06:39:05 -0700 Fix unused private field warning in GraphicsLayerUpdater.h 2015-06-09 12:30:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy commit-queue ossy oldest_to_newest 1100348 0 ossy 2015-06-08 06:39:05 -0700 clang build log: ----------------- In file included from ../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:27: ../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.h:66:33: warning: private field 'm_client' is not used [-Wunused-private-field] GraphicsLayerUpdaterClient& m_client; m_client is only used if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true. But it is true only on Cocoa platform. Let's guard this member properly. 1100350 1 254490 ossy 2015-06-08 06:41:04 -0700 Created attachment 254490 Patch 1100727 2 254490 darin 2015-06-09 11:42:04 -0700 Comment on attachment 254490 Patch Is there any way to do this more elegantly and thoroughly? I’m not sure what the value is of having a virtual destructor and a boolean when USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false. 1100744 3 254490 commit-queue 2015-06-09 12:30:45 -0700 Comment on attachment 254490 Patch Clearing flags on attachment: 254490 Committed r185372: <http://trac.webkit.org/changeset/185372> 1100745 4 commit-queue 2015-06-09 12:30:48 -0700 All reviewed patches have been landed. Closing bug. 254490 2015-06-08 06:41:04 -0700 2015-06-09 12:30:45 -0700 Patch bug-145757-20150608064038.patch text/plain 2496 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA0M2ZiYThlNTBiMWFl NGE5OTdiN2Y4NzdiNGJlMjNhZDQ5NDdiZC4uNzQ2NTIzNTFjNWQ5NzA5MTY5MTQ3MGI2YzIyZDRm N2Q4MGZlNjBhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA2LTA4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHVudXNlZCBw cml2YXRlIGZpZWxkIHdhcm5pbmcgaW4gR3JhcGhpY3NMYXllclVwZGF0ZXIuaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzU3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc0xheWVyVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xh eWVyVXBkYXRlcjo6R3JhcGhpY3NMYXllclVwZGF0ZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzTGF5ZXJVcGRhdGVyLmg6CisKIDIwMTUtMDYtMDcgIERhcmluIEFkbGVy ICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxODE3MjApOiBVbm5l Y2Vzc2FyeSBsYXlvdXQgdHJpZ2dlcmVkIGFueSB0aW1lIGFuaW1hdGVkIEdJRiBhZHZhbmNlcyB0 byBhIG5ldyBmcmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvR3JhcGhpY3NMYXllclVwZGF0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NMYXllclVwZGF0ZXIuY3BwCmluZGV4IGU3NTkyNmY5OWNiMDk4MGEwOTQw MDcwODIwYWViZmJiN2JhNDQ0OTUuLjA1MDMzMDVmNzM5MGUyYTc3MDk0N2FiZjQxNjIzZDMyODc2 ZTFhMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzTGF5ZXJVcGRhdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc0xheWVyVXBkYXRlci5jcHAKQEAgLTMxLDE3ICszMSwxOSBAQAogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKKyNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfRElTUExBWV9N T05JVE9SKQogR3JhcGhpY3NMYXllclVwZGF0ZXI6OkdyYXBoaWNzTGF5ZXJVcGRhdGVyKEdyYXBo aWNzTGF5ZXJVcGRhdGVyQ2xpZW50JiBjbGllbnQsIFBsYXRmb3JtRGlzcGxheUlEIGRpc3BsYXlJ RCkKICAgICA6IG1fY2xpZW50KGNsaWVudCkKIHsKLSNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05f RlJBTUVfRElTUExBWV9NT05JVE9SKQogICAgIERpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXI6 OnNoYXJlZE1hbmFnZXIoKS5yZWdpc3RlckNsaWVudCgqdGhpcyk7CiAgICAgRGlzcGxheVJlZnJl c2hNb25pdG9yTWFuYWdlcjo6c2hhcmVkTWFuYWdlcigpLndpbmRvd1NjcmVlbkRpZENoYW5nZShk aXNwbGF5SUQsICp0aGlzKTsKICAgICBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyOjpzaGFy ZWRNYW5hZ2VyKCkuc2NoZWR1bGVBbmltYXRpb24oKnRoaXMpOworfQogI2Vsc2UKLSAgICBVTlVT RURfUEFSQU0oZGlzcGxheUlEKTsKLSNlbmRpZgorR3JhcGhpY3NMYXllclVwZGF0ZXI6OkdyYXBo aWNzTGF5ZXJVcGRhdGVyKEdyYXBoaWNzTGF5ZXJVcGRhdGVyQ2xpZW50JiwgUGxhdGZvcm1EaXNw bGF5SUQpCit7CiB9CisjZW5kaWYKIAogR3JhcGhpY3NMYXllclVwZGF0ZXI6On5HcmFwaGljc0xh eWVyVXBkYXRlcigpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0xheWVyVXBkYXRlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NMYXllclVwZGF0ZXIuaAppbmRleCAyNDczYmE0N2E4ZjkwMGM5ZWZmNmU5 ZTdmYWQ1MDcxYWM5Zjg4NzkyLi44NjcxZjE2YTQ1Mzg0YzE5NWRkMGFiODA3YzA5OTVjY2JhYTBm ZGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0xheWVyVXBkYXRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzTGF5ZXJVcGRhdGVyLmgKQEAgLTYxLDkgKzYxLDggQEAgcHVibGljOgogcHJpdmF0ZToK ICNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfRElTUExBWV9NT05JVE9SKQogICAgIHZp cnR1YWwgdm9pZCBkaXNwbGF5UmVmcmVzaEZpcmVkKGRvdWJsZSB0aW1lc3RhbXApIG92ZXJyaWRl OwotI2VuZGlmCi0KICAgICBHcmFwaGljc0xheWVyVXBkYXRlckNsaWVudCYgbV9jbGllbnQ7Cisj ZW5kaWYKICAgICBib29sIG1fc2NoZWR1bGVkIHsgZmFsc2UgfTsKIH07CiAK