145756 2015-06-08 06:03:19 -0700 [GTK] Remove the unused scroll function from WebPageGtk.cpp 2015-06-08 07:08:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy cgarcia commit-queue ossy zan oldest_to_newest 1100344 0 ossy 2015-06-08 06:03:19 -0700 Before r164745 the scroll function in WebPageGtk.cpp was same as in WebPage.cpp, except the return type ( void vs bool ): - https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp?rev=164744#L1937 - https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp#L91 But the scroll function in WebPageGtk.cpp is unused as clang noticed it ( https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp#L2202 ) ../../Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:91:24: warning: unused function 'scroll' [-Wunused-function] static __inline__ void scroll(Page* page, ScrollDirection direction, ScrollGranularity granularity) 1100345 1 254488 ossy 2015-06-08 06:04:08 -0700 Created attachment 254488 Patch 1100353 2 254488 commit-queue 2015-06-08 07:08:55 -0700 Comment on attachment 254488 Patch Clearing flags on attachment: 254488 Committed r185315: <http://trac.webkit.org/changeset/185315> 1100354 3 commit-queue 2015-06-08 07:08:58 -0700 All reviewed patches have been landed. Closing bug. 254488 2015-06-08 06:04:08 -0700 2015-06-08 07:08:55 -0700 Patch bug-145756-20150608060342.patch text/plain 1602 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjUwYWZmMzI5ZWI4ZTcx ZDBjZDM0MTcxNGE1OTBiZDVlY2RiMDE4MC4uMDk3NzExMGIwNzcxNzM3MzcyNWI5NmI4MmY2ZjUw NjI1MTJmZmI0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA2LTA4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0dUS10gUmVtb3Zl IHRoZSB1bnVzZWQgc2Nyb2xsIGZ1bmN0aW9uIGZyb20gV2ViUGFnZUd0ay5jcHAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTc1NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL2d0ay9XZWJQYWdlR3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6c2Nyb2xsKTogRGVsZXRl ZC4KKwogMjAxNS0wNi0wOCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTg1MjYyKTogW0VGTF0gTW9kaWZ5IGxlZ2FjeVBsYXRm b3JtRGVmYXVsdE5ldHdvcmtDYWNoZURpcmVjdG9yeSgpIGFjY29yZGluZyB0byBuZXR3b3JrIGNh Y2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dl YlBhZ2VHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9XZWJQ YWdlR3RrLmNwcAppbmRleCAzZjJhYjk0NWJiYTlkMDYzOGMxYzkzYmY5YWNhNGJkN2E2N2I5ZjE1 Li5lYzk5MGVjZDYxYjFlODU3N2Y4ZWRiOGU5NzJmNWE4ZmMyY2ZhNTM1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlBhZ2VHdGsuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAKQEAg LTg4LDExICs4OCw2IEBAIHZvaWQgV2ViUGFnZTo6cGxhdGZvcm1QcmVmZXJlbmNlc0RpZENoYW5n ZShjb25zdCBXZWJQcmVmZXJlbmNlc1N0b3JlJikKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQog Ci1zdGF0aWMgaW5saW5lIHZvaWQgc2Nyb2xsKFBhZ2UqIHBhZ2UsIFNjcm9sbERpcmVjdGlvbiBk aXJlY3Rpb24sIFNjcm9sbEdyYW51bGFyaXR5IGdyYW51bGFyaXR5KQotewotICAgIHBhZ2UtPmZv Y3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpLmV2ZW50SGFuZGxlcigpLnNjcm9s bFJlY3Vyc2l2ZWx5KGRpcmVjdGlvbiwgZ3JhbnVsYXJpdHkpOwotfQotCiBib29sIFdlYlBhZ2U6 OnBlcmZvcm1EZWZhdWx0QmVoYXZpb3JGb3JLZXlFdmVudChjb25zdCBXZWJLZXlib2FyZEV2ZW50 JiBrZXlib2FyZEV2ZW50KQogewogICAgIGlmIChrZXlib2FyZEV2ZW50LnR5cGUoKSAhPSBXZWJF dmVudDo6S2V5RG93biAmJiBrZXlib2FyZEV2ZW50LnR5cGUoKSAhPSBXZWJFdmVudDo6UmF3S2V5 RG93bikK