145754 2015-06-08 03:09:04 -0700 [ARM] Add the missing setupArgumentsWithExecState functions after r185240 2015-06-08 13:23:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 145673 1 ossy ossy benjamin cgarcia clopez commit-queue ggaren gyuyoung.kim ossy oldest_to_newest 1100329 0 ossy 2015-06-08 03:09:04 -0700 http://trac.webkit.org/changeset/185240 broke the ARM Linux builds because of missing setupArgumentsWithExecState implementations. I started work on it, patch is coming soon. 1100331 1 254484 ossy 2015-06-08 03:30:32 -0700 Created attachment 254484 Patch build already tested, I'll set r? flag when testing is finished. 1100342 2 254484 ossy 2015-06-08 05:53:26 -0700 Comment on attachment 254484 Patch all tests pass with the patch 1100398 3 254484 benjamin 2015-06-08 10:18:40 -0700 Comment on attachment 254484 Patch Is this for classic ARM? IIRC, I tried my patch on ARMv7. Thanks for fixing in any case. 1100401 4 ossy 2015-06-08 10:32:30 -0700 (In reply to comment #3) > Comment on attachment 254484 [details] > Patch > > Is this for classic ARM? IIRC, I tried my patch on ARMv7. > > Thanks for fixing in any case. This build issue isn't related to the ARM/Thumb2 instruction set or v6/v7 architecture. On Linux we use ARM EABI and we have to align a 64-bit integer to even numbered register. EABI_32BIT_DUMMY_ARG macro ( == TrustedImm32(0) ) is responible for this alignment. But unfortunately we need more setupArgumentsWithExecState() because of the dummy argument. 1100409 5 254484 commit-queue 2015-06-08 11:22:30 -0700 Comment on attachment 254484 Patch Clearing flags on attachment: 254484 Committed r185323: <http://trac.webkit.org/changeset/185323> 1100410 6 commit-queue 2015-06-08 11:22:34 -0700 All reviewed patches have been landed. Closing bug. 1100435 7 benjamin 2015-06-08 13:23:10 -0700 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 254484 [details] > > Patch > > > > Is this for classic ARM? IIRC, I tried my patch on ARMv7. > > > > Thanks for fixing in any case. > > This build issue isn't related to the ARM/Thumb2 instruction set or > v6/v7 architecture. On Linux we use ARM EABI and we have to align a > 64-bit integer to even numbered register. EABI_32BIT_DUMMY_ARG macro > ( == TrustedImm32(0) ) is responible for this alignment. But unfortunately > we need more setupArgumentsWithExecState() because of the dummy argument. Oh, I did not know about that. I'll try to remember that for next time. 254484 2015-06-08 03:30:32 -0700 2015-06-08 11:22:30 -0700 Patch bug-145754-20150608033006.patch text/plain 2489 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MGQ1MjMyY2U1NmIwZTYwN2RjYjc1ZjZkZjdjYzk5M2E2YmQ1MjQzLi5mMjdjYTM3YmM3MDU2MzBj ZGQ3OTEwYmY1ODNkMWIyOWRkNDNlNDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wNi0wOCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtBUk1dIEFkZCB0aGUgbWlzc2luZyBzZXR1cEFyZ3VtZW50c1dpdGhF eGVjU3RhdGUgZnVuY3Rpb25zIGFmdGVyIHIxODUyNDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTc1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaml0L0NDYWxsSGVscGVycy5oOgorICAgICAgICAo SlNDOjpDQ2FsbEhlbHBlcnM6OnNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZSk6CisKIDIwMTUt MDYtMDYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJldHVybmVk IEV4Y2VwdGlvbiogdmFsdWVzIG5lZWQgdG8gYmUgaW5pdGlhbGl6ZWQgdG8gbnVsbHB0ciB3aGVu IG5vIGV4Y2VwdGlvbnMgYXJlIHRocm93bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxs SGVscGVycy5oCmluZGV4IGU0NzY2Mjc1NDc5ODJhZmJlMTIzNWViNGUyOTk1ZjBlMDM3NTU2YjUu LmI2OTI5M2JmNjk3ZWM1ODdlZTkzOTZhMjNhZTk0NzA0ZTIyY2ZlYjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9DQ2FsbEhlbHBlcnMuaApAQCAtMTgxMCw2ICsxODEwLDE0IEBAIHB1Ymxp YzoKICAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKGFyZzEsIGFyZzIsIGFyZzMp OwogICAgIH0KIAorICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhFeGVj U3RhdGUoVHJ1c3RlZEltbTMyIGFyZzEsIEdQUlJlZyBhcmcyLCBHUFJSZWcgYXJnMywgR1BSUmVn IGFyZzQsIEdQUlJlZyBhcmc1LCBUcnVzdGVkSW1tUHRyIGFyZzYpCisgICAgeworICAgICAgICBw b2tlKGFyZzYsIFBPS0VfQVJHVU1FTlRfT0ZGU0VUICsgMik7CisgICAgICAgIHBva2UoYXJnNSwg UE9LRV9BUkdVTUVOVF9PRkZTRVQgKyAxKTsKKyAgICAgICAgcG9rZShhcmc0LCBQT0tFX0FSR1VN RU5UX09GRlNFVCk7CisgICAgICAgIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShhcmcxLCBh cmcyLCBhcmczKTsKKyAgICB9CisKICAgICBBTFdBWVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVu dHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW0zMiBhcmcxLCBHUFJSZWcgYXJnMiwgR1BSUmVnIGFy ZzMsIEdQUlJlZyBhcmc0LCBHUFJSZWcgYXJnNSwgR1BSUmVnIGFyZzYsIEdQUlJlZyBhcmc3KQog ICAgIHsKICAgICAgICAgcG9rZShhcmc3LCBQT0tFX0FSR1VNRU5UX09GRlNFVCArIDMpOwpAQCAt MTgyOCw2ICsxODM2LDE2IEBAIHB1YmxpYzoKICAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhl Y1N0YXRlKGFyZzEsIGFyZzIsIGFyZzMpOwogICAgIH0KIAorICAgIEFMV0FZU19JTkxJTkUgdm9p ZCBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoVHJ1c3RlZEltbTMyIGFyZzEsIEdQUlJlZyBh cmcyLCBHUFJSZWcgYXJnMywgR1BSUmVnIGFyZzQsIEdQUlJlZyBhcmc1LCBHUFJSZWcgYXJnNiwg R1BSUmVnIGFyZzcsIFRydXN0ZWRJbW1QdHIgYXJnOCkKKyAgICB7CisgICAgICAgIHBva2UoYXJn OCwgUE9LRV9BUkdVTUVOVF9PRkZTRVQgKyA0KTsKKyAgICAgICAgcG9rZShhcmc3LCBQT0tFX0FS R1VNRU5UX09GRlNFVCArIDMpOworICAgICAgICBwb2tlKGFyZzYsIFBPS0VfQVJHVU1FTlRfT0ZG U0VUICsgMik7CisgICAgICAgIHBva2UoYXJnNSwgUE9LRV9BUkdVTUVOVF9PRkZTRVQgKyAxKTsK KyAgICAgICAgcG9rZShhcmc0LCBQT0tFX0FSR1VNRU5UX09GRlNFVCk7CisgICAgICAgIHNldHVw QXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShhcmcxLCBhcmcyLCBhcmczKTsKKyAgICB9CisKICAgICBB TFdBWVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW0z MiBhcmcxLCBHUFJSZWcgYXJnMiwgR1BSUmVnIGFyZzMsIFRydXN0ZWRJbW0zMiBhcmc0LCBUcnVz dGVkSW1tMzIgYXJnNSwgR1BSUmVnIGFyZzYsIEdQUlJlZyBhcmc3KQogICAgIHsKICAgICAgICAg cG9rZShhcmc3LCBQT0tFX0FSR1VNRU5UX09GRlNFVCArIDMpOwo=