145264 2015-05-21 06:27:11 -0700 [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn 2015-06-01 03:58:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy cgarcia gyuyoung.kim ossy oldest_to_newest 1096569 0 ossy 2015-05-21 06:27:11 -0700 issuse no1: ------------ Now unused parameter warnings are suppressed in WebKit2, but unfortunately the actual mechanism is only works with GCC, but not with Clang. The problem is that the command like looks like "-Wno-unused-parameter -Wall -Wextra" and Clang's -Wextra switches the unused parameter warning back. The proper fix is to put -Wno-unused-parameter after -Wextra. issuse no2: ------------ There are zillion unused parameter warnings in TestNetscapePlugIn, but we can't see them because of a bug: WEBKIT_SET_EXTRA_COMPILER_FLAGS(TestNetscapePlugin) is missing and no warnings options are passed to TestNetscapePlugIn. We should fix it and suppress only the unused parameter warnings there. 1096572 1 253522 ossy 2015-05-21 06:49:25 -0700 Created attachment 253522 Patch 1096573 2 253523 ossy 2015-05-21 07:10:33 -0700 Created attachment 253523 Patch typo fixed in changelog 1098467 3 253523 ossy 2015-06-01 03:57:53 -0700 Comment on attachment 253523 Patch Clearing flags on attachment: 253523 Committed r185056: <http://trac.webkit.org/changeset/185056> 1098468 4 ossy 2015-06-01 03:58:00 -0700 All reviewed patches have been landed. Closing bug. 253522 2015-05-21 06:49:25 -0700 2015-05-21 07:10:26 -0700 Patch bug-145264-20150521064920.patch text/plain 3443 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGFjNTQzZWQxZWI5ZTRl OTA3YzAxN2U0ZDIyMDg4MDVmNDc2ZmQ4ZS4uZDFiNjZiZTkwYWU2MDdkY2UwYWRiMWZlZWE2MWEx N2ZkYzVjNjBiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE1LTA1LTIxICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW2NtYWtlXSBTdXBw cmVzcyB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIFdlYktpdDIgYW5kIFRlc3ROZXRzY2Fw ZVBsdWdJbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ1MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDogVXNlIENPTVBJTEVfRkxBR1MgaW5zdGVhZCBvZiBDTUFLRV88Q3xD WFg+X0ZMQUdTIHRvIHB1dCAtV25vLXVudXNlZC1wYXJhbWV0ZXIgYmVmb3JlIC1XZXh0cmEuCisK KzIwMTUtMDUtMjEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwogICAg ICAgICBbRUZMXSBSZW1vdmUgYW4gdW51c2VkIHByaXZhdGUgZmllbGQgZnJvbSBFd2tQb3B1cE1l bnVJdGVtIGNsYXNzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDUyNDkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQg Yi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dAppbmRleCBiNzYxNjQyYjgxYjZlMWVkOWFl MGVmYTUwMDVmOGJlMTY2MjRkOGQ4Li41NDdhYTY3ODM4ODBhY2M3YTFiY2UzZDEwM2Y5ZmU3ZTg5 MWUyY2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dAorKysgYi9T b3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dApAQCAtNzcwLDEwICs3NzAsNiBAQCBtYWNybyhB RERfV0VCS0lUMl9QUkVGSVhfSEVBREVSIF90YXJnZXQpCiAgICAgZW5kaWYgKCkKIGVuZG1hY3Jv KCkKIAotIyBTdXBwcmVzcyB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGZvciBzb3VyY2VzIGlu IFdlYktpdDIuCi1zZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAtV25vLXVudXNl ZC1wYXJhbWV0ZXIiKQotc2V0KENNQUtFX0NYWF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1X bm8tdW51c2VkLXBhcmFtZXRlciIpCi0KIFdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19JRl9F WElTVFMoKQogCiBHRU5FUkFURV9XRUJLSVQyX01FU1NBR0VfU09VUkNFUyhXZWJLaXQyX0RFUklW RURfU09VUkNFUyAiJHtXZWJLaXQyX01FU1NBR0VTX0lOX0ZJTEVTfSIpCkBAIC03ODcsNiArNzgz LDkgQEAgYWRkX3dlYmtpdDJfcHJlZml4X2hlYWRlcihXZWJLaXQyKQogdGFyZ2V0X2xpbmtfbGli cmFyaWVzKFdlYktpdDIgJHtXZWJLaXQyX0xJQlJBUklFU30pCiBzZXRfdGFyZ2V0X3Byb3BlcnRp ZXMoV2ViS2l0MiBQUk9QRVJUSUVTIEZPTERFUiAiV2ViS2l0IikKIAorIyBTdXBwcmVzcyB1bnVz ZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGZvciBzb3VyY2VzIGluIFdlYktpdDIuCitBRERfVEFSR0VU X1BST1BFUlRJRVMoV2ViS2l0MiBDT01QSUxFX0ZMQUdTICItV25vLXVudXNlZC1wYXJhbWV0ZXIi KQorCiBpZiAoV2ViS2l0Ml9WRVJTSU9OX1NDUklQVCkKICAgICBBRERfVEFSR0VUX1BST1BFUlRJ RVMoV2ViS2l0MiBMSU5LX0ZMQUdTICIke1dlYktpdDJfVkVSU0lPTl9TQ1JJUFR9IikKIGVuZGlm ICgpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg NTQ3OTI5NjNiYTYxMzI3NGM3NjE5NmUyZDEwOTc0MzFkZTFiZGU0MC4uYmVmMTk0MjI5NjY2NjYx ZDZlYzBkNzAwZmYwZWEzMjkwZjg0YmM2OSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisr KyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA1LTIxICBDc2FiYSBP c3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2NtYWtlXSBTdXBwcmVz cyB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIFdlYktpdDIgYW5kIFRlc3ROZXRzY2FwZVBs dWdJbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1 MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQ6IFNldCBleHRy YSBjb21waWxlciBmbGFncyBhbmQgc3VwcHJlc3Mgb25seSB1bnVzZWQgcGFyYW1ldGVyIHdhcm5p bmdzLgorCiAyMDE1LTA1LTIwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXSBNb3ZlIE1haW5UaHJlYWRHdGssIFJ1bkxvb3BHdGssIFdvcmtRdWV1 ZUd0ayB1bmRlciBTb3VyY2UvV1RGL3d0Zi9nbGliLwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0IGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0CmluZGV4IDU1ZTZhNGQ1 YTc3ZWZkMjc2MjlhZWVmNDQyYmQxZTM4Y2FhYmRiYzUuLmI0YjhjMjIwMTBhNzFjMGY1NmJhNDUy ZDg0YzcxMzQ5NWY2MjQ2NTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3RO ZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9U ZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQKQEAgLTQ5LDMgKzQ5LDcgQEAgZW5kaWYg KCkKIGFkZF9saWJyYXJ5KFRlc3ROZXRzY2FwZVBsdWdpbiBTSEFSRUQgJHtXZWJLaXRUZXN0TmV0 c2NhcGVQbHVnaW5fU09VUkNFU30pCiB0YXJnZXRfbGlua19saWJyYXJpZXMoVGVzdE5ldHNjYXBl UGx1Z2luICR7V2ViS2l0VGVzdE5ldHNjYXBlUGx1Z2luX0xJQlJBUklFU30pCiBzZXRfdGFyZ2V0 X3Byb3BlcnRpZXMoVGVzdE5ldHNjYXBlUGx1Z2luIFBST1BFUlRJRVMgTElCUkFSWV9PVVRQVVRf RElSRUNUT1JZICR7Q01BS0VfTElCUkFSWV9PVVRQVVRfRElSRUNUT1JZfS9wbHVnaW5zKQorV0VC S0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyhUZXN0TmV0c2NhcGVQbHVnaW4pCisKKyMgU3Vw cHJlc3MgdW51c2VkIHBhcmFtZXRlciB3YXJuaW5ncyBmb3Igc291cmNlcyBpbiBXZWJLaXQyLgor QUREX1RBUkdFVF9QUk9QRVJUSUVTKFRlc3ROZXRzY2FwZVBsdWdpbiBDT01QSUxFX0ZMQUdTICIt V25vLXVudXNlZC1wYXJhbWV0ZXIiKQo= 253523 2015-05-21 07:10:33 -0700 2015-06-01 03:57:53 -0700 Patch bug-145264-20150521071028.patch text/plain 3460 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGFjNTQzZWQxZWI5ZTRl OTA3YzAxN2U0ZDIyMDg4MDVmNDc2ZmQ4ZS4uMWZkZDIyZTI1NjU0ODk2MWUwMzFiYmZiZjQyYTFj MjVhZDIxYzBiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE1LTA1LTIxICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW2NtYWtlXSBTdXBw cmVzcyB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIFdlYktpdDIgYW5kIFRlc3ROZXRzY2Fw ZVBsdWdJbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ1MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDogVXNlIENPTVBJTEVfRkxBR1MgaW5zdGVhZCBvZiBDTUFLRV88Q3xD WFg+X0ZMQUdTIHRvIHB1dCAtV25vLXVudXNlZC1wYXJhbWV0ZXIgYWZ0ZXIgLVdleHRyYS4KKwor MjAxNS0wNS0yMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCiAgICAg ICAgIFtFRkxdIFJlbW92ZSBhbiB1bnVzZWQgcHJpdmF0ZSBmaWVsZCBmcm9tIEV3a1BvcHVwTWVu dUl0ZW0gY2xhc3MKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NTI0OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dCBi L1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0CmluZGV4IGI3NjE2NDJiODFiNmUxZWQ5YWUw ZWZhNTAwNWY4YmUxNjYyNGQ4ZDguLjU0N2FhNjc4Mzg4MGFjYzdhMWJjZTNkMTAzZjlmZTdlODkx ZTJjYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0CkBAIC03NzAsMTAgKzc3MCw2IEBAIG1hY3JvKEFE RF9XRUJLSVQyX1BSRUZJWF9IRUFERVIgX3RhcmdldCkKICAgICBlbmRpZiAoKQogZW5kbWFjcm8o KQogCi0jIFN1cHByZXNzIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MgZm9yIHNvdXJjZXMgaW4g V2ViS2l0Mi4KLXNldChDTUFLRV9DX0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1Xbm8tdW51c2Vk LXBhcmFtZXRlciIpCi1zZXQoQ01BS0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9GTEFHU30gLVdu by11bnVzZWQtcGFyYW1ldGVyIikKLQogV0VCS0lUX0lOQ0xVREVfQ09ORklHX0ZJTEVTX0lGX0VY SVNUUygpCiAKIEdFTkVSQVRFX1dFQktJVDJfTUVTU0FHRV9TT1VSQ0VTKFdlYktpdDJfREVSSVZF RF9TT1VSQ0VTICIke1dlYktpdDJfTUVTU0FHRVNfSU5fRklMRVN9IikKQEAgLTc4Nyw2ICs3ODMs OSBAQCBhZGRfd2Via2l0Ml9wcmVmaXhfaGVhZGVyKFdlYktpdDIpCiB0YXJnZXRfbGlua19saWJy YXJpZXMoV2ViS2l0MiAke1dlYktpdDJfTElCUkFSSUVTfSkKIHNldF90YXJnZXRfcHJvcGVydGll cyhXZWJLaXQyIFBST1BFUlRJRVMgRk9MREVSICJXZWJLaXQiKQogCisjIFN1cHByZXNzIHVudXNl ZCBwYXJhbWV0ZXIgd2FybmluZ3MgZm9yIHNvdXJjZXMgaW4gV2ViS2l0Mi4KK0FERF9UQVJHRVRf UFJPUEVSVElFUyhXZWJLaXQyIENPTVBJTEVfRkxBR1MgIi1Xbm8tdW51c2VkLXBhcmFtZXRlciIp CisKIGlmIChXZWJLaXQyX1ZFUlNJT05fU0NSSVBUKQogICAgIEFERF9UQVJHRVRfUFJPUEVSVElF UyhXZWJLaXQyIExJTktfRkxBR1MgIiR7V2ViS2l0Ml9WRVJTSU9OX1NDUklQVH0iKQogZW5kaWYg KCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBj NTc0YTQ2ZGI2N2NlZDg4MmFkYWNhZDU3MGExNmU2ZjBjZjI1MjdjLi4zZDBlNTdjYmE2NDZjNTVj ZWM3NWQxN2JmZjgzZjhjMWI1ZWQ1MGUyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTUtMDUtMjEgIENzYWJhIE9z enRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAorICAgICAgICBbY21ha2VdIFN1cHByZXNz IHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MgaW4gV2ViS2l0MiBhbmQgVGVzdE5ldHNjYXBlUGx1 Z0luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUy NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dDogU2V0IGV4dHJh IGNvbXBpbGVyIGZsYWdzIGFuZCBzdXBwcmVzcyBvbmx5IHVudXNlZCBwYXJhbWV0ZXIgd2Fybmlu Z3MuCisKKzIwMTUtMDUtMjEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K KwogICAgICAgICBbRUZMXSBCdW1wIGxpYnNvdXAgdmVyc2lvbiB0byAyLjUwLjAKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTEyNwogCmRpZmYgLS1n aXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50 eHQgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50 eHQKaW5kZXggNTVlNmE0ZDVhNzdlZmQyNzYyOWFlZWY0NDJiZDFlMzhjYWFiZGJjNS4uYjRiOGMy MjAxMGE3MWMwZjU2YmE0NTJkODRjNzEzNDk1ZjYyNDY1OCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dApAQCAtNDks MyArNDksNyBAQCBlbmRpZiAoKQogYWRkX2xpYnJhcnkoVGVzdE5ldHNjYXBlUGx1Z2luIFNIQVJF RCAke1dlYktpdFRlc3ROZXRzY2FwZVBsdWdpbl9TT1VSQ0VTfSkKIHRhcmdldF9saW5rX2xpYnJh cmllcyhUZXN0TmV0c2NhcGVQbHVnaW4gJHtXZWJLaXRUZXN0TmV0c2NhcGVQbHVnaW5fTElCUkFS SUVTfSkKIHNldF90YXJnZXRfcHJvcGVydGllcyhUZXN0TmV0c2NhcGVQbHVnaW4gUFJPUEVSVElF UyBMSUJSQVJZX09VVFBVVF9ESVJFQ1RPUlkgJHtDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RP Ull9L3BsdWdpbnMpCitXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTKFRlc3ROZXRzY2Fw ZVBsdWdpbikKKworIyBTdXBwcmVzcyB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGZvciBzb3Vy Y2VzIGluIFdlYktpdDIuCitBRERfVEFSR0VUX1BST1BFUlRJRVMoVGVzdE5ldHNjYXBlUGx1Z2lu IENPTVBJTEVfRkxBR1MgIi1Xbm8tdW51c2VkLXBhcmFtZXRlciIpCg==