145125 2015-05-18 03:28:59 -0700 Suppress null-conversion warnings in ANGLE 2015-06-18 10:55:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145010 145121 1 ossy ossy achristensen commit-queue ossy oldest_to_newest 1095597 0 ossy 2015-05-18 03:28:59 -0700 ./glslang_lex.cpp:1282:84: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2463:83: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2490:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2640:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2649:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2665:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2673:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2857:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2870:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2932:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:2947:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./glslang_lex.cpp:3112:82: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] 12 warnings generated. ./Tokenizer.cpp:848:84: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1604:83: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1631:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1781:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1790:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1806:81: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1814:80: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:1998:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2011:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2073:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2088:89: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] ./Tokenizer.cpp:2253:82: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion] 12 warnings generated. We should fix it after ANGLE update - bug145010 . 1096270 1 achristensen 2015-05-20 09:58:53 -0700 I assume this is from gcc. Is there an equivalent of #pragma clang diagnostic ignored "-Wnull-conversion"? I don't think we want to actually change this generated code. 1096524 2 ossy 2015-05-21 01:42:44 -0700 No, it is clang warning. 1102891 3 ossy 2015-06-18 05:56:08 -0700 Let's suppress this warning instead of changing 3rdparty source. 1102892 4 255110 ossy 2015-06-18 05:57:23 -0700 Created attachment 255110 Patch 1102963 5 255110 commit-queue 2015-06-18 10:55:51 -0700 Comment on attachment 255110 Patch Clearing flags on attachment: 255110 Committed r185707: <http://trac.webkit.org/changeset/185707> 1102964 6 commit-queue 2015-06-18 10:55:54 -0700 All reviewed patches have been landed. Closing bug. 255110 2015-06-18 05:57:23 -0700 2015-06-18 10:55:51 -0700 Patch bug-145125-20150618055645.patch text/plain 1482 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1Njk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNiNjAzNGMzMmI4YzE2 ODViMzU1MmU1MjQ3NTUzZmVlMTQ2MDc4Zi4uOTNjZDVkNDYxY2IyZDA0OGUwYmRhYjdhMmY1YWRk NzQwMjcxNzk0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA2LTE4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3VwcHJlc3MgbnVs bC1jb252ZXJzaW9uIHdhcm5pbmdzIGluIEFOR0xFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUxMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE1LTA2LTE4ICBZ b3Vlbm4gRmFibGV0IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4gYW5kIFhhYmllciBSb2Ry aWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU3RyZWFtcyBB UEldIEltcGxlbWVudCBSZWFkYWJsZVN0cmVhbVJlYWRlci5yZWxlYXNlTG9jawpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxp c3RzLnR4dAppbmRleCBjM2Q5ZTBmNWIwMTg3OTk1OTA1ZWExZjJhOWVlMzY3ZDY0ZjUyZTc1Li5l YTY5ODNiYjY0YmIwZjUxZjRiZjczOTIzMGU2MzJhZGM5NTM2YzNiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dApAQCAtMzU4MCw2ICszNTgwLDEyIEBAIGVuZGlmICgpCiBpZiAoRU5BQkxFX0dSQVBISUNT X0NPTlRFWFRfM0QpCiAgICAgYWRkX2xpYnJhcnkoQU5HTEVTdXBwb3J0IFNUQVRJQyAke0FOR0xF U3VwcG9ydF9TT1VSQ0VTfSkKICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoQU5HTEVTdXBwb3J0 IFBST1BFUlRJRVMgRk9MREVSICJXZWJDb3JlIikKKworICAgICMgU3VwcHJlc3MgbnVsbCBjb252 ZXJzaW9uIHdhcm5pbmdzIGZvciBzb3VyY2VzIGluIFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFCisg ICAgaWYgKCIke0NNQUtFX0NYWF9DT01QSUxFUl9JRH0iIFNUUkVRVUFMICJDbGFuZyIpCisgICAg ICAgIEFERF9UQVJHRVRfUFJPUEVSVElFUyhBTkdMRVN1cHBvcnQgQ09NUElMRV9GTEFHUyAiLVdu by1udWxsLWNvbnZlcnNpb24iKQorICAgIGVuZGlmICgpCisKICAgICB0YXJnZXRfaW5jbHVkZV9k aXJlY3RvcmllcyhBTkdMRVN1cHBvcnQgUFJJVkFURQogICAgICAgICAiJHtUSElSRFBBUlRZX0RJ Un0vQU5HTEUvaW5jbHVkZSIKICAgICAgICAgIiR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYyIK