144959 2015-05-13 12:20:45 -0700 [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error 2015-06-01 11:05:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=144747 P2 Minor --- 1 mcatanzaro ossy clopez commit-queue glenn gyuyoung.kim mcatanzaro ossy rniwa oldest_to_newest 1094522 0 mcatanzaro 2015-05-13 12:20:45 -0700 In https://bugs.webkit.org/show_bug.cgi?id=144747#c5 check-webkit-style claims: ERROR: Source/WebKit2/PlatformGTK.cmake:491: Alphabetical sorting problem. "PluginProcess/PluginControllerProxy.cpp" should be before "PluginProcess/EntryPoint/unix/PluginProcessMain.cpp". [list/order] [5] There really is an alphabetical sorting problem on line 491: list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES ${WTF_DIR} ${CAIRO_INCLUDE_DIRS} But I have no clue where PluginProcess/PluginControllerProxy.cpp and PluginProcess/EntryPoint/unix/PluginProcessMain.cpp are coming from. Those have nothing to do with this. 1097795 1 clopez 2015-05-27 18:14:19 -0700 Also on https://bugs.webkit.org/show_bug.cgi?id=145408#c9 It complains about an alphabetical sorting error on Source/WebCore/PlatformEfl.cmake. While this error is true, it was not caused by my patch. It was already there and my patch don't touches any line near it. So it shouldn't complain about something unrelated with the patch. 1098488 2 ossy 2015-06-01 06:25:00 -0700 $ Tools/Scripts/check-webkit-style Source/WebCore/PlatformEfl.cmake ERROR: Source/WebCore/PlatformEfl.cmake:366: Alphabetical sorting problem. "platform/efl/PlatformSpeechSynthesisProviderEfl.cpp" should be before "platform/efl/PlatformSpeechSynthesizerEfl.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformEfl.cmake:378: There should be exactly one empty line instead of 0 between "crypto/SubtleCrypto.cpp" and "crypto/algorithms/CryptoAlgorithmAES_CBC.cpp". [list/emptyline] [5] ERROR: Source/WebCore/PlatformEfl.cmake:383: Alphabetical sorting problem. "crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp" should be before "crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformEfl.cmake:391: Alphabetical sorting problem. "crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp" should be before "crypto/gnutls/CryptoAlgorithmRegistryGnuTLS.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformEfl.cmake:396: Alphabetical sorting problem. "crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp" should be before "crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp". [list/order] [5] Total errors found: 5 in 1 files But these entries aren't in these lines, but - 484 instead of 366 - 495 instead of 378 - 501 instead of 383 - 509 instead of 391 - 514 instead of 396 The difference is 118 everywhere, I have no idea why. Let me check it to try to find where the bug is. 1098493 3 253999 ossy 2015-06-01 07:27:13 -0700 Created attachment 253999 Patch The bug is in _check_list_order, line_number isn't incremented when matched is true. We should use enumerate to avoid this kind of bugs. 1098542 4 253999 commit-queue 2015-06-01 11:05:39 -0700 Comment on attachment 253999 Patch Clearing flags on attachment: 253999 Committed r185065: <http://trac.webkit.org/changeset/185065> 1098543 5 commit-queue 2015-06-01 11:05:51 -0700 All reviewed patches have been landed. Closing bug. 253999 2015-06-01 07:27:13 -0700 2015-06-01 11:05:39 -0700 Patch bug-144959-20150601072655.patch text/plain 3851 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGQ4YTMxNzlkZWU3YThiNmU1OWFhNWM0NThlNjQ2YTA2 MzljMjNiYS4uYzUxOWQ1NzRjMDZhNjc3ZTQ4ZjM5ZjViOTk4YWU4MzZhNzE3NmUzMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDE1LTA2LTAxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgW0NNYWtlXSBjaGVjay13ZWJraXQtc3R5bGUgcHJvdmlkZXMgYm9ndXMgZXhwbGFu YXRpb24gZm9yIGFscGhhYmV0aWNhbCBzb3J0aW5nIGVycm9yCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5NTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY21ha2UucHk6CisgICAgICAgIChDTWFrZUNoZWNrZXIuY2hlY2spOiBVc2UgZW51bWVy YXRlIGluc3RlYWQgb2YgeHJhbmdlLgorICAgICAgICAoQ01ha2VDaGVja2VyLl9jaGVja19saXN0 X29yZGVyKTogVXNlIGVudW1lcmF0ZSBpbnN0ZWFkIG9mIGluY3JlbWVudGluZyBsaW5lX251bWJl ciBtYW51YWxseS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nt YWtlX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ01ha2VDaGVja2VyVGVzdC50ZXN0X2NoZWNrKTog VXBkYXRlIHRoZSBleHBlY3RlZCByZXN1bHRzLgorCisyMDE1LTA2LTAxICBDc2FiYSBPc3p0cm9n b27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKICAgICAgICAgW2NtYWtlXSBTdXBwcmVzcyB1bnVz ZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIFdlYktpdDIgYW5kIFRlc3ROZXRzY2FwZVBsdWdJbgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MjY0CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2Uu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NtYWtlLnB5CmluZGV4 IGU0MTIzNmJhZTExMWZmMTI0NDlkNzFhOWU1OTdlOTBiZGU1NzE0NzQuLmM4ZTc4MTVlMTNhN2Q2 N2I1NDk3NDA4ZTM1ZWY3YjBlOTVjZjFlNDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jbWFrZS5weQpAQCAtOTAsOSArOTAsOCBAQCBjbGFzcyBDTWFrZUNo ZWNrZXIob2JqZWN0KToKIAogICAgIGRlZiBjaGVjayhzZWxmLCBsaW5lcyk6CiAgICAgICAgIHNl bGYuX3RhYl9jaGVja2VyLmNoZWNrKGxpbmVzKQotICAgICAgICBzZWxmLl9udW1fbGluZXMgPSBs ZW4obGluZXMpCi0gICAgICAgIGZvciBsIGluIHhyYW5nZShzZWxmLl9udW1fbGluZXMpOgotICAg ICAgICAgICAgc2VsZi5fcHJvY2Vzc19saW5lKGwgKyAxLCBsaW5lc1tsXSkKKyAgICAgICAgZm9y IGxpbmVfbnVtYmVyLCBsaW5lIGluIGVudW1lcmF0ZShsaW5lcywgc3RhcnQ9MSk6CisgICAgICAg ICAgICBzZWxmLl9wcm9jZXNzX2xpbmUobGluZV9udW1iZXIsIGxpbmUpCiAgICAgICAgIHNlbGYu X2NoZWNrX2xpc3Rfb3JkZXIobGluZXMpCiAKICAgICBkZWYgX3Byb2Nlc3NfbGluZShzZWxmLCBs aW5lX251bWJlciwgbGluZV9jb250ZW50KToKQEAgLTE1MSwxMiArMTUwLDEwIEBAIGNsYXNzIENN YWtlQ2hlY2tlcihvYmplY3QpOgogICAgIGRlZiBfY2hlY2tfbGlzdF9vcmRlcihzZWxmLCBsaW5l cyk6CiAgICAgICAgIGxhc3RfbGluZSA9IE5vbmUKIAotICAgICAgICBsaW5lX251bWJlciA9IDAK LSAgICAgICAgZm9yIGxpbmUgaW4gbGluZXM6CisgICAgICAgIGZvciBsaW5lX251bWJlciwgbGlu ZSBpbiBlbnVtZXJhdGUobGluZXMsIHN0YXJ0PTEpOgogICAgICAgICAgICAgbWF0Y2hlZCA9IHNl YXJjaCgnXCRcey4qXH0nLCBsaW5lKQogICAgICAgICAgICAgaWYgbWF0Y2hlZDoKICAgICAgICAg ICAgICAgICBjb250aW51ZQotICAgICAgICAgICAgbGluZV9udW1iZXIgKz0gMQogICAgICAgICAg ICAgbGluZSA9IGxpbmUuc3RyaXAoKQogCiAgICAgICAgICAgICBpZiBsYXN0X2xpbmUgPT0gTm9u ZToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21h a2VfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nt YWtlX3VuaXR0ZXN0LnB5CmluZGV4IDE5ZjgwODU4NDU4M2U1OGMwYjgwNjAxOWRjNGFmMTZkNjkz OWZjNjguLmNjM2Y4NTZlYWU3NjAzMzFhNmU5MWM1ZTZkZWFjZTk1NDQ4ODcwZWEgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY21ha2VfdW5pdHRlc3Qu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jbWFrZV91bml0 dGVzdC5weQpAQCAtMTMxLDggKzEzMSw4IEBAIGNsYXNzIENNYWtlQ2hlY2tlclRlc3QodW5pdHRl c3QuVGVzdENhc2UpOgogICAgICAgICAgICAgKDI0LCAnbGlzdC9wYXJlbnRoZXNlcycsIDUsICdU aGUgcGFyZW50aGVzZXMgYWZ0ZXIgdGhlIGxhc3QgbGlzdGl0ZW0gImIiIHNob3VsZCBiZSBpbiBh IG5ldyBsaW5lLicpLAogICAgICAgICAgICAgKDMxLCAgJ2xpc3QvZHVwbGljYXRlJywgNSwgJ1Ro ZSBpdGVtICJhIiBzaG91bGQgYmUgYWRkZWQgb25seSBvbmNlIHRvIHRoZSBsaXN0LicpLAogICAg ICAgICAgICAgKDM1LCAnbGlzdC9vcmRlcicsIDUsICdBbHBoYWJldGljYWwgc29ydGluZyBwcm9i bGVtLiAiYSIgc2hvdWxkIGJlIGJlZm9yZSAiYiIuJyksCi0gICAgICAgICAgICAoNDEsICdsaXN0 L29yZGVyJywgNSwgJ0FscGhhYmV0aWNhbCBzb3J0aW5nIHByb2JsZW0uICJjL2MuYyIgc2hvdWxk IGJlIGJlZm9yZSAiYy9iL2EuYSIuJyksCi0gICAgICAgICAgICAoNDksICdsaXN0L2VtcHR5bGlu ZScsIDUsICdUaGVyZSBzaG91bGQgYmUgbm8gZW1wdHkgbGluZSBiZXR3ZWVuICJhIiBhbmQgImIi LicpLAotICAgICAgICAgICAgKDU0LCAnbGlzdC9lbXB0eWxpbmUnLCA1LCAnVGhlcmUgc2hvdWxk IGJlIGV4YWN0bHkgb25lIGVtcHR5IGxpbmUgaW5zdGVhZCBvZiAwIGJldHdlZW4gImEvYi5iIiBh bmQgImIvYS5hIi4nKSwKLSAgICAgICAgICAgICg1NywgJ2xpc3QvZW1wdHlsaW5lJywgNSwgJ1Ro ZXJlIHNob3VsZCBiZSBleGFjdGx5IG9uZSBlbXB0eSBsaW5lIGluc3RlYWQgb2YgMiBiZXR3ZWVu ICJiL2EuYSIgYW5kICJjL2EuYSIuJyksCisgICAgICAgICAgICAoNDIsICdsaXN0L29yZGVyJywg NSwgJ0FscGhhYmV0aWNhbCBzb3J0aW5nIHByb2JsZW0uICJjL2MuYyIgc2hvdWxkIGJlIGJlZm9y ZSAiYy9iL2EuYSIuJyksCisgICAgICAgICAgICAoNTAsICdsaXN0L2VtcHR5bGluZScsIDUsICdU aGVyZSBzaG91bGQgYmUgbm8gZW1wdHkgbGluZSBiZXR3ZWVuICJhIiBhbmQgImIiLicpLAorICAg ICAgICAgICAgKDU1LCAnbGlzdC9lbXB0eWxpbmUnLCA1LCAnVGhlcmUgc2hvdWxkIGJlIGV4YWN0 bHkgb25lIGVtcHR5IGxpbmUgaW5zdGVhZCBvZiAwIGJldHdlZW4gImEvYi5iIiBhbmQgImIvYS5h Ii4nKSwKKyAgICAgICAgICAgICg1OCwgJ2xpc3QvZW1wdHlsaW5lJywgNSwgJ1RoZXJlIHNob3Vs ZCBiZSBleGFjdGx5IG9uZSBlbXB0eSBsaW5lIGluc3RlYWQgb2YgMiBiZXR3ZWVuICJiL2EuYSIg YW5kICJjL2EuYSIuJyksCiAgICAgICAgICAgICBdKQo=