144799 2015-05-08 03:03:36 -0700 [Streams API] Refactor ReadableStreamReader close promise callback cleaning 2015-05-10 11:35:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf benjamin calvaris commit-queue darin oldest_to_newest 1093156 0 youennf 2015-05-08 03:03:36 -0700 Cleaning ReadableStreamReader code as discussed in https://bugs.webkit.org/show_bug.cgi?id=141162#c10 would be good. 1093158 1 252717 youennf 2015-05-08 03:10:04 -0700 Created attachment 252717 Patch 1093539 2 252717 commit-queue 2015-05-10 11:34:58 -0700 Comment on attachment 252717 Patch Clearing flags on attachment: 252717 Committed r184048: <http://trac.webkit.org/changeset/184048> 1093540 3 commit-queue 2015-05-10 11:35:02 -0700 All reviewed patches have been landed. Closing bug. 252717 2015-05-08 03:10:04 -0700 2015-05-10 11:34:58 -0700 Patch bug-144799-20150508120841.patch text/plain 4039 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGFiZGExMWQ1ZDcxOTE4 ZWQ3NjVjNWEwZmUxMWI0NDAxNmQ3YTBjNC4uNTY0Y2M2MTMxOTJhYjRlMTZmMGI4NjYyMjBkYTNm NjhlYzNlYWQzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTA5ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFi bGV0IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KKworICAgICAgICBbU3RyZWFtcyBBUEld IFJlZmFjdG9yIFJlYWRhYmxlU3RyZWFtUmVhZGVyIGNsb3NlIHByb21pc2UgY2FsbGJhY2sgY2xl YW5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NDc5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1v dmVkIGNsb3NlIGNhbGxiYWNrIGNsZWFuaW5nIHRvIHJlbGVhc2VTdHJlYW0sIHdoaWNoIGlzIG5v dyByZWxlYXNlU3RyZWFtQW5kQ2xlYW4uCisgICAgICAgIE1vdmVkIHRoYXQgbWV0aG9kIHRvIHBy aXZhdGUgYXMgaXQgaXMgbm8gbG9uZ2VyIG5lZWRlZCBieSBzdWJjbGFzc2VzLgorCisgICAgICAg IE5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMvUmVhZGFi bGVTdHJlYW1SZWFkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVhZGFibGVTdHJlYW1SZWFk ZXI6OnJlbGVhc2VTdHJlYW1BbmRDbGVhbik6CisgICAgICAgIChXZWJDb3JlOjpSZWFkYWJsZVN0 cmVhbVJlYWRlcjo6Y2hhbmdlU3RhdGVUb0Nsb3NlZCk6CisgICAgICAgIChXZWJDb3JlOjpSZWFk YWJsZVN0cmVhbVJlYWRlcjo6Y2hhbmdlU3RhdGVUb0Vycm9yZWQpOgorICAgICAgICAqIE1vZHVs ZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbVJlYWRlci5oOgorCiAyMDE1LTA1LTA4ICBYYWJpZXIg Um9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFibGV0 IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBbU3RyZWFtcyBBUEldIFJl YWRhYmxlU3RyZWFtIGNvbnN0cnVjdG9yIHN0YXJ0IGZ1bmN0aW9uIHNob3VsZCBiZSBhYmxlIHRv IGVycm9yIHRoZSBzdHJlYW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3Ry ZWFtcy9SZWFkYWJsZVN0cmVhbVJlYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0 cmVhbXMvUmVhZGFibGVTdHJlYW1SZWFkZXIuY3BwCmluZGV4IDA2NWY1ZDdmYWI4ZGEzMzI1NjFk Yzk4YjMzMWRjMTg4MzEzNDdiMDQuLjIyY2IwODdmOTM2YmIxODJiMWMyOTgzOThmOGJmY2Q1NDg4 NTA3ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJs ZVN0cmVhbVJlYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1Jl YWRhYmxlU3RyZWFtUmVhZGVyLmNwcApAQCAtNzUsMTEgKzc1LDE0IEBAIHZvaWQgUmVhZGFibGVT dHJlYW1SZWFkZXI6OmluaXRpYWxpemUoKQogICAgIH0KIH0KIAotdm9pZCBSZWFkYWJsZVN0cmVh bVJlYWRlcjo6cmVsZWFzZVN0cmVhbSgpCit2b2lkIFJlYWRhYmxlU3RyZWFtUmVhZGVyOjpyZWxl YXNlU3RyZWFtQW5kQ2xlYW4oKQogewogICAgIEFTU0VSVChtX3N0cmVhbSk7CiAgICAgbV9zdHJl YW0tPnJlbGVhc2UoKTsKICAgICBtX3N0cmVhbSA9IG51bGxwdHI7CisKKyAgICBtX2Nsb3NlZFN1 Y2Nlc3NDYWxsYmFjayA9IG51bGxwdHI7CisgICAgbV9jbG9zZWRFcnJvckNhbGxiYWNrID0gbnVs bHB0cjsKIH0KIAogdm9pZCBSZWFkYWJsZVN0cmVhbVJlYWRlcjo6Y2xvc2VkKENsb3NlZFN1Y2Nl c3NDYWxsYmFjayBzdWNjZXNzQ2FsbGJhY2ssIENsb3NlZEVycm9yQ2FsbGJhY2sgZXJyb3JDYWxs YmFjaykKQEAgLTEwMSwxNiArMTA0LDEyIEBAIHZvaWQgUmVhZGFibGVTdHJlYW1SZWFkZXI6OmNo YW5nZVN0YXRlVG9DbG9zZWQoKQogICAgIEFTU0VSVChtX3N0YXRlID09IFN0YXRlOjpSZWFkYWJs ZSk7CiAgICAgbV9zdGF0ZSA9IFN0YXRlOjpDbG9zZWQ7CiAKLSAgICBpZiAobV9jbG9zZWRTdWNj ZXNzQ2FsbGJhY2spIHsKLSAgICAgICAgQ2xvc2VkU3VjY2Vzc0NhbGxiYWNrIGNsb3NlZFN1Y2Nl c3NDYWxsYmFjayA9IFdURjo6bW92ZShtX2Nsb3NlZFN1Y2Nlc3NDYWxsYmFjayk7Ci0gICAgICAg IGNsb3NlZFN1Y2Nlc3NDYWxsYmFjaygpOwotICAgIH0KLSAgICBBU1NFUlQoIW1fY2xvc2VkU3Vj Y2Vzc0NhbGxiYWNrKTsKLSAgICBtX2Nsb3NlZEVycm9yQ2FsbGJhY2sgPSBudWxscHRyOworICAg IGlmIChtX2Nsb3NlZFN1Y2Nlc3NDYWxsYmFjaykKKyAgICAgICAgbV9jbG9zZWRTdWNjZXNzQ2Fs bGJhY2soKTsKIAogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgcmVhZCBwcm9taXNlIGZ1bGZpbGxp bmcuCiAKLSAgICByZWxlYXNlU3RyZWFtKCk7CisgICAgcmVsZWFzZVN0cmVhbUFuZENsZWFuKCk7 CiB9CiAKIHZvaWQgUmVhZGFibGVTdHJlYW1SZWFkZXI6OmNoYW5nZVN0YXRlVG9FcnJvcmVkKCkK QEAgLTExOCwxNiArMTE3LDEyIEBAIHZvaWQgUmVhZGFibGVTdHJlYW1SZWFkZXI6OmNoYW5nZVN0 YXRlVG9FcnJvcmVkKCkKICAgICBBU1NFUlQobV9zdGF0ZSA9PSBTdGF0ZTo6UmVhZGFibGUpOwog ICAgIG1fc3RhdGUgPSBTdGF0ZTo6RXJyb3JlZDsKIAotICAgIGlmIChtX2Nsb3NlZEVycm9yQ2Fs bGJhY2spIHsKLSAgICAgICAgQ2xvc2VkRXJyb3JDYWxsYmFjayBjbG9zZWRFcnJvckNhbGxiYWNr ID0gV1RGOjptb3ZlKG1fY2xvc2VkRXJyb3JDYWxsYmFjayk7Ci0gICAgICAgIGNsb3NlZEVycm9y Q2FsbGJhY2soKTsKLSAgICB9Ci0gICAgQVNTRVJUKCFtX2Nsb3NlZEVycm9yQ2FsbGJhY2spOwot ICAgIG1fY2xvc2VkU3VjY2Vzc0NhbGxiYWNrID0gbnVsbHB0cjsKKyAgICBpZiAobV9jbG9zZWRF cnJvckNhbGxiYWNrKQorICAgICAgICBtX2Nsb3NlZEVycm9yQ2FsbGJhY2soKTsKIAogICAgIC8v IEZJWE1FOiBJbXBsZW1lbnQgcmVhZCBwcm9taXNlIHJlamVjdGlvbi4KIAotICAgIHJlbGVhc2VT dHJlYW0oKTsKKyAgICByZWxlYXNlU3RyZWFtQW5kQ2xlYW4oKTsKIH0KIAogY29uc3QgY2hhciog UmVhZGFibGVTdHJlYW1SZWFkZXI6OmFjdGl2ZURPTU9iamVjdE5hbWUoKSBjb25zdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtUmVhZGVy LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1SZWFkZXIu aAppbmRleCA3ZGRhZjAyMzIzZTk4MjE4ZjRmYjhjNDdhOTMxMjBjNjNjY2Y1OTI4Li43MTkxMDIw NzI3ODFlYjU4MDIyYjg4ZDExZjVmOGI3YzgwZDlmYmI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1SZWFkZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1SZWFkZXIuaApAQCAtNjksMTMg KzY5LDEzIEBAIHB1YmxpYzoKIHByb3RlY3RlZDoKICAgICBSZWFkYWJsZVN0cmVhbVJlYWRlcihS ZWFkYWJsZVN0cmVhbSYpOwogCi0gICAgdm9pZCByZWxlYXNlU3RyZWFtKCk7Ci0KIHByaXZhdGU6 CiAgICAgLy8gQWN0aXZlRE9NT2JqZWN0IEFQSS4KICAgICBjb25zdCBjaGFyKiBhY3RpdmVET01P YmplY3ROYW1lKCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgYm9vbCBjYW5TdXNwZW5kRm9yUGFnZUNh Y2hlKCkgY29uc3Qgb3ZlcnJpZGU7CisKICAgICB2b2lkIGluaXRpYWxpemUoKTsKKyAgICB2b2lk IHJlbGVhc2VTdHJlYW1BbmRDbGVhbigpOwogCiAgICAgUmVmUHRyPFJlYWRhYmxlU3RyZWFtPiBt X3N0cmVhbTsKICAgICBTdGF0ZSBtX3N0YXRlIHsgU3RhdGU6OlJlYWRhYmxlIH07Cg==