144753 2015-05-07 12:25:39 -0700 exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp 2015-05-07 17:22:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 144178 1 saam saam basile_clement commit-queue fpizlo ggaren mark.lam mmirman msaboff oliver oldest_to_newest 1092699 0 saam 2015-05-07 12:25:39 -0700 This allows the byte code generator to emit byte code that "may" throw exceptions as part of the setup code without worrying that this code will increment the exceptionFuzz counter. We don't want setup code to increment the exceptionFuzz counter because if the limit is reached in setup code there will obviously not be an exception handler to catch the exception and we end up not testing anything of significance. 1092832 1 252646 saam 2015-05-07 16:29:33 -0700 Created attachment 252646 patch 1092837 2 252646 mark.lam 2015-05-07 16:31:40 -0700 Comment on attachment 252646 patch r=me 1092887 3 252646 commit-queue 2015-05-07 17:22:21 -0700 Comment on attachment 252646 patch Clearing flags on attachment: 252646 Committed r183962: <http://trac.webkit.org/changeset/183962> 1092888 4 commit-queue 2015-05-07 17:22:26 -0700 All reviewed patches have been landed. Closing bug. 252646 2015-05-07 16:29:33 -0700 2015-05-07 17:22:21 -0700 patch clean-backup.diff text/plain 6320 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgzOTU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE1LTA1LTA3ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBleGNlcHRpb25GdXp6IHRlc3RzIHNob3VsZCBleHBsaWNpdGx5IGluaXRpYWxpemUgdGhl IGV4Y2VwdGlvbkZ1enogYm9vbGVhbiBpbiBKYXZhU2NyaXB0IGNvZGUgdGhyb3VnaCBhIGZ1bmN0 aW9uIGluIGpzYy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDc1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgYWxsb3dzIHRoZSBCeXRlY29kZUdlbmVyYXRvciB0byBmcmVlbHkgZW1pdCBz dGFydHVwIGNvZGUgdGhhdCAibWF5IgorICAgICAgICB0aHJvdyBleGNlcHRpb25zIHdpdGhvdXQg d29ycnlpbmcgdGhhdCB0aGlzIHN0YXJ0dXAgY29kZSB3aWxsIHRyaWdnZXIKKyAgICAgICAgdGhl IGV4Y2VwdGlvbkZ1enogZXhjZXB0aW9uLiBUaGUgZXhjZXB0aW9uRnV6eiBjb3VudGVyIHdpbGwg b25seSBiZWdpbgorICAgICAgICB0aWNraW5nIHdoZW4gdGhlICdlbmFibGVFeGNlcHRpb25GdXp6 JyBmdW5jdGlvbiBpcyBleHBsaWNpdGx5IGNhbGxlZCBpbiAKKyAgICAgICAgdGhlIGV4Y2VwdGlv bkZ1enogdGVzdHMuCisKKyAgICAgICAgKiBqc2MuY3BwOgorICAgICAgICAoR2xvYmFsT2JqZWN0 OjpmaW5pc2hDcmVhdGlvbik6CisgICAgICAgIChmdW5jdGlvbkVuYWJsZUV4Y2VwdGlvbkZ1enop OgorICAgICAgICAqIHRlc3RzL2V4Y2VwdGlvbkZ1enovM2QtY3ViZS5qczoKKyAgICAgICAgKiB0 ZXN0cy9leGNlcHRpb25GdXp6L2RhdGUtZm9ybWF0LXhwYXJiLmpzOgorICAgICAgICAqIHRlc3Rz L2V4Y2VwdGlvbkZ1enovZWFybGV5LWJveWVyLmpzOgorCiAyMDE1LTA1LTA3ICBZdXN1a2UgU3V6 dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIEZ1bmN0aW9uQ2FsbEJyYWNr ZXROb2RlIHNob3VsZCBzdG9yZSB0aGUgYmFzZSB2YWx1ZSB0byB0aGUgdGVtcG9yYXJ5IHdoZW4g c3Vic2NyaXB0IGhhcyBhc3NpZ25tZW50CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNj LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNp b24gMTgzODkxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQ3OCw2ICs0NzgsNyBAQCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBmdW5jCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblJldHVy blR5cGVGb3IoRXhlY1N0YXRlKik7CiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBmdW5jdGlvbkR1bXBCYXNpY0Jsb2NrRXhlY3V0aW9uUmFuZ2VzKEV4ZWNTdGF0ZSopOwogc3Rh dGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25IYXNCYXNpY0Jsb2NrRXhl Y3V0ZWQoRXhlY1N0YXRlKik7CitzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBm dW5jdGlvbkVuYWJsZUV4Y2VwdGlvbkZ1enooRXhlY1N0YXRlKik7CiAKICNpZiBFTkFCTEUoU0FN UExJTkdfRkxBR1MpCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlv blNldFNhbXBsaW5nRmxhZ3MoRXhlY1N0YXRlKik7CkBAIC02MzUsNiArNjM2LDggQEAgcHJvdGVj dGVkOgogCiAgICAgICAgIGFkZEZ1bmN0aW9uKHZtLCAiZHVtcEJhc2ljQmxvY2tFeGVjdXRpb25S YW5nZXMiLCBmdW5jdGlvbkR1bXBCYXNpY0Jsb2NrRXhlY3V0aW9uUmFuZ2VzICwgMCk7CiAgICAg ICAgIGFkZEZ1bmN0aW9uKHZtLCAiaGFzQmFzaWNCbG9ja0V4ZWN1dGVkIiwgZnVuY3Rpb25IYXNC YXNpY0Jsb2NrRXhlY3V0ZWQsIDIpOworCisgICAgICAgIGFkZEZ1bmN0aW9uKHZtLCAiZW5hYmxl RXhjZXB0aW9uRnV6eiIsIGZ1bmN0aW9uRW5hYmxlRXhjZXB0aW9uRnV6eiwgMCk7CiAgICAgICAg IAogICAgICAgICBKU0FycmF5KiBhcnJheSA9IGNvbnN0cnVjdEVtcHR5QXJyYXkoZ2xvYmFsRXhl YygpLCAwKTsKICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBhcmd1bWVudHMuc2l6ZSgp OyArK2kpCkBAIC0xMTI5LDYgKzExMzIsMTIgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBmdW5jdGlvbkhhcwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFuKGhhc0V4 ZWN1dGVkKSk7CiB9CiAKK0VuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25FbmFi bGVFeGNlcHRpb25GdXp6KEV4ZWNTdGF0ZSopCit7CisgICAgT3B0aW9uczo6ZW5hYmxlRXhjZXB0 aW9uRnV6eigpID0gdHJ1ZTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVk KCkpOworfQorCiAvLyBVc2UgU0VIIGZvciBSZWxlYXNlIGJ1aWxkcyBvbmx5IHRvIGdldCByaWQg b2YgdGhlIGNyYXNoIHJlcG9ydCBkaWFsb2cKIC8vIChsdWNraWx5IHRoZSBzYW1lIHRlc3RzIGZh aWwgaW4gUmVsZWFzZSBhbmQgRGVidWcgYnVpbGRzIHNvIGZhcikuIE5lZWQgdG8KIC8vIGJlIGlu IGEgc2VwYXJhdGUgbWFpbiBmdW5jdGlvbiBiZWNhdXNlIHRoZSBqc2NtYWluIGZ1bmN0aW9uIHJl cXVpcmVzIG9iamVjdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL2V4Y2VwdGlv bkZ1enovM2QtY3ViZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVz dHMvZXhjZXB0aW9uRnV6ei8zZC1jdWJlLmpzCShyZXZpc2lvbiAxODM4OTEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvdGVzdHMvZXhjZXB0aW9uRnV6ei8zZC1jdWJlLmpzCSh3b3JraW5nIGNv cHkpCkBAIC00LDYgKzQsOSBAQCB0cnkgewogLy8gaHR0cDovL3d3dy5zcGVpY2gubmV0L2NvbXB1 dGVyL21venRlc3RpbmcvM2QuaHRtCiAvLyBDcmVhdGVkIGJ5IFNpbW9uIFNwZWljaAogCitlbmFi bGVFeGNlcHRpb25GdXp6KCk7CisKKwogdmFyIFEgPSBuZXcgQXJyYXkoKTsKIHZhciBNVHJhbnMg PSBuZXcgQXJyYXkoKTsgIC8vIHRyYW5zZm9ybWF0aW9uIG1hdHJpeAogdmFyIE1RdWJlID0gbmV3 IEFycmF5KCk7ICAvLyBwb3NpdGlvbiBpbmZvcm1hdGlvbiBvZiBxdWJlCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvdGVzdHMvZXhjZXB0aW9uRnV6ei9kYXRlLWZvcm1hdC14cGFyYi5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvZXhjZXB0aW9uRnV6ei9k YXRlLWZvcm1hdC14cGFyYi5qcwkocmV2aXNpb24gMTgzODkxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3Rlc3RzL2V4Y2VwdGlvbkZ1enovZGF0ZS1mb3JtYXQteHBhcmIuanMJKHdvcmtpbmcg Y29weSkKQEAgLTEzLDYgKzEzLDkgQEAgdHJ5IHsKICAqIGRldGFpbHMuCiAgKi8KIAorZW5hYmxl RXhjZXB0aW9uRnV6eigpOworCisKIERhdGUucGFyc2VGdW5jdGlvbnMgPSB7Y291bnQ6MH07CiBE YXRlLnBhcnNlUmVnZXhlcyA9IFtdOwogRGF0ZS5mb3JtYXRGdW5jdGlvbnMgPSB7Y291bnQ6MH07 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvZXhjZXB0aW9uRnV6ei9lYXJsZXkt Ym95ZXIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL2V4Y2Vw dGlvbkZ1enovZWFybGV5LWJveWVyLmpzCShyZXZpc2lvbiAxODM4OTEpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvdGVzdHMvZXhjZXB0aW9uRnV6ei9lYXJsZXktYm95ZXIuanMJKHdvcmtpbmcg Y29weSkKQEAgLTM5LDYgKzM5LDggQEAgZnVuY3Rpb24gaW5pdFJ1bnRpbWUoKSB7CiB9CiAqLwog CitlbmFibGVFeGNlcHRpb25GdXp6KCk7CisKIAogZnVuY3Rpb24gc2NfcHJpbnRfZGVidWcoKSB7 CiAgICAgc2NfcHJpbnQuYXBwbHkobnVsbCwgYXJndW1lbnRzKTsKSW5kZXg6IFRvb2xzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzk1NikKKysr IFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA1 LTA3ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAgICAgICBleGNl cHRpb25GdXp6IHRlc3RzIHNob3VsZCBleHBsaWNpdGx5IGluaXRpYWxpemUgdGhlIGV4Y2VwdGlv bkZ1enogYm9vbGVhbiBpbiBKYXZhU2NyaXB0IGNvZGUgdGhyb3VnaCBhIGZ1bmN0aW9uIGluIGpz Yy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NDc1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9qcy1leGNlcHRpb24tZnV6ejoKKwogMjAx NS0wNS0wNyAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTmV3IGZv cmNlLXJlbGF0ZWQgRE9NIGV2ZW50cyBzaG91bGQgZmlyZSBpbiBXSzEgdmlld3MKSW5kZXg6IFRv b2xzL1NjcmlwdHMvanNjLXN0cmVzcy10ZXN0LWhlbHBlcnMvanMtZXhjZXB0aW9uLWZ1enoKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9qcy1leGNl cHRpb24tZnV6egkocmV2aXNpb24gMTgzODkxKQorKysgVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNz LXRlc3QtaGVscGVycy9qcy1leGNlcHRpb24tZnV6egkod29ya2luZyBjb3B5KQpAQCAtNzEsNyAr NzEsNyBAQCBpZiAoc2hpZnQgQEFSR1YpIHsKICAgICBkaWUgIklnbm9yaW5nIGdhcmJhZ2UgYXJn dW1lbnRzOyBvbmx5IHRoZSBmaXJzdCBub24tb3B0aW9uIGFyZ3VtZW50IGlzIHVzZWQgYXMgdGhl IGNvbW1hbmQgc3RyaW5nLiI7CiB9CiAKLW9wZW4gKG15ICR0ZXN0SW5wdXQsICIkY29tbWFuZFN0 cmluZyAtLWVuYWJsZUV4Y2VwdGlvbkZ1eno9dHJ1ZSB8Iikgb3IgZmFpbCgiQ2Fubm90IGV4ZWN1 dGUgaW5pdGlhbCBjb21tYW5kIHdoZW4gZ2V0dGluZyBjaGVjayBjb3VudCIpOworb3BlbiAobXkg JHRlc3RJbnB1dCwgIiRjb21tYW5kU3RyaW5nIHwiKSBvciBmYWlsKCJDYW5ub3QgZXhlY3V0ZSBp bml0aWFsIGNvbW1hbmQgd2hlbiBnZXR0aW5nIGNoZWNrIGNvdW50Iik7CiB3aGlsZSAobXkgJGlu cHV0TGluZSA9IDwkdGVzdElucHV0PikgewogICAgIGNob21wKCRpbnB1dExpbmUpOwogICAgIG15 ICRoYW5kbGVkID0gMDsKQEAgLTEwNCw3ICsxMDQsNyBAQCBmb3IgKG15ICRpdGVyYXRpb24gPSAw OyAkaXRlcmF0aW9uIDwgJHJlCiAgICAgaWYgKCR2ZXJib3NlKSB7CiAgICAgICAgIHByaW50ICJp dGVyYXRpb24oJGl0ZXJhdGlvbikgdGFyZ2V0KCR0YXJnZXQpOiBSdW5uaW5nLlxuIjsKICAgICB9 Ci0gICAgb3BlbiAoJHRlc3RJbnB1dCwgIiRjb21tYW5kU3RyaW5nIC0tZW5hYmxlRXhjZXB0aW9u RnV6ej10cnVlIC0tZmlyZUV4Y2VwdGlvbkZ1enpBdD0kdGFyZ2V0IHwiKSBvciBmYWlsKCJDYW5u b3QgZXhlY3V0ZSBjb21tYW5kIG9uIGl0ZXJhdGlvbiAkaXRlcmF0aW9uIik7CisgICAgb3BlbiAo JHRlc3RJbnB1dCwgIiRjb21tYW5kU3RyaW5nIC0tZmlyZUV4Y2VwdGlvbkZ1enpBdD0kdGFyZ2V0 IHwiKSBvciBmYWlsKCJDYW5ub3QgZXhlY3V0ZSBjb21tYW5kIG9uIGl0ZXJhdGlvbiAkaXRlcmF0 aW9uIik7CiAgICAgbXkgJHN0YXRlID0gIndhaXRpbmciOwogICAgIHdoaWxlIChteSAkaW5wdXRM aW5lID0gPCR0ZXN0SW5wdXQ+KSB7CiAgICAgICAgIGNob21wKCRpbnB1dExpbmUpOwo=