14443 2007-06-27 22:25:58 -0700 Forms dont submit when disabling submit button 2012-03-16 01:25:56 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 NEW http://gifts.30boxes.com/broken.html P2 Normal --- 39021 1 allia.z webkit-unassigned ap darren dglazkov kaustubh.ra rniwa rsesek tkent oldest_to_newest 6011 0 allia.z 2007-06-27 22:25:58 -0700 Forms do not submit when disabling the submit button via an onclick event, even when returning true. 4323 1 15579 ap 2007-07-19 05:32:20 -0700 Created attachment 15579 test case 4325 2 ap 2007-07-19 05:33:48 -0700 Confirmed with r24182. Works in Firefox. 89006 3 rsesek 2008-08-21 08:43:15 -0700 This is a regression from fixing https://bugs.webkit.org/show_bug.cgi?id=9245. Not sure how to go about fixing this, though... 89830 4 browserbugs2 2008-08-31 17:12:02 -0700 This bug seems to be the exact opposite of bug 16886. You guys should be talking to each others to sort this out because both bugs can not be confirmed. 473863 5 kaustubh.ra 2011-09-27 05:12:52 -0700 This seems to be old but existing issue. During initial implementation of SubmitInputType::handleDOMActivateEvent (revision - 72059 -http://trac.webkit.org/changeset/72059/trunk/WebCore/html/SubmitInputType.cpp) There was check added to see if submitButton->disabled() but this line will never hit infact the function will not be called if the button is disabled. In the use case, the onclick script it handled first making the button disabled and then continued to handleDOMActivateEvent where it returns due to disabled submitButton. Should be removed that check. Attaching patch. 473976 6 rniwa 2011-09-27 09:18:33 -0700 Does IE submit in this case? 474058 7 kaustubh.ra 2011-09-27 10:39:16 -0700 (In reply to comment #6) > Does IE submit in this case? Nope. only Firefox has does complete form submission. MSIE & Opera does not. I think we might need to clear out again about this. 474064 8 rniwa 2011-09-27 10:45:19 -0700 (In reply to comment #7) > (In reply to comment #6) > > Does IE submit in this case? > > Nope. only Firefox has does complete form submission. > MSIE & Opera does not. I think we might need to clear out again about this. Yes, we definitely need to figure out the right behavior on whatwg. Intuitively, I wouldn't expect the form to submit when the only submit button is disabled. This may as well as considered as a Gecko bug. 474072 9 kaustubh.ra 2011-09-27 10:52:37 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Does IE submit in this case? > > > > Nope. only Firefox has does complete form submission. > > MSIE & Opera does not. I think we might need to clear out again about this. > > Yes, we definitely need to figure out the right behavior on whatwg. Intuitively, I wouldn't expect the form to submit when the only submit button is disabled. This may as well as considered as a Gecko bug. If you suggest, I will mail on whatwg for this issue. IMHO, until and unless form submit is not disabled, form submit action should happen on the click. But not sure with the compatibility of the browsers. 474091 10 rniwa 2011-09-27 11:11:47 -0700 By the way, could you add yourself to committers.py so that Bugzilla's auto-completion can recognize you. Also, listing your IRC nick name will allow me to talk to you on #webkit more easily :) 474100 11 rniwa 2011-09-27 11:17:52 -0700 ap suggests I add you myself. What's your IRC nickname? 474103 12 kaustubh.ra 2011-09-27 11:21:39 -0700 (In reply to comment #11) > ap suggests I add you myself. What's your IRC nickname? Sure, my IRC nickname is silverroots 474564 13 kaustubh.ra 2011-09-28 00:22:42 -0700 (In reply to comment #12) > (In reply to comment #11) > > ap suggests I add you myself. What's your IRC nickname? > > Sure, my IRC nickname is silverroots Thanks Ryosuke :) 475868 14 kaustubh.ra 2011-09-29 21:06:32 -0700 (In reply to comment #8) > > Yes, we definitely need to figure out the right behavior on whatwg. Intuitively, I wouldn't expect the form to submit when the only submit button is disabled. This may as well as considered as a Gecko bug. in this case, the submit button is active before clicking it, but on it's on click handler it is made disabled. Firefox seems to run both on click and on submit handlers in this case one followed by another. 573615 15 kaustubh.ra 2012-03-07 22:21:45 -0800 The whatwg discussion thread - http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-January/034536.html As per Ian, we should be fixing this issue. Will provide a patch soon. 580199 16 darren 2012-03-15 23:52:03 -0700 I seems to be having the same problem with links. On click event if I disable the link I would still expect the event to bubble and route the browser to the href value but nothing happens. 580275 17 kaustubh.ra 2012-03-16 01:25:56 -0700 (In reply to comment #16) > I seems to be having the same problem with links. > On click event if I disable the link I would still expect the event to bubble and route the browser to the href value but nothing happens. Yes, this might have issues with most of the elements. I am assuming handleDOMActiveEvent should be modified to make it more smarter so that it can handle such cases. Not sure thought. 15579 2007-07-19 05:32:20 -0700 2007-07-19 05:32:20 -0700 test case disable-submit.html text/html 117 ap PGZvcm0gYWN0aW9uPSJqYXZhc2NyaXB0OmFsZXJ0KCdTVUNDRVNTJykiPgo8aW5wdXQgdHlwZT0i c3VibWl0IiBvbmNsaWNrPSJ0aGlzLmRpc2FibGVkPXRydWU7IHJldHVybiB0cnVlOyI+CjwvZm9y bT4K