144373 2015-04-28 20:27:07 -0700 REGRESSION(181868): Windows Live SkyDrive cannot open an excel file 2015-04-29 11:48:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue ggaren joepeck oldest_to_newest 1089861 0 joepeck 2015-04-28 20:27:07 -0700 * SUMMARY REGRESSION(181868): Windows Live SkyDrive cannot open an excel file. * STEPS TO REPRODUCE 1. Open <https://skydrive.live.com> 2. Sign In 3. Open/Create an Excel document => never loads, infinitely stays on loading page * NOTES The page does stuff like: (Ewa.js) --------------------- var w = window, wHTMLElementPrototype = w.HTMLElement.prototype; wHTMLElementPrototype.__defineGetter__("innerText", function() { try { return this.textContent } catch (d) { for (var b = "", a = 0, c = this.childNodes.length; a < c; a++) if (this.childNodes[a].nodeType == 3) b += this.childNodes[a].textContent; return b } }); wHTMLElementPrototype.__defineSetter__("innerText", function(b) { var a = document.createTextNode(b); this.innerHTML = ""; this.appendChild(a) }); --------------------- • Firefox: the properties don’t exist on HTMLElement.prototype, so they are created • Chrome: the properties do exist and are configurable, so they are updated • WebKit: the properties do exist and are NOT configurable - before r181868 we failed silently - after r181868 we throw an exception 1089862 1 joepeck 2015-04-28 20:28:16 -0700 Hmm, it seems Web IDL prefers that interface attributes be configurable by default: http://www.w3.org/TR/WebIDL/#es-attributes > The property has attributes > { [[Get]]: G, [[Set]]: S, [[Enumerable]]: true, [[Configurable]]: configurable }, > where: configurable is false if the attribute was declared with the > [Unforgeable] extended attribute and true otherwise; Seems like the ultimate best path forward would be to: (1) Make IDL attributes configurable (2) Keep this exception when trying to reconfigure a non-configurable property. But for now, lets just go back to failing silently. 1089863 2 joepeck 2015-04-28 20:28:33 -0700 <rdar://problem/20642043> 1089874 3 251920 joepeck 2015-04-28 20:42:04 -0700 Created attachment 251920 [PATCH] Proposed Fix =(. This will Reopen 142934 and in there I have a plan for hopefully re-enabling this warning. 1089920 4 251920 commit-queue 2015-04-29 00:54:51 -0700 Comment on attachment 251920 [PATCH] Proposed Fix Clearing flags on attachment: 251920 Committed r183535: <http://trac.webkit.org/changeset/183535> 1089921 5 commit-queue 2015-04-29 00:54:55 -0700 All reviewed patches have been landed. Closing bug. 1090077 6 ggaren 2015-04-29 11:05:50 -0700 > • Firefox: the properties don’t exist on HTMLElement.prototype, so they are > created O'rly? Most DOM properties in Firefox are getters and setters in the prototype chain. Out of curiosity, where *does* Firefox define innerText? 1090093 7 joepeck 2015-04-29 11:48:12 -0700 (In reply to comment #6) > > • Firefox: the properties don’t exist on HTMLElement.prototype, so they are > > created > > O'rly? Most DOM properties in Firefox are getters and setters in the > prototype chain. Out of curiosity, where *does* Firefox define innerText? Firefox doesn't appear to support "innerText" at all. 251920 2015-04-28 20:42:04 -0700 2015-04-29 00:54:51 -0700 [PATCH] Proposed Fix revert.patch text/plain 6681 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiMjJkZDQ2Li45OTk0N2JkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTUtMDQt MjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBSRUdS RVNTSU9OKDE4MTg2OCk6IFdpbmRvd3MgTGl2ZSBTa3lEcml2ZSBjYW5ub3Qgb3BlbiBhbiBleGNl bCBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDQzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGpzL3Byb3BlcnR5LWdldHRlcnMtYW5kLXNldHRlcnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IGpzL3NjcmlwdC10ZXN0cy9wcm9wZXJ0eS1nZXR0ZXJzLWFuZC1zZXR0ZXJzLmpzOgorCisyMDE1 LTA0LTI4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg Tm9kZUxpc3QgaGFzIGlzc3VlcyB3aXRoIFN5bWJvbCBhbmQgZW1wdHkgc3RyaW5nCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQzMTAKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvanMvcHJvcGVydHktZ2V0dGVycy1hbmQtc2V0dGVycy1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9qcy9wcm9wZXJ0eS1nZXR0ZXJzLWFuZC1zZXR0ZXJzLWV4cGVj dGVkLnR4dAppbmRleCA1MzFlNDg5Li5lOTJjOWFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9q cy9wcm9wZXJ0eS1nZXR0ZXJzLWFuZC1zZXR0ZXJzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9qcy9wcm9wZXJ0eS1nZXR0ZXJzLWFuZC1zZXR0ZXJzLWV4cGVjdGVkLnR4dApAQCAtNDMs MjEgKzQzLDYgQEAgUEFTUyBvMTIuX19sb29rdXBHZXR0ZXJfXygnYicpIGlzIHZvaWQgMAogV2hl biB1bmRlZmluZWQsIGFjY2Vzc2luZyBfX2xvb2t1cEdldHRlcl9fIGFuZCBfX2xvb2t1cFNldHRl cl9fIHNob3VsZCBub3QgY3Jhc2gKIFBBU1MgbzEzLl9fbG9va3VwR2V0dGVyX18oJ2InKSBpcyB2 b2lkIDAKIFBBU1MgbzEzLl9fbG9va3VwU2V0dGVyX18oJ2InKSBpcyB2b2lkIDAKLV9fZGVmaW5l R2V0dGVyX18gYW5kIF9fZGVmaW5lU2V0dGVyX18gc2hvdWxkIHRocm93IGV4Y2VwdGlvbnMgd2hl biBhY3Rpbmcgb24gc2VhbGVkIG9iamVjdHMKLVBBU1MgbzE0Ll9fZGVmaW5lR2V0dGVyX18oJ2En LCBmdW5jdGlvbigpe30pIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IEF0dGVtcHRpbmcgdG8g Y29uZmlndXJhYmxlIGF0dHJpYnV0ZSBvZiB1bmNvbmZpZ3VyYWJsZSBwcm9wZXJ0eS4uCi1QQVNT IG8xNC5fX2RlZmluZUdldHRlcl9fKCdiJywgZnVuY3Rpb24oKXt9KSB0aHJldyBleGNlcHRpb24g VHlwZUVycm9yOiBBdHRlbXB0aW5nIHRvIGRlZmluZSBwcm9wZXJ0eSBvbiBvYmplY3QgdGhhdCBp cyBub3QgZXh0ZW5zaWJsZS4uCi1QQVNTIG8xNC5fX2RlZmluZVNldHRlcl9fKCdhJywgZnVuY3Rp b24oKXt9KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBBdHRlbXB0aW5nIHRvIGNvbmZpZ3Vy YWJsZSBhdHRyaWJ1dGUgb2YgdW5jb25maWd1cmFibGUgcHJvcGVydHkuLgotUEFTUyBvMTQuX19k ZWZpbmVTZXR0ZXJfXygnYicsIGZ1bmN0aW9uKCl7fSkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJv cjogQXR0ZW1wdGluZyB0byBkZWZpbmUgcHJvcGVydHkgb24gb2JqZWN0IHRoYXQgaXMgbm90IGV4 dGVuc2libGUuLgotX19kZWZpbmVHZXR0ZXJfXyBhbmQgX19kZWZpbmVTZXR0ZXJfXyBzaG91bGQg dGhyb3cgZXhjZXB0aW9ucyB3aGVuIGFjdGluZyBvbiBmcm96ZW4gb2JqZWN0cwotUEFTUyBvMTUu X19kZWZpbmVHZXR0ZXJfXygnYScsIGZ1bmN0aW9uKCl7fSkgdGhyZXcgZXhjZXB0aW9uIFR5cGVF cnJvcjogQXR0ZW1wdGluZyB0byBjb25maWd1cmFibGUgYXR0cmlidXRlIG9mIHVuY29uZmlndXJh YmxlIHByb3BlcnR5Li4KLVBBU1MgbzE1Ll9fZGVmaW5lR2V0dGVyX18oJ2InLCBmdW5jdGlvbigp e30pIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IEF0dGVtcHRpbmcgdG8gZGVmaW5lIHByb3Bl cnR5IG9uIG9iamVjdCB0aGF0IGlzIG5vdCBleHRlbnNpYmxlLi4KLVBBU1MgbzE1Ll9fZGVmaW5l U2V0dGVyX18oJ2EnLCBmdW5jdGlvbigpe30pIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IEF0 dGVtcHRpbmcgdG8gY29uZmlndXJhYmxlIGF0dHJpYnV0ZSBvZiB1bmNvbmZpZ3VyYWJsZSBwcm9w ZXJ0eS4uCi1QQVNTIG8xNS5fX2RlZmluZVNldHRlcl9fKCdiJywgZnVuY3Rpb24oKXt9KSB0aHJl dyBleGNlcHRpb24gVHlwZUVycm9yOiBBdHRlbXB0aW5nIHRvIGRlZmluZSBwcm9wZXJ0eSBvbiBv YmplY3QgdGhhdCBpcyBub3QgZXh0ZW5zaWJsZS4uCi1fX2RlZmluZUdldHRlcl9fIGFuZCBfX2Rl ZmluZVNldHRlcl9fIHNob3VsZCB0aHJvdyBleGNlcHRpb25zIHdoZW4gYWN0aW5nIG9uIHVuY29u ZmlndXJhYmxlIHByb3BlcnRpZXMKLVBBU1MgbzE2Ll9fZGVmaW5lR2V0dGVyX18oJ2EnLCBmdW5j dGlvbigpe30pIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgotUEFTUyBvMTYuX19kZWZpbmVTZXR0 ZXJfXygnYScsIGZ1bmN0aW9uKCl7fSkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCi1QQVNTIG8x Ni5fX2RlZmluZVNldHRlcl9fKCdiJywgZnVuY3Rpb24oKXt9KSB0aHJldyBleGNlcHRpb24gVHlw ZUVycm9yOiBBdHRlbXB0aW5nIHRvIGNvbmZpZ3VyYWJsZSBhdHRyaWJ1dGUgb2YgdW5jb25maWd1 cmFibGUgcHJvcGVydHkuLgotUEFTUyBvMTYuX19kZWZpbmVTZXR0ZXJfXygnYicsIGZ1bmN0aW9u KCl7fSkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogQXR0ZW1wdGluZyB0byBjb25maWd1cmFi bGUgYXR0cmlidXRlIG9mIHVuY29uZmlndXJhYmxlIHByb3BlcnR5Li4KIFBBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvanMvc2NyaXB0LXRlc3RzL3Byb3BlcnR5LWdldHRlcnMtYW5kLXNldHRlcnMuanMgYi9MYXlv dXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvcHJvcGVydHktZ2V0dGVycy1hbmQtc2V0dGVycy5qcwpp bmRleCBlNWZjMWExLi45OTBkZTJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQt dGVzdHMvcHJvcGVydHktZ2V0dGVycy1hbmQtc2V0dGVycy5qcworKysgYi9MYXlvdXRUZXN0cy9q cy9zY3JpcHQtdGVzdHMvcHJvcGVydHktZ2V0dGVycy1hbmQtc2V0dGVycy5qcwpAQCAtOTksMjcg Kzk5LDMgQEAgdmFyIG8xMyA9IG5ldyBPYmplY3QoKQogCiBzaG91bGRCZSgibzEzLl9fbG9va3Vw R2V0dGVyX18oJ2InKSIsICJ2b2lkIDAiKTsKIHNob3VsZEJlKCJvMTMuX19sb29rdXBTZXR0ZXJf XygnYicpIiwgInZvaWQgMCIpOwotCi1kZWJ1ZygiX19kZWZpbmVHZXR0ZXJfXyBhbmQgX19kZWZp bmVTZXR0ZXJfXyBzaG91bGQgdGhyb3cgZXhjZXB0aW9ucyB3aGVuIGFjdGluZyBvbiBzZWFsZWQg b2JqZWN0cyIpOwotdmFyIG8xNCA9IHthOjE0fTsKLU9iamVjdC5zZWFsKG8xNCk7Ci1zaG91bGRU aHJvdygibzE0Ll9fZGVmaW5lR2V0dGVyX18oJ2EnLCBmdW5jdGlvbigpe30pIik7Ci1zaG91bGRU aHJvdygibzE0Ll9fZGVmaW5lR2V0dGVyX18oJ2InLCBmdW5jdGlvbigpe30pIik7Ci1zaG91bGRU aHJvdygibzE0Ll9fZGVmaW5lU2V0dGVyX18oJ2EnLCBmdW5jdGlvbigpe30pIik7Ci1zaG91bGRU aHJvdygibzE0Ll9fZGVmaW5lU2V0dGVyX18oJ2InLCBmdW5jdGlvbigpe30pIik7Ci0KLWRlYnVn KCJfX2RlZmluZUdldHRlcl9fIGFuZCBfX2RlZmluZVNldHRlcl9fIHNob3VsZCB0aHJvdyBleGNl cHRpb25zIHdoZW4gYWN0aW5nIG9uIGZyb3plbiBvYmplY3RzIik7Ci12YXIgbzE1ID0ge2E6MTV9 OwotT2JqZWN0LmZyZWV6ZShvMTUpOwotc2hvdWxkVGhyb3coIm8xNS5fX2RlZmluZUdldHRlcl9f KCdhJywgZnVuY3Rpb24oKXt9KSIpOwotc2hvdWxkVGhyb3coIm8xNS5fX2RlZmluZUdldHRlcl9f KCdiJywgZnVuY3Rpb24oKXt9KSIpOwotc2hvdWxkVGhyb3coIm8xNS5fX2RlZmluZVNldHRlcl9f KCdhJywgZnVuY3Rpb24oKXt9KSIpOwotc2hvdWxkVGhyb3coIm8xNS5fX2RlZmluZVNldHRlcl9f KCdiJywgZnVuY3Rpb24oKXt9KSIpOwotCi1kZWJ1ZygiX19kZWZpbmVHZXR0ZXJfXyBhbmQgX19k ZWZpbmVTZXR0ZXJfXyBzaG91bGQgdGhyb3cgZXhjZXB0aW9ucyB3aGVuIGFjdGluZyBvbiB1bmNv bmZpZ3VyYWJsZSBwcm9wZXJ0aWVzIik7Ci12YXIgbzE2ID0ge2E6MTZ9OwotT2JqZWN0LmRlZmlu ZVByb3BlcnR5KG8xNiwgImIiLCB7dmFsdWU6IDE2LCBjb25maWd1cmFibGU6IGZhbHNlfSk7Ci1z aG91bGROb3RUaHJvdygibzE2Ll9fZGVmaW5lR2V0dGVyX18oJ2EnLCBmdW5jdGlvbigpe30pIik7 Ci1zaG91bGROb3RUaHJvdygibzE2Ll9fZGVmaW5lU2V0dGVyX18oJ2EnLCBmdW5jdGlvbigpe30p Iik7Ci1zaG91bGRUaHJvdygibzE2Ll9fZGVmaW5lU2V0dGVyX18oJ2InLCBmdW5jdGlvbigpe30p Iik7Ci1zaG91bGRUaHJvdygibzE2Ll9fZGVmaW5lU2V0dGVyX18oJ2InLCBmdW5jdGlvbigpe30p Iik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAzZTY2Yjg5Li45M2FlNTk0IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNS0wNC0yOCAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04oMTgxODY4 KTogV2luZG93cyBMaXZlIFNreURyaXZlIGNhbm5vdCBvcGVuIGFuIGV4Y2VsIGZpbGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDM3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmVydCByMTgxODY4 IGFzIGl0IGNhdXNlZCBhIGZhaWx1cmUgb24gbGl2ZS5jb20uIFdlIGNhbiB0cnkKKyAgICAgICAg cmUtZW5hYmxpbmcgdGhpcyBleGNlcHRpb24gYWZ0ZXIgd2UgbWFrZSBpZGwgYXR0cmlidXRlcyBj b25maWd1cmFibGUsCisgICAgICAgIHdoaWNoIG1heSBoYXZlIHByZXZlbnRlZCB0aGlzIHBhcnRp Y3VsYXIgZmFpbHVyZS4KKworICAgICAgICAqIHJ1bnRpbWUvT2JqZWN0UHJvdG90eXBlLmNwcDoK KyAgICAgICAgKEpTQzo6b2JqZWN0UHJvdG9GdW5jRGVmaW5lR2V0dGVyKToKKyAgICAgICAgKEpT Qzo6b2JqZWN0UHJvdG9GdW5jRGVmaW5lU2V0dGVyKToKKworMjAxNS0wNC0yOCAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIERlYWRsb2NrIG9uIGFwcGxp Y2F0aW9ucyB1c2luZyBKU0NvbnRleHQgb24gbm9uLW1haW4gdGhyZWFkCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQzNzAKIApkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0UHJvdG90eXBlLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdFByb3RvdHlwZS5jcHAKaW5kZXggZWY4NTRi MC4uOTA1ZDBkMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2Jq ZWN0UHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmpl Y3RQcm90b3R5cGUuY3BwCkBAIC0xMzAsNyArMTMwLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hP U1RfQ0FMTCBvYmplY3RQcm90b0Z1bmNEZWZpbmVHZXR0ZXIoRXhlY1N0YXRlKiBleGVjKQogICAg IGRlc2NyaXB0b3Iuc2V0RW51bWVyYWJsZSh0cnVlKTsKICAgICBkZXNjcmlwdG9yLnNldENvbmZp Z3VyYWJsZSh0cnVlKTsKIAotICAgIGJvb2wgc2hvdWxkVGhyb3cgPSB0cnVlOworICAgIGJvb2wg c2hvdWxkVGhyb3cgPSBmYWxzZTsKICAgICB0aGlzT2JqZWN0LT5tZXRob2RUYWJsZShleGVjLT52 bSgpKS0+ZGVmaW5lT3duUHJvcGVydHkodGhpc09iamVjdCwgZXhlYywgcHJvcGVydHlOYW1lLCBk ZXNjcmlwdG9yLCBzaG91bGRUaHJvdyk7CiAKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpz VW5kZWZpbmVkKCkpOwpAQCAtMTU2LDcgKzE1Niw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgb2JqZWN0UHJvdG9GdW5jRGVmaW5lU2V0dGVyKEV4ZWNTdGF0ZSogZXhlYykKICAgICBk ZXNjcmlwdG9yLnNldEVudW1lcmFibGUodHJ1ZSk7CiAgICAgZGVzY3JpcHRvci5zZXRDb25maWd1 cmFibGUodHJ1ZSk7CiAKLSAgICBib29sIHNob3VsZFRocm93ID0gdHJ1ZTsKKyAgICBib29sIHNo b3VsZFRocm93ID0gZmFsc2U7CiAgICAgdGhpc09iamVjdC0+bWV0aG9kVGFibGUoZXhlYy0+dm0o KSktPmRlZmluZU93blByb3BlcnR5KHRoaXNPYmplY3QsIGV4ZWMsIHByb3BlcnR5TmFtZSwgZGVz Y3JpcHRvciwgc2hvdWxkVGhyb3cpOwogCiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1Vu ZGVmaW5lZCgpKTsK